New issue
Advanced search Search tips

Issue 704902 link

Starred by 2 users
Status: Fixed
Owner:
r...@igalia.com
Closed: Mar 2017
Cc:
jfernan...@igalia.com
r...@igalia.com
style-bugs@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug

Blocking:
issue 576815
issue 617371



Sign in to add a comment

[selectors-4] Import W3C Test Suite

Project Member Reported by r...@igalia.com, Mar 24 2017 

The test suite has tests for ":focus-within" pseudo-class that would be useful for its implementation:
https://github.com/w3c/csswg-test/tree/master/selectors-4/

It has also 2 tests for ":dir" psuedo-class that is not implemented yet.

And a few more for selectors that are already implemented.

Let's import this suite.
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 24 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/567655f3f72b9ac9754c2fccfcacca4953d4c656

commit 567655f3f72b9ac9754c2fccfcacca4953d4c656
Author: rego <rego@igalia.com>
Date: Fri Mar 24 13:23:06 2017

[selectors-4] Import W3C Test Suite

This patch imports "selectors-4" test suite from W3C csswg-test repo:
https://github.com/w3c/csswg-test/tree/master/selectors-4/

Only 2 tests are passing right now. Other fail because of
the psuedo-classes haven't been implemented yet:
:dir (crbug.com/576815) and :focus-within ( crbug.com/617371 ).

BUG= 704902 

Review-Url: https://codereview.chromium.org/2776693002
Cr-Commit-Position: refs/heads/master@{#459401}

[modify] https://crrev.com/567655f3f72b9ac9754c2fccfcacca4953d4c656/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/567655f3f72b9ac9754c2fccfcacca4953d4c656/third_party/WebKit/LayoutTests/W3CImportExpectations
[add] https://crrev.com/567655f3f72b9ac9754c2fccfcacca4953d4c656/third_party/WebKit/LayoutTests/external/csswg-test/selectors-4/focus-within-001-expected.html
[add] https://crrev.com/567655f3f72b9ac9754c2fccfcacca4953d4c656/third_party/WebKit/LayoutTests/external/csswg-test/selectors-4/focus-within-001.html
[add] https://crrev.com/567655f3f72b9ac9754c2fccfcacca4953d4c656/third_party/WebKit/LayoutTests/external/csswg-test/selectors-4/focus-within-002-expected.html
[add] https://crrev.com/567655f3f72b9ac9754c2fccfcacca4953d4c656/third_party/WebKit/LayoutTests/external/csswg-test/selectors-4/focus-within-002.html
[add] https://crrev.com/567655f3f72b9ac9754c2fccfcacca4953d4c656/third_party/WebKit/LayoutTests/external/csswg-test/selectors-4/focus-within-003-expected.html
[add] https://crrev.com/567655f3f72b9ac9754c2fccfcacca4953d4c656/third_party/WebKit/LayoutTests/external/csswg-test/selectors-4/focus-within-003.html
[add] https://crrev.com/567655f3f72b9ac9754c2fccfcacca4953d4c656/third_party/WebKit/LayoutTests/external/csswg-test/selectors-4/focus-within-004-expected.html
[add] https://crrev.com/567655f3f72b9ac9754c2fccfcacca4953d4c656/third_party/WebKit/LayoutTests/external/csswg-test/selectors-4/focus-within-004.html
[add] https://crrev.com/567655f3f72b9ac9754c2fccfcacca4953d4c656/third_party/WebKit/LayoutTests/external/csswg-test/selectors-4/focus-within-005-expected.html
[add] https://crrev.com/567655f3f72b9ac9754c2fccfcacca4953d4c656/third_party/WebKit/LayoutTests/external/csswg-test/selectors-4/focus-within-005.html
[add] https://crrev.com/567655f3f72b9ac9754c2fccfcacca4953d4c656/third_party/WebKit/LayoutTests/external/csswg-test/selectors-4/focus-within-006-expected.html
[add] https://crrev.com/567655f3f72b9ac9754c2fccfcacca4953d4c656/third_party/WebKit/LayoutTests/external/csswg-test/selectors-4/focus-within-006.html
[add] https://crrev.com/567655f3f72b9ac9754c2fccfcacca4953d4c656/third_party/WebKit/LayoutTests/external/csswg-test/selectors-4/focus-within-shadow-001-expected.html
[add] https://crrev.com/567655f3f72b9ac9754c2fccfcacca4953d4c656/third_party/WebKit/LayoutTests/external/csswg-test/selectors-4/focus-within-shadow-001.html
[add] https://crrev.com/567655f3f72b9ac9754c2fccfcacca4953d4c656/third_party/WebKit/LayoutTests/external/csswg-test/selectors-4/focus-within-shadow-002-expected.html
[add] https://crrev.com/567655f3f72b9ac9754c2fccfcacca4953d4c656/third_party/WebKit/LayoutTests/external/csswg-test/selectors-4/focus-within-shadow-002.html
[add] https://crrev.com/567655f3f72b9ac9754c2fccfcacca4953d4c656/third_party/WebKit/LayoutTests/external/csswg-test/selectors-4/focus-within-shadow-003-expected.html
[add] https://crrev.com/567655f3f72b9ac9754c2fccfcacca4953d4c656/third_party/WebKit/LayoutTests/external/csswg-test/selectors-4/focus-within-shadow-003.html
[add] https://crrev.com/567655f3f72b9ac9754c2fccfcacca4953d4c656/third_party/WebKit/LayoutTests/external/csswg-test/selectors-4/focus-within-shadow-004-expected.html
[add] https://crrev.com/567655f3f72b9ac9754c2fccfcacca4953d4c656/third_party/WebKit/LayoutTests/external/csswg-test/selectors-4/focus-within-shadow-004.html
[add] https://crrev.com/567655f3f72b9ac9754c2fccfcacca4953d4c656/third_party/WebKit/LayoutTests/external/csswg-test/selectors-4/focus-within-shadow-005-expected.html
[add] https://crrev.com/567655f3f72b9ac9754c2fccfcacca4953d4c656/third_party/WebKit/LayoutTests/external/csswg-test/selectors-4/focus-within-shadow-005.html
[add] https://crrev.com/567655f3f72b9ac9754c2fccfcacca4953d4c656/third_party/WebKit/LayoutTests/external/csswg-test/selectors-4/of-type-selectors-expected.xhtml
[add] https://crrev.com/567655f3f72b9ac9754c2fccfcacca4953d4c656/third_party/WebKit/LayoutTests/external/csswg-test/selectors-4/of-type-selectors.xhtml
[add] https://crrev.com/567655f3f72b9ac9754c2fccfcacca4953d4c656/third_party/WebKit/LayoutTests/external/csswg-test/selectors-4/selector-required-expected.html
[add] https://crrev.com/567655f3f72b9ac9754c2fccfcacca4953d4c656/third_party/WebKit/LayoutTests/external/csswg-test/selectors-4/selector-required.html
[add] https://crrev.com/567655f3f72b9ac9754c2fccfcacca4953d4c656/third_party/WebKit/LayoutTests/external/csswg-test/selectors-4/selectors-dir-selector-ltr-001-expected.xht
[add] https://crrev.com/567655f3f72b9ac9754c2fccfcacca4953d4c656/third_party/WebKit/LayoutTests/external/csswg-test/selectors-4/selectors-dir-selector-ltr-001.html
[add] https://crrev.com/567655f3f72b9ac9754c2fccfcacca4953d4c656/third_party/WebKit/LayoutTests/external/csswg-test/selectors-4/selectors-dir-selector-rtl-001-expected.xht
[add] https://crrev.com/567655f3f72b9ac9754c2fccfcacca4953d4c656/third_party/WebKit/LayoutTests/external/csswg-test/selectors-4/selectors-dir-selector-rtl-001.html

Comment 2 by r...@igalia.com, Mar 24 2017

Status: Fixed (was: Started)
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 28 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/29f372aa0cdb9b2b6cca4f8bf4297ee9d126c16d

commit 29f372aa0cdb9b2b6cca4f8bf4297ee9d126c16d
Author: rego <rego@igalia.com>
Date: Tue Mar 28 14:22:54 2017

[selectors-4] Import more tests from W3C repository

On the first import we forgot to import the tests from Mozilla.

From the new imported tests only 1 is passing right now.
Again the other miss :dir (crbug.com/576815) and
:focus-within ( crbug.com/617371 ) implementations.

BUG= 704902 

Review-Url: https://codereview.chromium.org/2783663002
Cr-Commit-Position: refs/heads/master@{#460097}

[modify] https://crrev.com/29f372aa0cdb9b2b6cca4f8bf4297ee9d126c16d/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/29f372aa0cdb9b2b6cca4f8bf4297ee9d126c16d/third_party/WebKit/LayoutTests/W3CImportExpectations
[add] https://crrev.com/29f372aa0cdb9b2b6cca4f8bf4297ee9d126c16d/third_party/WebKit/LayoutTests/external/csswg-test/vendor-imports/mozilla/mozilla-central-reftests/selectors4/child-index-no-parent-01-expected.html
[add] https://crrev.com/29f372aa0cdb9b2b6cca4f8bf4297ee9d126c16d/third_party/WebKit/LayoutTests/external/csswg-test/vendor-imports/mozilla/mozilla-central-reftests/selectors4/child-index-no-parent-01.html
[add] https://crrev.com/29f372aa0cdb9b2b6cca4f8bf4297ee9d126c16d/third_party/WebKit/LayoutTests/external/csswg-test/vendor-imports/mozilla/mozilla-central-reftests/selectors4/dir-style-01a-expected.html
[add] https://crrev.com/29f372aa0cdb9b2b6cca4f8bf4297ee9d126c16d/third_party/WebKit/LayoutTests/external/csswg-test/vendor-imports/mozilla/mozilla-central-reftests/selectors4/dir-style-01a.html
[add] https://crrev.com/29f372aa0cdb9b2b6cca4f8bf4297ee9d126c16d/third_party/WebKit/LayoutTests/external/csswg-test/vendor-imports/mozilla/mozilla-central-reftests/selectors4/dir-style-01b-expected.html
[add] https://crrev.com/29f372aa0cdb9b2b6cca4f8bf4297ee9d126c16d/third_party/WebKit/LayoutTests/external/csswg-test/vendor-imports/mozilla/mozilla-central-reftests/selectors4/dir-style-01b.html
[add] https://crrev.com/29f372aa0cdb9b2b6cca4f8bf4297ee9d126c16d/third_party/WebKit/LayoutTests/external/csswg-test/vendor-imports/mozilla/mozilla-central-reftests/selectors4/dir-style-02a-expected.html
[add] https://crrev.com/29f372aa0cdb9b2b6cca4f8bf4297ee9d126c16d/third_party/WebKit/LayoutTests/external/csswg-test/vendor-imports/mozilla/mozilla-central-reftests/selectors4/dir-style-02a.html
[add] https://crrev.com/29f372aa0cdb9b2b6cca4f8bf4297ee9d126c16d/third_party/WebKit/LayoutTests/external/csswg-test/vendor-imports/mozilla/mozilla-central-reftests/selectors4/dir-style-02b-expected.html
[add] https://crrev.com/29f372aa0cdb9b2b6cca4f8bf4297ee9d126c16d/third_party/WebKit/LayoutTests/external/csswg-test/vendor-imports/mozilla/mozilla-central-reftests/selectors4/dir-style-02b.html
[add] https://crrev.com/29f372aa0cdb9b2b6cca4f8bf4297ee9d126c16d/third_party/WebKit/LayoutTests/external/csswg-test/vendor-imports/mozilla/mozilla-central-reftests/selectors4/dir-style-03a-expected.html
[add] https://crrev.com/29f372aa0cdb9b2b6cca4f8bf4297ee9d126c16d/third_party/WebKit/LayoutTests/external/csswg-test/vendor-imports/mozilla/mozilla-central-reftests/selectors4/dir-style-03a.html
[add] https://crrev.com/29f372aa0cdb9b2b6cca4f8bf4297ee9d126c16d/third_party/WebKit/LayoutTests/external/csswg-test/vendor-imports/mozilla/mozilla-central-reftests/selectors4/dir-style-03b-expected.html
[add] https://crrev.com/29f372aa0cdb9b2b6cca4f8bf4297ee9d126c16d/third_party/WebKit/LayoutTests/external/csswg-test/vendor-imports/mozilla/mozilla-central-reftests/selectors4/dir-style-03b.html
[add] https://crrev.com/29f372aa0cdb9b2b6cca4f8bf4297ee9d126c16d/third_party/WebKit/LayoutTests/external/csswg-test/vendor-imports/mozilla/mozilla-central-reftests/selectors4/dir-style-04-expected.html
[add] https://crrev.com/29f372aa0cdb9b2b6cca4f8bf4297ee9d126c16d/third_party/WebKit/LayoutTests/external/csswg-test/vendor-imports/mozilla/mozilla-central-reftests/selectors4/dir-style-04.html
[add] https://crrev.com/29f372aa0cdb9b2b6cca4f8bf4297ee9d126c16d/third_party/WebKit/LayoutTests/external/csswg-test/vendor-imports/mozilla/mozilla-central-reftests/selectors4/focus-within-1-expected.html
[add] https://crrev.com/29f372aa0cdb9b2b6cca4f8bf4297ee9d126c16d/third_party/WebKit/LayoutTests/external/csswg-test/vendor-imports/mozilla/mozilla-central-reftests/selectors4/focus-within-1.html
[add] https://crrev.com/29f372aa0cdb9b2b6cca4f8bf4297ee9d126c16d/third_party/WebKit/LayoutTests/external/csswg-test/vendor-imports/mozilla/mozilla-central-reftests/selectors4/focus-within-2-expected.html
[add] https://crrev.com/29f372aa0cdb9b2b6cca4f8bf4297ee9d126c16d/third_party/WebKit/LayoutTests/external/csswg-test/vendor-imports/mozilla/mozilla-central-reftests/selectors4/focus-within-2.html
[add] https://crrev.com/29f372aa0cdb9b2b6cca4f8bf4297ee9d126c16d/third_party/WebKit/LayoutTests/external/csswg-test/vendor-imports/mozilla/mozilla-central-reftests/selectors4/focus-within-3-expected.html
[add] https://crrev.com/29f372aa0cdb9b2b6cca4f8bf4297ee9d126c16d/third_party/WebKit/LayoutTests/external/csswg-test/vendor-imports/mozilla/mozilla-central-reftests/selectors4/focus-within-3.html
►

Sign in to add a comment