New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 704895 link

Starred by 1 user
Status: Available
Owner: ----
Cc:
█ fsam...@chromium.org
█ briander...@chromium.org
skyos...@chromium.org
enne@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 703098



Sign in to add a comment

cc: Avoid sending BeginFrames with past deadline to renderer.

Project Member Reported by eseckler@chromium.org, Mar 24 2017 
BeginFrames with past deadline are thrown out by the Scheduler. They thus already are an overhead, but with BeginFrameAcks, they'll further incur an additional BeginFrameDidNotSwap IPC. (This seems to be primarily a problem on Android, see linked blocking bug.)

We can probably just avoid issuing missed BeginFrames with past deadline in the BeginFrameSources (during AddObserver) altogether.

Comment 1 by fsam...@chromium.org, Mar 24 2017 

Yea, we were surprised by these too when writing unit tests in FrameGenerator. We currently just skip MISSED frames in FrameGenerator too: https://cs.chromium.org/chromium/src/services/ui/ws/frame_generator.cc?l=106

A missed BeginFrame is issued when you add an observer to an ExternalBeginFrameSource: https://cs.chromium.org/chromium/src/cc/scheduler/begin_frame_source.cc?l=350

Comment 2 by eseckler@chromium.org, Jan 11 2018 

I had a patch for this here: https://codereview.chromium.org/2767933002/. Not sure if this would still be beneficial?

Comment 3 by eseckler@chromium.org, Apr 27 2018

Owner: ----
Status: Available (was: Started)
►

Sign in to add a comment