New issue
Advanced search Search tips

Issue 704890 link

Starred by 1 user
Status: Fixed
Owner:
rmis...@google.com
Closed: May 2017
Cc:
rmis...@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

when reverting a CL, don't TBR the CC list

Project Member Reported by jochen@chromium.org, Mar 24 2017 
only TBR the original reviewers

Comment 1 by andyb...@chromium.org, Mar 25 2017

Labels: -Pri-3 Pri-2
Owner: rmis...@google.com
Status: Assigned (was: Untriaged)

Comment 2 by aga...@chromium.org, Apr 6 2017

Labels: Milestone-Launch Proj-Gerrit-Migration

Comment 3 by rmis...@google.com, Apr 19 2017

Status: Started (was: Assigned)

Comment 4 by aga...@chromium.org, May 1 2017 

Ravi, you already submitted a CL which fixes this, right? Am I totally misremembering?

Comment 5 by rmis...@google.com, May 2 2017

Status: Fixed (was: Started)
Yep, I was waiting for the change to be live.
Tested by click on 'Revert' here: https://chromium-review.googlesource.com/c/476891/
The CC list did not get added to TBR. Marking as fixed.

Comment 6 by jochen@chromium.org, May 30 2017

Status: Assigned (was: Fixed)
this still happens, e.g. https://chromium-review.googlesource.com/c/517501

Comment 7 by aga...@chromium.org, May 30 2017

Status: Fixed (was: Assigned)
Only the original reviewers were added to the TBR= line.

But yes, there's another bug here, which is that the original CCs appear to have been "upgraded" to full reviewers in the gerrit metadata. I'm going to leave this bug fixed but have filed a new one for that: https://bugs.chromium.org/p/gerrit/issues/detail?id=6337
►

Sign in to add a comment