New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 704880 link

Starred by 1 user
Status: Fixed
Owner:
dpa...@chromium.org
Closed: Mar 2017
Cc:
nyerramilli@chromium.org
kkaluri@chromium.org
█ msrchandra@chromium.org
█ ranjitkan@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Regression: 'No search results found' text is not seen after typing 'hb' in search text box in md-settings

Reported by sans...@etouch.net, Mar 24 2017 
Chrome Version: 59.0.3050.0 Revision bf9bcae65b9dc113edb7409c582238d5cbf7acaf-refs/heads/master@{#459323}
OS: Windows(7,8,10),Linux (14.04 LTS),Mac (10.11.6, 10.12.1)

Steps:
1. Launch Chrome and navigate to chrome://md-settings
2. Type 'hb' in search text box and observe

Actual: 'No search results found' text is not seen after typing 'hb' in search text box instead People section is visible 

Expected: 'No search results found' should be seen after typing 'hb' in search text box

This is a regression issue, broken in 'M-56' will soon update the other info:

Good Build: 56.0.2903.0
Bad Build: 56.0.2905.0
Actual_video.mov
1.5 MB Download
Expected_video.mov
1.3 MB Download

Comment 1 by ranjitkan@chromium.org, Mar 24 2017

Labels: hasbisect-per-revision Proj-MaterialDesign-WebUI
Owner: mahmadi@chromium.org
Status: Assigned (was: Unconfirmed)
Able to reproduce the issue and below are the bisect details for the same using per-revision bisect

Good Build: 56.0.2903.0 (428231)
Bad Build: 56.0.2905.0 (428611)

You are probably looking for a change made after 428510 (known good), but no later than 428511 (first known bad).
CHANGELOG URL:
The script might not always return single CL as suspect as some perf builds might get missing due to failure.

https://chromium.googlesource.com/chromium/src/+log/86e29baab34cd4e0bf09d17f043e57d8f259c25b..685f5586bab6fc956a133dd84de505ea5483833f

@ mahmadi: Assigning to you, kindly take a look into it.

Thanks.!

Comment 2 by mahmadi@chromium.org, Mar 24 2017

Owner: dpa...@chromium.org
dpapad@, assigning MD settings search related bug to you.

Comment 3 by dpa...@chromium.org, Mar 24 2017

Labels: -Pri-1 Pri-2

Comment 4 by dpa...@chromium.org, Mar 24 2017

Status: Started (was: Assigned)
Found the problem.
Project Member

Comment 5 by bugdroid1@chromium.org, Mar 24 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2ad0e26fba82875b90424b386851cfd1abd855a0

commit 2ad0e26fba82875b90424b386851cfd1abd855a0
Author: dpapad <dpapad@chromium.org>
Date: Fri Mar 24 21:00:22 2017

MD Settings: Don't search inside <dialog> elements.

The disconnectDialog inside people-page was being searched erroneously
causing the people section to be returned as a result, instead of displaying
the "no results found" message.

BUG= 704880 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2774003002
Cr-Commit-Position: refs/heads/master@{#459549}

[modify] https://crrev.com/2ad0e26fba82875b90424b386851cfd1abd855a0/chrome/browser/resources/settings/search_settings.js
[modify] https://crrev.com/2ad0e26fba82875b90424b386851cfd1abd855a0/chrome/test/data/webui/settings/search_settings_test.js

Comment 6 by dpa...@chromium.org, Mar 24 2017

Status: Fixed (was: Started)

Comment 7 by kkaluri@chromium.org, Mar 28 2017

Cc: kkaluri@chromium.org
Labels: TE-Verified-59.0.3053.3 TE-Veriifed-M59
Verified this issue on windows 10, Mac 10.12.3, and Ubuntu 14.04 using chrome version #59.0.3053.3 with the steps mentioned in comment #0.
Observed 'No search results found' is seen after typing 'hb' in search text box
Hence adding TE-Verified labels.
Please find the attached screen cast for the same.
Thanks!!
Issue 704880.mp4
339 KB View Download
►

Sign in to add a comment