[NoStatePrefetch] Delete the "wash" origin in histograms. |
||||
Issue descriptionThis origin was introduced at a time where the prerender metrics were unable to keep track of multiple origin simultaneously. When several origin were active at once, the origin would be reported as a "wash". This limitation no longer exists, and origins now don't interfere with each other. Moreover, the wash origin is actually harmful now because it destroys information.
,
Mar 24 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9aac56e95a24dcdeec343f906922f06cddfdf5a5 commit 9aac56e95a24dcdeec343f906922f06cddfdf5a5 Author: droger <droger@chromium.org> Date: Fri Mar 24 15:54:32 2017 [Prerender] Remove the "wash" origin in prerender histograms This origin was introduced at a time where the prerender metrics were unable to keep track of multiple origins simultaneously. When several origins were active at once, the origin would be reported as a "wash". This limitation no longer exists, and origins now don't interfere with each other. Moreover, the wash origin is actually harmful now because it destroys information. BUG= 704868 Review-Url: https://codereview.chromium.org/2769903005 Cr-Commit-Position: refs/heads/master@{#459437} [modify] https://crrev.com/9aac56e95a24dcdeec343f906922f06cddfdf5a5/chrome/browser/prerender/prerender_histograms.cc [modify] https://crrev.com/9aac56e95a24dcdeec343f906922f06cddfdf5a5/chrome/browser/prerender/prerender_histograms.h [modify] https://crrev.com/9aac56e95a24dcdeec343f906922f06cddfdf5a5/chrome/browser/prerender/prerender_manager.cc [modify] https://crrev.com/9aac56e95a24dcdeec343f906922f06cddfdf5a5/tools/metrics/histograms/histograms.xml
,
Mar 27 2017
Requesting a merge to beta. This is a metrics fix with no user-visible impact.
,
Mar 27 2017
Your change meets the bar and is auto-approved for M58. Please go ahead and merge the CL to branch 3029 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Mar 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0c7714ff66b36ad6bcbfbc74ed44e6e2652c8e5c commit 0c7714ff66b36ad6bcbfbc74ed44e6e2652c8e5c Author: David Roger <droger@google.com> Date: Mon Mar 27 11:47:37 2017 [Prerender] Remove the "wash" origin in prerender histograms This origin was introduced at a time where the prerender metrics were unable to keep track of multiple origins simultaneously. When several origins were active at once, the origin would be reported as a "wash". This limitation no longer exists, and origins now don't interfere with each other. Moreover, the wash origin is actually harmful now because it destroys information. BUG= 704868 Review-Url: https://codereview.chromium.org/2769903005 Cr-Commit-Position: refs/heads/master@{#459437} (cherry picked from commit 9aac56e95a24dcdeec343f906922f06cddfdf5a5) Review-Url: https://codereview.chromium.org/2775263002 . Cr-Commit-Position: refs/branch-heads/3029@{#423} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} [modify] https://crrev.com/0c7714ff66b36ad6bcbfbc74ed44e6e2652c8e5c/chrome/browser/prerender/prerender_histograms.cc [modify] https://crrev.com/0c7714ff66b36ad6bcbfbc74ed44e6e2652c8e5c/chrome/browser/prerender/prerender_histograms.h [modify] https://crrev.com/0c7714ff66b36ad6bcbfbc74ed44e6e2652c8e5c/chrome/browser/prerender/prerender_manager.cc [modify] https://crrev.com/0c7714ff66b36ad6bcbfbc74ed44e6e2652c8e5c/tools/metrics/histograms/histograms.xml |
||||
►
Sign in to add a comment |
||||
Comment 1 by pasko@chromium.org
, Mar 24 2017