Issue metadata
Sign in to add a comment
|
Regression : Picture at R.H.S corner of Uber tray is not changing while selecting picture in chrome://md-settings/changePicture page |
||||||||||||||||||||||
Issue descriptionChrome Version: 59.0.3049.0/9395.0.0 dev channel Samus,Zako,Swanky OS: Chrome What steps will reproduce the problem? (1)Sign in to user ->Observe picture at R.H.S corner of Uber tray and at User Name in Uber Tray(For Example 'Gazania Flower' is seen) (2) Now Go to chrome://md-settings -> observe 'Gazania Flower' picture at User Name Under 'People' section -> Click on picture to navigate to 'Change picture' page (3)Now select any other picture (For example 'Chess') and now observe for changed picture at R.H.S corner of Uber tray (Please refer Video) Expected: Picture at R.H.S corner of Uber tray should be changed on selecting other pictures Actual: Instead picture at R.H.S corner of Uber tray is not changing for first time This is Regression Issue as same is working fine in 59.0.3041.0/9389.0.0 dev-channel Parrot device @stevenjb : Please confirm the Issue Note: From "Actal_Picture" Video observe 1. On selecting 'chess' picture for first time there is no change in picture at R.H.S corner of Uber tray and next on selecting 'Dog' picture observe previous picture(Chess) at corner of Uber tray 2. Issue is not seen for picture available at User name in chrome://md-settings and at Uber tray
,
Mar 27 2017
Based on comment #1 (and the video showing that the image change sin the system menu) this seems like a Tray issue, not a Settings issue. That said, I can not reproduce this on a recent ToT build. -> tdanderson@ for confirmation / triage
,
Mar 28 2017
Issue 706022 has been merged into this issue.
,
Mar 28 2017
On 59.0.3051.3 canary minnie: * Upon logging in I noticed the avatar was not present in the system tray. * The first time I switched avatars from chrome://settings, the avatar laid out over top of the time in the system tray. * Every subsequent time I switched avatars from chrome://settings, the avatar in the system tray updated to be the *previous* avatar. However upon opening the system menu, the system menu shows the correct current avatar. * I do not see the bug repro in the avatar image visible in chrome://settings itself, just with the avatar image visible in the system tray. My best guess is that this is a recent regression from one of xiyuan's changes in ash/common/system/user/. xiyuan@, can you please have a look? https://chromium.googlesource.com/chromium/src/+/fda72a9f6483a0cf08aa68091eb8f8af464bec64 https://chromium.googlesource.com/chromium/src/+/f1ff14d7d25d3c37239e6804a3bfd6928c9cd1ef
,
Mar 28 2017
Sounds like caused the mojo replacement CL. will take a look.
,
Mar 28 2017
Think it is racing because the current ash/chrome code runs in mixed mojo and non-mojo code. The avatar image is now updated via mojo but ash::UserObserver still goes the old code path as directly calls to ash. So when TrayUser decides to update the avatar, the mojo message has not yet arrived so it updates with the stale image. I will fix this by consolidating UserObserver code path into mojo one.
,
Mar 28 2017
,
Mar 29 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d24a096f2db3e68da5d48df57a75cf643da1e178 commit d24a096f2db3e68da5d48df57a75cf643da1e178 Author: xiyuan <xiyuan@chromium.org> Date: Wed Mar 29 23:21:26 2017 ash: Fix system tray avatar not updated regression This is caused by racing between mojo and non-mojo code path. The avater image is updated via SessionController mojo interface but UserObserver interface is still a direct call and could reach ash before the mojo message. The CL fixes the issue by replacing UserObserver interface with SessionController observer. BUG= 704862 Review-Url: https://codereview.chromium.org/2780963002 Cr-Commit-Position: refs/heads/master@{#460571} [modify] https://crrev.com/d24a096f2db3e68da5d48df57a75cf643da1e178/ash/BUILD.gn [modify] https://crrev.com/d24a096f2db3e68da5d48df57a75cf643da1e178/ash/common/session/session_controller.cc [modify] https://crrev.com/d24a096f2db3e68da5d48df57a75cf643da1e178/ash/common/session/session_state_observer.h [modify] https://crrev.com/d24a096f2db3e68da5d48df57a75cf643da1e178/ash/common/system/tray/system_tray_notifier.cc [modify] https://crrev.com/d24a096f2db3e68da5d48df57a75cf643da1e178/ash/common/system/tray/system_tray_notifier.h [modify] https://crrev.com/d24a096f2db3e68da5d48df57a75cf643da1e178/ash/common/system/user/rounded_image_view.cc [modify] https://crrev.com/d24a096f2db3e68da5d48df57a75cf643da1e178/ash/common/system/user/rounded_image_view.h [modify] https://crrev.com/d24a096f2db3e68da5d48df57a75cf643da1e178/ash/common/system/user/tray_user.cc [modify] https://crrev.com/d24a096f2db3e68da5d48df57a75cf643da1e178/ash/common/system/user/tray_user.h [modify] https://crrev.com/d24a096f2db3e68da5d48df57a75cf643da1e178/ash/common/system/user/tray_user_unittest.cc [delete] https://crrev.com/430e7d67e925e6cf8c4be45fa93b4f7a0e3e142a/ash/common/system/user/user_observer.h [modify] https://crrev.com/d24a096f2db3e68da5d48df57a75cf643da1e178/chrome/browser/ui/ash/system_tray_delegate_chromeos.cc [modify] https://crrev.com/d24a096f2db3e68da5d48df57a75cf643da1e178/chrome/browser/ui/ash/system_tray_delegate_chromeos.h
,
Mar 30 2017
,
Apr 5 2017
Still reproduced on Chrome OS 9433.0.0 59.0.3055.0 as per the bug described.
,
Apr 5 2017
3055 does not have the fix. Expect the fix in 59.0.3056.0 or above.
,
Apr 24 2017
Chrome OS 9460.5.0/59.0.3071.15 |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by mmanchala@chromium.org
, Mar 24 2017