New issue
Advanced search Search tips

Issue 704850 link

Starred by 1 user
Status: Fixed
Owner:
tkent@chromium.org
Closed: Mar 2017
Cc:
keishi@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Calendar picker should be larger if touch devices are available

Project Member Reported by tkent@chromium.org, Mar 24 2017 
Chrome Version: 59 canary
OS: Windows, CrOS?

What steps will reproduce the problem?
(1) Prepare a touchscreen hardware.
(2) Open the following URL:
   data:text/html,<input type=date>
(3) Click ▼ in the field.

What is the expected result?
Each of day area in the calendar picker should be larger than one in non-touchable devices.

What happens instead?
The calendar picker is same as one in non-touchable devices.

page at the end of this report.
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 27 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2e43cb93b5ab8a098a297d27b60d705076c1213c

commit 2e43cb93b5ab8a098a297d27b60d705076c1213c
Author: tkent <tkent@chromium.org>
Date: Mon Mar 27 02:45:16 2017

input[type=date]: Enlarge day fields if touch-enabled input devices are available.

* We haven't passed pointer type information to PagePopups.
* We should use any-pointer query, not pointer query.
 e.g. If the primary pointer is a mouse, and the device also has a touch-screen,
  day fields should be larger.

BUG= 704850 

Review-Url: https://codereview.chromium.org/2776663002
Cr-Commit-Position: refs/heads/master@{#459690}

[modify] https://crrev.com/2e43cb93b5ab8a098a297d27b60d705076c1213c/third_party/WebKit/LayoutTests/TestExpectations
[add] https://crrev.com/2e43cb93b5ab8a098a297d27b60d705076c1213c/third_party/WebKit/LayoutTests/fast/forms/calendar-picker/calendar-picker-appearance-coarse.html
[add] https://crrev.com/2e43cb93b5ab8a098a297d27b60d705076c1213c/third_party/WebKit/LayoutTests/platform/win/fast/forms/calendar-picker/calendar-picker-appearance-coarse-expected.png
[add] https://crrev.com/2e43cb93b5ab8a098a297d27b60d705076c1213c/third_party/WebKit/LayoutTests/platform/win/fast/forms/calendar-picker/calendar-picker-appearance-coarse-expected.txt
[modify] https://crrev.com/2e43cb93b5ab8a098a297d27b60d705076c1213c/third_party/WebKit/Source/web/WebPagePopupImpl.cpp
[modify] https://crrev.com/2e43cb93b5ab8a098a297d27b60d705076c1213c/third_party/WebKit/Source/web/resources/calendarPicker.js
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 27 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/74e06f61f3b1eb53c2fe555e8c9e66c0e5f26598

commit 74e06f61f3b1eb53c2fe555e8c9e66c0e5f26598
Author: Rebaseline Bot <blink-rebaseline-bot@chromium.org>
Date: Mon Mar 27 19:08:34 2017

Auto-rebaseline for r459690

Build: https://build.chromium.org/p/chromium.infra.cron/builders/rebaseline-o-matic/builds/645169

https://chromium.googlesource.com/chromium/src/+/2e43cb93b5ab8

BUG= 704850 
TBR=tkent@chromium.org

Review-Url: https://codereview.chromium.org/2781683002 .
Cr-Commit-Position: refs/heads/master@{#459845}

[modify] https://crrev.com/74e06f61f3b1eb53c2fe555e8c9e66c0e5f26598/third_party/WebKit/LayoutTests/TestExpectations
[rename] https://crrev.com/74e06f61f3b1eb53c2fe555e8c9e66c0e5f26598/third_party/WebKit/LayoutTests/fast/forms/calendar-picker/calendar-picker-appearance-coarse-expected.txt
[add] https://crrev.com/74e06f61f3b1eb53c2fe555e8c9e66c0e5f26598/third_party/WebKit/LayoutTests/platform/linux/fast/forms/calendar-picker/calendar-picker-appearance-coarse-expected.png
[add] https://crrev.com/74e06f61f3b1eb53c2fe555e8c9e66c0e5f26598/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/forms/calendar-picker/calendar-picker-appearance-coarse-expected.png
[add] https://crrev.com/74e06f61f3b1eb53c2fe555e8c9e66c0e5f26598/third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/forms/calendar-picker/calendar-picker-appearance-coarse-expected.png
[add] https://crrev.com/74e06f61f3b1eb53c2fe555e8c9e66c0e5f26598/third_party/WebKit/LayoutTests/platform/mac-mac10.9/fast/forms/calendar-picker/calendar-picker-appearance-coarse-expected.png
[add] https://crrev.com/74e06f61f3b1eb53c2fe555e8c9e66c0e5f26598/third_party/WebKit/LayoutTests/platform/mac-retina/fast/forms/calendar-picker/calendar-picker-appearance-coarse-expected.png
[add] https://crrev.com/74e06f61f3b1eb53c2fe555e8c9e66c0e5f26598/third_party/WebKit/LayoutTests/platform/mac/fast/forms/calendar-picker/calendar-picker-appearance-coarse-expected.png
[add] https://crrev.com/74e06f61f3b1eb53c2fe555e8c9e66c0e5f26598/third_party/WebKit/LayoutTests/platform/win7/fast/forms/calendar-picker/calendar-picker-appearance-coarse-expected.png

Comment 3 by tkent@chromium.org, Mar 27 2017

Labels: M-59
Status: Fixed (was: Started)
►

Sign in to add a comment