Chrome crashes after closing bookmarks context menu through 'Esc' key.
Reported by
avsha...@etouch.net,
Mar 24 2017
|
|||||
Issue descriptionChrome Version : 59.0.3050.0 (Official Build) bf9bcae65b9dc113edb7409c582238d5cbf7acaf-refs/heads/master@{#459323} 32/64-bit OS: Windows(7,8,8.1,10), Linux (14.04 LTS) What steps will reproduce the problem? 1. Launch chrome, open NTP, right click on Bookmarks Bar and add a 'New Folder'. 2. Right click on newly added folder and add another 'New Folder' inside it. 3. On Bookmarks bar, click on 'New folder' and again click on 'New Folder' inside it such that "(empty)" message is seen. 4. Now keep mouse cursor on "(empty)" message and (without moving mouse) right click on it twice. 5. Press 'Esc' key and observe. Actual : Chrome crashes after pressing 'Esc' key. Expected : Chrome should not crash. Crash ID 03043416-3c52-4fa6-94aa-388913c7ba9f (Server ID: 97c320d480000000) This is a Non-Regression issue seen from M-30 build 30.0.1549.0. Note : Above issue is not reproducible on Mac(10.11.6, 10.12.1, 10.12) OS.
,
Mar 24 2017
,
Mar 24 2017
,
Mar 29 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1f74ed2b7c59a6202072a0ceee38bbfb922bfb61 commit 1f74ed2b7c59a6202072a0ceee38bbfb922bfb61 Author: jonross <jonross@chromium.org> Date: Wed Mar 29 17:54:57 2017 MenuController Do Not SetSelection to Empty Items on Drag There is a Chrome crash caused by the following: - Menu opened - Submenu of the above opened, with only an empty menu item - Context menu nested above the empty menu item - A dragging right-click outside of the context menu, and within the empty menu item - Pressing ESC once the context menu has relaunched Empty menu items cannot be set as selection targets, and we do not allow arrow keys to select them. In a normal mouse over they are ignored. MenuController::OnMouseDragged however was not handling the result of GetMenuPart which signified an empty menu item. It would attempt to update the selection to an invalid state, and would hide the current menu. The subsequent OnMouseReleased would bring back the context menu, as the drag was only hiding the menu, not closing. The subsequent ESC key would then attempt to be processed by the invalid menu set in OnMouseDragged. This change update OnMouseDragged to properly ingore mouse targets of empty menu items. Bringing it inline with the behaviours of OnMouseMoved. TEST=MenuControllerTest.RepostEventToEmptyMenuItem BUG= 704846 Review-Url: https://codereview.chromium.org/2778383002 Cr-Commit-Position: refs/heads/master@{#460449} [modify] https://crrev.com/1f74ed2b7c59a6202072a0ceee38bbfb922bfb61/ui/views/controls/menu/menu_controller.cc [modify] https://crrev.com/1f74ed2b7c59a6202072a0ceee38bbfb922bfb61/ui/views/controls/menu/menu_controller_unittest.cc [modify] https://crrev.com/1f74ed2b7c59a6202072a0ceee38bbfb922bfb61/ui/views/test/menu_test_utils.cc [modify] https://crrev.com/1f74ed2b7c59a6202072a0ceee38bbfb922bfb61/ui/views/test/menu_test_utils.h
,
Mar 29 2017
,
Apr 4 2017
Verified the the issue on windows 7 using chrome M59 #59.0.3061.3 and issue is fixed. Due to the build failure on linux , verified the issue on ubuntu 14.04 using chrome M59 #59.0.3061.0 and issue is fixed. No crash is seen on pressing esc key . Attached screencast for reference. Adding Te-Verified labels. Thanks! |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by ranjitkan@chromium.org
, Mar 24 2017