New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 704825 link

Starred by 7 users

Issue metadata

Status: Assigned
Owner:
OOO until 4th Feb
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug
Team-Security-UX

Blocking:
issue 697243



Sign in to add a comment

Can't undo permission when there is a pattern

Project Member Reported by benwells@chromium.org, Mar 24 2017

Issue description

1. Clear permissions of https://permission.site (or any site)
2. Go to content settings and add an exception for notifications for https://[*.]permission.site to allow.
3. Go to https://permission.site page info and notice that the notification is allow, non default. Seems right.
4. Change that back to Ask (default) in page info
5. Reload and go back to page info and notice it is back to Allow.

I think the right solution here is ... to basically rethink the way we present the permissions model we have :)

Currently we have 'defaults' and 'exceptions'. Patterns are exceptions. Things you allow via prompts are excetpsions.

What we should have is 'defaults', 'exceptions' and 'allowed / blocked sites'. Patterns are still exceptions but are an advanced concept.

When in page info and the current setting is due to an exception, it should be treated like when the setting comes from an exception or enterprise setting. I.e. not be editable from page info.

Exceptions should also be treated quite differently in the settings UI we have.
 
I would consider this a special case of  Issue 614618 .
But if there's a reasonable way to fix  Issue 614618  without fixing this, I don't mind keeping them separate. Do you see such a way?
Components: UI>Browser>Bubbles>PageInfo
Blocking: 697243
Some context to #1: as far as I understand, the inability to override an inherited setting with Ask (except for Flash) is "working as intended" for our current permissions model. However, it would be nice if our model either naturally supported it, or were structured in such a way that you wouldn't "want" to do it this way.

But the UI is still doing something wrong in either case.
Ah, thanks for pointing that bug out. It happens to have has fixed itself, as we now scoped all permissions to origin by default :)
Re #4: Right - according to the model it is kind of expected, but the UI is currently wrong :)

I think disabling it in this case and making it clear how to undo the manual exception is the right way to go, but that will require design work and probable improvements in settings.
Owner: raymes@chromium.org
Status: Assigned (was: Untriaged)
assigning to Raymes as general owner of permissions model
benwells: I think I agree with your suggestion in the original description in terms of simplicity. One problem is that currently per-origins settings actually have a higher precedence than broad exceptions. It would be a fairly significant breaking change to change that. We would need to determine how many users it would impact and whether the breakage would be worth it. 

One of the use cases we've seen is that some people want to be able to broadly block something (like Javascript on all https) but enable it on a case-by-case basis. Changing the way exceptions work would make this impossible to do.

Another approach to this would be to treat exceptions more like embargo. That is, they apply on top of defaults but are overridable by users for specific sites. This is basically the behavior today. The challenge then is how to do the UX. I think there could be some reasonable solutions there. Probably not as clean as what you're suggestion in #0 but still reasonable.
OK. Seems like we have a few options and can come up with something good, once we have the time to implement it...
Components: -UI>Browser>Permissions Internals>Permissions>Model
Cc: mea...@chromium.org msramek@chromium.org ashej...@chromium.org nyerramilli@chromium.org
 Issue 614618  has been merged into this issue.
We have a doc about this here: https://docs.google.com/document/d/1XxLt9tlNizWDMbO_gWegVnZs_kNM1anI1vR56fjRhf0/edit

Now we just have to find time to do the work :) 
Cc: -ashej...@chromium.org
Labels: Hotlist-EnamelAndFriendsFixIt
Labels: -Hotlist-EnamelAndFriendsFixIt
Labels: Hotlist-DesktopUIValid Hotlist-DesktopUIChecked
*** UI Mass Triage***

Tested on latest Canary #72.0.3618.0 on Windows 10 and was able to reproduce the issue as the issue seems to be fixed. Hence, adding appropriate labels.

Thanks!

Sign in to add a comment