Issue 704824 link

Starred by 1 user

Issue metadata

Status:	Fixed
Owner:	npm@chromium.org
Closed:	Mar 2017
Cc:	█ msrchandra@chromium.org
Components:	Internals>Plugins>PDF
EstimatedDays:	----
NextAction:	----
OS:	Linux
Pri:	2
Type:	Bug
Reproducible Stability-Memory-AddressSanitizer Stability-Memory-LeakSanitizer Stability-Libfuzzer Clusterfuzz Test-Predator-Wrong-CLs

Blocking:
issue 62400

Direct-leak in CPDF_InterForm::AddTerminalField

Project Member Reported by ClusterFuzz, Mar 24 2017

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=6375485740417024

Fuzzer: libfuzzer_pdfium_xfa_fuzzer
Job Type: libfuzzer_chrome_asan
Platform Id: linux

Crash Type: Direct-leak
Crash Address: 
Crash State:
  CPDF_InterForm::AddTerminalField
  CPDF_InterForm::LoadField
  CPDF_InterForm::CPDF_InterForm
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan&range=459191:459241

Reproducer Testcase: https://clusterfuzz.com/download/AMIfv95pCwWrnxw2c4m4AM0tlFVXBSQVHMrzs88YDQ_cSR8h9zHmONeb6Sls_hCUcyBmP4ShHlOjeK1-i4JQO93c-EmTAqhI04rNgdJkFFK440cDdVoO0-n6pJaa6bkbZSgDeEzXnh3OttgHK5rlyoOfte5-xzYui9x7xvO1_aeYasZG9NsOLJJkDkg8wk3mhAnP_uROi0ZuiKg8w0Iw4hVtR8vt6-xUV-9Kcs4e9XGmVWzHhRiTFFSESmCI8pmPWCsBlsfBvVjSt2rYgMTN9hCZCqPxLhbg5yKveKScbWaCjw9oR5EX9NnO2-PZhwo4tYNkzLp4JWn2CrVNbwqfx9eDC7pgoPic9r4LzYBOQbYH-_S9q6yPUpZOU2jzDLskz2R9f-HukQivq5ismNg4QP7m73hLexyEaQ?testcase_id=6375485740417024


Issue filed automatically.

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reproducing.md for more information.

Comment 1 by msrchandra@chromium.org, Mar 24 2017

Cc: msrchandra@chromium.org
Labels: Test-Predator-Wrong-CLs
Owner: npm@chromium.org
Status: Assigned (was: Untriaged)

Predator and CL did not provide any possible suspects.
Using Code Search for the file, "cpdf_interform.cpp" assigning to the concern owner.
Suspecting Commit#
https://pdfium.googlesource.com/pdfium.git/+/a478dc5ca23b6f2f609b119cdc6b0336d1471d8c

@Nicolas Pena -- Could you please look into the issue, kindly re-assign if this is not related to your changes.
Thank You.

Comment 2 by thestig@chromium.org, Mar 24 2017

Components: Internals>Plugins>PDF

Project Member

Comment 3 by bugdroid1@chromium.org, Mar 24 2017

The following revision refers to this bug:
  https://pdfium.googlesource.com/pdfium/+/08b96e737d916c00f0045126d2207f4303951e55

commit 08b96e737d916c00f0045126d2207f4303951e55
Author: Nicolas Pena <npm@chromium.org>
Date: Fri Mar 24 19:37:14 2017

Use unique_ptr in CFieldTree::Node

Bug:  chromium:704824 
Change-Id: I3de1a0bcee3317cfaa7e56578b637e427098230a
Reviewed-on: https://pdfium-review.googlesource.com/3213
Commit-Queue: Nicolás Peña <npm@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>

[modify] https://crrev.com/08b96e737d916c00f0045126d2207f4303951e55/core/fpdfdoc/cpdf_interform.h
[modify] https://crrev.com/08b96e737d916c00f0045126d2207f4303951e55/core/fpdfdoc/cpdf_interform.cpp
[modify] https://crrev.com/08b96e737d916c00f0045126d2207f4303951e55/core/fpdfdoc/cpdf_formfield.h

Comment 4 by dsinclair@chromium.org, Mar 27 2017

Blocking: 62400

This is an XFA issue which is not enabled on any branch of Chrome.

Comment 5 by npm@chromium.org, Mar 27 2017

Status: Fixed (was: Assigned)

►

Issue 704824 link

Issue metadata

Direct-leak in CPDF_InterForm::AddTerminalField

Issue description

Comment 1 by msrchandra@chromium.org, Mar 24 2017

Comment 1 Deleted

Comment 2 by thestig@chromium.org, Mar 24 2017

Comment 2 Deleted

Comment 3 by bugdroid1@chromium.org, Mar 24 2017

Comment 3 Deleted

Comment 4 by dsinclair@chromium.org, Mar 27 2017

Comment 4 Deleted

Comment 5 by npm@chromium.org, Mar 27 2017

Comment 5 Deleted

Sign in to add a comment