New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 704791 link

Starred by 1 user

Issue metadata

Status: Untriaged
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

"transpose" command should not change selection when if it is canceled by beforeinput

Project Member Reported by yosin@chromium.org, Mar 24 2017

Issue description

When "transpose" command is canceled by "beforeinput" event handler,
Blink change selection at L1413.

Note: This issue is found by looking  issue 704036 

void Editor::transpose() {
 ....

1410  // Select the two characters.
1411  if (createVisibleSelection(newSelection) !=
1412      frame().selection().computeVisibleSelectionInDOMTreeDeprecated())
1413    frame().selection().setSelection(newSelection);
1414
1415  if (dispatchBeforeInputInsertText(
1416          eventTargetNodeForDocument(frame().document()), transposed,
1417          InputEvent::InputType::InsertTranspose) !=
1418      DispatchEventResult::NotCanceled)
1419    return;

 
Components: Blink>Editing

Comment 2 by yosin@chromium.org, Jan 10 2018

Labels: Pri-3

Comment 3 by chongz@chromium.org, Jan 11 2018

Cc: chongz@chromium.org yosin@chromium.org xiaoche...@chromium.org
Owner: ----
Status: Available (was: Assigned)
Un-assigning myself so others can pick up.
Project Member

Comment 4 by sheriffbot@chromium.org, Jan 14

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment