Issue metadata
Sign in to add a comment
|
10.3%-12.9% regression in blink_perf.dom at 458558:458608 |
||||||||||||||||||||
Issue descriptionSee the link to graphs below.
,
Mar 24 2017
Started bisect job https://chromeperf.appspot.com/buildbucket_job_status/8984285702836671280
,
Mar 24 2017
=== Auto-CCing suspected CL author rune@opera.com === Hi rune@opera.com, the bisect results pointed to your CL, please take a look at the results. === BISECT JOB RESULTS === Perf regression found with culprit Suspected Commit Author : rune Commit : df2ef06a75aae87d449e2f801e90fd418679871b Date : Tue Mar 21 22:13:56 2017 Subject: Updating :in-range should not rely on validation. Bisect Details Configuration: android_one_perf_bisect Benchmark : blink_perf.dom Metric : select-single-add/select-single-add Change : 9.39% | 152.10120935 -> 137.818211885 Revision Result N chromium@458572 152.101 +- 4.058 6 good chromium@458575 152.743 +- 1.81692 6 good chromium@458576 137.834 +- 2.61735 6 bad <-- chromium@458577 137.829 +- 1.82494 6 bad chromium@458581 138.489 +- 2.80588 6 bad chromium@458590 137.105 +- 1.86983 6 bad chromium@458608 137.818 +- 2.54752 6 bad To Run This Test src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests blink_perf.dom Debug Info https://chromeperf.appspot.com/buildbucket_job_status/8984285702836671280 Is this bisect wrong? https://chromeperf.appspot.com/bad_bisect?try_job_id=5546409526296576 | O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq | X | for more information addressing perf regression bugs. For feedback, | / \ | file a bug with component Speed>Bisection. Thank you!
,
Mar 24 2017
,
Mar 24 2017
,
Mar 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b2cdcbfc13078c618e722c988e5afc0a5d435e74 commit b2cdcbfc13078c618e722c988e5afc0a5d435e74 Author: rune <rune@opera.com> Date: Mon Mar 27 09:37:53 2017 Update :in-range/:out-of-range when steppable min/max/value changes. We called pseudoStateChanged in a lot of cases where it wasn't necessary. It should suffice to call it for the mentioned pseudo classes when the min and max attributes changes, or the value is changed, either as an attribute or as a result of user input. This should fix the performance regressions in issue 704775 . R=tkent@chromium.org BUG= 704775 Review-Url: https://codereview.chromium.org/2774723004 Cr-Commit-Position: refs/heads/master@{#459733} [modify] https://crrev.com/b2cdcbfc13078c618e722c988e5afc0a5d435e74/third_party/WebKit/Source/core/html/HTMLFormControlElement.cpp [modify] https://crrev.com/b2cdcbfc13078c618e722c988e5afc0a5d435e74/third_party/WebKit/Source/core/html/HTMLInputElement.cpp [modify] https://crrev.com/b2cdcbfc13078c618e722c988e5afc0a5d435e74/third_party/WebKit/Source/core/html/forms/InputType.cpp [modify] https://crrev.com/b2cdcbfc13078c618e722c988e5afc0a5d435e74/third_party/WebKit/Source/core/html/forms/InputType.h
,
Mar 27 2017
|
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by jasontiller@chromium.org
, Mar 24 2017