New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 704771 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 1
Type: Bug
Team-Security-UX



Sign in to add a comment

Repeated notification permission prompt dismissal blocks requests -> no way to whitelist during development

Reported by s...@sethkinast.com, Mar 24 2017

Issue description

Chrome Version       : 59.0.3049.0 canary (64-bit)

What steps will reproduce the problem?
(1) Dismiss a notification request prompt several times
(2) Get the console message: "Notifications permission has been blocked as the user has dismissed the permission prompt several times. See https://www.chromestatus.com/features/6443143280984064 for more information."

What is the expected result?
I'm working on testing a notification flow, so I want to repeatedly pop the dialog, dismiss it, accept it, etc.

What happens instead?
No way to disable this block behavior (for testing) via a whitelist, config, etc

 
Clearing browsing data will clear the block. We're also working on a patch that will allow you to clear the block by resetting the permission state to "Ask" via the page info dialog from the lock icon.

Comment 2 by s...@sethkinast.com, Mar 24 2017

Sounds good, thanks! I cleared the block successfully by clearing the "Cookies and other site and plugin data" subtype.
Labels: -Pri-3 M-59 OS-Android OS-Chrome OS-Linux OS-Mac OS-Windows Pri-1
Owner: patricia...@chromium.org
Status: Assigned (was: Unconfirmed)
Thanks for the bug report. Hopefully we'll have the extra clearing behaviour on Canary in the next week or so (and I'll updated the chromestatus entry when it lands so it's clear how to remove the block in testing). :)

+patricialor, who will possibly implement (it'll be me otherwise).
Project Member

Comment 4 by bugdroid1@chromium.org, Apr 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7131c1fee08ad62e85476acfd3604765bc997f39

commit 7131c1fee08ad62e85476acfd3604765bc997f39
Author: patricialor <patricialor@chromium.org>
Date: Fri Apr 07 01:25:52 2017

Permissions: Clear embargo if user changes an embargoed permission's setting.

Allow the embargo status of a permission to be cleared when the user changes the
setting for an embargoed permission to "Ask" or "Allow". However, the system
will still remember that the setting was previously embargoed, so if another
permission prompt is dismissed for that permission, it will be re-embargoed.
Permissions embargoed because they are blacklisted will be re-embargoed if they
are still on the blacklist during the next permission request.

BUG= 704771 
TEST=Run Chrome with the command line flag
--enable-features=BlockPromptsIfDismissedOften and navigate to
https://permission.site. Place the notification permission under embargo by
clicking the "Notifications" button three times until the permission prompt no
longer appears. In the page info bubble, the "Notifications" drop-down should
say "block". Choose "Allow" instead, which should update the bubble to allow
notifications and ask for the page to be reloaded. Then change the drop-down to
"Ask", which should also update the notifications permission back to "Ask".
Click the "Notifications" button on the page again and notice the permission
prompt to ask for notifications permission is shown again.

Review-Url: https://codereview.chromium.org/2790473004
Cr-Commit-Position: refs/heads/master@{#462733}

[modify] https://crrev.com/7131c1fee08ad62e85476acfd3604765bc997f39/chrome/browser/android/preferences/website_preference_bridge.cc
[modify] https://crrev.com/7131c1fee08ad62e85476acfd3604765bc997f39/chrome/browser/permissions/permission_decision_auto_blocker.cc
[modify] https://crrev.com/7131c1fee08ad62e85476acfd3604765bc997f39/chrome/browser/permissions/permission_decision_auto_blocker.h
[modify] https://crrev.com/7131c1fee08ad62e85476acfd3604765bc997f39/chrome/browser/permissions/permission_decision_auto_blocker_unittest.cc
[modify] https://crrev.com/7131c1fee08ad62e85476acfd3604765bc997f39/chrome/browser/ui/page_info/page_info.cc

Status: Fixed (was: Assigned)
The change in #c4 should have fixed this for Desktop and Android.
Cc: krajshree@chromium.org
Labels: Needs-Feedback
Tested the issue on Windows 10 using chrome version #59.0.3067.6 and Mac 10.12.3 and Ubuntu 14.04 using chrome version #59.0.3067.0(due to non-availability of chrome dev build #59.0.3067.6 for OS-Mac and OS-Linux) as per comment #4.

Attached a screen cast for reference.

Following are the steps followed to reproduce the issue.
------------
1. Ran Chrome with the command line flag --enable-features=BlockPromptsIfDismissedOften
2. Navigated to https://permission.site.
3. Clicked the "Notifications" button three times, but permission prompt did not disappear.
4. In the page info bubble, clicked "allow" button.
5. In chrome://settings/content, clicked "notifications" option in which "ask before sending(recommended)" option was by default enabled.
6. Refreshed the permissions page and clicked the "Notifications" button on the page again and did not observe any permission prompt asking for notifications permission.

patricialor@ - Could you please verify the screen cast and please let us know if anything missed from our side. 

Thanks...!!
704771.mp4
3.1 MB View Download
Oops, sorry - thanks for checking this, the instructions I provided were not complete. Here's your repro steps amended to include everything:

1. Run Chrome with the command line flag --enable-features=BlockPromptsIfDismissedOften
2. Navigate to https://permission.site.
3. Click the "Notifications" button, observe the permission prompt appeared under the omnibox, then press escape to close it.
4. Repeat step #3. On the fourth click, the prompt will not appear again.
5. Open the page info bubble by clicking on the "Secure" text in the omnibox. Observe the notifications drop-down says "Block".
6. Change this to "Allow".
7. Reload the page as asked. Observe that clicking on the "Notifications" button again turns it green.
8. Open the page info bubble again, but this time change the notifications drop-down to "Ask".
9. Click the "Notifications" button again and observe the permission prompt appears again under the omnibox. After pressing escape to close it, clicking the "Notifications" button again should not show another prompt.

Sign in to add a comment