New issue
Advanced search Search tips

Issue 704754 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug



Sign in to add a comment

Cloud Print Connector may not work correctly without initializing COM STA

Project Member Reported by thestig@chromium.org, Mar 23 2017

Issue description

Chrome Version: 57.0.2987.98, 59.3041.0 canary.
OS: Windows

What steps will reproduce the problem?
1. Visit chrome browser.
2. Open chrome://devices page
3. Try to register Classic printers by selecting "AddPrinters" button.
4. Navigate to printer confirmation page with "Finish Printer registration" click the button
5. After confirming the Printer Registration check the added Printers in Management page

What is the expected result?

User should able to print the job without any error.

What happens instead?

The classic printers are getting registered to the user account successfully but if user tries to submit the job to the printer, the printers are going to OFFLINE & submitted job status shows as "InProgress or Queued".

This was originally filed as b/36221111

r446071 removed the COM STA initialization by default, which means the service process that hosts the Cloud Print Connector no longer works correctly in some situations. r446071 has been merged to M57, so the same problem occurs there as well.
 
Cc: robliao@chromium.org fdoray@chromium.org gab@chromium.org
Components: Internals>TaskScheduler
We will have an ability to specify COM STA task runners soon.
How do you feel about https://codereview.chromium.org/2774653003 in the meanwhile?

Comment 3 by gov...@chromium.org, Mar 24 2017

Cc: pbomm...@chromium.org
By looking at b/36221111, this seems to be an M57 regression but specific to HP printers. How many users are impacted by this? Please note that M57 for desktop has been out for stable at 1% of users since last two weeks (starting 03/09).

Please plan to have fix landed/merged to M57 release branch by 5:00 PM PT, tomorrow Friday, 03/24 so we can pick it up for next week Stable release if this is indeed a stable blocker. Thank you.
Other printers may be affected. We don't know for sure. I'll try to get the fix landed / merged ASAP.

Comment 6 by gov...@chromium.org, Mar 24 2017

Thank you  thestig@.
Cl is not yet landed in Canary. Will it be a safe to directly merge to release branch (M57 and M58) without Canary coverage?
CL is in CQ and should land shortly. Not sure if it will make a Canary build in time for testing tomorrow. I've tested the M57 version locally. It is service process code, so it only affects the Cloud Print Connector.
Project Member

Comment 8 by bugdroid1@chromium.org, Mar 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d36381e3b65747fc7ea9df344129fa7ced3a0afe

commit d36381e3b65747fc7ea9df344129fa7ced3a0afe
Author: thestig <thestig@chromium.org>
Date: Fri Mar 24 03:26:36 2017

Initialize COM STA in the service process.

BUG= 704754 

Review-Url: https://codereview.chromium.org/2774653003
Cr-Commit-Position: refs/heads/master@{#459353}

[modify] https://crrev.com/d36381e3b65747fc7ea9df344129fa7ced3a0afe/chrome/service/service_process.cc

Comment 9 by gov...@chromium.org, Mar 24 2017

Cl listed at #8 didn't make it today's canary cut 8:00 PM PT.
As it is service process code only affects the Cloud Print Connector, we don't expect to see any functional/stability regression, correct?
Correct. Nothing else should be affected by this. I can do my own official build tomorrow at ToT and verify it works there too.
Thank you  thestig@. Please update the bug once you verify it works in ToT tomorrow. I will approve M57 merge then. Please plan for M57 merge before 5:00 PM PT.

Comment 12 by gab@chromium.org, Mar 24 2017

Thanks for digging into this, let us know if it doesn't merge cleanly in M57.
gab: It doesn't merge cleanly, but I have the branch-specific CLs ready in comment 5. Doing a built at ToT now to verify.
Well, the bad news is ToT builds are broken for a different reason, so I can't actually verify.
That is to say, Canary, without r459353 is broken too - printers aren't registering at all.
Labels: Merge-Request-57
Though I have tested M57 locally and I know it works. So in the interest of time, I'll request a merge now. We'll get a new M57 build with the merge and I will verify that works.
Labels: -Merge-Request-57 Merge-Approved-57
Approving merge to M57 based on comment #9, #10 and #16. Please merge ASAP. Thank you.
Project Member

Comment 18 by bugdroid1@chromium.org, Mar 24 2017

Labels: -merge-approved-57 merge-merged-2987
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a30e61fe2c335554a3287313485e82d6bfe0b271

commit a30e61fe2c335554a3287313485e82d6bfe0b271
Author: Lei Zhang <thestig@chromium.org>
Date: Fri Mar 24 21:12:23 2017

M57: Initialize COM STA in the service process.

BUG= 704754 

Review-Url: https://codereview.chromium.org/2765333004 .
Cr-Commit-Position: refs/branch-heads/2987@{#876}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}

[modify] https://crrev.com/a30e61fe2c335554a3287313485e82d6bfe0b271/chrome/service/service_process.cc

Comment 19 by gab@chromium.org, Mar 24 2017

Cool thanks, CL looks pretty similar to me so I guess conflict was minor?
Minor indeed. It conflicted with r458450.
59.0.3048.0 + r459353 works for me. Will verify the next M57 build when it's ready.
Filed  bug 705175  for the printer registration problem that is preventing verification on ToT. After verifying for M57, I will also request a merge to M58.
M57 build #57.0.2987.127 is available with this fix for testing.
Please request a merge to M58 as well if change looks good in M57. Thank you.
Labels: Merge-Request-58
We tested 57.0.2987.128 and the offline cloud printer issue no longer occurs.
Project Member

Comment 26 by sheriffbot@chromium.org, Mar 27 2017

Labels: -Merge-Request-58 Hotlist-Merge-Approved Merge-Approved-58
Your change meets the bar and is auto-approved for M58. Please go ahead and merge the CL to branch 3029 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Your change is approved for M58. Please merge ASAP so that it will be picked up for next Beta Release, RC cut on (Tuesday-03/28) at 4.00 PM PST.
Project Member

Comment 28 by bugdroid1@chromium.org, Mar 27 2017

Labels: -merge-approved-58 merge-merged-3029
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7609c1d6cc0485f6c03dd22572be811bd0212d39

commit 7609c1d6cc0485f6c03dd22572be811bd0212d39
Author: Lei Zhang <thestig@chromium.org>
Date: Mon Mar 27 18:04:14 2017

M58: Initialize COM STA in the service process.

BUG= 704754 

Review-Url: https://codereview.chromium.org/2772573004 .
Cr-Commit-Position: refs/branch-heads/3029@{#432}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}

[modify] https://crrev.com/7609c1d6cc0485f6c03dd22572be811bd0212d39/chrome/service/service_process.cc

Status: Fixed (was: Started)

Sign in to add a comment