New issue
Advanced search Search tips

Issue 704749 link

Starred by 2 users

Issue metadata

Status: Available
Owner: ----
Cc:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Feature

Blocked on:
issue 807500



Sign in to add a comment

Investigate Running AppVerifier as an FYI Bot

Project Member Reported by robliao@chromium.org, Mar 23 2017

Issue description

AppVerifier has been finding some real code bugs in Chrome. It might be useful to have it as a bot.

wfh@chromium.org> is it possible to stand up an FYI bot with appverifier running?

robliao@chromium.org>
That's a good question. AppVerifier currently doesn't play nicely with the renderer processes, so I have to enable it and then disable it. This is probably easily scriptable with ImageFileExecutionOptions registry manipulations. To get the messages, you also need to run under a cdb/ntsd/windbg debugger.

It certainly is an interesting idea.

wfh@chromium.org> right so basically it has to be enabled for browser but not renderer? can it be toggled on/off using !gflags in cdb?
 

Comment 1 by wfh@chromium.org, Mar 23 2017

Labels: OS-Windows
I see I am already subscribed to your newsletter. :) great!
Description: Show this description
gflags does control whether or not App Verifier gets injected (https://msdn.microsoft.com/en-us/library/windows/hardware/ff542875(v=vs.85).aspx)
	
0x100 FLG_APPLICATION_VERIFIER

So yeah, we can likely toggle it back and forth to prevent it from running. Given that AppVerifier does mutate ImageFileExecutionOptions, we'd also have to check that the NT kernel doesn't do anything based off of that either.
Description: Show this description
Blockedon: 807500
The blocking issue is now fixed and Chrome can run with Application Verifier. It has already found one handle race condition in mojo (fixed) and I hit one random failure (I failed to get call stacks or other details unfortunately) so there is at least one bug out there waiting to be found.

The Leaks check needs to be disable and on some machines the Locks check has to be disabled (Intel driver bug, reported to Intel) but the setup should be easy. I think it would be a matter of configuring it with the UI then saving the registry data so that it can be reapplied from the command line.

Sign in to add a comment