New issue
Advanced search Search tips

Issue 704706 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Bug

Blocked on:
issue 704675
issue 704676



Sign in to add a comment

[Payments] Desktop Handle canMakePayment

Project Member Reported by ma...@chromium.org, Mar 23 2017

Issue description

Handle canMakePayment according to spec.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1a5be4fc4a86617e3c0700eb3be847989a7d175a

commit 1a5be4fc4a86617e3c0700eb3be847989a7d175a
Author: mathp <mathp@chromium.org>
Date: Fri Mar 24 18:09:19 2017

[Payments] Support canMakePayment on Desktop

Filed bugs for missing features.

BUG= 704706 
TEST=components_unittests, browser_tests

Review-Url: https://codereview.chromium.org/2766353004
Cr-Commit-Position: refs/heads/master@{#459475}

[modify] https://crrev.com/1a5be4fc4a86617e3c0700eb3be847989a7d175a/chrome/browser/ui/views/payments/credit_card_editor_view_controller_browsertest.cc
[modify] https://crrev.com/1a5be4fc4a86617e3c0700eb3be847989a7d175a/chrome/browser/ui/views/payments/payment_request_browsertest.cc
[add] https://crrev.com/1a5be4fc4a86617e3c0700eb3be847989a7d175a/chrome/browser/ui/views/payments/payment_request_can_make_payment_browsertest.cc
[modify] https://crrev.com/1a5be4fc4a86617e3c0700eb3be847989a7d175a/chrome/test/BUILD.gn
[modify] https://crrev.com/1a5be4fc4a86617e3c0700eb3be847989a7d175a/components/payments/content/payment_request.cc
[modify] https://crrev.com/1a5be4fc4a86617e3c0700eb3be847989a7d175a/components/payments/content/payment_request_state.cc
[modify] https://crrev.com/1a5be4fc4a86617e3c0700eb3be847989a7d175a/components/payments/content/payment_request_state.h
[modify] https://crrev.com/1a5be4fc4a86617e3c0700eb3be847989a7d175a/components/payments/content/payment_request_state_unittest.cc

Status: Fixed (was: Assigned)

Comment 3 by ma...@chromium.org, May 9 2017

yay thanks for the last hurrah on this!
Components: -UI>Browser>Autofill>Payments UI>Browser>Payments

Sign in to add a comment