New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 704688 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Bug



Sign in to add a comment

Flash needs UKM Metrics

Project Member Reported by tommycli@chromium.org, Mar 23 2017

Issue description

Flash needs UKM Metrics
 
Labels: Merge-Request-58
Doing an early merge request for 58, since this will be critical for the next wave of outreach and given the surgical nature of the patch.
Please add applicable OSs.  Thanks!
Labels: OS-Chrome OS-Linux OS-Mac OS-Windows
Project Member

Comment 5 by sheriffbot@chromium.org, Apr 4 2017

Labels: -Merge-Request-58 Hotlist-Merge-Approved Merge-Approved-58
Your change meets the bar and is auto-approved for M58. Please go ahead and merge the CL to branch 3029 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 6 by bugdroid1@chromium.org, Apr 4 2017

Labels: -merge-approved-58 merge-merged-3029
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9e5d523917b41921ae89fa538492f8a0ca84566a

commit 9e5d523917b41921ae89fa538492f8a0ca84566a
Author: Tommy C. Li <tommycli@chromium.org>
Date: Tue Apr 04 17:30:38 2017

Plugins: Add UKM Metrics to Flash loads

Tracks the main frame's URL for loads of Flash plugin instances.

BUG= 704688 

Review-Url: https://codereview.chromium.org/2768263003
Cr-Commit-Position: refs/heads/master@{#461458}
(cherry picked from commit 910b408e9d1ba5c36b5663a682b70cfc43e58a53)

Review-Url: https://codereview.chromium.org/2798643002 .
Cr-Commit-Position: refs/branch-heads/3029@{#570}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}

[modify] https://crrev.com/9e5d523917b41921ae89fa538492f8a0ca84566a/chrome/browser/plugins/plugin_info_message_filter.cc
[modify] https://crrev.com/9e5d523917b41921ae89fa538492f8a0ca84566a/chrome/browser/plugins/plugin_info_message_filter.h
[modify] https://crrev.com/9e5d523917b41921ae89fa538492f8a0ca84566a/components/ukm/ukm_service.h

Status: Fixed (was: Untriaged)
Thanks all!
Cc: johnpallett@chromium.org ericde@chromium.org
Thank you sir!
Project Member

Comment 9 by bugdroid1@chromium.org, May 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f4063d939f75d7858172f7a0558b3873697d9b1e

commit f4063d939f75d7858172f7a0558b3873697d9b1e
Author: rkaplow <rkaplow@chromium.org>
Date: Wed May 03 21:58:19 2017

Add Flash to UKM entry list

BUG= 704688 

Review-Url: https://codereview.chromium.org/2861843003
Cr-Commit-Position: refs/heads/master@{#469149}

[modify] https://crrev.com/f4063d939f75d7858172f7a0558b3873697d9b1e/tools/metrics/ukm/ukm.xml

Sign in to add a comment