New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 704684 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Aug 2017
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

pass voice interaction context from cros to arc

Project Member Reported by muyuanli@chromium.org, Mar 23 2017

Issue description

To implement voice interaction api in Android, the context from cros
should be passed to ARC.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bac4a9787174ce5e4bb7c4dded78f60550d667ba

commit bac4a9787174ce5e4bb7c4dded78f60550d667ba
Author: muyuanli <muyuanli@chromium.org>
Date: Wed Apr 05 02:43:07 2017

Taking screenshot of current focused window.

BUG= 704684 
BUG=b:35643583
TEST=screenshot sent to voice interaction session
  in ARC.

Review-Url: https://codereview.chromium.org/2795693005
Cr-Commit-Position: refs/heads/master@{#461950}

[modify] https://crrev.com/bac4a9787174ce5e4bb7c4dded78f60550d667ba/chrome/browser/chromeos/arc/voice_interaction/arc_voice_interaction_framework_service.cc

Project Member

Comment 2 by bugdroid1@chromium.org, Apr 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c693ba146941bf2baba7f2544f3ccb6349dd211f

commit c693ba146941bf2baba7f2544f3ccb6349dd211f
Author: muyuanli <muyuanli@chromium.org>
Date: Thu Apr 27 19:12:40 2017

1. Refactor accessibility to allow code sharing from
   web_contents_android and ARC.
2. Implement sending voice interaction structure from
   cros to ARC.

BUG=b/35643583
BUG= 704684 
TEST=
  browser_tests --gtest_filter=\
     ArcVoiceInteractionArcHomeServiceTest.*
TEST=manually verified ax element position in clank
TEST=verified voice interaction structure sent to ARC

Review-Url: https://codereview.chromium.org/2808383004
Cr-Commit-Position: refs/heads/master@{#467746}

[modify] https://crrev.com/c693ba146941bf2baba7f2544f3ccb6349dd211f/chrome/browser/chromeos/BUILD.gn
[modify] https://crrev.com/c693ba146941bf2baba7f2544f3ccb6349dd211f/chrome/browser/chromeos/arc/arc_service_launcher.cc
[add] https://crrev.com/c693ba146941bf2baba7f2544f3ccb6349dd211f/chrome/browser/chromeos/arc/voice_interaction/arc_voice_interaction_arc_home_service.cc
[add] https://crrev.com/c693ba146941bf2baba7f2544f3ccb6349dd211f/chrome/browser/chromeos/arc/voice_interaction/arc_voice_interaction_arc_home_service.h
[add] https://crrev.com/c693ba146941bf2baba7f2544f3ccb6349dd211f/chrome/browser/chromeos/arc/voice_interaction/arc_voice_interaction_arc_home_service_browsertest.cc
[modify] https://crrev.com/c693ba146941bf2baba7f2544f3ccb6349dd211f/chrome/test/BUILD.gn
[modify] https://crrev.com/c693ba146941bf2baba7f2544f3ccb6349dd211f/components/arc/BUILD.gn
[modify] https://crrev.com/c693ba146941bf2baba7f2544f3ccb6349dd211f/components/arc/arc_bridge_host_impl.cc
[modify] https://crrev.com/c693ba146941bf2baba7f2544f3ccb6349dd211f/components/arc/arc_bridge_host_impl.h
[modify] https://crrev.com/c693ba146941bf2baba7f2544f3ccb6349dd211f/components/arc/arc_bridge_service.h
[modify] https://crrev.com/c693ba146941bf2baba7f2544f3ccb6349dd211f/components/arc/common/arc_bridge.mojom
[add] https://crrev.com/c693ba146941bf2baba7f2544f3ccb6349dd211f/components/arc/common/voice_interaction_arc_home.mojom
[modify] https://crrev.com/c693ba146941bf2baba7f2544f3ccb6349dd211f/content/browser/accessibility/browser_accessibility_android.cc
[modify] https://crrev.com/c693ba146941bf2baba7f2544f3ccb6349dd211f/content/browser/web_contents/web_contents_android.cc
[modify] https://crrev.com/c693ba146941bf2baba7f2544f3ccb6349dd211f/content/browser/web_contents/web_contents_impl.cc
[modify] https://crrev.com/c693ba146941bf2baba7f2544f3ccb6349dd211f/content/browser/web_contents/web_contents_impl.h
[modify] https://crrev.com/c693ba146941bf2baba7f2544f3ccb6349dd211f/content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsImpl.java
[modify] https://crrev.com/c693ba146941bf2baba7f2544f3ccb6349dd211f/content/public/browser/web_contents.h
[modify] https://crrev.com/c693ba146941bf2baba7f2544f3ccb6349dd211f/ui/accessibility/BUILD.gn
[modify] https://crrev.com/c693ba146941bf2baba7f2544f3ccb6349dd211f/ui/accessibility/platform/ax_android_constants.cc
[modify] https://crrev.com/c693ba146941bf2baba7f2544f3ccb6349dd211f/ui/accessibility/platform/ax_android_constants.h
[add] https://crrev.com/c693ba146941bf2baba7f2544f3ccb6349dd211f/ui/accessibility/platform/ax_snapshot_node_android_platform.cc
[add] https://crrev.com/c693ba146941bf2baba7f2544f3ccb6349dd211f/ui/accessibility/platform/ax_snapshot_node_android_platform.h

Status: Fixed (was: Assigned)

Sign in to add a comment