New issue
Advanced search Search tips

Issue 704680 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Feature

Blocking:
issue 704716



Sign in to add a comment

Add Svelte RGBA_4444 support to GPU Raster path

Project Member Reported by ericrk@chromium.org, Mar 23 2017

Issue description

To save memory, we use RGBA_4444 when supported on Svelte devices. The GPU raster path doesn't allow this format at the moment. In preparation for enabling GPU raster on Svelte, we need to allow use of RGBA_4444.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d03c005d730e9510dd6afa7f8d8199e370db96f5

commit d03c005d730e9510dd6afa7f8d8199e370db96f5
Author: ericrk <ericrk@chromium.org>
Date: Fri Mar 24 18:48:52 2017

Enable RGBA_4444 in GpuRasterBufferProvider

Currently, OneCopy/ZeroCopyRasterBufferProvider supports RGBA_4444
(used in Svelte). This change adds similar logic to
GpuRasterBufferProvider.

This also splits ResourceProvider::IsResourceFormatSupported into
ResourceProvider::IsTextureFormatSupported and
IsRasterBufferFormatSupported. This naming matches the existing
best_texture_format() and best_raster_buffer_format() names.

BUG= 704680 
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2775723002
Cr-Commit-Position: refs/heads/master@{#459494}

[modify] https://crrev.com/d03c005d730e9510dd6afa7f8d8199e370db96f5/cc/output/gl_renderer.cc
[modify] https://crrev.com/d03c005d730e9510dd6afa7f8d8199e370db96f5/cc/raster/gpu_raster_buffer_provider.cc
[modify] https://crrev.com/d03c005d730e9510dd6afa7f8d8199e370db96f5/cc/raster/gpu_raster_buffer_provider.h
[modify] https://crrev.com/d03c005d730e9510dd6afa7f8d8199e370db96f5/cc/raster/one_copy_raster_buffer_provider.cc
[modify] https://crrev.com/d03c005d730e9510dd6afa7f8d8199e370db96f5/cc/raster/raster_buffer_provider_perftest.cc
[modify] https://crrev.com/d03c005d730e9510dd6afa7f8d8199e370db96f5/cc/raster/raster_buffer_provider_unittest.cc
[modify] https://crrev.com/d03c005d730e9510dd6afa7f8d8199e370db96f5/cc/raster/zero_copy_raster_buffer_provider.cc
[modify] https://crrev.com/d03c005d730e9510dd6afa7f8d8199e370db96f5/cc/resources/resource_provider.cc
[modify] https://crrev.com/d03c005d730e9510dd6afa7f8d8199e370db96f5/cc/resources/resource_provider.h
[modify] https://crrev.com/d03c005d730e9510dd6afa7f8d8199e370db96f5/cc/test/layer_tree_pixel_resource_test.cc
[modify] https://crrev.com/d03c005d730e9510dd6afa7f8d8199e370db96f5/cc/trees/layer_tree_host_impl.cc

Comment 2 by ericrk@chromium.org, Mar 29 2017

Status: Fixed (was: Started)

Comment 3 by ericrk@chromium.org, Mar 29 2017

Blocking: 704716

Sign in to add a comment