New issue
Advanced search Search tips

Issue 704679 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

decodeAudioData should detach the ArrayBuffer

Project Member Reported by rtoy@chromium.org, Mar 23 2017

Issue description

Project Member

Comment 1 by bugdroid1@chromium.org, Mar 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3010bfc167e7af9d4ecd48a54189c721c2b93dbf

commit 3010bfc167e7af9d4ecd48a54189c721c2b93dbf
Author: rtoy <rtoy@chromium.org>
Date: Thu Mar 23 23:02:01 2017

Detach buffer in decodeAudioData

Handle audio buffer according to WebAudio spec.  If the audio buffer
is detached, reject the promise with DataCloneError.  Otherwise, detach
the buffer and decode the buffer.

Chrome Feature: https://www.chromestatus.com/feature/5539919174828032

BUG= 704679 , 696179
TEST=decodeAudioData/decode-audio-data-neuter.html

Review-Url: https://codereview.chromium.org/2746913003
Cr-Commit-Position: refs/heads/master@{#459266}

[modify] https://crrev.com/3010bfc167e7af9d4ecd48a54189c721c2b93dbf/third_party/WebKit/LayoutTests/webaudio/decodeAudioData/decode-audio-data-basic.html
[add] https://crrev.com/3010bfc167e7af9d4ecd48a54189c721c2b93dbf/third_party/WebKit/LayoutTests/webaudio/decodeAudioData/decode-audio-data-neuter.html
[modify] https://crrev.com/3010bfc167e7af9d4ecd48a54189c721c2b93dbf/third_party/WebKit/Source/modules/webaudio/BaseAudioContext.cpp

Comment 2 by rtoy@chromium.org, Mar 24 2017

Labels: M-59
Status: Fixed (was: Started)

Sign in to add a comment