New issue
Advanced search Search tips

Issue 704672 link

Starred by 2 users
Status: WontFix
Owner: ----
Closed: Apr 2017
Cc:
lfg@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

ASSERT_NO_EXCEPTION should assert in release builds

Project Member Reported by esprehn@chromium.org, Mar 23 2017 
ASSERT_NO_EXCEPTION is used internally when we know that the code should never throw, for example when calling appendChild() from inside the C++ code in a place where author code cannot interfere.

Today ASSERT_NO_EXCEPTION only asserts in debug, but this means we're probably hiding bugs in the wild.

Comment 1 by jbroman@chromium.org, Apr 11 2017 

I'm not sure I understand why these are more worth checking in release than our other ASSERT/DCHECKs. If we're concerned about cases that aren't found by our tests and fuzzers, maybe we could just switch to CHECK in a canary release?

Comment 2 by esprehn@chromium.org, Apr 11 2017 

I reasoned this was different because exceptions are action at a distance. A DCHECK you know what you're testing, but calling appendChild with ASSERT_NO_EXCEPTION is basically "make sure nothing bad happened, but I don't really know what could happen."

But yeah it does seem to be about the same as other dchecks, and we already ship dump-on-dcheck or tried CHECKs in canary before.

Comment 3 by esprehn@chromium.org, Apr 11 2017

Status: WontFix (was: Untriaged)
►

Sign in to add a comment