New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 704665 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

Get rid of first_event_time and last_event_time in LatencyComponent

Project Member Reported by mfomitchev@chromium.org, Mar 23 2017

Issue description

I don't think we should have first_event_time and last_event_time in LatencyInfo::LatencyComponent. From what I see in most cases, we log one event per component, so usually event_time, first_event_time, and last_event_time are all equal. LatencyInfo is sent cross-process as part of compositor frames and also in some other contexts. There's multiple components in each LatencyInfo, and there could be multiple LatencyInfo objects sent as part of a single compositor frame, so this is hundreds of bytes of cross-IPC data, which doesn't seem to be warranted. 

In cases where we need sub-component granularity for events (I am not sure if there are cases like that), can we just create separate components?

tdresser@, jbauman@, sadrul@ - WDYT?
 
Yeah, I'm having a hard time finding where these aren't equal.

Our event coalescing logic used to rely on this, I think, but it appears not to anymore:
https://cs.chromium.org/chromium/src/content/common/input/event_with_latency_info.h?rcl=cbfd644ca2d24fc324101ea15e6198ca71c804c1&l=50
Labels: Hotlist-Input-Dev
Owner: mfomitchev@chromium.org
Status: Available (was: Untriaged)
Owner: tdres...@chromium.org
Owner: nzolghadr@chromium.org
Navid, do you have bandwidth for this?
Cc: -mfomitchev@chromium.org
Status: Assigned (was: Available)

Sign in to add a comment