New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 704650 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Task
Launch-M-Approved: 60-Stable
Launch-M-Target: 60-Stable

Blocked on:
issue 625044
issue 683938

Blocking:
issue 638732



Sign in to add a comment

Require user activation for navigator.vibrate

Project Member Reported by bi...@google.com, Mar 23 2017

Issue description

The vibrate API is abused by sites and ads for social engineering, and we'd like to gate vibrate with user activation (aka. user gesture or user initiated actions) to better protect user.

A follow up of gating vibrate with user activation in cross-origin iframe:  http://crbug.com/625044  &  http://crbug.com/683938 .

See more context:
https://github.com/WICG/interventions/issues/47


 

Comment 1 by rbyers@chromium.org, Mar 27 2017

Blockedon: 683938 625044
Labels: -Type-Bug Type-Launch-OWP

Comment 2 by rbyers@chromium.org, Mar 27 2017

Labels: OWP-Type-ChangeBehavior
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8ff07186c17d708d63ce2bf9fc6d6a9bca92cdae

commit 8ff07186c17d708d63ce2bf9fc6d6a9bca92cdae
Author: binlu <binlu@google.com>
Date: Fri Apr 07 11:42:56 2017

Use hasReceivedUserGesture for collecting vibrate metrics on user gesture.

This is to be consistent with our intended implementation & better
measure the metrics on vibrate blocking.

The Intent to Deprecate thread:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/QGcpjisxtik

BUG= 704650 

Review-Url: https://codereview.chromium.org/2804913004
Cr-Commit-Position: refs/heads/master@{#462838}

[modify] https://crrev.com/8ff07186c17d708d63ce2bf9fc6d6a9bca92cdae/third_party/WebKit/Source/modules/vibration/NavigatorVibration.cpp

Comment 4 by bi...@google.com, Apr 7 2017

Labels: Merge-Request-58
Asking approval to be merged into M58 (for the patch in comment #3) to collect metrics for gating vibrate with user gesture. The Intent to Deprecate thread:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/QGcpjisxtik.
Pls add appropriate OSs label.

Comment 6 by binlu@chromium.org, Apr 7 2017

Labels: OS-Android
It's a blink change, but more applicable to Android, and so set the OSs label as "Android".
Project Member

Comment 7 by sheriffbot@chromium.org, Apr 7 2017

Labels: -Merge-Request-58 Hotlist-Merge-Approved Merge-Approved-58
Your change meets the bar and is auto-approved for M58. Please go ahead and merge the CL to branch 3029 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 8 by bugdroid1@chromium.org, Apr 7 2017

Labels: -merge-approved-58 merge-merged-3029
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b6390f2e420693475ecdc1d31b91ee1159202e5a

commit b6390f2e420693475ecdc1d31b91ee1159202e5a
Author: gogerald <gogerald@google.com>
Date: Fri Apr 07 18:35:49 2017

Use hasReceivedUserGesture for collecting vibrate metrics on user gesture.

This is to be consistent with our intended implementation & better
measure the metrics on vibrate blocking.

The Intent to Deprecate thread:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/QGcpjisxtik

BUG= 704650 

Review-Url: https://codereview.chromium.org/2804913004
Cr-Commit-Position: refs/heads/master@{#462838}
(cherry picked from commit 8ff07186c17d708d63ce2bf9fc6d6a9bca92cdae)

Review-Url: https://codereview.chromium.org/2801363002 .
Cr-Commit-Position: refs/branch-heads/3029@{#630}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}

[modify] https://crrev.com/b6390f2e420693475ecdc1d31b91ee1159202e5a/third_party/WebKit/Source/modules/vibration/NavigatorVibration.cpp

Project Member

Comment 9 by bugdroid1@chromium.org, Apr 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c5b59119ca57398e87a692c9ea836efee2627966

commit c5b59119ca57398e87a692c9ea836efee2627966
Author: binlu <binlu@google.com>
Date: Wed Apr 19 15:39:07 2017

Remove navigator.vibrate without user gesture.

Calls to navigator.vibrate will immediately return 'false' if user
hasn't tapped on the frame or any embedded frame yet.

The implementation is behind an experimental flag.

The Intent to Deprecate thread:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/QGcpjisxtik

BUG= 704650 

Review-Url: https://codereview.chromium.org/2778693004
Cr-Commit-Position: refs/heads/master@{#465618}

[modify] https://crrev.com/c5b59119ca57398e87a692c9ea836efee2627966/chrome/browser/about_flags.cc
[modify] https://crrev.com/c5b59119ca57398e87a692c9ea836efee2627966/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/c5b59119ca57398e87a692c9ea836efee2627966/chrome/browser/flag_descriptions.h
[modify] https://crrev.com/c5b59119ca57398e87a692c9ea836efee2627966/content/child/runtime_features.cc
[modify] https://crrev.com/c5b59119ca57398e87a692c9ea836efee2627966/content/public/common/content_features.cc
[modify] https://crrev.com/c5b59119ca57398e87a692c9ea836efee2627966/content/public/common/content_features.h
[modify] https://crrev.com/c5b59119ca57398e87a692c9ea836efee2627966/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/c5b59119ca57398e87a692c9ea836efee2627966/third_party/WebKit/LayoutTests/http/tests/feature-policy/resources/feature-policy-vibrate-disabled.html
[modify] https://crrev.com/c5b59119ca57398e87a692c9ea836efee2627966/third_party/WebKit/LayoutTests/http/tests/feature-policy/resources/feature-policy-vibrate-enabled.html
[modify] https://crrev.com/c5b59119ca57398e87a692c9ea836efee2627966/third_party/WebKit/LayoutTests/http/tests/feature-policy/vibrate-disabled-expected.txt
[modify] https://crrev.com/c5b59119ca57398e87a692c9ea836efee2627966/third_party/WebKit/LayoutTests/http/tests/feature-policy/vibrate-enabledforall.php
[modify] https://crrev.com/c5b59119ca57398e87a692c9ea836efee2627966/third_party/WebKit/LayoutTests/http/tests/feature-policy/vibrate-enabledforself.php
[delete] https://crrev.com/6e935156eb8bfd135d843804d2c62b2e3d742945/third_party/WebKit/LayoutTests/http/tests/security/resources/same-origin-iframe-for-vibrate-allowed.html
[delete] https://crrev.com/6e935156eb8bfd135d843804d2c62b2e3d742945/third_party/WebKit/LayoutTests/http/tests/security/vibrate_in_same_origin_iframe_allowed.html
[rename] https://crrev.com/c5b59119ca57398e87a692c9ea836efee2627966/third_party/WebKit/LayoutTests/http/tests/security/vibration/resources/vibrate-in-cross-origin-iframe-blocked.html
[rename] https://crrev.com/c5b59119ca57398e87a692c9ea836efee2627966/third_party/WebKit/LayoutTests/http/tests/security/vibration/resources/vibrate-in-iframe-with-user-gesture-allowed.html
[add] https://crrev.com/c5b59119ca57398e87a692c9ea836efee2627966/third_party/WebKit/LayoutTests/http/tests/security/vibration/resources/vibrate-in-same-origin-iframe-with-user-gesture-allowed.html
[add] https://crrev.com/c5b59119ca57398e87a692c9ea836efee2627966/third_party/WebKit/LayoutTests/http/tests/security/vibration/resources/vibrate-with-user-gesture-allowed.html
[rename] https://crrev.com/c5b59119ca57398e87a692c9ea836efee2627966/third_party/WebKit/LayoutTests/http/tests/security/vibration/vibrate-in-cross-origin-iframe-blocked-expected.txt
[rename] https://crrev.com/c5b59119ca57398e87a692c9ea836efee2627966/third_party/WebKit/LayoutTests/http/tests/security/vibration/vibrate-in-cross-origin-iframe-blocked.html
[rename] https://crrev.com/c5b59119ca57398e87a692c9ea836efee2627966/third_party/WebKit/LayoutTests/http/tests/security/vibration/vibrate-in-cross-origin-iframe-with-user-gesture-allowed-expected.txt
[rename] https://crrev.com/c5b59119ca57398e87a692c9ea836efee2627966/third_party/WebKit/LayoutTests/http/tests/security/vibration/vibrate-in-cross-origin-iframe-with-user-gesture-allowed.html
[add] https://crrev.com/c5b59119ca57398e87a692c9ea836efee2627966/third_party/WebKit/LayoutTests/http/tests/security/vibration/vibrate-in-same-origin-iframe-with-user-gesture-allowed-expected.txt
[copy] https://crrev.com/c5b59119ca57398e87a692c9ea836efee2627966/third_party/WebKit/LayoutTests/http/tests/security/vibration/vibrate-in-same-origin-iframe-with-user-gesture-allowed.html
[add] https://crrev.com/c5b59119ca57398e87a692c9ea836efee2627966/third_party/WebKit/LayoutTests/http/tests/security/vibration/vibrate-on-top-page-before-during-after-user-gesture-expected.txt
[add] https://crrev.com/c5b59119ca57398e87a692c9ea836efee2627966/third_party/WebKit/LayoutTests/http/tests/security/vibration/vibrate-on-top-page-before-during-after-user-gesture.html
[add] https://crrev.com/c5b59119ca57398e87a692c9ea836efee2627966/third_party/WebKit/LayoutTests/resources/user-gesture-utils.js
[modify] https://crrev.com/c5b59119ca57398e87a692c9ea836efee2627966/third_party/WebKit/LayoutTests/vibration/cancel-vibration-during-pattern-vibrating.html
[modify] https://crrev.com/c5b59119ca57398e87a692c9ea836efee2627966/third_party/WebKit/LayoutTests/vibration/resources/vibrate-from-iframe.html
[modify] https://crrev.com/c5b59119ca57398e87a692c9ea836efee2627966/third_party/WebKit/LayoutTests/vibration/vibration-durations.html
[modify] https://crrev.com/c5b59119ca57398e87a692c9ea836efee2627966/third_party/WebKit/LayoutTests/vibration/vibration-exceptions.html
[modify] https://crrev.com/c5b59119ca57398e87a692c9ea836efee2627966/third_party/WebKit/LayoutTests/vibration/vibration-iframe-expected.txt
[modify] https://crrev.com/c5b59119ca57398e87a692c9ea836efee2627966/third_party/WebKit/LayoutTests/vibration/vibration-page-visibility.html
[modify] https://crrev.com/c5b59119ca57398e87a692c9ea836efee2627966/third_party/WebKit/LayoutTests/vibration/vibration-patterns.html
[modify] https://crrev.com/c5b59119ca57398e87a692c9ea836efee2627966/third_party/WebKit/LayoutTests/vibration/vibration.html
[modify] https://crrev.com/c5b59119ca57398e87a692c9ea836efee2627966/third_party/WebKit/Source/core/frame/Deprecation.cpp
[modify] https://crrev.com/c5b59119ca57398e87a692c9ea836efee2627966/third_party/WebKit/Source/core/frame/UseCounter.h
[modify] https://crrev.com/c5b59119ca57398e87a692c9ea836efee2627966/third_party/WebKit/Source/modules/vibration/NavigatorVibration.cpp
[modify] https://crrev.com/c5b59119ca57398e87a692c9ea836efee2627966/third_party/WebKit/Source/platform/RuntimeEnabledFeatures.json5
[modify] https://crrev.com/c5b59119ca57398e87a692c9ea836efee2627966/tools/metrics/histograms/histograms.xml

Comment 10 by bi...@google.com, Apr 19 2017

Labels: Merge-Request-59 Launch-M-Approved-60-Stable Launch-M-Target-60-Stable
Asking approval to be merged into M59 for the patch in comment #9, to the deprecation of vibrate without user gesture. The Intent to Deprecate thread:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/QGcpjisxtik.
Project Member

Comment 11 by sheriffbot@chromium.org, Apr 19 2017

Labels: -Merge-Request-59 Merge-Approved-59
Your change meets the bar and is auto-approved for M59. Please go ahead and merge the CL to branch 3071 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 12 by bugdroid1@chromium.org, Apr 19 2017

Labels: -merge-approved-59 merge-merged-3071
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/54365e69605bb69a531764a8be7f398ede395131

commit 54365e69605bb69a531764a8be7f398ede395131
Author: gogerald <gogerald@google.com>
Date: Wed Apr 19 17:10:11 2017

Remove navigator.vibrate without user gesture.

Calls to navigator.vibrate will immediately return 'false' if user
hasn't tapped on the frame or any embedded frame yet.

The implementation is behind an experimental flag.

The Intent to Deprecate thread:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/QGcpjisxtik

BUG= 704650 

Review-Url: https://codereview.chromium.org/2778693004
Cr-Commit-Position: refs/heads/master@{#465618}
(cherry picked from commit c5b59119ca57398e87a692c9ea836efee2627966)

Review-Url: https://codereview.chromium.org/2825403002 .
Cr-Commit-Position: refs/branch-heads/3071@{#54}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}

[modify] https://crrev.com/54365e69605bb69a531764a8be7f398ede395131/chrome/browser/about_flags.cc
[modify] https://crrev.com/54365e69605bb69a531764a8be7f398ede395131/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/54365e69605bb69a531764a8be7f398ede395131/chrome/browser/flag_descriptions.h
[modify] https://crrev.com/54365e69605bb69a531764a8be7f398ede395131/content/child/runtime_features.cc
[modify] https://crrev.com/54365e69605bb69a531764a8be7f398ede395131/content/public/common/content_features.cc
[modify] https://crrev.com/54365e69605bb69a531764a8be7f398ede395131/content/public/common/content_features.h
[modify] https://crrev.com/54365e69605bb69a531764a8be7f398ede395131/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/54365e69605bb69a531764a8be7f398ede395131/third_party/WebKit/LayoutTests/http/tests/feature-policy/resources/feature-policy-vibrate-disabled.html
[modify] https://crrev.com/54365e69605bb69a531764a8be7f398ede395131/third_party/WebKit/LayoutTests/http/tests/feature-policy/resources/feature-policy-vibrate-enabled.html
[modify] https://crrev.com/54365e69605bb69a531764a8be7f398ede395131/third_party/WebKit/LayoutTests/http/tests/feature-policy/vibrate-disabled-expected.txt
[modify] https://crrev.com/54365e69605bb69a531764a8be7f398ede395131/third_party/WebKit/LayoutTests/http/tests/feature-policy/vibrate-enabledforall.php
[modify] https://crrev.com/54365e69605bb69a531764a8be7f398ede395131/third_party/WebKit/LayoutTests/http/tests/feature-policy/vibrate-enabledforself.php
[delete] https://crrev.com/338ccfc9d423bc8bf189f4ced51d168f57f7d6df/third_party/WebKit/LayoutTests/http/tests/security/resources/same-origin-iframe-for-vibrate-allowed.html
[delete] https://crrev.com/338ccfc9d423bc8bf189f4ced51d168f57f7d6df/third_party/WebKit/LayoutTests/http/tests/security/vibrate_in_same_origin_iframe_allowed.html
[rename] https://crrev.com/54365e69605bb69a531764a8be7f398ede395131/third_party/WebKit/LayoutTests/http/tests/security/vibration/resources/vibrate-in-cross-origin-iframe-blocked.html
[rename] https://crrev.com/54365e69605bb69a531764a8be7f398ede395131/third_party/WebKit/LayoutTests/http/tests/security/vibration/resources/vibrate-in-iframe-with-user-gesture-allowed.html
[add] https://crrev.com/54365e69605bb69a531764a8be7f398ede395131/third_party/WebKit/LayoutTests/http/tests/security/vibration/resources/vibrate-in-same-origin-iframe-with-user-gesture-allowed.html
[add] https://crrev.com/54365e69605bb69a531764a8be7f398ede395131/third_party/WebKit/LayoutTests/http/tests/security/vibration/resources/vibrate-with-user-gesture-allowed.html
[rename] https://crrev.com/54365e69605bb69a531764a8be7f398ede395131/third_party/WebKit/LayoutTests/http/tests/security/vibration/vibrate-in-cross-origin-iframe-blocked-expected.txt
[rename] https://crrev.com/54365e69605bb69a531764a8be7f398ede395131/third_party/WebKit/LayoutTests/http/tests/security/vibration/vibrate-in-cross-origin-iframe-blocked.html
[rename] https://crrev.com/54365e69605bb69a531764a8be7f398ede395131/third_party/WebKit/LayoutTests/http/tests/security/vibration/vibrate-in-cross-origin-iframe-with-user-gesture-allowed-expected.txt
[rename] https://crrev.com/54365e69605bb69a531764a8be7f398ede395131/third_party/WebKit/LayoutTests/http/tests/security/vibration/vibrate-in-cross-origin-iframe-with-user-gesture-allowed.html
[add] https://crrev.com/54365e69605bb69a531764a8be7f398ede395131/third_party/WebKit/LayoutTests/http/tests/security/vibration/vibrate-in-same-origin-iframe-with-user-gesture-allowed-expected.txt
[copy] https://crrev.com/54365e69605bb69a531764a8be7f398ede395131/third_party/WebKit/LayoutTests/http/tests/security/vibration/vibrate-in-same-origin-iframe-with-user-gesture-allowed.html
[add] https://crrev.com/54365e69605bb69a531764a8be7f398ede395131/third_party/WebKit/LayoutTests/http/tests/security/vibration/vibrate-on-top-page-before-during-after-user-gesture-expected.txt
[add] https://crrev.com/54365e69605bb69a531764a8be7f398ede395131/third_party/WebKit/LayoutTests/http/tests/security/vibration/vibrate-on-top-page-before-during-after-user-gesture.html
[add] https://crrev.com/54365e69605bb69a531764a8be7f398ede395131/third_party/WebKit/LayoutTests/resources/user-gesture-utils.js
[modify] https://crrev.com/54365e69605bb69a531764a8be7f398ede395131/third_party/WebKit/LayoutTests/vibration/cancel-vibration-during-pattern-vibrating.html
[modify] https://crrev.com/54365e69605bb69a531764a8be7f398ede395131/third_party/WebKit/LayoutTests/vibration/resources/vibrate-from-iframe.html
[modify] https://crrev.com/54365e69605bb69a531764a8be7f398ede395131/third_party/WebKit/LayoutTests/vibration/vibration-durations.html
[modify] https://crrev.com/54365e69605bb69a531764a8be7f398ede395131/third_party/WebKit/LayoutTests/vibration/vibration-exceptions.html
[modify] https://crrev.com/54365e69605bb69a531764a8be7f398ede395131/third_party/WebKit/LayoutTests/vibration/vibration-iframe-expected.txt
[modify] https://crrev.com/54365e69605bb69a531764a8be7f398ede395131/third_party/WebKit/LayoutTests/vibration/vibration-page-visibility.html
[modify] https://crrev.com/54365e69605bb69a531764a8be7f398ede395131/third_party/WebKit/LayoutTests/vibration/vibration-patterns.html
[modify] https://crrev.com/54365e69605bb69a531764a8be7f398ede395131/third_party/WebKit/LayoutTests/vibration/vibration.html
[modify] https://crrev.com/54365e69605bb69a531764a8be7f398ede395131/third_party/WebKit/Source/core/frame/Deprecation.cpp
[modify] https://crrev.com/54365e69605bb69a531764a8be7f398ede395131/third_party/WebKit/Source/core/frame/UseCounter.h
[modify] https://crrev.com/54365e69605bb69a531764a8be7f398ede395131/third_party/WebKit/Source/modules/vibration/NavigatorVibration.cpp
[modify] https://crrev.com/54365e69605bb69a531764a8be7f398ede395131/third_party/WebKit/Source/platform/RuntimeEnabledFeatures.json5
[modify] https://crrev.com/54365e69605bb69a531764a8be7f398ede395131/tools/metrics/histograms/histograms.xml

Project Member

Comment 13 by bugdroid1@chromium.org, Apr 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e66f2ff1ce2c15bb342ad8dd7579a0578af1d6bc

commit e66f2ff1ce2c15bb342ad8dd7579a0578af1d6bc
Author: binlu <binlu@google.com>
Date: Mon Apr 24 21:19:57 2017

Remove vibrate w/o user gesture by default.

Change the flag from "experimental" to "stable" and from 'DISABLED_BY_DEFAULT' TO 'ENABLED_BY_DEFAULT': Calls to navigator.vibrate will return 'false' if user hasn't tapped on the frame or any embedded frame yet.

This is for M60 since M59 had branched last week, and the previous CL has been merged to M59:
https://bugs.chromium.org/p/chromium/issues/detail?id=704650#c12.

The Intent to Deprecate & Remove thread:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/QGcpjisxtik

BUG= 704650 

Review-Url: https://codereview.chromium.org/2834493002
Cr-Commit-Position: refs/heads/master@{#466768}

[modify] https://crrev.com/e66f2ff1ce2c15bb342ad8dd7579a0578af1d6bc/content/public/common/content_features.cc
[delete] https://crrev.com/38d160e2906fdc0b7db4acc44a0c1df1e1ea2b02/third_party/WebKit/LayoutTests/http/tests/security/vibration/resources/vibrate-in-same-origin-iframe-with-user-gesture-allowed.html
[modify] https://crrev.com/e66f2ff1ce2c15bb342ad8dd7579a0578af1d6bc/third_party/WebKit/LayoutTests/http/tests/security/vibration/vibrate-in-same-origin-iframe-with-user-gesture-allowed-expected.txt
[modify] https://crrev.com/e66f2ff1ce2c15bb342ad8dd7579a0578af1d6bc/third_party/WebKit/LayoutTests/http/tests/security/vibration/vibrate-in-same-origin-iframe-with-user-gesture-allowed.html
[modify] https://crrev.com/e66f2ff1ce2c15bb342ad8dd7579a0578af1d6bc/third_party/WebKit/LayoutTests/http/tests/security/vibration/vibrate-on-top-page-before-during-after-user-gesture-expected.txt
[modify] https://crrev.com/e66f2ff1ce2c15bb342ad8dd7579a0578af1d6bc/third_party/WebKit/LayoutTests/http/tests/security/vibration/vibrate-on-top-page-before-during-after-user-gesture.html
[modify] https://crrev.com/e66f2ff1ce2c15bb342ad8dd7579a0578af1d6bc/third_party/WebKit/Source/platform/RuntimeEnabledFeatures.json5

Project Member

Comment 14 by sheriffbot@chromium.org, Jul 21 2017

Labels: Hotlist-Google
Labels: migrated-launch-owp Type-Task
This issue has been automatically relabelled type=task because type=launch-owp issues are now officially deprecated. The deprecation is because they were creating confusion about how to get launch approvals, which should be instead done via type=launch issues.

We recommend this issue be used for implementation tracking (for public visibility), but if you already have an issue for that, you may mark this as duplicate.

For more details see here: https://docs.google.com/document/d/1JA6RohjtZQc26bTrGoIE_bSXGXUDQz8vc6G0n_sZJ2o/edit

For any questions, please contact owencm, sshruthi, larforge

Comment 17 by bi...@google.com, Mar 9 2018

Status: Fixed (was: Assigned)
Project Member

Comment 18 by bugdroid1@chromium.org, Mar 13 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/40109c91e1e57c23c2babff06b141e13c9e125ba

commit 40109c91e1e57c23c2babff06b141e13c9e125ba
Author: Ian Clelland <iclelland@chromium.org>
Date: Tue Mar 13 16:09:57 2018

Remove the browser feature for VibrateWithoutUserGesture

The renderer feature was removed in https://crrev.com/86dad9f3, except
for the linkage between browser and renderer in c/c/runtime_features.cc.
This CL removes that link, as well as the base::Feature for the removed
feature, and the entry in chrome://flags.

Bug:  704650 
Change-Id: Iddf4038c7c2f4c8d7a45770262b977d78996b696
Reviewed-on: https://chromium-review.googlesource.com/957478
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Ian Clelland <iclelland@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542816}
[modify] https://crrev.com/40109c91e1e57c23c2babff06b141e13c9e125ba/chrome/browser/about_flags.cc
[modify] https://crrev.com/40109c91e1e57c23c2babff06b141e13c9e125ba/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/40109c91e1e57c23c2babff06b141e13c9e125ba/chrome/browser/flag_descriptions.h
[modify] https://crrev.com/40109c91e1e57c23c2babff06b141e13c9e125ba/content/child/runtime_features.cc
[modify] https://crrev.com/40109c91e1e57c23c2babff06b141e13c9e125ba/content/public/common/content_features.cc
[modify] https://crrev.com/40109c91e1e57c23c2babff06b141e13c9e125ba/content/public/common/content_features.h

Sign in to add a comment