New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 704648 link

Starred by 2 users
Status: Fixed
Owner:
mmenke@chromium.org
Closed: Mar 2017
Cc:
█ pam@chromium.org
█ atanasova@chromium.org
█ bauerb@chromium.org
treib@chromium.org
█ aber...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug
Proj-Servicification

Blocking:
issue 598073



Sign in to add a comment

Replace SupervisedUserResourceThrottle with a NavigationThrottle

Project Member Reported by mmenke@chromium.org, Mar 23 2017 
SupervisedUserResourceThrottle interposes on main frame network requests to block requests for certain URLs.  We're working towards wrapping the network stack in a Mojo interface, and it would be good to minimize or eliminate Chrome code that's behind that Mojo boundary.  Since this class only cares about navigations, we can hook it up as NavigationThrottle, and have it live on the UI thread.  As an added bonus, the new code will require less setup, since it has to get data from the UI thread anyways during construction.

Comment 1 by mmenke@chromium.org, Mar 27 2017

Blocking: 598073

Comment 2 by treib@chromium.org, Mar 28 2017

Cc: treib@chromium.org bauerb@chromium.org
Labels: OS-All

Comment 3 by treib@chromium.org, Mar 28 2017 

Somewhat related: bug 651115, bug 690993, and (maybe) bug 671472

Comment 4 by treib@chromium.org, Mar 28 2017

Cc: pam@chromium.org aber...@chromium.org atanasova@chromium.org
 Issue 576604  has been merged into this issue.
Project Member

Comment 5 by bugdroid1@chromium.org, Mar 31 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/db2637ff32cb9a619f1e2920293eb2e68f20ac4c

commit db2637ff32cb9a619f1e2920293eb2e68f20ac4c
Author: mmenke <mmenke@chromium.org>
Date: Thu Mar 30 23:59:42 2017

Convert SupervisedUserResourceThrottle to a NavigationThrottle.

Also do a bit of incidental cleanup that enables - remove the second
SuprvisedUserURLFilter that lived on the IO thread, remove refcounting
of SuprvisedUserURLFilter, get rid of SupervisedUserContext, don't
duplicate std::maps when updating the filter, etc.

This is part of the effort to move content/browser/loader behind a
Mojo interface

TBR=calamity@chromium.org
BUG= 704648 

Review-Url: https://codereview.chromium.org/2776493005
Cr-Commit-Position: refs/heads/master@{#460940}

[modify] https://crrev.com/db2637ff32cb9a619f1e2920293eb2e68f20ac4c/chrome/browser/BUILD.gn
[modify] https://crrev.com/db2637ff32cb9a619f1e2920293eb2e68f20ac4c/chrome/browser/chrome_content_browser_client.cc
[modify] https://crrev.com/db2637ff32cb9a619f1e2920293eb2e68f20ac4c/chrome/browser/loader/chrome_resource_dispatcher_host_delegate.cc
[modify] https://crrev.com/db2637ff32cb9a619f1e2920293eb2e68f20ac4c/chrome/browser/ntp_tiles/chrome_most_visited_sites_factory.cc
[modify] https://crrev.com/db2637ff32cb9a619f1e2920293eb2e68f20ac4c/chrome/browser/profiles/profile_io_data.cc
[modify] https://crrev.com/db2637ff32cb9a619f1e2920293eb2e68f20ac4c/chrome/browser/profiles/profile_io_data.h
[modify] https://crrev.com/db2637ff32cb9a619f1e2920293eb2e68f20ac4c/chrome/browser/search/search.cc
[modify] https://crrev.com/db2637ff32cb9a619f1e2920293eb2e68f20ac4c/chrome/browser/search/search_unittest.cc
[modify] https://crrev.com/db2637ff32cb9a619f1e2920293eb2e68f20ac4c/chrome/browser/supervised_user/supervised_user_browsertest.cc
[modify] https://crrev.com/db2637ff32cb9a619f1e2920293eb2e68f20ac4c/chrome/browser/supervised_user/supervised_user_content_provider_android.cc
[modify] https://crrev.com/db2637ff32cb9a619f1e2920293eb2e68f20ac4c/chrome/browser/supervised_user/supervised_user_interstitial.cc
[modify] https://crrev.com/db2637ff32cb9a619f1e2920293eb2e68f20ac4c/chrome/browser/supervised_user/supervised_user_navigation_observer.cc
[modify] https://crrev.com/db2637ff32cb9a619f1e2920293eb2e68f20ac4c/chrome/browser/supervised_user/supervised_user_navigation_observer.h
[rename] https://crrev.com/db2637ff32cb9a619f1e2920293eb2e68f20ac4c/chrome/browser/supervised_user/supervised_user_navigation_throttle.cc
[add] https://crrev.com/db2637ff32cb9a619f1e2920293eb2e68f20ac4c/chrome/browser/supervised_user/supervised_user_navigation_throttle.h
[rename] https://crrev.com/db2637ff32cb9a619f1e2920293eb2e68f20ac4c/chrome/browser/supervised_user/supervised_user_navigation_throttle_browsertest.cc
[delete] https://crrev.com/6c378ee936e8504fb0617e35287634f8d860b384/chrome/browser/supervised_user/supervised_user_resource_throttle.h
[modify] https://crrev.com/db2637ff32cb9a619f1e2920293eb2e68f20ac4c/chrome/browser/supervised_user/supervised_user_service.cc
[modify] https://crrev.com/db2637ff32cb9a619f1e2920293eb2e68f20ac4c/chrome/browser/supervised_user/supervised_user_service.h
[modify] https://crrev.com/db2637ff32cb9a619f1e2920293eb2e68f20ac4c/chrome/browser/supervised_user/supervised_user_service_unittest.cc
[modify] https://crrev.com/db2637ff32cb9a619f1e2920293eb2e68f20ac4c/chrome/browser/supervised_user/supervised_user_url_filter.cc
[modify] https://crrev.com/db2637ff32cb9a619f1e2920293eb2e68f20ac4c/chrome/browser/supervised_user/supervised_user_url_filter.h
[modify] https://crrev.com/db2637ff32cb9a619f1e2920293eb2e68f20ac4c/chrome/browser/supervised_user/supervised_user_url_filter_unittest.cc
[modify] https://crrev.com/db2637ff32cb9a619f1e2920293eb2e68f20ac4c/chrome/browser/ui/webui/browsing_history_handler.cc
[modify] https://crrev.com/db2637ff32cb9a619f1e2920293eb2e68f20ac4c/chrome/browser/ui/webui/supervised_user_internals_message_handler.cc
[modify] https://crrev.com/db2637ff32cb9a619f1e2920293eb2e68f20ac4c/chrome/browser/ui/webui/supervised_user_internals_message_handler.h
[modify] https://crrev.com/db2637ff32cb9a619f1e2920293eb2e68f20ac4c/chrome/test/BUILD.gn

Comment 6 by mmenke@chromium.org, Mar 31 2017

Status: Fixed (was: Assigned)

Comment 7 by laforge@google.com, Nov 7 2017

Components: Internals>Network>Service

Comment 8 by laforge@google.com, Nov 7 2017

Components: -Internals>Network>Service Internals>Services>Network
Apologies, applied the wrong component in bulk.
►

Sign in to add a comment