brillo::make_unique_ptr is identical to base::WrapUnique provided by libchrome. With base::MakeUnique and base::WrapUnique from libchrome, we can simply deprecate and remove brillo::make_unique_ptr.
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/9b0c62445f22eea642e24b8f82baf0c159b4432b commit 9b0c62445f22eea642e24b8f82baf0c159b4432b Author: Ben Chan <benchan@chromium.org> Date: Sat Mar 25 02:38:06 2017 login: replace brillo::make_unique_ptr with base::MakeUnique base::MakeUnique mimics std::make_unique and is preferred over brillo::make_unique_ptr (which is identical to base::WrapUnique). brillo::make_unique_ptr will eventually be deprecated and removed as its functionality is well covered by base::MakeUnique and base::WrapUnique. BUG= chromium:704644 TEST=Run unit tests. Change-Id: I0f9aff1eebd247f4fe5db3f5717f888f0bba96b0 Reviewed-on: https://chromium-review.googlesource.com/458590 Commit-Ready: Ben Chan <benchan@chromium.org> Tested-by: Ben Chan <benchan@chromium.org> Reviewed-by: Dan Erat <derat@chromium.org> [modify] https://crrev.com/9b0c62445f22eea642e24b8f82baf0c159b4432b/login_manager/login_metrics.cc [modify] https://crrev.com/9b0c62445f22eea642e24b8f82baf0c159b4432b/login_manager/cumulative_use_time_metric_unittest.cc
The following revision refers to this bug: https://chrome-internal.googlesource.com/chromeos/ap-daemons/+/ad2a3db3703d285e692b0d00632beabd4bc1f6fd commit ad2a3db3703d285e692b0d00632beabd4bc1f6fd Author: Ben Chan <benchan@chromium.org> Date: Tue Mar 28 05:41:03 2017
The following revision refers to this bug: https://chromium.googlesource.com/aosp/platform/system/update_engine/+/5c02c1335b98b3a1c8759a664bf7b6a48773f913 commit 5c02c1335b98b3a1c8759a664bf7b6a48773f913 Author: Ben Chan <benchan@chromium.org> Date: Fri Jun 30 19:51:26 2017 Replace brillo::make_unique_ptr with base::MakeUnique/base::WrapUnique. base::MakeUnique mimics std::make_unique and is preferred over brillo::make_unique_ptr (which is identical to base::WrapUnique). brillo::make_unique_ptr will eventually be deprecated and removed as its functionality is well covered by base::MakeUnique and base::WrapUnique. BUG= chromium:704644 TEST=Run unit tests. Change-Id: I771b312d04643a1c74dd843947ed30bda510eed2 Reviewed-on: https://chromium-review.googlesource.com/458562 Commit-Ready: Ben Chan <benchan@chromium.org> Tested-by: Ben Chan <benchan@chromium.org> Reviewed-by: Dan Erat <derat@chromium.org> Reviewed-by: Alex Deymo <deymo@google.com> Reviewed-by: Mike Frysinger <vapier@chromium.org> Reviewed-by: Sen Jiang <senj@chromium.org> [modify] https://crrev.com/5c02c1335b98b3a1c8759a664bf7b6a48773f913/boot_control_chromeos.cc [modify] https://crrev.com/5c02c1335b98b3a1c8759a664bf7b6a48773f913/payload_generator/mapfile_filesystem.cc [modify] https://crrev.com/5c02c1335b98b3a1c8759a664bf7b6a48773f913/omaha_request_action_unittest.cc [modify] https://crrev.com/5c02c1335b98b3a1c8759a664bf7b6a48773f913/sideload_main.cc [modify] https://crrev.com/5c02c1335b98b3a1c8759a664bf7b6a48773f913/update_manager/real_shill_provider_unittest.cc [modify] https://crrev.com/5c02c1335b98b3a1c8759a664bf7b6a48773f913/update_manager/state_factory.cc [modify] https://crrev.com/5c02c1335b98b3a1c8759a664bf7b6a48773f913/update_attempter.cc [modify] https://crrev.com/5c02c1335b98b3a1c8759a664bf7b6a48773f913/hardware_chromeos.cc [modify] https://crrev.com/5c02c1335b98b3a1c8759a664bf7b6a48773f913/payload_generator/zip_unittest.cc [modify] https://crrev.com/5c02c1335b98b3a1c8759a664bf7b6a48773f913/payload_consumer/xz_extent_writer_unittest.cc [modify] https://crrev.com/5c02c1335b98b3a1c8759a664bf7b6a48773f913/payload_consumer/extent_writer_unittest.cc [modify] https://crrev.com/5c02c1335b98b3a1c8759a664bf7b6a48773f913/network_selector_android.cc [modify] https://crrev.com/5c02c1335b98b3a1c8759a664bf7b6a48773f913/network_selector_stub.cc [modify] https://crrev.com/5c02c1335b98b3a1c8759a664bf7b6a48773f913/update_attempter_unittest.cc [modify] https://crrev.com/5c02c1335b98b3a1c8759a664bf7b6a48773f913/update_manager/real_system_provider_unittest.cc [modify] https://crrev.com/5c02c1335b98b3a1c8759a664bf7b6a48773f913/hardware_android.cc [modify] https://crrev.com/5c02c1335b98b3a1c8759a664bf7b6a48773f913/payload_consumer/bzip_extent_writer_unittest.cc [modify] https://crrev.com/5c02c1335b98b3a1c8759a664bf7b6a48773f913/connection_manager_unittest.cc [modify] https://crrev.com/5c02c1335b98b3a1c8759a664bf7b6a48773f913/boot_control_recovery.cc [modify] https://crrev.com/5c02c1335b98b3a1c8759a664bf7b6a48773f913/boot_control_android.cc [modify] https://crrev.com/5c02c1335b98b3a1c8759a664bf7b6a48773f913/real_system_state.cc [modify] https://crrev.com/5c02c1335b98b3a1c8759a664bf7b6a48773f913/update_manager/real_device_policy_provider_unittest.cc [modify] https://crrev.com/5c02c1335b98b3a1c8759a664bf7b6a48773f913/payload_consumer/delta_performer.cc
The following revision refers to this bug: https://chrome-internal.googlesource.com/chromeos/ap/wireless/+/9ad40806f3916eeef1dd19dade43b76c4b2d38d7 commit 9ad40806f3916eeef1dd19dade43b76c4b2d38d7 Author: Ben Chan <benchan@chromium.org> Date: Thu Jul 06 04:54:57 2017
The following revision refers to this bug: https://chromium.googlesource.com/aosp/platform/external/libbrillo/+/070af5efe6be713dc10310405c3951939fda828a commit 070af5efe6be713dc10310405c3951939fda828a Author: Ben Chan <benchan@chromium.org> Date: Thu Jul 06 08:33:12 2017 Remove brillo::make_unique_ptr. base::MakeUnique mimics std::make_unique and is preferred over brillo::make_unique_ptr (which is identical to base::WrapUnique). Dependents of brillo::make_unique_ptr have been migrated to use base::MakeUnique and base::WrapUnique. This CL removes brillo::make_unique_ptr from libbrillo. BUG= chromium:704644 TEST=Run unit tests. Change-Id: I8e034988149f465e12114d4568367022f1e21d6d Reviewed-on: https://chromium-review.googlesource.com/558379 Commit-Ready: Ben Chan <benchan@chromium.org> Tested-by: Ben Chan <benchan@chromium.org> Reviewed-by: Dan Erat <derat@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [delete] https://crrev.com/7a0a61f2e3ae80b7edd5e774b8b3318f81e7c3c6/brillo/make_unique_ptr.h
Comment 1 by benchan@chromium.org
, Mar 23 2017