Allow mp3 audio codec in mpeg2ts container in MSE |
||
Issue descriptionChrome already supports using mp3 with MSE. But currently it only allows mp3 streams to be used with audio/mpeg mime type (see https://cs.chromium.org/chromium/src/media/filters/stream_parser_factory.cc?rcl=394caf0ffa05d6c7ada7560a3379f4807215bfb4&l=333). Some Chromecast apps use a combination of H.264 video + MP3 audio track in a mpeg2ts container. For those apps we'd like to allow using an explicit 'mp3' (as opposed to implicitly implying mp3 codec for the 'audio/mpeg' mime type without the codecs= parameter) in mpeg2ts (mime type = 'video/mp2t') containers.
,
Mar 23 2017
(CR comment referenced in #1 is https://codereview.chromium.org/2773793002/diff/1/media/filters/stream_parser_factory.cc#newcode301)
,
Mar 23 2017
Note also that DASH-IF mpd format references RFC6381 also for codec IDs (see ISO 23009-1:2014), strengthening the case that the current MSE bytestream spec's reference of RFC6381 is correct.
,
Mar 23 2017
RFC6381 references http://www.mp4ra.org/object.html for ISO-BMFF. The problem I'm having is finding a definitive reference from RFC6381 for mpeg2-ts.
,
Mar 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9ad504653bc097753e522941f47d7ce761476706 commit 9ad504653bc097753e522941f47d7ce761476706 Author: servolk <servolk@chromium.org> Date: Tue Mar 28 18:19:58 2017 Allow mp3 audio codec for mpeg2ts containers in MSE Some Chromecast apps use H.264 video + MP3 audio in mpeg2ts container. BUG= 704638 Review-Url: https://codereview.chromium.org/2773793002 Cr-Commit-Position: refs/heads/master@{#460170} [modify] https://crrev.com/9ad504653bc097753e522941f47d7ce761476706/media/base/audio_codecs.cc [modify] https://crrev.com/9ad504653bc097753e522941f47d7ce761476706/media/filters/chunk_demuxer.cc [modify] https://crrev.com/9ad504653bc097753e522941f47d7ce761476706/media/filters/stream_parser_factory.cc [modify] https://crrev.com/9ad504653bc097753e522941f47d7ce761476706/media/formats/mp2t/mp2t_stream_parser.cc [modify] https://crrev.com/9ad504653bc097753e522941f47d7ce761476706/media/test/data/README [add] https://crrev.com/9ad504653bc097753e522941f47d7ce761476706/media/test/data/bear-audio-mp4a.69.ts [add] https://crrev.com/9ad504653bc097753e522941f47d7ce761476706/media/test/data/bear-audio-mp4a.6B.ts [modify] https://crrev.com/9ad504653bc097753e522941f47d7ce761476706/media/test/pipeline_integration_test.cc
,
Mar 28 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by wolenetz@chromium.org
, Mar 23 2017