New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 704636 link

Starred by 3 users

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

browser header doesn't paint well at the left side

Project Member Reported by warx@chromium.org, Mar 23 2017

Issue description

tot Chrome code updated today

+sky@, do you notice any recent changes that might break this?


 
Screenshot from 2017-03-23 11:30:19.png
647 KB View Download

Comment 1 by sky@chromium.org, Mar 23 2017

I'm not aware of any, but I don't see all the changes. Try looking at the history of tab_strip. That said, this looks more like a frame painting issue. That is, doesn't it look like the non-client area (the area behind the tab-strip) isn't painted correctly? I believe that code is in browser_header_painter_ash.cc and related classes.

Comment 2 by warx@chromium.org, Mar 23 2017

Cc: abodenha@chromium.org
Labels: ReleaseBlock-Stable M-59
Owner: warx@chromium.org
Status: Assigned (was: Untriaged)
It looks like the non-client area isn't painted correctly.

Seems only happens when you have theme installed. Also happens on device. I can take a look.

Comment 3 by warx@chromium.org, Mar 23 2017

Cc: danakj@chromium.org
Components: -UI>Browser>TabStrip UI>Browser
Summary: browser header doesn't paint well at the left side (was: Tabstrip doesn't paint well at the left side)
CL breaks this is: https://codereview.chromium.org/2770943002

+danakj@
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 29 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b30c149bc6b38870ca74cb8dcd5fb34e90e75480

commit b30c149bc6b38870ca74cb8dcd5fb34e90e75480
Author: warx <warx@chromium.org>
Date: Wed Mar 29 03:21:07 2017

cros: Fix browser header wrongly drawn frame image

Changes:
Check the code before https://codereview.chromium.org/2770943002, found that when frame_overlay_image_.isNull(), TileImageInt should be called.

BUG= 704636 
TEST=test that bug doesn't happen with theme installed

Review-Url: https://codereview.chromium.org/2770943004
Cr-Commit-Position: refs/heads/master@{#460265}

[modify] https://crrev.com/b30c149bc6b38870ca74cb8dcd5fb34e90e75480/chrome/browser/ui/views/frame/browser_header_painter_ash.cc
[modify] https://crrev.com/b30c149bc6b38870ca74cb8dcd5fb34e90e75480/ui/gfx/canvas.cc
[modify] https://crrev.com/b30c149bc6b38870ca74cb8dcd5fb34e90e75480/ui/gfx/canvas.h

Comment 5 by warx@chromium.org, Mar 29 2017

Status: Fixed (was: Assigned)

Comment 6 by warx@chromium.org, Apr 3 2017

Cc: warx@chromium.org
 Issue 707551  has been merged into this issue.

Comment 7 by son...@google.com, May 17 2017

Status: Verified (was: Fixed)
Verified on build 9460.42.0

Sign in to add a comment