Setting an override IP is impossible |
|||||||
Issue descriptionChrome Version: 59.0.3041.0 OS: Cros What steps will reproduce the problem? (1) Open the new settings page (2) Internet connection (3) Ethernet (4) Uncheck Configure IP automatically (5) try to type in an IP address What is the expected result? You can enter the address What happens instead? The setting disappears and "Configure automatic" turns back on. Please use labels and text to provide additional information. I have tried everything. Unplugging the network cable, re-plug without network worked, but once plugged back in it switches back to automatic
,
Mar 23 2017
,
Mar 31 2017
,
Apr 3 2017
,
Apr 12 2017
,
Apr 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c8c17a113a396c2080658a9a7d06c30bc8c5dba4 commit c8c17a113a396c2080658a9a7d06c30bc8c5dba4 Author: stevenjb <stevenjb@chromium.org> Date: Thu Apr 13 03:25:36 2017 MD Settings: Internet: IP Settings: Only set to static on change Currently we set the mode to static before changing any properties. This may result in an invalid configuration that will be rejected, reverting back to automatic. This CL: * Only sets the IPConfig mode to static when a property is changed. * Fixes a case where IP config state was incorrectly sent on page load when networkProperties is incomplete. * Cleans up some functions in internet_detail_page.js to avoid potential dom-if pitfalls when using |this.foo| instead of |foo| inside a bound getter. (Also to improve consistency within the file). BUG= 704631 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2817613002 Cr-Commit-Position: refs/heads/master@{#464274} [modify] https://crrev.com/c8c17a113a396c2080658a9a7d06c30bc8c5dba4/chrome/browser/resources/settings/internet_page/internet_detail_page.html [modify] https://crrev.com/c8c17a113a396c2080658a9a7d06c30bc8c5dba4/chrome/browser/resources/settings/internet_page/internet_detail_page.js [modify] https://crrev.com/c8c17a113a396c2080658a9a7d06c30bc8c5dba4/chrome/browser/resources/settings/internet_page/network_ip_config.js
,
Apr 13 2017
,
May 9 2017
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by skuhne@chromium.org
, Mar 23 2017