New issue
Advanced search Search tips

Issue 704619 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

When a page does not have a favicon, store this information into the database

Project Member Reported by pkotw...@chromium.org, Mar 23 2017

Issue description

When a page does not have a favicon, store this information into the database

 

Comment 1 by jkrcal@chromium.org, Mar 24 2017

Cc: jkrcal@chromium.org
Do you plan to persist the urls collected by WasUnableToDownloadFavicon calls or something different?
I was planning on storing a mapping between a 404 page URL to an entry in the favicon database with no favicon_bitmaps.
This is to handle the case of us getting 404s for the default favicon (favicon.ico) which we try to fetch if the page does not have any <link rel="icon"> URLs

This would enable removing WasUnableToDownloadFavicon()

Comment 3 by jkrcal@chromium.org, Mar 27 2017

I was wondering because WasUnableToDownloadFavicon() is now being used from the new function in LargeIconService for downloading from the Google server. 

If I get it right, that case could also be handled using your DB-based solution.
Yes, this could be handled in the database based solution too

Sign in to add a comment