testPostFormEntryWithKeyboard is disabled on device |
|||||||||||||
Issue descriptionThis test has failed 4 times in the last ~200 runs. No other test in the suite has failed during that time. https://build.chromium.org/p/chromium.fyi/builders/EarlGreyiOS/builds/25684 https://build.chromium.org/p/chromium.fyi/builders/EarlGreyiOS/builds/25660 https://build.chromium.org/p/chromium.fyi/builders/EarlGreyiOS/builds/25659 https://build.chromium.org/p/chromium.fyi/builders/EarlGreyiOS/builds/25575 This is the error for all 4 examples: BrowsingTestCase.testBrowsingPostEntryWithKeyboard: ../../ios/chrome/browser/web/browsing_egtest.mm:661: error: -[BrowsingTestCase testBrowsingPostEntryWithKeyboard] : Exception: NoMatchingElementException Exception Name: NoMatchingElementException Exception Reason: Cannot find UI Element. Exception with Assertion: { "Assertion Criteria" : "assertWithMatcher: notNil", "Element Matcher" : "(kindOfClass('OmniboxTextFieldIOS') && an object with text "localhost:8080/foo/")", "Recovery Suggestion" : "Check if element exists in the UI, modify assert criteria, or adjust the matcher" }
,
Mar 23 2017
I lied (was looking at the wrong test in git blame). gchatz@ last addressed to flakiness, so re-assigning.
,
Mar 23 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2991103274c1a534ab244946305b2138b6d5b353 commit 2991103274c1a534ab244946305b2138b6d5b353 Author: baxley <baxley@chromium.org> Date: Thu Mar 23 18:28:43 2017 Mark testBrowsingPostEntryWithKeyboard as FLAKY_. This test is failing every ~50 runs. BUG= 704618 TBR=liaoyuke Review-Url: https://codereview.chromium.org/2773773002 Cr-Commit-Position: refs/heads/master@{#459152} [modify] https://crrev.com/2991103274c1a534ab244946305b2138b6d5b353/ios/chrome/browser/web/browsing_egtest.mm
,
Mar 23 2017
Looks like the load resulting from the form submission has not completed by the time the omnibox is checked for the correct URL. One possible fix would be to add a wait for page to finish loading after reenabling synchronization.
,
Mar 23 2017
gchatz@ if you going to touch this, could you please move this code to forms_egtest.mm. browsing_egtest looks like a bag of unrelated tests.
,
Apr 5 2017
Any update here gchatz?
,
Apr 5 2017
CL is up here: https://codereview.chromium.org/2793233004/ I will look at moving it out to forms_egtest after verifying that the fix successfully fixes the flake.
,
Apr 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/92d289e82e3aac87336b3ee2d50e830ae8fbf384 commit 92d289e82e3aac87336b3ee2d50e830ae8fbf384 Author: gchatz <gchatz@chromium.org> Date: Thu Apr 06 01:38:06 2017 Add wait to testBrowsingPostEntryWithKeyboard. The testBrowsingPostEntryWithKeyboard test flakes occasionally because the omnibox's text has not updated to the next page after a form submission. So, a wait is added to its helper method to ensure that the page load is completed before checking the omnibox text. BUG= 704618 Review-Url: https://codereview.chromium.org/2793233004 Cr-Commit-Position: refs/heads/master@{#462313} [modify] https://crrev.com/92d289e82e3aac87336b3ee2d50e830ae8fbf384/ios/chrome/browser/web/browsing_egtest.mm
,
Apr 7 2017
Is this now fixed?
,
Apr 7 2017
Not yet
,
Apr 10 2017
Any update gchatz? where do we stand with this test?
,
Apr 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/24a7ab49adbbaeefd815066ac9e530e4713560b1 commit 24a7ab49adbbaeefd815066ac9e530e4713560b1 Author: gchatz <gchatz@chromium.org> Date: Tue Apr 11 01:17:15 2017 Validate page load in testBrowsingPostEntryWithKeyboard with web view text. The testBrowsingPostEntryWithKeyboard test currently uses the waitForPageToFinishLoading API to ensure that the page is loaded before validating omnibox text. But, this is not sufficient to prevent flake as the page load may not have started at this point. This CL resolves the flake by waiting for and validating that the web view has text from the target page instead. BUG= 704618 Review-Url: https://codereview.chromium.org/2815503002 Cr-Commit-Position: refs/heads/master@{#463484} [modify] https://crrev.com/24a7ab49adbbaeefd815066ac9e530e4713560b1/ios/chrome/browser/web/browsing_egtest.mm
,
Apr 11 2017
A potential fix landed, we will see if it works.
,
Apr 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0db784a312d2096eef72e1174f8614479483cb35 commit 0db784a312d2096eef72e1174f8614479483cb35 Author: gchatz <gchatz@chromium.org> Date: Thu Apr 13 02:09:20 2017 Remove flaky label from testBrowsingPostEntryWithKeyboard. Remove the flaky label from testBrowsingPostEntryWithKeyboard since it has not flaked over the past few days. Also adds a TODO to move the test to forms_egtest.mm. BUG= 704618 Review-Url: https://codereview.chromium.org/2813363002 Cr-Commit-Position: refs/heads/master@{#464244} [modify] https://crrev.com/0db784a312d2096eef72e1174f8614479483cb35/ios/chrome/browser/web/browsing_egtest.mm
,
Apr 13 2017
,
Apr 13 2017
[Auto-generated comment by a script] We noticed that this issue is targeted for M-59; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-59 label, otherwise remove Merge-TBD label. Thanks.
,
Apr 20 2017
Landed before branch.
,
Apr 21 2017
testBrowsingPostEntryWithKeyboard is still flaky on devices.
,
Apr 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3a3fc00c8e6a6a50be35443c6d44238fd6258842 commit 3a3fc00c8e6a6a50be35443c6d44238fd6258842 Author: liaoyuke <liaoyuke@chromium.org> Date: Fri Apr 21 22:49:28 2017 Disable flaky testBrowsingPostEntryWithKeyboard on devices. testBrowsingPostEntryWithKeyboard is flaky on devices. For example: https://uberchromegw.corp.google.com/i/internal.bling.main/builders/ iphone10-device-x64/builds/4627 https://uberchromegw.corp.google.com/i/internal.bling.main/builders/ iphone10-device-x64/builds/4622 TBR=eugenebut@chromium.org BUG= 704618 Review-Url: https://codereview.chromium.org/2834183003 Cr-Commit-Position: refs/heads/master@{#466481} [modify] https://crrev.com/3a3fc00c8e6a6a50be35443c6d44238fd6258842/ios/chrome/browser/web/browsing_egtest.mm
,
Apr 28 2017
Reassigning for retriage, since I am not available for much of the time up to branch.
,
May 5 2017
baxley or jif?
,
May 8 2017
Yuke also fixed a similar test.
,
May 8 2017
Per discussions during convergence, a test that is only disabled on devices should not be RBB, so I'm removing the label.
,
Jul 14 2017
Note: Test renamed testPostFormEntryWithKeyboard and moved to forms_egtest.mm in https://codereview.chromium.org/2961483002/ Test still disabled on device. Removing milestone
,
Jul 14 2017
,
May 29 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b82d833e2f22c0e8b5fd9f51878274233a69e59a commit b82d833e2f22c0e8b5fd9f51878274233a69e59a Author: Eugene But <eugenebut@google.com> Date: Tue May 29 14:24:33 2018 Enable testPostFormEntryWithKeyboard on device. Test does not fail on device anymore. Bug: 704618 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Id2835dcf87baf448c7c2ede8a7ad11e1591aa72c Reviewed-on: https://chromium-review.googlesource.com/1074010 Reviewed-by: Mohammad Refaat <mrefaat@chromium.org> Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Cr-Commit-Position: refs/heads/master@{#562416} [modify] https://crrev.com/b82d833e2f22c0e8b5fd9f51878274233a69e59a/ios/chrome/browser/web/forms_egtest.mm
,
May 29 2018
|
|||||||||||||
►
Sign in to add a comment |
|||||||||||||
Comment 1 by baxley@chromium.org
, Mar 23 2017Labels: M-59 ReleaseBlock-Beta
Owner: eugene...@chromium.org