New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 704617 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Last visit > 30 days ago
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

[Media Router] code clean up: move dial api into the if (enable_media_router) block in extensions/BUILD.gn

Project Member Reported by zhaobin@chromium.org, Mar 23 2017

Issue description

To address Devlin's code review comments: "if media router is the only consumer of dial, it would be great to move this and the full dial api into the if (enable_media_router) block"

https://codereview.chromium.org/2756483007/diff/140001/chrome/browser/extensions/BUILD.gn

 

Comment 1 by mfo...@chromium.org, Mar 23 2017

There's a good chance enable_media_router is actually going away.  See https://codereview.chromium.org/2760403003

Comment 2 by sko...@chromium.org, Apr 24 2017

Status: Assigned (was: Untriaged)

Comment 3 by mfo...@chromium.org, Apr 24 2017

Status: WontFix (was: Assigned)
The referenced patch landed, so this is WontFix.

Sign in to add a comment