New issue
Advanced search Search tips

Issue 704615 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Closed: Jun 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug

Blocking:
issue 671246



Sign in to add a comment

Move ash/shared into ash/public/cpp

Project Member Reported by sky@chromium.org, Mar 23 2017

Issue description

ash/shared predates ash/public/cpp, but serves the same purpose. The files should move to ash/public/cpp.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1be030652a3b79cfae1ea6192b0f63144e4d6888

commit 1be030652a3b79cfae1ea6192b0f63144e4d6888
Author: Scott Violet <sky@chromium.org>
Date: Mon Jun 26 21:08:30 2017

chromeos: moves ash/shared to ash/public/cpp

The two should be combined given they share the same
role. ash/shared/immersive needs a cleanup (it predates the switch
back to aura), but I'm holding off on that until it becomes clear as
to which direction we want to take immersive going forward.

BUG= 704615 
TEST=none

Change-Id: Ie805238757577a07570815234e7908d15c647673
Reviewed-on: https://chromium-review.googlesource.com/548959
Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#482397}
[modify] https://crrev.com/1be030652a3b79cfae1ea6192b0f63144e4d6888/ash/BUILD.gn
[modify] https://crrev.com/1be030652a3b79cfae1ea6192b0f63144e4d6888/ash/ash_touch_exploration_manager_chromeos.cc
[modify] https://crrev.com/1be030652a3b79cfae1ea6192b0f63144e4d6888/ash/aura/shell_port_classic.cc
[modify] https://crrev.com/1be030652a3b79cfae1ea6192b0f63144e4d6888/ash/content/display/screen_orientation_controller_chromeos_unittest.cc
[modify] https://crrev.com/1be030652a3b79cfae1ea6192b0f63144e4d6888/ash/display/display_manager_unittest.cc
[modify] https://crrev.com/1be030652a3b79cfae1ea6192b0f63144e4d6888/ash/display/screen_orientation_controller_chromeos.cc
[modify] https://crrev.com/1be030652a3b79cfae1ea6192b0f63144e4d6888/ash/frame/custom_frame_view_ash.cc
[modify] https://crrev.com/1be030652a3b79cfae1ea6192b0f63144e4d6888/ash/frame/header_view.h
[modify] https://crrev.com/1be030652a3b79cfae1ea6192b0f63144e4d6888/ash/metrics/pointer_metrics_recorder.cc
[modify] https://crrev.com/1be030652a3b79cfae1ea6192b0f63144e4d6888/ash/metrics/pointer_metrics_recorder_unittest.cc
[modify] https://crrev.com/1be030652a3b79cfae1ea6192b0f63144e4d6888/ash/mus/bridge/immersive_handler_factory_mus.cc
[modify] https://crrev.com/1be030652a3b79cfae1ea6192b0f63144e4d6888/ash/mus/bridge/immersive_handler_factory_mus.h
[modify] https://crrev.com/1be030652a3b79cfae1ea6192b0f63144e4d6888/ash/mus/bridge/shell_port_mash.cc
[modify] https://crrev.com/1be030652a3b79cfae1ea6192b0f63144e4d6888/ash/mus/non_client_frame_controller.cc
[modify] https://crrev.com/1be030652a3b79cfae1ea6192b0f63144e4d6888/ash/public/cpp/BUILD.gn
[rename] https://crrev.com/1be030652a3b79cfae1ea6192b0f63144e4d6888/ash/public/cpp/app_types.h
[rename] https://crrev.com/1be030652a3b79cfae1ea6192b0f63144e4d6888/ash/public/cpp/immersive/immersive_context.cc
[rename] https://crrev.com/1be030652a3b79cfae1ea6192b0f63144e4d6888/ash/public/cpp/immersive/immersive_context.h
[rename] https://crrev.com/1be030652a3b79cfae1ea6192b0f63144e4d6888/ash/public/cpp/immersive/immersive_focus_watcher.h
[rename] https://crrev.com/1be030652a3b79cfae1ea6192b0f63144e4d6888/ash/public/cpp/immersive/immersive_fullscreen_controller.cc
[rename] https://crrev.com/1be030652a3b79cfae1ea6192b0f63144e4d6888/ash/public/cpp/immersive/immersive_fullscreen_controller.h
[rename] https://crrev.com/1be030652a3b79cfae1ea6192b0f63144e4d6888/ash/public/cpp/immersive/immersive_fullscreen_controller_delegate.h
[add] https://crrev.com/1be030652a3b79cfae1ea6192b0f63144e4d6888/ash/public/cpp/immersive/immersive_gesture_handler.h
[rename] https://crrev.com/1be030652a3b79cfae1ea6192b0f63144e4d6888/ash/public/cpp/immersive/immersive_handler_factory.cc
[rename] https://crrev.com/1be030652a3b79cfae1ea6192b0f63144e4d6888/ash/public/cpp/immersive/immersive_handler_factory.h
[rename] https://crrev.com/1be030652a3b79cfae1ea6192b0f63144e4d6888/ash/public/cpp/immersive/immersive_revealed_lock.cc
[rename] https://crrev.com/1be030652a3b79cfae1ea6192b0f63144e4d6888/ash/public/cpp/immersive/immersive_revealed_lock.h
[delete] https://crrev.com/07e062e8bda7ba01334dcf0f2a58c36d6e2ac81c/ash/shared/BUILD.gn
[delete] https://crrev.com/07e062e8bda7ba01334dcf0f2a58c36d6e2ac81c/ash/shared/DEPS
[delete] https://crrev.com/07e062e8bda7ba01334dcf0f2a58c36d6e2ac81c/ash/shared/README.md
[delete] https://crrev.com/07e062e8bda7ba01334dcf0f2a58c36d6e2ac81c/ash/shared/immersive_gesture_handler.h
[modify] https://crrev.com/1be030652a3b79cfae1ea6192b0f63144e4d6888/ash/test/immersive_fullscreen_controller_test_api.cc
[modify] https://crrev.com/1be030652a3b79cfae1ea6192b0f63144e4d6888/ash/wm/immersive_context_ash.cc
[modify] https://crrev.com/1be030652a3b79cfae1ea6192b0f63144e4d6888/ash/wm/immersive_context_ash.h
[modify] https://crrev.com/1be030652a3b79cfae1ea6192b0f63144e4d6888/ash/wm/immersive_focus_watcher_aura.cc
[modify] https://crrev.com/1be030652a3b79cfae1ea6192b0f63144e4d6888/ash/wm/immersive_focus_watcher_aura.h
[modify] https://crrev.com/1be030652a3b79cfae1ea6192b0f63144e4d6888/ash/wm/immersive_fullscreen_controller_unittest.cc
[modify] https://crrev.com/1be030652a3b79cfae1ea6192b0f63144e4d6888/ash/wm/immersive_gesture_handler_aura.cc
[modify] https://crrev.com/1be030652a3b79cfae1ea6192b0f63144e4d6888/ash/wm/immersive_gesture_handler_aura.h
[modify] https://crrev.com/1be030652a3b79cfae1ea6192b0f63144e4d6888/ash/wm/immersive_handler_factory_ash.h
[modify] https://crrev.com/1be030652a3b79cfae1ea6192b0f63144e4d6888/ash/wm/resize_handle_window_targeter.cc
[modify] https://crrev.com/1be030652a3b79cfae1ea6192b0f63144e4d6888/ash/wm/workspace/backdrop_controller.cc
[modify] https://crrev.com/1be030652a3b79cfae1ea6192b0f63144e4d6888/ash/wm/workspace/workspace_layout_manager_unittest.cc
[modify] https://crrev.com/1be030652a3b79cfae1ea6192b0f63144e4d6888/chrome/browser/ui/ash/launcher/arc_app_window_launcher_controller.cc
[modify] https://crrev.com/1be030652a3b79cfae1ea6192b0f63144e4d6888/chrome/browser/ui/views/apps/chrome_native_app_window_views_aura_ash.cc
[modify] https://crrev.com/1be030652a3b79cfae1ea6192b0f63144e4d6888/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.cc
[modify] https://crrev.com/1be030652a3b79cfae1ea6192b0f63144e4d6888/chrome/browser/ui/views/frame/immersive_context_mus.h
[modify] https://crrev.com/1be030652a3b79cfae1ea6192b0f63144e4d6888/chrome/browser/ui/views/frame/immersive_handler_factory_mus.cc
[modify] https://crrev.com/1be030652a3b79cfae1ea6192b0f63144e4d6888/chrome/browser/ui/views/frame/immersive_handler_factory_mus.h
[modify] https://crrev.com/1be030652a3b79cfae1ea6192b0f63144e4d6888/chrome/browser/ui/views/frame/immersive_mode_controller_ash.cc
[modify] https://crrev.com/1be030652a3b79cfae1ea6192b0f63144e4d6888/chrome/browser/ui/views/frame/immersive_mode_controller_ash.h
[modify] https://crrev.com/1be030652a3b79cfae1ea6192b0f63144e4d6888/components/arc/BUILD.gn
[modify] https://crrev.com/1be030652a3b79cfae1ea6192b0f63144e4d6888/components/arc/DEPS
[modify] https://crrev.com/1be030652a3b79cfae1ea6192b0f63144e4d6888/components/arc/arc_util.cc
[modify] https://crrev.com/1be030652a3b79cfae1ea6192b0f63144e4d6888/components/arc/arc_util_unittest.cc
[modify] https://crrev.com/1be030652a3b79cfae1ea6192b0f63144e4d6888/ui/aura/client/aura_constants.h

Comment 2 by sky@chromium.org, Jun 26 2017

Owner: sky@chromium.org
Status: Fixed (was: Untriaged)

Comment 3 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment