New issue
Advanced search Search tips

Issue 704614 link

Starred by 1 user
Status: Fixed
Owner:
w...@chromium.org
Closed: May 2018
Cc:
reillyg@chromium.org
tzik@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

"MediaFileValidatorTest.UnsupportedExtension" is flaky

Project Member Reported by chromium...@appspot.gserviceaccount.com, Mar 23 2017 
"MediaFileValidatorTest.UnsupportedExtension" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyNgsSBUZsYWtlIitNZWRpYUZpbGVWYWxpZGF0b3JUZXN0LlVuc3VwcG9ydGVkRXh0ZW5zaW9uDA.

Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs

Comment 1 by wittman@chromium.org, Mar 23 2017 

Flakes on linux_chromium_rel_ng.

[ RUN      ] MediaFileValidatorTest.UnsupportedExtension
Xlib:  extension "RANDR" missing on display ":99".
Xlib:  extension "RANDR" missing on display ":99".
[2315:2315:0317/113057.040196:WARNING:audio_manager.cc(295)] Multiple instances of AudioManager detected
[2315:2315:0317/113057.040218:WARNING:audio_manager.cc(254)] Multiple instances of AudioManager detected
[2315:2315:0317/113057.147516:WARNING:password_store_factory.cc(247)] Using basic (unencrypted) store for password storage. See https://chromium.googlesource.com/chromium/src/+/master/docs/linux_password_storage.md for more information about password storage options.
[2315:2340:0317/113057.466084:FATAL:ref_counted.h(322)] Assert failed: ptr_ != nullptr.
#0 0x000002e64817 base::debug::StackTrace::StackTrace()
#1 0x000002e7d23b logging::LogMessage::~LogMessage()
#2 0x000000c74d11 MediaFileValidatorTest::OnTestFilesCheckResult()
#3 0x000000c74830 (anonymous namespace)::HandleCheckFileResult()
#4 0x000004cf6439 storage::FileSystemOperationRunner::DidGetMetadata()
#5 0x000001e0b0a3 _ZN4base8internal13FunctorTraitsIMN7content24ServiceWorkerContextCoreEFvRKNS_8CallbackIFvNS2_23ServiceWorkerStatusCodeEELNS0_8CopyModeE1ELNS0_10RepeatModeE1EEERK4GURLS5_RKSt6vectorINS2_29ServiceWorkerRegistrationInfoESaISG_EEEvE6InvokeIRKNS_7WeakPtrIS3_EEJSB_SE_S5_SK_EEEvSM_OT_DpOT0_
#6 0x000004cf9257 _ZN4base8internal7InvokerINS0_9BindStateIMN7storage25FileSystemOperationRunnerEFvRKNS4_15OperationHandleERKNS_8CallbackIFvNS_4File5ErrorERKNS9_4InfoEELNS0_8CopyModeE1ELNS0_10RepeatModeE1EEESA_SD_EJNS_7WeakPtrIS4_EES5_SH_EEESE_E3RunEPNS0_13BindStateBaseEOSA_SD_
#7 0x0000031be9af _ZN4base8internal7InvokerINS0_9BindStateINS_8CallbackIFvNS_4File5ErrorERKNS4_4InfoEELNS0_8CopyModeE1ELNS0_10RepeatModeE1EEEJS5_S6_EEEFvvEE3RunEPNS0_13BindStateBaseE
#8 0x00000176f9b0 _ZNO4base8internal8RunMixinINS_8CallbackIFvvELNS0_8CopyModeE0ELNS0_10RepeatModeE0EEEE3RunEv
#9 0x000002f12aba base::debug::TaskAnnotator::RunTask()
#10 0x000002e847cd base::MessageLoop::RunTask()
#11 0x000002e84e76 base::MessageLoop::DoWork()
#12 0x000002e87ef9 base::MessagePumpLibevent::Run()
#13 0x000002e8451e base::MessageLoop::RunHandler()
#14 0x000002ead2cc base::RunLoop::Run()
#15 0x000002ed87bc base::Thread::Run()
#16 0x000001ac8075 content::BrowserThreadImpl::IOThreadRun()
#17 0x000001ac8223 content::BrowserThreadImpl::Run()
#18 0x000002ed8cd8 base::Thread::ThreadMain()
#19 0x000002ed1a1c base::(anonymous namespace)::ThreadFunc()
#20 0x7fc39401f184 start_thread
#21 0x7fc38db5837d clone

Comment 2 by wittman@chromium.org, Mar 23 2017

Cc: tzik@chromium.org
Labels: -Sheriff-Chromium
Owner: kinuko@chromium.org
Unable to find anyone who's significantly touched this code recently. Assigning/cc'ing OWNERS.
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 24 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/df86c4558553e33a10eaa267d7bc1eea16c8905f

commit df86c4558553e33a10eaa267d7bc1eea16c8905f
Author: wittman <wittman@chromium.org>
Date: Fri Mar 24 00:29:03 2017

Disable MediaFileValidatorTest.UnsupportedExtension

Flaky on linux_chromium_rel_ng.

BUG= 704614 
TBR=kinuko

Review-Url: https://codereview.chromium.org/2774653004
Cr-Commit-Position: refs/heads/master@{#459300}

[modify] https://crrev.com/df86c4558553e33a10eaa267d7bc1eea16c8905f/chrome/browser/media_galleries/fileapi/media_file_validator_browsertest.cc

Comment 4 by thestig@chromium.org, Mar 24 2017

Cc: reillyg@chromium.org

Comment 5 by wittman@chromium.org, Mar 24 2017 

This test always fails in concert with NaClBrowserTestPnaclSubzero.PnaclErrorHandling, which may be useful information for tracking down the underlying cause.

NaClBrowserTestPnaclSubzero.PnaclErrorHandling is covered by bug 704980.

Comment 6 by w...@chromium.org, May 31 2018

Labels: M-68 OS-Linux
Owner: w...@chromium.org
Status: Started (was: Untriaged)
Project Member

Comment 7 by bugdroid1@chromium.org, May 31 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/120c299d9dcef1a05cb35863cb168bd3c1eda2d8

commit 120c299d9dcef1a05cb35863cb168bd3c1eda2d8
Author: Wez <wez@chromium.org>
Date: Thu May 31 17:26:19 2018

Migrate MediaFileValidatorTest from MessageLoopRunner to RunLoop.

This also removes potential for MoveTest*() operations to complete on
the TaskScheduler and IO thread before the quit closure has been saved,
to be called on completion.

Bug:  704614 
Change-Id: Ibb266e9af8b42f75d390789cad49d9db6ce87144
Reviewed-on: https://chromium-review.googlesource.com/1079990
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563295}
[modify] https://crrev.com/120c299d9dcef1a05cb35863cb168bd3c1eda2d8/chrome/browser/media_galleries/fileapi/media_file_validator_browsertest.cc

Comment 8 by w...@chromium.org, May 31 2018

Status: Fixed (was: Started)
►

Sign in to add a comment