New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 704610 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2017
Cc:
Components:
EstimatedDays: 0
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

Offline pages task scheduled using GcmNetworkManager are not persisted.

Project Member Reported by fgor...@chromium.org, Mar 23 2017

Issue description

Offline pages task scheduled using GcmNetworkManager are not persisted.

This means that if device reboots, the scheduled task will not be resumed until scheduled again.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0c1ab0868b12be571311df463894f06e47c8e62a

commit 0c1ab0868b12be571311df463894f06e47c8e62a
Author: fgorski <fgorski@chromium.org>
Date: Thu Mar 23 19:23:48 2017

[Offline pages] Ensuring tasks scheduled through GCM NM are persisted

We are currently not persisting tasks scheduled through GCM Network
Manager, which means requests to offline pages in the background will
not be resumed after a device restart.

This patch fixes the issue.

BUG= 704610 

Review-Url: https://codereview.chromium.org/2769233003
Cr-Commit-Position: refs/heads/master@{#459174}

[modify] https://crrev.com/0c1ab0868b12be571311df463894f06e47c8e62a/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/BackgroundGcmScheduler.java

Labels: ReleaseBlock-Stable Merge-Request-58
Status: Started (was: Assigned)
Requesting a merge as we realized this is blocking stable for us.
Project Member

Comment 3 by sheriffbot@chromium.org, Mar 23 2017

Labels: -Merge-Request-58 Hotlist-Merge-Approved Merge-Approved-58
Your change meets the bar and is auto-approved for M58. Please go ahead and merge the CL to branch 3029 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 24 2017

Labels: -merge-approved-58 merge-merged-3029
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/375291f41f99e762d3213317d2544f5b78ec4fb1

commit 375291f41f99e762d3213317d2544f5b78ec4fb1
Author: Filip Gorski <fgorski@chromium.org>
Date: Fri Mar 24 16:17:59 2017

[Offline pages] Ensuring tasks scheduled through GCM NM are persisted

We are currently not persisting tasks scheduled through GCM Network
Manager, which means requests to offline pages in the background will
not be resumed after a device restart.

This patch fixes the issue.

BUG= 704610 

Review-Url: https://codereview.chromium.org/2769233003
Cr-Commit-Position: refs/heads/master@{#459174}
(cherry picked from commit 0c1ab0868b12be571311df463894f06e47c8e62a)

Review-Url: https://codereview.chromium.org/2776723002 .
Cr-Commit-Position: refs/branch-heads/3029@{#409}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}

[modify] https://crrev.com/375291f41f99e762d3213317d2544f5b78ec4fb1/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/BackgroundGcmScheduler.java

Status: Fixed (was: Started)

Sign in to add a comment