New issue
Advanced search Search tips

Issue 704603 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 671445
Owner:
Closed: Apr 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

"SameSiteSubframe/DragAndDropBrowserTest.DragImageBetweenFrames/0" is flaky

Project Member Reported by chromium...@appspot.gserviceaccount.com, Mar 23 2017

Issue description

"SameSiteSubframe/DragAndDropBrowserTest.DragImageBetweenFrames/0" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 5 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNySwsSBUZsYWtlIkBTYW1lU2l0ZVN1YmZyYW1lL0RyYWdBbmREcm9wQnJvd3NlclRlc3QuRHJhZ0ltYWdlQmV0d2VlbkZyYW1lcy8wDA.

Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
 
Project Member

Comment 1 by chromium...@appspot.gserviceaccount.com, Mar 26 2017

Detected 3 new flakes for test/step "SameSiteSubframe/DragAndDropBrowserTest.DragImageBetweenFrames/0". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNySwsSBUZsYWtlIkBTYW1lU2l0ZVN1YmZyYW1lL0RyYWdBbmREcm9wQnJvd3NlclRlc3QuRHJhZ0ltYWdlQmV0d2VlbkZyYW1lcy8wDA. This message was posted automatically by the chromium-try-flakes app.

Comment 2 by kolos@chromium.org, Mar 27 2017

Owner: lukasza@chromium.org
Status: Assigned (was: Untriaged)
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b5d111dd6e2b1fcb235fa318c46e0eb876accad1

commit b5d111dd6e2b1fcb235fa318c46e0eb876accad1
Author: kolos <kolos@chromium.org>
Date: Mon Mar 27 10:17:19 2017

Disable flaky SameSiteSubframe/DragAndDropBrowserTest.DragImageBetweenFrames

TBR=lukasza@chromium.org
BUG= 704603 

Review-Url: https://codereview.chromium.org/2772253002
Cr-Commit-Position: refs/heads/master@{#459741}

[modify] https://crrev.com/b5d111dd6e2b1fcb235fa318c46e0eb876accad1/chrome/browser/ui/views/drag_and_drop_interactive_uitest.cc

Comment 4 by kolos@chromium.org, Mar 27 2017

Labels: -Sheriff-Chromium
Project Member

Comment 5 by chromium...@appspot.gserviceaccount.com, Mar 27 2017

Labels: Sheriff-Chromium
Detected 3 new flakes for test/step "SameSiteSubframe/DragAndDropBrowserTest.DragImageBetweenFrames/0". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNySwsSBUZsYWtlIkBTYW1lU2l0ZVN1YmZyYW1lL0RyYWdBbmREcm9wQnJvd3NlclRlc3QuRHJhZ0ltYWdlQmV0d2VlbkZyYW1lcy8wDA. This message was posted automatically by the chromium-try-flakes app. Since flakiness is ongoing, the issue was moved back into Sheriff Bug Queue (unless already there).

Comment 6 by hayato@chromium.org, Mar 28 2017

Labels: -Sheriff-Chromium
Project Member

Comment 7 by bugdroid1@chromium.org, Apr 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/66c46290f9774951731d1d38ad75d7aa2d1ac23d

commit 66c46290f9774951731d1d38ad75d7aa2d1ac23d
Author: kenrb <kenrb@chromium.org>
Date: Mon Apr 03 18:47:36 2017

Fix flakiness in DragAndDropBrowserTests

Multiple drag and drop tests in interactive_ui_tests have been flaky
with OOPIFs present. One cause was addressed in r460177, and this CL
fixes another, which is that UI interaction can happen before surface-
based hit testing is ready in the browser process.

This CL includes a small refactor of SurfaceHitTestReadyNotifier to
unify code paths for tests inside and outside of content/.

Most of this patch was written by lukasza@.

BUG= 671445 , 704603 

Review-Url: https://codereview.chromium.org/2786223002
Cr-Commit-Position: refs/heads/master@{#461490}

[modify] https://crrev.com/66c46290f9774951731d1d38ad75d7aa2d1ac23d/chrome/browser/ui/views/drag_and_drop_interactive_uitest.cc
[modify] https://crrev.com/66c46290f9774951731d1d38ad75d7aa2d1ac23d/content/browser/accessibility/touch_accessibility_aura_browsertest.cc
[modify] https://crrev.com/66c46290f9774951731d1d38ad75d7aa2d1ac23d/content/browser/site_per_process_browsertest.cc
[modify] https://crrev.com/66c46290f9774951731d1d38ad75d7aa2d1ac23d/content/public/test/browser_test_utils.cc
[modify] https://crrev.com/66c46290f9774951731d1d38ad75d7aa2d1ac23d/content/public/test/browser_test_utils.h
[modify] https://crrev.com/66c46290f9774951731d1d38ad75d7aa2d1ac23d/content/test/content_browser_test_utils_internal.cc
[modify] https://crrev.com/66c46290f9774951731d1d38ad75d7aa2d1ac23d/content/test/content_browser_test_utils_internal.h

Mergedinto: 671445
Status: Duplicate (was: Assigned)

Sign in to add a comment