Need to handle unibuild detection on ARM devices |
|||
Issue descriptionThe detection seems to be using target tools instead of host [1]: 08:55:54: INFO: RunCommand: /b/cbuild/internal_master/chromite/bin/cros_sdk -- /build/nyan_kitty/usr/bin/fdtget -l /usr/share/chromeos-config/config.dtb /chromeos/models in /b/cbuild/internal_master 08:55:56: INFO: (stderr): * Generating locale-archive: forcing # of jobs to 1 -bash: /build/nyan_kitty/usr/bin/fdtget: cannot execute binary file: Exec format error fdtget failed: * Generating locale-archive: forcing # of jobs to 1 -bash: /build/nyan_kitty/usr/bin/fdtget: cannot execute binary file: Exec format error https://uberchromegw.corp.google.com/i/chromeos/builders/nyan_kitty-paladin/builds/1114/steps/steps/logs/stdio This needs to run the host tool. For now, we will not detect unified builds on ARM (not that we have any yet).
,
Jul 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/9b4522a4bc6b9ba67b381694c11fe28534193b27 commit 9b4522a4bc6b9ba67b381694c11fe28534193b27 Author: Simon Glass <sjg@chromium.org> Date: Fri Jul 21 13:32:04 2017 commands: Correct the operation of the unified build check The current code reads the config file and the fdtget tool from the wrong places (they are swapped). Adjust this to behave correctly: - config.dtb should come from the board's root inside the chroot - fdtget should come from the chroot itself Tidy up the function comment a little also to make it clearer. BUG= chromium:747023 BUG= chromium:704597 TEST=PYTHONPATH=~/cosarm ./commands_unittest PYTHONPATH=~/cosarm ./build_stages_unittest Also manually print out a few things as the test is not very good Change-Id: If54a1e7165bca07f10d2d789992ccba95c78b8ff Signed-off-by: Simon Glass <sjg@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/579792 Reviewed-by: Jason Clinton <jclinton@chromium.org> [modify] https://crrev.com/9b4522a4bc6b9ba67b381694c11fe28534193b27/cbuildbot/stages/build_stages_unittest.py [modify] https://crrev.com/9b4522a4bc6b9ba67b381694c11fe28534193b27/cbuildbot/commands.py [modify] https://crrev.com/9b4522a4bc6b9ba67b381694c11fe28534193b27/cbuildbot/commands_unittest.py
,
Jul 24 2017
,
Jul 24 2017
That seemed to fix it: https://uberchromegw.corp.google.com/i/chromeos/builders/nyan_kitty-paladin/builds/2381/steps/steps/logs/stdio 13:21:28: INFO: RunCommand: /b/c/cbuild/repository/chromite/bin/cros_sdk -- /usr/bin/fdtget -l /build/nyan_kitty/usr/share/chromeos-config/config.dtb /chromeos/models in /b/c/cbuild/repository 13:21:30: INFO: (stderr): * Generating locale-archive: forcing # of jobs to 1 Couldn't open blob from '/build/nyan_kitty/usr/share/chromeos-config/config.dtb': No such file or directory
,
Jul 24 2017
|
|||
►
Sign in to add a comment |
|||
Comment 1 by sjg@chromium.org
, Jun 9 2017