GLSurfaceFormat refactor: remove "surfaceless" attribute |
|||
Issue descriptionThe GLSurfaceFormat refactor in http://crrev.com/2616723002 replaced a format enum with a class that behaves equivalently. It included a IsSurfaceless() attribute as a replacement for the SURFACE_SURFACELESS enum value. That attribute seems to be redundant since surfaces have an IsSurfaceless() attribute instead.
,
Mar 23 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bedc60e74ddc887d5599b468c83191f992311458 commit bedc60e74ddc887d5599b468c83191f992311458 Author: c.padhi <c.padhi@samsung.com> Date: Thu Mar 23 22:20:10 2017 gl: Remove redundant methods/variables from GLSurfaceFormat This commit removes IsDefault(), SetIsSurfaceless() and IsSurfaceless() from GLSurfaceFormat. GLSurface::IsSurfaceless() can be directly used instead of GLSurfaceFormat::IsSurfaceless(). BUG= 704581 Review-Url: https://codereview.chromium.org/2764853002 Cr-Commit-Position: refs/heads/master@{#459252} [modify] https://crrev.com/bedc60e74ddc887d5599b468c83191f992311458/ui/gl/gl_surface_egl.cc [modify] https://crrev.com/bedc60e74ddc887d5599b468c83191f992311458/ui/gl/gl_surface_format.cc [modify] https://crrev.com/bedc60e74ddc887d5599b468c83191f992311458/ui/gl/gl_surface_format.h [modify] https://crrev.com/bedc60e74ddc887d5599b468c83191f992311458/ui/gl/gl_surface_format_unittest.cc [modify] https://crrev.com/bedc60e74ddc887d5599b468c83191f992311458/ui/gl/init/gl_factory_ozone.cc
,
Mar 23 2017
,
May 19 2017
|
|||
►
Sign in to add a comment |
|||
Comment 1 by klausw@chromium.org
, Mar 23 2017Status: Assigned (was: Untriaged)