Issue metadata
Sign in to add a comment
|
[Mac] [Regression] Mouse in wrong location over tab after drag tab out of its window |
||||||||||||||||||||||
Issue descriptionChrome Version: 58.0.3029.19 OS: 10.12 What steps will reproduce the problem? (1) Create a window (A) with two tabs (2) Create a second window (B) with one tab (3) Drag the tab from window B to move it into window A What is the expected result? After dragging the tab out of its window, the mouse should appear over the same mouse down point within the tab. What happens instead? After dragging the tab out of its window the window slides such that the mouse is lower than its original mouse down point in the tab. Suspecting https://codereview.chromium.org/2666213003: [Mac] Fullscreen layout issues - Fixed the incorrect y offset for tab detached windows in fullscreen - Fixed the layout issue with the infobar in fullscreen BUG= 670445 , 678204
,
Apr 5 2017
A friendly reminder that M58 Stable launch is coming soon! Your bug is labelled as Stable ReleaseBlock, please make sure to land the fix, verified in trunk and get it merged into the release branch ASAP.
,
Apr 6 2017
A friendly reminder that M58 Stable is launch is coming soon (less than 2 weeks)! Your bug is labelled as Stable ReleaseBlock, pls make sure to land the fix and get it merged into the release branch ASAP so it gets enough baking time in Beta (before Stable promotion). Thank you!
,
Apr 6 2017
spqchan@ - just wondering what's happening with this bug.
,
Apr 6 2017
I started work on it. I'm planning to focus on this at the Fix It
,
Apr 6 2017
Probably better to work on it right now? M58 goes stable in two weeks (less than that one we get to Fix It time).
,
Apr 6 2017
Sure
,
Apr 7 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5ec735024b7275e96970796f14bff80e1e9ae6a2 commit 5ec735024b7275e96970796f14bff80e1e9ae6a2 Author: spqchan <spqchan@chromium.org> Date: Fri Apr 07 18:08:11 2017 [Mac] Fix for the tab detach position BUG= 704579 Review-Url: https://codereview.chromium.org/2802143002 Cr-Commit-Position: refs/heads/master@{#462921} [modify] https://crrev.com/5ec735024b7275e96970796f14bff80e1e9ae6a2/chrome/browser/ui/cocoa/browser_window_controller.h [modify] https://crrev.com/5ec735024b7275e96970796f14bff80e1e9ae6a2/chrome/browser/ui/cocoa/browser_window_controller.mm [modify] https://crrev.com/5ec735024b7275e96970796f14bff80e1e9ae6a2/chrome/browser/ui/cocoa/tabs/tab_strip_drag_controller.mm [modify] https://crrev.com/5ec735024b7275e96970796f14bff80e1e9ae6a2/chrome/browser/ui/cocoa/tabs/tab_window_controller.h [modify] https://crrev.com/5ec735024b7275e96970796f14bff80e1e9ae6a2/chrome/browser/ui/cocoa/tabs/tab_window_controller.mm
,
Apr 10 2017
,
Apr 10 2017
Your change meets the bar and is auto-approved for M58. Please go ahead and merge the CL to branch 3029 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Apr 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/704e2568b1859fadf79a523d39820f33a6077465 commit 704e2568b1859fadf79a523d39820f33a6077465 Author: spqchan <spqchan@chromium.org> Date: Mon Apr 10 18:10:15 2017 [Mac] Fix for the tab detach position BUG= 704579 (cherry picked from commit 5ec735024b7275e96970796f14bff80e1e9ae6a2) Review-Url: https://codereview.chromium.org/2802143002 Cr-Original-Commit-Position: refs/heads/master@{#462921} Cr-Commit-Position: refs/branch-heads/3029@{#648} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} [modify] https://crrev.com/704e2568b1859fadf79a523d39820f33a6077465/chrome/browser/ui/cocoa/browser_window_controller.h [modify] https://crrev.com/704e2568b1859fadf79a523d39820f33a6077465/chrome/browser/ui/cocoa/browser_window_controller.mm [modify] https://crrev.com/704e2568b1859fadf79a523d39820f33a6077465/chrome/browser/ui/cocoa/tabs/tab_strip_drag_controller.mm [modify] https://crrev.com/704e2568b1859fadf79a523d39820f33a6077465/chrome/browser/ui/cocoa/tabs/tab_window_controller.h [modify] https://crrev.com/704e2568b1859fadf79a523d39820f33a6077465/chrome/browser/ui/cocoa/tabs/tab_window_controller.mm
,
Apr 12 2017
Tested the issue on Mac 10.12.3 using chrome version 58.0.3029.68 with the steps mentioned in comment #0.Observed that the mouse pointer appeared at the same mouse down point within the tab after tab dragging. Please find the attached screen cast for the same. Adding TE-Verified labels. Thanks,
,
Apr 12 2017
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by shrike@chromium.org
, Mar 25 2017