Title in password bubbles should be left aligned with the text |
||||||
Issue description
,
Mar 24 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bf765c663d54787ab8dc3bb1b8c1748aab1d0eea commit bf765c663d54787ab8dc3bb1b8c1748aab1d0eea Author: dvadym <dvadym@chromium.org> Date: Fri Mar 24 14:26:09 2017 Fix Password bubble title misalignment. This CL sets correct margins for Password Bubbles titles. Screenshots with explanation what's wrong and how bubbles look like with this CL are attached on the bug. BUG= 704575 Review-Url: https://codereview.chromium.org/2773733002 Cr-Commit-Position: refs/heads/master@{#459418} [modify] https://crrev.com/bf765c663d54787ab8dc3bb1b8c1748aab1d0eea/chrome/browser/ui/cocoa/passwords/confirmation_password_saved_view_controller.mm [modify] https://crrev.com/bf765c663d54787ab8dc3bb1b8c1748aab1d0eea/chrome/browser/ui/cocoa/passwords/passwords_bubble_utils.h [modify] https://crrev.com/bf765c663d54787ab8dc3bb1b8c1748aab1d0eea/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc
,
Mar 27 2017
This is a small UI fix.
,
Mar 27 2017
Your change meets the bar and is auto-approved for M58. Please go ahead and merge the CL to branch 3029 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Mar 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/623dc2bca68212e0f7e4617e84585a74fe63c7bc commit 623dc2bca68212e0f7e4617e84585a74fe63c7bc Author: Vadym Doroshenko <dvadym@chromium.org> Date: Mon Mar 27 11:49:35 2017 [Merge to M-58] Fix Password bubble title misalignment. This CL sets correct margins for Password Bubbles titles. Screenshots with explanation what's wrong and how bubbles look like with this CL are attached on the bug. BUG= 704575 Review-Url: https://codereview.chromium.org/2773733002 Cr-Commit-Position: refs/heads/master@{#459418} (cherry picked from commit bf765c663d54787ab8dc3bb1b8c1748aab1d0eea) Review-Url: https://codereview.chromium.org/2777123002 . Cr-Commit-Position: refs/branch-heads/3029@{#424} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} [modify] https://crrev.com/623dc2bca68212e0f7e4617e84585a74fe63c7bc/chrome/browser/ui/cocoa/passwords/confirmation_password_saved_view_controller.mm [modify] https://crrev.com/623dc2bca68212e0f7e4617e84585a74fe63c7bc/chrome/browser/ui/cocoa/passwords/passwords_bubble_utils.h [modify] https://crrev.com/623dc2bca68212e0f7e4617e84585a74fe63c7bc/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc
,
Mar 27 2017
,
Mar 29 2017
Tested the issue on Windows-7,Mac-10.12.3 and Linux Ubuntu-14.04 using chrome version# 58.0.3029.41. Observed that the fix is working as expected. Hence adding TE-Verified labels. Please find the attached screenshot for the same. Thanks!! |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by dvadym@chromium.org
, Mar 23 20179.6 KB
9.6 KB View Download
9.1 KB
9.1 KB View Download