EnableAccelerationToAvoidReadbacks for SW-HW canvas switches |
|||
Issue descriptionThis has been removed by: https://codereview.chromium.org/2767753002 due to: crbug.com/702492 The underlying issue still remains: the switch from software to accelerated leaves the invalidation in a weird state. I'm attaching a follow up test I'm using.
,
Apr 7 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2f0fa56eb8fc2eee27d437e7b6c8038ba5a52d87 commit 2f0fa56eb8fc2eee27d437e7b6c8038ba5a52d87 Author: fserb <fserb@chromium.org> Date: Fri Apr 07 00:25:33 2017 Do compositing update when switching from software to accelerated canvas Also, re-enables switching from sw to accelerated canvas. BUG= 704571 Review-Url: https://codereview.chromium.org/2799033002 Cr-Commit-Position: refs/heads/master@{#462706} [modify] https://crrev.com/2f0fa56eb8fc2eee27d437e7b6c8038ba5a52d87/third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp [modify] https://crrev.com/2f0fa56eb8fc2eee27d437e7b6c8038ba5a52d87/third_party/WebKit/Source/platform/graphics/ExpensiveCanvasHeuristicParameters.h
,
Apr 7 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9c1cc6a2801bf174202550d981303837277f058d commit 9c1cc6a2801bf174202550d981303837277f058d Author: kbr <kbr@chromium.org> Date: Fri Apr 07 05:54:58 2017 Revert of Do compositing update when switching from software to accelerated canvas (patchset #1 id:1 of https://codereview.chromium.org/2799033002/ ) Reason for revert: Suspect this caused linux_optional_gpu_tests_rel tryserver to break in http://crbug.com/709342 . Original issue's description: > Do compositing update when switching from software to accelerated canvas > > Also, re-enables switching from sw to accelerated canvas. > > BUG= 704571 > > Review-Url: https://codereview.chromium.org/2799033002 > Cr-Commit-Position: refs/heads/master@{#462706} > Committed: https://chromium.googlesource.com/chromium/src/+/2f0fa56eb8fc2eee27d437e7b6c8038ba5a52d87 TBR=junov@chromium.org,fserb@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= 704571 Review-Url: https://codereview.chromium.org/2799133004 Cr-Commit-Position: refs/heads/master@{#462783} [modify] https://crrev.com/9c1cc6a2801bf174202550d981303837277f058d/third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp [modify] https://crrev.com/9c1cc6a2801bf174202550d981303837277f058d/third_party/WebKit/Source/platform/graphics/ExpensiveCanvasHeuristicParameters.h
,
Apr 7 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1dbe1136b6651ba54f52c2569ef95a62d31aac8f commit 1dbe1136b6651ba54f52c2569ef95a62d31aac8f Author: fserb <fserb@chromium.org> Date: Fri Apr 07 17:07:47 2017 Do compositing update when switching from software to accelerated canvas Also, re-enables switching from sw to accelerated canvas. BUG= 704571 Review-Url: https://codereview.chromium.org/2799033002 Cr-Original-Commit-Position: refs/heads/master@{#462706} Committed: https://chromium.googlesource.com/chromium/src/+/2f0fa56eb8fc2eee27d437e7b6c8038ba5a52d87 Review-Url: https://codereview.chromium.org/2799033002 Cr-Commit-Position: refs/heads/master@{#462900} [modify] https://crrev.com/1dbe1136b6651ba54f52c2569ef95a62d31aac8f/third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp [modify] https://crrev.com/1dbe1136b6651ba54f52c2569ef95a62d31aac8f/third_party/WebKit/Source/platform/graphics/ExpensiveCanvasHeuristicParameters.h
,
Apr 7 2017
Issue 704861 has been merged into this issue.
,
Apr 7 2017
After that unjust revert, we are back! :) |
|||
►
Sign in to add a comment |
|||
Comment 1 by fs...@chromium.org
, Mar 31 2017