New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 704567 link

Starred by 1 user
Status: Verified
Owner:
█ zqzh...@chromium.org
Android MediaRouter only (left Chro...
Closed: Mar 2017
Cc:
█ avayvod@chromium.org
mlamouri@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

When the playback state changes to paused when the service is pending for start, the notification info is not updated

Project Member Reported by zqzh...@chromium.org, Mar 23 2017 
STR:

1. Navigate to https://xxyzzzq.github.io/sandbox/media-session/flicker.html
2. Press "Flicker" button twice. ** Don't press play button **
3. Observe the notification

Observed behavior: the notification shows "pause" button
Expected behavior: the notification shows "play" button
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 23 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/54c2facf2675be87fcbe39b74550b87fc0df08d8

commit 54c2facf2675be87fcbe39b74550b87fc0df08d8
Author: zqzhang <zqzhang@chromium.org>
Date: Thu Mar 23 18:00:03 2017

[Media>UI] Allow the notification info to be updated before playback service is created

This CL fixes an issue that when a playback service is pending for start, and
the playback gets paused, the MediaNotificationInfo is not updated so that when
the service gets started, we are still seeing info with "playing" state.

BUG= 704567 

Review-Url: https://codereview.chromium.org/2769213002
Cr-Commit-Position: refs/heads/master@{#459139}

[modify] https://crrev.com/54c2facf2675be87fcbe39b74550b87fc0df08d8/chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaNotificationManager.java

Comment 2 by zqzh...@chromium.org, Mar 23 2017

Labels: Merge-Request-58
Project Member

Comment 3 by sheriffbot@chromium.org, Mar 23 2017

Labels: -Merge-Request-58 Hotlist-Merge-Approved Merge-Approved-58
Your change meets the bar and is auto-approved for M58. Please go ahead and merge the CL to branch 3029 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 23 2017

Labels: -merge-approved-58 merge-merged-3029
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bdb151d3a1eb329db72dfd8fa3f56374a3909488

commit bdb151d3a1eb329db72dfd8fa3f56374a3909488
Author: Zhiqiang Zhang <zqzhang@google.com>
Date: Thu Mar 23 18:58:14 2017

[Media>UI] Allow the notification info to be updated before playback service is created

This CL fixes an issue that when a playback service is pending for start, and
the playback gets paused, the MediaNotificationInfo is not updated so that when
the service gets started, we are still seeing info with "playing" state.

BUG= 704567 

Review-Url: https://codereview.chromium.org/2769213002
Cr-Commit-Position: refs/heads/master@{#459139}
(cherry picked from commit 54c2facf2675be87fcbe39b74550b87fc0df08d8)

Review-Url: https://codereview.chromium.org/2775703002 .
Cr-Commit-Position: refs/branch-heads/3029@{#390}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}

[modify] https://crrev.com/bdb151d3a1eb329db72dfd8fa3f56374a3909488/chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaNotificationManager.java

Comment 5 by zqzh...@chromium.org, Mar 23 2017

Status: Fixed (was: Started)

Comment 6 by ram...@chromium.org, Mar 29 2017

Status: Verified (was: Fixed)
Verified on Chrome release "58.0.3029.42"
►

Sign in to add a comment