New issue
Advanced search Search tips

Issue 704549 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: Oct 11
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Feature

Blocking:
issue 651282



Sign in to add a comment

bluetooth: False characteristics properties should be hidden in bluetooth-internals

Project Member Reported by fbeaufort@chromium.org, Mar 23 2017

Issue description

Google Chrome	58.0.3029.18 (Official Build) dev (64-bit)
Platform	9334.10.0 (Official Build) dev-channel link

What steps will reproduce the problem?
(1) Go to chrome://bluetooth-internals
(2) Scan for devices and connect to one BLE device
(3) Expand one characteristic

What is the expected result?
I should see properties that are set to true not all of them.

What happens instead?
I see everything which makes it hard to play with this page in my opinion.

See screenshot attached.
 
Screenshot 2017-03-23 at 3.24.16 PM.png
247 KB View Download

Comment 1 Deleted

Comment 2 by ortuno@chromium.org, Mar 28 2017

I will happily review any CLs to fix this but I'm tempted to close this issue given the low priority of the internals page.
What do you think of marking it as a Hotlist=GoodFirstBug instead of closing it?
Blocking: 651282
Labels: Hotlist-GoodFirstBug
Status: Available (was: Untriaged)
In bluetooth-internals page, most of screens uses object_fieldset.js for showing the properties.
So if we modify the redraw function by adding a check for value and proceed for drawing, it will take care of hiding the false properties in all the screens. Is this change Ok or should be handled specifically for characteristics properties only?
OK to change all rendering using the component.  However, the usefulness of having a shorter list of only non-false items comes with a trade off of not seeing what the other potential items are.

To explain, a novice, or even experienced Bluetooth developer may look at the UI and not know that certain property types exist.  Currently the UI hints to them that these exist and are false, perhaps leading them to adjust their peripheral device to change behavior to work correctly.  If we remove them all then developers won't notice.

I wonder if we can render all items but hint succinctly that there are more.  Or, have a toggle that the user can press to show all items.

E.g. some snippet of JavaScript on a button that toggles a CSS property to show hidden items, or to show a <dialog> with all items included.
Having a toogle would be great indeed to show all items!
Project Member

Comment 8 by bugdroid1@chromium.org, Oct 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/41626c1116701140d4469d22595b7e6775fe8e35

commit 41626c1116701140d4469d22595b7e6775fe8e35
Author: Pramod B S <pramod.bs@samsung.com>
Date: Thu Oct 26 10:06:03 2017

bluetooth: Hide False characterstics properties in bluetooth-internals

Added a button that toggle to show/hide the false properties

Bug:  704549 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I4db0a7bd2a3bab63aa5bf01dd6c968d9598f3494
Reviewed-on: https://chromium-review.googlesource.com/691636
Commit-Queue: srirama chandra sekhar <srirama.m@samsung.com>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Vincent Scheib <scheib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#511779}
[modify] https://crrev.com/41626c1116701140d4469d22595b7e6775fe8e35/chrome/browser/resources/bluetooth_internals/bluetooth_internals.css
[modify] https://crrev.com/41626c1116701140d4469d22595b7e6775fe8e35/chrome/browser/resources/bluetooth_internals/characteristic_list.js
[modify] https://crrev.com/41626c1116701140d4469d22595b7e6775fe8e35/chrome/browser/resources/bluetooth_internals/object_fieldset.js

Cc: -scheib@chromium.org
Status: Fixed (was: Available)

Sign in to add a comment