Issue metadata
Sign in to add a comment
|
Check failed: m_base.document() == document when navigating after CTRL+F (finding in page) |
||||||||||||||||||||||||
Issue descriptionChromium: 59.0.3050.0 (Developer Build) (64-bit) Revision: 857be195275fb6546a034c1e18ea3b54fe741c82 OS: Linux What steps will reproduce the problem? (1) Hit CTRL+F and search for something (2) Click on a link to navigate What is the expected result? A navigation should occurs. What happens instead? A crash. ``` [134384:134384:0323/143737.150544:FATAL:SelectionTemplate.cpp(92)] Check failed: m_base.document() == document (#document vs. #document)Selection(base: #text "example"@offsetInAnchor[0], extent: #text "example"@offsetInAnchor[7]) #0 0x2ad20d3f1cab base::debug::StackTrace::StackTrace() #1 0x2ad20d3f033c base::debug::StackTrace::StackTrace() #2 0x2ad20d45e24f logging::LogMessage::~LogMessage() #3 0x2ad22667f7e9 blink::SelectionTemplate<>::assertValidFor() #4 0x2ad226651de5 blink::FrameSelection::setSelectionDeprecated() #5 0x2ad226651caf blink::FrameSelection::setSelection() #6 0x2ad21def6c6d blink::WebLocalFrameImpl::setFindEndstateFocusAndSelection() #7 0x2ad21def9374 blink::WebLocalFrameImpl::stopFinding() #8 0x2ad213346dfa content::RenderFrameImpl::OnStopFinding() ``` +CC yosin because you have worked on the blink::SelectionTemplate
,
Mar 23 2017
This is only in debug builds, right? I can't repro on canary, and it looks like that's a DCHECK. Still, it's definitely something we should resolve. yosin@ or paulmeyer@, are you able to take a look?
,
Mar 23 2017
Yes, it is only in debug builds. I try to reproduce the bug again It fails in: * in 238d72aa2c10617a4ca08fcc10f9a231277c667d * in a8e6ee4111187f847c2aa29b8d4afed3a888a012 * in 031bf0357d31bb636570b5e13f93c7500d1582ac (most recent)
,
Mar 25 2017
Lower to Pri-2 since it can occurred only in debug build during navigation. To fix this, we should make WebLocalFrameImpl::stopFinding() does nothing when m_textFinder->activeMatch()->document() != m_frame->document(). This isn't regression. RenderFrameImpl::OnStopFinding() is called via IPC invoked by browser process at leaving current document during navigation. The change reveals the issue.
,
Mar 25 2017
,
Jun 7 2017
|
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by arthurso...@chromium.org
, Mar 23 2017