New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 704498 link

Starred by 2 users

Issue metadata

Status: Archived
Owner: ----
Closed: Jan 9
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

EVDI: cursor updates in user space

Reported by christia...@displaylink.com, Mar 23 2017

Issue description

Getting EVDI cursor updates in user-space will help enabling some cursor performance improvements.

Opening an issue as an reference for incoming reviews.
 
Cc: kathrelk...@chromium.org pbath...@chromium.org
Components: Internals>Input>Touch>Pad
Components: -Internals>Input>Touch>Pad OS>Kernel>Display
adjusting labels, evdi isn't touch, it's display
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 9 2018

Labels: merge-merged-chromeos-3.8
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/kernel/+/b185b46d49ab26ad8f5d8b8162d653fcf45a30b7

commit b185b46d49ab26ad8f5d8b8162d653fcf45a30b7
Author: Lukasz Spintzyk <lukasz.spintzyk@displaylink.com>
Date: Tue Jan 09 16:10:40 2018

drm/evdi: Add enable_cursor_blending module param

Parameter is used to enable or disable cursor compositioning on user
supplied framebuffer during EVDI_GRABPIX ioctl.

This adds possibility to get framebuffer content without
cursor and composite cursor in user space application.

By default cursor compositioning is enabled.

BUG= chromium:704498 
TEST=tested on lulu board
CQ-DEPEND=CL:*508612,CL:743561

Change-Id: I85f55153159acbb85250009d1a3deac0158c4123
Signed-off-by: Lukasz Spintzyk <lukasz.spintzyk@displaylink.com>
Reviewed-on: https://chromium-review.googlesource.com/776759
Commit-Ready: Dawid Kurek <dawid.kurek@displaylink.com>
Tested-by: Łukasz Spintzyk <lukasz.spintzyk@displaylink.com>
Reviewed-by: Dominik Behr <dbehr@chromium.org>
Reviewed-by: Łukasz Spintzyk <lukasz.spintzyk@displaylink.com>

[modify] https://crrev.com/b185b46d49ab26ad8f5d8b8162d653fcf45a30b7/drivers/gpu/drm/evdi/evdi_painter.c
[modify] https://crrev.com/b185b46d49ab26ad8f5d8b8162d653fcf45a30b7/drivers/gpu/drm/evdi/evdi_drv.c
[modify] https://crrev.com/b185b46d49ab26ad8f5d8b8162d653fcf45a30b7/drivers/gpu/drm/evdi/evdi_drv.h

Project Member

Comment 4 by bugdroid1@chromium.org, Jan 9 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/kernel/+/bfcf4026cee76ba9cd1db35d9906335f9135fbc2

commit bfcf4026cee76ba9cd1db35d9906335f9135fbc2
Author: Lukasz Spintzyk <lukasz.spintzyk@displaylink.com>
Date: Tue Jan 09 16:10:41 2018

drm/evdi: Add drm cursor events

This is new api which sends notifications about changed cursor.
User can disable cursor blending inside evdi and use drm events instead.

This method is recomended as previous solution was generating
full screen changes when cursor has changed.

BUG= chromium:704498 
TEST=tested on lulu board
CQ-DEPEND=CL:*508612,CL:743561

Change-Id: I5260d6cb27787ff278b0907504bb1e2882ad893f
Signed-off-by: Lukasz Spintzyk <lukasz.spintzyk@displaylink.com>
Reviewed-on: https://chromium-review.googlesource.com/776760
Commit-Ready: Dawid Kurek <dawid.kurek@displaylink.com>
Tested-by: Łukasz Spintzyk <lukasz.spintzyk@displaylink.com>
Reviewed-by: Dominik Behr <dbehr@chromium.org>
Reviewed-by: Łukasz Spintzyk <lukasz.spintzyk@displaylink.com>

[modify] https://crrev.com/bfcf4026cee76ba9cd1db35d9906335f9135fbc2/drivers/gpu/drm/evdi/evdi_gem.c
[modify] https://crrev.com/bfcf4026cee76ba9cd1db35d9906335f9135fbc2/drivers/gpu/drm/evdi/evdi_drv.h
[modify] https://crrev.com/bfcf4026cee76ba9cd1db35d9906335f9135fbc2/drivers/gpu/drm/evdi/evdi_painter.c
[modify] https://crrev.com/bfcf4026cee76ba9cd1db35d9906335f9135fbc2/drivers/gpu/drm/evdi/evdi_modeset.c
[modify] https://crrev.com/bfcf4026cee76ba9cd1db35d9906335f9135fbc2/drivers/gpu/drm/evdi/evdi_cursor.h
[modify] https://crrev.com/bfcf4026cee76ba9cd1db35d9906335f9135fbc2/include/uapi/drm/evdi_drm.h
[modify] https://crrev.com/bfcf4026cee76ba9cd1db35d9906335f9135fbc2/drivers/gpu/drm/evdi/evdi_cursor.c

Project Member

Comment 5 by bugdroid1@chromium.org, Jan 9 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/kernel/+/20deea1b5cab62afd9990b798354510b0fb28030

commit 20deea1b5cab62afd9990b798354510b0fb28030
Author: Lukasz Spintzyk <lukasz.spintzyk@displaylink.com>
Date: Tue Jan 09 16:10:43 2018

drm/evdi: Cursor api cleanup

Changed cursor functions to have name like evdi_cursor_*

Removed evdi_cursor_copy function and introduced cursor lock.
Instead reading from cursor copy we can just lock cursor structure
and read it safely.

BUG= chromium:704498 
TEST=tested on lulu board
CQ-DEPEND=CL:*508612,CL:743561

Change-Id: I3c1119f1a07fd16b04ac5d3418e972d97779e9cb
Signed-off-by: Lukasz Spintzyk <lukasz.spintzyk@displaylink.com>
Reviewed-on: https://chromium-review.googlesource.com/776761
Commit-Ready: Dawid Kurek <dawid.kurek@displaylink.com>
Tested-by: Łukasz Spintzyk <lukasz.spintzyk@displaylink.com>
Reviewed-by: Dominik Behr <dbehr@chromium.org>
Reviewed-by: Łukasz Spintzyk <lukasz.spintzyk@displaylink.com>

[modify] https://crrev.com/20deea1b5cab62afd9990b798354510b0fb28030/drivers/gpu/drm/evdi/evdi_cursor.c
[modify] https://crrev.com/20deea1b5cab62afd9990b798354510b0fb28030/drivers/gpu/drm/evdi/evdi_painter.c
[modify] https://crrev.com/20deea1b5cab62afd9990b798354510b0fb28030/drivers/gpu/drm/evdi/evdi_main.c
[modify] https://crrev.com/20deea1b5cab62afd9990b798354510b0fb28030/drivers/gpu/drm/evdi/evdi_cursor.h
[modify] https://crrev.com/20deea1b5cab62afd9990b798354510b0fb28030/drivers/gpu/drm/evdi/evdi_modeset.c

Project Member

Comment 6 by bugdroid1@chromium.org, Jan 9 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/kernel/+/301b17a1484b989c4c85daeb60a232c344076baa

commit 301b17a1484b989c4c85daeb60a232c344076baa
Author: Lukasz Spintzyk <lukasz.spintzyk@displaylink.com>
Date: Tue Jan 09 16:10:44 2018

drm/evdi: Drop cursor 64x64 limit

Instead of copying cursor during cursor_set event we vmap gem object
and read directly from gem object. Hence there is no need for cursor
buffer allocation and cursor buffer limits.

BUG= chromium:704498 
TEST=tested on lulu board
CQ-DEPEND=CL:*508612,CL:743561

Change-Id: I515d31fce3cf598c96ca0acd5ecf92b9e37e4689
Signed-off-by: Lukasz Spintzyk <lukasz.spintzyk@displaylink.com>
Reviewed-on: https://chromium-review.googlesource.com/776762
Commit-Ready: Dawid Kurek <dawid.kurek@displaylink.com>
Tested-by: Łukasz Spintzyk <lukasz.spintzyk@displaylink.com>
Reviewed-by: Dominik Behr <dbehr@chromium.org>
Reviewed-by: Łukasz Spintzyk <lukasz.spintzyk@displaylink.com>

[modify] https://crrev.com/301b17a1484b989c4c85daeb60a232c344076baa/drivers/gpu/drm/evdi/evdi_fb.c
[modify] https://crrev.com/301b17a1484b989c4c85daeb60a232c344076baa/drivers/gpu/drm/evdi/evdi_drv.h
[modify] https://crrev.com/301b17a1484b989c4c85daeb60a232c344076baa/drivers/gpu/drm/evdi/evdi_painter.c
[modify] https://crrev.com/301b17a1484b989c4c85daeb60a232c344076baa/drivers/gpu/drm/evdi/evdi_modeset.c
[modify] https://crrev.com/301b17a1484b989c4c85daeb60a232c344076baa/drivers/gpu/drm/evdi/evdi_cursor.h
[modify] https://crrev.com/301b17a1484b989c4c85daeb60a232c344076baa/drivers/gpu/drm/evdi/evdi_cursor.c

Project Member

Comment 7 by bugdroid1@chromium.org, Jan 9 2018

Labels: merge-merged-chromeos-3.14
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/kernel/+/46292bf0c99d4a3bbe775fd55fb4960cf691f2e1

commit 46292bf0c99d4a3bbe775fd55fb4960cf691f2e1
Author: Lukasz Spintzyk <lukasz.spintzyk@displaylink.com>
Date: Tue Jan 09 16:10:56 2018

drm/evdi: Add enable_cursor_blending module param

Parameter is used to enable or disable cursor compositioning on user
supplied framebuffer during EVDI_GRABPIX ioctl.

This adds possibility to get framebuffer content without
cursor and composite cursor in user space application.

By default cursor compositioning is enabled.

BUG= chromium:704498 
TEST=tested on lulu board
CQ-DEPEND=CL:*508612,CL:743561

Change-Id: I85f55153159acbb85250009d1a3deac0158c4123
Signed-off-by: Lukasz Spintzyk <lukasz.spintzyk@displaylink.com>
Reviewed-on: https://chromium-review.googlesource.com/475671
Commit-Ready: Dawid Kurek <dawid.kurek@displaylink.com>
Tested-by: Łukasz Spintzyk <lukasz.spintzyk@displaylink.com>
Reviewed-by: Dominik Behr <dbehr@chromium.org>
Reviewed-by: Łukasz Spintzyk <lukasz.spintzyk@displaylink.com>

[modify] https://crrev.com/46292bf0c99d4a3bbe775fd55fb4960cf691f2e1/drivers/gpu/drm/evdi/evdi_painter.c
[modify] https://crrev.com/46292bf0c99d4a3bbe775fd55fb4960cf691f2e1/drivers/gpu/drm/evdi/evdi_drv.c
[modify] https://crrev.com/46292bf0c99d4a3bbe775fd55fb4960cf691f2e1/drivers/gpu/drm/evdi/evdi_drv.h

Project Member

Comment 8 by bugdroid1@chromium.org, Jan 9 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/kernel/+/7ed8b22a4392694c8de750f265ed108c35f05a8f

commit 7ed8b22a4392694c8de750f265ed108c35f05a8f
Author: Lukasz Spintzyk <lukasz.spintzyk@displaylink.com>
Date: Tue Jan 09 16:10:58 2018

drm/evdi: Add drm cursor events

This is new api which sends notifications about changed cursor.
User can disable cursor blending inside evdi and use drm events instead.

This method is recomended as previous solution was generating
full screen changes when cursor has changed.

BUG= chromium:704498 
TEST=tested on lulu board
CQ-DEPEND=CL:*508612,CL:743561

Change-Id: I5260d6cb27787ff278b0907504bb1e2882ad893f
Signed-off-by: Lukasz Spintzyk <lukasz.spintzyk@displaylink.com>
Reviewed-on: https://chromium-review.googlesource.com/475672
Commit-Ready: Dawid Kurek <dawid.kurek@displaylink.com>
Tested-by: Łukasz Spintzyk <lukasz.spintzyk@displaylink.com>
Reviewed-by: Dominik Behr <dbehr@chromium.org>

[modify] https://crrev.com/7ed8b22a4392694c8de750f265ed108c35f05a8f/drivers/gpu/drm/evdi/evdi_gem.c
[modify] https://crrev.com/7ed8b22a4392694c8de750f265ed108c35f05a8f/drivers/gpu/drm/evdi/evdi_drv.h
[modify] https://crrev.com/7ed8b22a4392694c8de750f265ed108c35f05a8f/drivers/gpu/drm/evdi/evdi_painter.c
[modify] https://crrev.com/7ed8b22a4392694c8de750f265ed108c35f05a8f/drivers/gpu/drm/evdi/evdi_modeset.c
[modify] https://crrev.com/7ed8b22a4392694c8de750f265ed108c35f05a8f/drivers/gpu/drm/evdi/evdi_cursor.h
[modify] https://crrev.com/7ed8b22a4392694c8de750f265ed108c35f05a8f/include/uapi/drm/evdi_drm.h
[modify] https://crrev.com/7ed8b22a4392694c8de750f265ed108c35f05a8f/drivers/gpu/drm/evdi/evdi_cursor.c

Project Member

Comment 9 by bugdroid1@chromium.org, Jan 9 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/kernel/+/65da053c84a5677f61e047c0316a8b2a96238988

commit 65da053c84a5677f61e047c0316a8b2a96238988
Author: Lukasz Spintzyk <lukasz.spintzyk@displaylink.com>
Date: Tue Jan 09 16:10:59 2018

drm/evdi: Cursor api cleanup

Changed cursor functions to have name like evdi_cursor_*

Removed evdi_cursor_copy function and introduced cursor lock.
Instead reading from cursor copy we can just lock cursor structure
and read it safely.

BUG= chromium:704498 
TEST=tested on lulu board
CQ-DEPEND=CL:*508612,CL:743561

Change-Id: I3c1119f1a07fd16b04ac5d3418e972d97779e9cb
Signed-off-by: Lukasz Spintzyk <lukasz.spintzyk@displaylink.com>
Reviewed-on: https://chromium-review.googlesource.com/475673
Commit-Ready: Dawid Kurek <dawid.kurek@displaylink.com>
Tested-by: Łukasz Spintzyk <lukasz.spintzyk@displaylink.com>
Reviewed-by: Dominik Behr <dbehr@chromium.org>

[modify] https://crrev.com/65da053c84a5677f61e047c0316a8b2a96238988/drivers/gpu/drm/evdi/evdi_cursor.c
[modify] https://crrev.com/65da053c84a5677f61e047c0316a8b2a96238988/drivers/gpu/drm/evdi/evdi_painter.c
[modify] https://crrev.com/65da053c84a5677f61e047c0316a8b2a96238988/drivers/gpu/drm/evdi/evdi_main.c
[modify] https://crrev.com/65da053c84a5677f61e047c0316a8b2a96238988/drivers/gpu/drm/evdi/evdi_cursor.h
[modify] https://crrev.com/65da053c84a5677f61e047c0316a8b2a96238988/drivers/gpu/drm/evdi/evdi_modeset.c

Project Member

Comment 10 by bugdroid1@chromium.org, Jan 9 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/kernel/+/16faea8c7f13f5c0d0245e3b3984dd16070cc7e4

commit 16faea8c7f13f5c0d0245e3b3984dd16070cc7e4
Author: Lukasz Spintzyk <lukasz.spintzyk@displaylink.com>
Date: Tue Jan 09 16:11:00 2018

drm/evdi: Drop cursor 64x64 limit

Instead of copying cursor during cursor_set event we vmap gem object
and read directly from gem object. Hence there is no need for cursor
buffer allocation and cursor buffer limits.

BUG= chromium:704498 
TEST=tested on lulu board
CQ-DEPEND=CL:*508612,CL:743561

Change-Id: I515d31fce3cf598c96ca0acd5ecf92b9e37e4689
Signed-off-by: Lukasz Spintzyk <lukasz.spintzyk@displaylink.com>
Reviewed-on: https://chromium-review.googlesource.com/475674
Commit-Ready: Dawid Kurek <dawid.kurek@displaylink.com>
Tested-by: Łukasz Spintzyk <lukasz.spintzyk@displaylink.com>
Reviewed-by: Dominik Behr <dbehr@chromium.org>
Reviewed-by: Łukasz Spintzyk <lukasz.spintzyk@displaylink.com>

[modify] https://crrev.com/16faea8c7f13f5c0d0245e3b3984dd16070cc7e4/drivers/gpu/drm/evdi/evdi_fb.c
[modify] https://crrev.com/16faea8c7f13f5c0d0245e3b3984dd16070cc7e4/drivers/gpu/drm/evdi/evdi_drv.h
[modify] https://crrev.com/16faea8c7f13f5c0d0245e3b3984dd16070cc7e4/drivers/gpu/drm/evdi/evdi_painter.c
[modify] https://crrev.com/16faea8c7f13f5c0d0245e3b3984dd16070cc7e4/drivers/gpu/drm/evdi/evdi_modeset.c
[modify] https://crrev.com/16faea8c7f13f5c0d0245e3b3984dd16070cc7e4/drivers/gpu/drm/evdi/evdi_cursor.h
[modify] https://crrev.com/16faea8c7f13f5c0d0245e3b3984dd16070cc7e4/drivers/gpu/drm/evdi/evdi_cursor.c

Project Member

Comment 11 by bugdroid1@chromium.org, Jan 9 2018

Labels: merge-merged-chromeos-3.10
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/kernel/+/a2d88158a917ffc336551c08c7f56241784d1024

commit a2d88158a917ffc336551c08c7f56241784d1024
Author: Lukasz Spintzyk <lukasz.spintzyk@displaylink.com>
Date: Tue Jan 09 16:11:02 2018

drm/evdi: Add enable_cursor_blending module param

Parameter is used to enable or disable cursor compositioning on user
supplied framebuffer during EVDI_GRABPIX ioctl.

This adds possibility to get framebuffer content without
cursor and composite cursor in user space application.

By default cursor compositioning is enabled.

BUG= chromium:704498 
TEST=tested on lulu board
CQ-DEPEND=CL:*508612,CL:743561

Change-Id: I85f55153159acbb85250009d1a3deac0158c4123
Signed-off-by: Lukasz Spintzyk <lukasz.spintzyk@displaylink.com>
Reviewed-on: https://chromium-review.googlesource.com/776754
Commit-Ready: Dawid Kurek <dawid.kurek@displaylink.com>
Tested-by: Łukasz Spintzyk <lukasz.spintzyk@displaylink.com>
Reviewed-by: Dominik Behr <dbehr@chromium.org>
Reviewed-by: Łukasz Spintzyk <lukasz.spintzyk@displaylink.com>

[modify] https://crrev.com/a2d88158a917ffc336551c08c7f56241784d1024/drivers/gpu/drm/evdi/evdi_painter.c
[modify] https://crrev.com/a2d88158a917ffc336551c08c7f56241784d1024/drivers/gpu/drm/evdi/evdi_drv.c
[modify] https://crrev.com/a2d88158a917ffc336551c08c7f56241784d1024/drivers/gpu/drm/evdi/evdi_drv.h

Project Member

Comment 12 by bugdroid1@chromium.org, Jan 9 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/kernel/+/68c26df883fa83fc675ff799b71164e1234c8993

commit 68c26df883fa83fc675ff799b71164e1234c8993
Author: Lukasz Spintzyk <lukasz.spintzyk@displaylink.com>
Date: Tue Jan 09 16:11:03 2018

drm/evdi: Add drm cursor events

This is new api which sends notifications about changed cursor.
User can disable cursor blending inside evdi and use drm events instead.

This method is recomended as previous solution was generating
full screen changes when cursor has changed.

BUG= chromium:704498 
TEST=tested on lulu board
CQ-DEPEND=CL:*508612,CL:743561

Change-Id: I5260d6cb27787ff278b0907504bb1e2882ad893f
Signed-off-by: Lukasz Spintzyk <lukasz.spintzyk@displaylink.com>
Reviewed-on: https://chromium-review.googlesource.com/776755
Commit-Ready: Dawid Kurek <dawid.kurek@displaylink.com>
Tested-by: Łukasz Spintzyk <lukasz.spintzyk@displaylink.com>
Reviewed-by: Dominik Behr <dbehr@chromium.org>

[modify] https://crrev.com/68c26df883fa83fc675ff799b71164e1234c8993/drivers/gpu/drm/evdi/evdi_gem.c
[modify] https://crrev.com/68c26df883fa83fc675ff799b71164e1234c8993/drivers/gpu/drm/evdi/evdi_drv.h
[modify] https://crrev.com/68c26df883fa83fc675ff799b71164e1234c8993/drivers/gpu/drm/evdi/evdi_painter.c
[modify] https://crrev.com/68c26df883fa83fc675ff799b71164e1234c8993/drivers/gpu/drm/evdi/evdi_modeset.c
[modify] https://crrev.com/68c26df883fa83fc675ff799b71164e1234c8993/drivers/gpu/drm/evdi/evdi_cursor.h
[modify] https://crrev.com/68c26df883fa83fc675ff799b71164e1234c8993/include/uapi/drm/evdi_drm.h
[modify] https://crrev.com/68c26df883fa83fc675ff799b71164e1234c8993/drivers/gpu/drm/evdi/evdi_cursor.c

Project Member

Comment 13 by bugdroid1@chromium.org, Jan 9 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/kernel/+/193d9b227c3350c13e98907fafee705a397ba592

commit 193d9b227c3350c13e98907fafee705a397ba592
Author: Lukasz Spintzyk <lukasz.spintzyk@displaylink.com>
Date: Tue Jan 09 16:11:04 2018

drm/evdi: Cursor api cleanup

Changed cursor functions to have name like evdi_cursor_*

Removed evdi_cursor_copy function and introduced cursor lock.
Instead reading from cursor copy we can just lock cursor structure
and read it safely.

BUG= chromium:704498 
TEST=tested on lulu board
CQ-DEPEND=CL:*508612,CL:743561

Change-Id: I3c1119f1a07fd16b04ac5d3418e972d97779e9cb
Signed-off-by: Lukasz Spintzyk <lukasz.spintzyk@displaylink.com>
Reviewed-on: https://chromium-review.googlesource.com/776756
Commit-Ready: Dawid Kurek <dawid.kurek@displaylink.com>
Tested-by: Łukasz Spintzyk <lukasz.spintzyk@displaylink.com>
Reviewed-by: Dominik Behr <dbehr@chromium.org>

[modify] https://crrev.com/193d9b227c3350c13e98907fafee705a397ba592/drivers/gpu/drm/evdi/evdi_cursor.c
[modify] https://crrev.com/193d9b227c3350c13e98907fafee705a397ba592/drivers/gpu/drm/evdi/evdi_painter.c
[modify] https://crrev.com/193d9b227c3350c13e98907fafee705a397ba592/drivers/gpu/drm/evdi/evdi_main.c
[modify] https://crrev.com/193d9b227c3350c13e98907fafee705a397ba592/drivers/gpu/drm/evdi/evdi_cursor.h
[modify] https://crrev.com/193d9b227c3350c13e98907fafee705a397ba592/drivers/gpu/drm/evdi/evdi_modeset.c

Project Member

Comment 14 by bugdroid1@chromium.org, Jan 9 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/kernel/+/cab9fac5f8b2009f933dc95e6dc85b4aaf7927cc

commit cab9fac5f8b2009f933dc95e6dc85b4aaf7927cc
Author: Lukasz Spintzyk <lukasz.spintzyk@displaylink.com>
Date: Tue Jan 09 16:11:05 2018

drm/evdi: Drop cursor 64x64 limit

Instead of copying cursor during cursor_set event we vmap gem object
and read directly from gem object. Hence there is no need for cursor
buffer allocation and cursor buffer limits.

BUG= chromium:704498 
TEST=tested on lulu board
CQ-DEPEND=CL:*508612,CL:743561

Change-Id: I515d31fce3cf598c96ca0acd5ecf92b9e37e4689
Signed-off-by: Lukasz Spintzyk <lukasz.spintzyk@displaylink.com>
Reviewed-on: https://chromium-review.googlesource.com/776757
Commit-Ready: Dawid Kurek <dawid.kurek@displaylink.com>
Tested-by: Łukasz Spintzyk <lukasz.spintzyk@displaylink.com>
Reviewed-by: Dominik Behr <dbehr@chromium.org>

[modify] https://crrev.com/cab9fac5f8b2009f933dc95e6dc85b4aaf7927cc/drivers/gpu/drm/evdi/evdi_fb.c
[modify] https://crrev.com/cab9fac5f8b2009f933dc95e6dc85b4aaf7927cc/drivers/gpu/drm/evdi/evdi_drv.h
[modify] https://crrev.com/cab9fac5f8b2009f933dc95e6dc85b4aaf7927cc/drivers/gpu/drm/evdi/evdi_painter.c
[modify] https://crrev.com/cab9fac5f8b2009f933dc95e6dc85b4aaf7927cc/drivers/gpu/drm/evdi/evdi_modeset.c
[modify] https://crrev.com/cab9fac5f8b2009f933dc95e6dc85b4aaf7927cc/drivers/gpu/drm/evdi/evdi_cursor.h
[modify] https://crrev.com/cab9fac5f8b2009f933dc95e6dc85b4aaf7927cc/drivers/gpu/drm/evdi/evdi_cursor.c

Project Member

Comment 15 by bugdroid1@chromium.org, Jan 9 2018

Labels: merge-merged-chromeos-4.4
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/kernel/+/69071a67c75f5791ea9fe902e000a1e953527a4d

commit 69071a67c75f5791ea9fe902e000a1e953527a4d
Author: Dawid Kurek <dawid.kurek@displaylink.com>
Date: Tue Jan 09 16:10:45 2018

drm/evdi: Add enable_cursor_blending module param

Parameter is used to enable or disable cursor compositioning on user
supplied framebuffer during EVDI_GRABPIX ioctl.

This adds possibility to get framebuffer content without
cursor and composite cursor in user space application.

By default cursor compositioning is enabled.

BUG= chromium:704498 
TEST=tested on lulu board
CQ-DEPEND=CL:*508612,CL:743561

Change-Id: I85f55153159acbb85250009d1a3deac0158c4123
Signed-off-by: Lukasz Spintzyk <lukasz.spintzyk@displaylink.com>
Reviewed-on: https://chromium-review.googlesource.com/776773
Commit-Ready: Dawid Kurek <dawid.kurek@displaylink.com>
Tested-by: Łukasz Spintzyk <lukasz.spintzyk@displaylink.com>
Reviewed-by: Dominik Behr <dbehr@chromium.org>
Reviewed-by: Łukasz Spintzyk <lukasz.spintzyk@displaylink.com>

[modify] https://crrev.com/69071a67c75f5791ea9fe902e000a1e953527a4d/drivers/gpu/drm/evdi/evdi_painter.c
[modify] https://crrev.com/69071a67c75f5791ea9fe902e000a1e953527a4d/drivers/gpu/drm/evdi/evdi_drv.c
[modify] https://crrev.com/69071a67c75f5791ea9fe902e000a1e953527a4d/drivers/gpu/drm/evdi/evdi_drv.h

Project Member

Comment 16 by bugdroid1@chromium.org, Jan 9 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/kernel/+/19b8eb44d86bc43161fb3ffb50195ddcc8373192

commit 19b8eb44d86bc43161fb3ffb50195ddcc8373192
Author: Dawid Kurek <dawid.kurek@displaylink.com>
Date: Tue Jan 09 16:10:47 2018

drm/evdi: Add drm cursor events

This is new api which sends notifications about changed cursor.
User can disable cursor blending inside evdi and use drm events instead.

This method is recomended as previous solution was generating
full screen changes when cursor has changed.

BUG= chromium:704498 
TEST=tested on lulu board
CQ-DEPEND=CL:*508612,CL:743561

Change-Id: I5260d6cb27787ff278b0907504bb1e2882ad893f
Signed-off-by: Lukasz Spintzyk <lukasz.spintzyk@displaylink.com>
Reviewed-on: https://chromium-review.googlesource.com/776774
Commit-Ready: Dawid Kurek <dawid.kurek@displaylink.com>
Tested-by: Łukasz Spintzyk <lukasz.spintzyk@displaylink.com>
Reviewed-by: Dominik Behr <dbehr@chromium.org>
Reviewed-by: Łukasz Spintzyk <lukasz.spintzyk@displaylink.com>

[modify] https://crrev.com/19b8eb44d86bc43161fb3ffb50195ddcc8373192/drivers/gpu/drm/evdi/evdi_gem.c
[modify] https://crrev.com/19b8eb44d86bc43161fb3ffb50195ddcc8373192/drivers/gpu/drm/evdi/evdi_drv.h
[modify] https://crrev.com/19b8eb44d86bc43161fb3ffb50195ddcc8373192/drivers/gpu/drm/evdi/evdi_painter.c
[modify] https://crrev.com/19b8eb44d86bc43161fb3ffb50195ddcc8373192/drivers/gpu/drm/evdi/evdi_modeset.c
[modify] https://crrev.com/19b8eb44d86bc43161fb3ffb50195ddcc8373192/drivers/gpu/drm/evdi/evdi_cursor.h
[modify] https://crrev.com/19b8eb44d86bc43161fb3ffb50195ddcc8373192/include/uapi/drm/evdi_drm.h
[modify] https://crrev.com/19b8eb44d86bc43161fb3ffb50195ddcc8373192/drivers/gpu/drm/evdi/evdi_cursor.c

Project Member

Comment 17 by bugdroid1@chromium.org, Jan 9 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/kernel/+/07e60658f86e5aa099d7b887eff76f768bfd3ed5

commit 07e60658f86e5aa099d7b887eff76f768bfd3ed5
Author: Dawid Kurek <dawid.kurek@displaylink.com>
Date: Tue Jan 09 16:10:48 2018

drm/evdi: Cursor api cleanup

Changed cursor functions to have name like evdi_cursor_*

Removed evdi_cursor_copy function and introduced cursor lock.
Instead reading from cursor copy we can just lock cursor structure
and read it safely.

BUG= chromium:704498 
TEST=tested on lulu board
CQ-DEPEND=CL:*508612,CL:743561

Change-Id: Ia30b56357fe569c95e9b027382f201644b0a8f52
Signed-off-by: Lukasz Spintzyk <lukasz.spintzyk@displaylink.com>
Reviewed-on: https://chromium-review.googlesource.com/776775
Commit-Ready: Dawid Kurek <dawid.kurek@displaylink.com>
Tested-by: Łukasz Spintzyk <lukasz.spintzyk@displaylink.com>
Reviewed-by: Stéphane Marchesin <marcheu@chromium.org>
Reviewed-by: Łukasz Spintzyk <lukasz.spintzyk@displaylink.com>

[modify] https://crrev.com/07e60658f86e5aa099d7b887eff76f768bfd3ed5/drivers/gpu/drm/evdi/evdi_cursor.c
[modify] https://crrev.com/07e60658f86e5aa099d7b887eff76f768bfd3ed5/drivers/gpu/drm/evdi/evdi_painter.c
[modify] https://crrev.com/07e60658f86e5aa099d7b887eff76f768bfd3ed5/drivers/gpu/drm/evdi/evdi_main.c
[modify] https://crrev.com/07e60658f86e5aa099d7b887eff76f768bfd3ed5/drivers/gpu/drm/evdi/evdi_cursor.h
[modify] https://crrev.com/07e60658f86e5aa099d7b887eff76f768bfd3ed5/drivers/gpu/drm/evdi/evdi_modeset.c

Project Member

Comment 18 by bugdroid1@chromium.org, Jan 9 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/kernel/+/48431ff1b06dcb82de3f66ef531bd1205385c2d4

commit 48431ff1b06dcb82de3f66ef531bd1205385c2d4
Author: Dawid Kurek <dawid.kurek@displaylink.com>
Date: Tue Jan 09 16:10:50 2018

drm/evdi: Drop cursor 64x64 limit

Instead of copying cursor during cursor_set event we vmap gem object
and read directly from gem object. Hence there is no need for cursor
buffer allocation and cursor buffer limits.

BUG= chromium:704498 
TEST=tested on lulu board
CQ-DEPEND=CL:*508612,CL:743561

Change-Id: I515d31fce3cf598c96ca0acd5ecf92b9e37e4689
Signed-off-by: Lukasz Spintzyk <lukasz.spintzyk@displaylink.com>
Reviewed-on: https://chromium-review.googlesource.com/776776
Commit-Ready: Dawid Kurek <dawid.kurek@displaylink.com>
Tested-by: Łukasz Spintzyk <lukasz.spintzyk@displaylink.com>
Reviewed-by: Stéphane Marchesin <marcheu@chromium.org>
Reviewed-by: Łukasz Spintzyk <lukasz.spintzyk@displaylink.com>

[modify] https://crrev.com/48431ff1b06dcb82de3f66ef531bd1205385c2d4/drivers/gpu/drm/evdi/evdi_cursor.c
[modify] https://crrev.com/48431ff1b06dcb82de3f66ef531bd1205385c2d4/drivers/gpu/drm/evdi/evdi_fb.c
[modify] https://crrev.com/48431ff1b06dcb82de3f66ef531bd1205385c2d4/drivers/gpu/drm/evdi/evdi_modeset.c
[modify] https://crrev.com/48431ff1b06dcb82de3f66ef531bd1205385c2d4/drivers/gpu/drm/evdi/evdi_drv.h

Project Member

Comment 19 by bugdroid1@chromium.org, Jan 9 2018

Labels: merge-merged-chromeos-3.18
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/kernel/+/30775560245547868c4df634bc35906b7e97336e

commit 30775560245547868c4df634bc35906b7e97336e
Author: Lukasz Spintzyk <lukasz.spintzyk@displaylink.com>
Date: Tue Jan 09 16:10:51 2018

drm/evdi: Add enable_cursor_blending module param

Parameter is used to enable or disable cursor compositioning on user
supplied framebuffer during EVDI_GRABPIX ioctl.

This adds possibility to get framebuffer content without
cursor and composite cursor in user space application.

By default cursor compositioning is enabled.

BUG= chromium:704498 
TEST=tested on lulu board
CQ-DEPEND=CL:*508612,CL:743561

Change-Id: I85f55153159acbb85250009d1a3deac0158c4123
Signed-off-by: Lukasz Spintzyk <lukasz.spintzyk@displaylink.com>
Reviewed-on: https://chromium-review.googlesource.com/776675
Commit-Ready: Dawid Kurek <dawid.kurek@displaylink.com>
Tested-by: Łukasz Spintzyk <lukasz.spintzyk@displaylink.com>
Reviewed-by: Dominik Behr <dbehr@chromium.org>
Reviewed-by: Łukasz Spintzyk <lukasz.spintzyk@displaylink.com>

[modify] https://crrev.com/30775560245547868c4df634bc35906b7e97336e/drivers/gpu/drm/evdi/evdi_painter.c
[modify] https://crrev.com/30775560245547868c4df634bc35906b7e97336e/drivers/gpu/drm/evdi/evdi_drv.c
[modify] https://crrev.com/30775560245547868c4df634bc35906b7e97336e/drivers/gpu/drm/evdi/evdi_drv.h

Project Member

Comment 20 by bugdroid1@chromium.org, Jan 9 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/kernel/+/d43de54756a83b55869af98cbc2568a819a1fce4

commit d43de54756a83b55869af98cbc2568a819a1fce4
Author: Lukasz Spintzyk <lukasz.spintzyk@displaylink.com>
Date: Tue Jan 09 16:10:52 2018

drm/evdi: Add drm cursor events

This is new api which sends notifications about changed cursor.
User can disable cursor blending inside evdi and use drm events instead.

This method is recomended as previous solution was generating
full screen changes when cursor has changed.

BUG= chromium:704498 
TEST=tested on lulu board
CQ-DEPEND=CL:*508612,CL:743561

Change-Id: I5260d6cb27787ff278b0907504bb1e2882ad893f
Signed-off-by: Lukasz Spintzyk <lukasz.spintzyk@displaylink.com>
Reviewed-on: https://chromium-review.googlesource.com/776676
Commit-Ready: Dawid Kurek <dawid.kurek@displaylink.com>
Tested-by: Łukasz Spintzyk <lukasz.spintzyk@displaylink.com>
Reviewed-by: Dominik Behr <dbehr@chromium.org>

[modify] https://crrev.com/d43de54756a83b55869af98cbc2568a819a1fce4/drivers/gpu/drm/evdi/evdi_gem.c
[modify] https://crrev.com/d43de54756a83b55869af98cbc2568a819a1fce4/drivers/gpu/drm/evdi/evdi_drv.h
[modify] https://crrev.com/d43de54756a83b55869af98cbc2568a819a1fce4/drivers/gpu/drm/evdi/evdi_painter.c
[modify] https://crrev.com/d43de54756a83b55869af98cbc2568a819a1fce4/drivers/gpu/drm/evdi/evdi_modeset.c
[modify] https://crrev.com/d43de54756a83b55869af98cbc2568a819a1fce4/drivers/gpu/drm/evdi/evdi_cursor.h
[modify] https://crrev.com/d43de54756a83b55869af98cbc2568a819a1fce4/include/uapi/drm/evdi_drm.h
[modify] https://crrev.com/d43de54756a83b55869af98cbc2568a819a1fce4/drivers/gpu/drm/evdi/evdi_cursor.c

Project Member

Comment 21 by bugdroid1@chromium.org, Jan 9 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/kernel/+/4ca3291e466b9cfcea3bcc2a92ecec244bcef5fb

commit 4ca3291e466b9cfcea3bcc2a92ecec244bcef5fb
Author: Lukasz Spintzyk <lukasz.spintzyk@displaylink.com>
Date: Tue Jan 09 16:10:54 2018

drm/evdi: Cursor api cleanup

Changed cursor functions to have name like evdi_cursor_*

Removed evdi_cursor_copy function and introduced cursor lock.
Instead reading from cursor copy we can just lock cursor structure
and read it safely.

BUG= chromium:704498 
TEST=tested on lulu board
CQ-DEPEND=CL:*508612,CL:743561

Change-Id: I3c1119f1a07fd16b04ac5d3418e972d97779e9cb
Signed-off-by: Lukasz Spintzyk <lukasz.spintzyk@displaylink.com>
Reviewed-on: https://chromium-review.googlesource.com/776677
Commit-Ready: Dawid Kurek <dawid.kurek@displaylink.com>
Tested-by: Łukasz Spintzyk <lukasz.spintzyk@displaylink.com>
Reviewed-by: Dominik Behr <dbehr@chromium.org>

[modify] https://crrev.com/4ca3291e466b9cfcea3bcc2a92ecec244bcef5fb/drivers/gpu/drm/evdi/evdi_cursor.c
[modify] https://crrev.com/4ca3291e466b9cfcea3bcc2a92ecec244bcef5fb/drivers/gpu/drm/evdi/evdi_painter.c
[modify] https://crrev.com/4ca3291e466b9cfcea3bcc2a92ecec244bcef5fb/drivers/gpu/drm/evdi/evdi_main.c
[modify] https://crrev.com/4ca3291e466b9cfcea3bcc2a92ecec244bcef5fb/drivers/gpu/drm/evdi/evdi_cursor.h
[modify] https://crrev.com/4ca3291e466b9cfcea3bcc2a92ecec244bcef5fb/drivers/gpu/drm/evdi/evdi_modeset.c

Project Member

Comment 22 by bugdroid1@chromium.org, Jan 9 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/kernel/+/ddeafd89a595679adffaf50db11331b0e5e5bde4

commit ddeafd89a595679adffaf50db11331b0e5e5bde4
Author: Lukasz Spintzyk <lukasz.spintzyk@displaylink.com>
Date: Tue Jan 09 16:10:55 2018

drm/evdi: Drop cursor 64x64 limit

Instead of copying cursor during cursor_set event we vmap gem object
and read directly from gem object. Hence there is no need for cursor
buffer allocation and cursor buffer limits.

BUG= chromium:704498 
TEST=tested on lulu board
CQ-DEPEND=CL:*508612,CL:743561

Change-Id: I515d31fce3cf598c96ca0acd5ecf92b9e37e4689
Signed-off-by: Lukasz Spintzyk <lukasz.spintzyk@displaylink.com>
Reviewed-on: https://chromium-review.googlesource.com/776678
Commit-Ready: Dawid Kurek <dawid.kurek@displaylink.com>
Tested-by: Łukasz Spintzyk <lukasz.spintzyk@displaylink.com>
Reviewed-by: Dominik Behr <dbehr@chromium.org>

[modify] https://crrev.com/ddeafd89a595679adffaf50db11331b0e5e5bde4/drivers/gpu/drm/evdi/evdi_fb.c
[modify] https://crrev.com/ddeafd89a595679adffaf50db11331b0e5e5bde4/drivers/gpu/drm/evdi/evdi_drv.h
[modify] https://crrev.com/ddeafd89a595679adffaf50db11331b0e5e5bde4/drivers/gpu/drm/evdi/evdi_painter.c
[modify] https://crrev.com/ddeafd89a595679adffaf50db11331b0e5e5bde4/drivers/gpu/drm/evdi/evdi_modeset.c
[modify] https://crrev.com/ddeafd89a595679adffaf50db11331b0e5e5bde4/drivers/gpu/drm/evdi/evdi_cursor.h
[modify] https://crrev.com/ddeafd89a595679adffaf50db11331b0e5e5bde4/drivers/gpu/drm/evdi/evdi_cursor.c

Project Member

Comment 23 by sheriffbot@chromium.org, Jan 9

Status: Archived (was: Unconfirmed)
Issue has not been modified or commented on in the last 365 days, please re-open or file a new bug if this is still an issue.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment