New issue
Advanced search Search tips

Issue 704496 link

Starred by 1 user
Status: Fixed
Owner:
mastiz@chromium.org
Closed: Mar 2017
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Improve selection of favicon bitmaps

Project Member Reported by mastiz@chromium.org, Mar 23 2017 
Currently, on mobile, chrome fetches the largest favicon available. During download, it reduces images to no more than 192x192 (on Android, currently 144x144).

For sites publishing 192x192 favicons and even higher-resolution ones, it makes no sense to download anything bigger than 192.
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 31 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/89f78d0440e218d828e11e891ad76e5f98a1f41b

commit 89f78d0440e218d828e11e891ad76e5f98a1f41b
Author: mastiz <mastiz@chromium.org>
Date: Fri Mar 31 11:49:01 2017

Always select best favicon bitmap

We do this by always sorting candidates by score, which should list
the best-matching sizes first.

This has two positive effects:
1. On mobile, selection of high-resolution bitmap doesn't choose
   the absolute largest, but the best fit.

2. On desktop, candidates are also sorted, so exact matches are more
   likely to be processed first and hence reducing the total number of
   downloaded images.

BUG= 704496 

Review-Url: https://codereview.chromium.org/2739173002
Cr-Commit-Position: refs/heads/master@{#461096}

[modify] https://crrev.com/89f78d0440e218d828e11e891ad76e5f98a1f41b/components/favicon/core/favicon_handler.cc
[modify] https://crrev.com/89f78d0440e218d828e11e891ad76e5f98a1f41b/components/favicon/core/favicon_handler.h
[modify] https://crrev.com/89f78d0440e218d828e11e891ad76e5f98a1f41b/components/favicon/core/favicon_handler_unittest.cc
[modify] https://crrev.com/89f78d0440e218d828e11e891ad76e5f98a1f41b/components/favicon_base/select_favicon_frames.cc

Comment 2 by mastiz@chromium.org, Mar 31 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment