New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 704493 link

Starred by 1 user
Status: Fixed
Owner:
gambard@chromium.org
Closed: Jul 2017
Cc:
ios-bugs@chromium.org
█ ramyan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug



Sign in to add a comment

Add ContentSuggestions EG tests in Showcase

Project Member Reported by gambard@chromium.org, Mar 23 2017 
The EG tests for ContentSuggestions will be more easily implemented in showcase where the data can be mock easily.
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 2 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6858b7fa2ae42b6c687589f39dd8c70509cb44ac

commit 6858b7fa2ae42b6c687589f39dd8c70509cb44ac
Author: gambard <gambard@chromium.org>
Date: Fri Jun 02 16:19:02 2017

Add CSDataSource in showcase

This CL adds a fake data source for ContentSuggestions in showcase.

BUG= 704493 

Review-Url: https://codereview.chromium.org/2769063005
Cr-Commit-Position: refs/heads/master@{#476683}

[modify] https://crrev.com/6858b7fa2ae42b6c687589f39dd8c70509cb44ac/ios/showcase/DEPS
[modify] https://crrev.com/6858b7fa2ae42b6c687589f39dd8c70509cb44ac/ios/showcase/content_suggestions/BUILD.gn
[modify] https://crrev.com/6858b7fa2ae42b6c687589f39dd8c70509cb44ac/ios/showcase/content_suggestions/sc_content_suggestions_coordinator.mm
[add] https://crrev.com/6858b7fa2ae42b6c687589f39dd8c70509cb44ac/ios/showcase/content_suggestions/sc_content_suggestions_data_source.h
[add] https://crrev.com/6858b7fa2ae42b6c687589f39dd8c70509cb44ac/ios/showcase/content_suggestions/sc_content_suggestions_data_source.mm
[modify] https://crrev.com/6858b7fa2ae42b6c687589f39dd8c70509cb44ac/ios/showcase/content_suggestions/sc_content_suggestions_egtest.mm
[add] https://crrev.com/6858b7fa2ae42b6c687589f39dd8c70509cb44ac/ios/showcase/content_suggestions/sc_content_suggestions_item.h
[add] https://crrev.com/6858b7fa2ae42b6c687589f39dd8c70509cb44ac/ios/showcase/content_suggestions/sc_content_suggestions_item.mm
[add] https://crrev.com/6858b7fa2ae42b6c687589f39dd8c70509cb44ac/ios/showcase/content_suggestions/sc_content_suggestions_most_visited_item.h
[add] https://crrev.com/6858b7fa2ae42b6c687589f39dd8c70509cb44ac/ios/showcase/content_suggestions/sc_content_suggestions_most_visited_item.mm
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 13 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9252a3b5bb4c21ab80082b5a82530dee524bdca7

commit 9252a3b5bb4c21ab80082b5a82530dee524bdca7
Author: Gauthier Ambard <gambard@chromium.org>
Date: Tue Jun 13 16:25:43 2017

Revert "Add EG test for SCContentSuggestions"

This reverts commit 2be5085c9c7797ebadf40df25c25e54449743406.

Reason for revert: Breaks on iPhone 5

Original change's description:
> Add EG test for SCContentSuggestions
> 
> This CL adds Earl Grey tests testing swipe to dismiss, tap and long press on
> suggested content.
> 
> BUG= 704493 
> 
> Change-Id: Ibd3d9e8030fcaf4069a2cf632791bbb0387a7301
> Reviewed-on: https://chromium-review.googlesource.com/529248
> Commit-Queue: Gauthier Ambard <gambard@chromium.org>
> Reviewed-by: Louis Romero <lpromero@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#478984}

TBR=lpromero@chromium.org,edchin@chromium.org,gambard@chromium.org

Change-Id: I8677cffaf92abd123f6b0a215886416f76fca175
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  704493 
Reviewed-on: https://chromium-review.googlesource.com/533338
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#479040}
[modify] https://crrev.com/9252a3b5bb4c21ab80082b5a82530dee524bdca7/ios/showcase/content_suggestions/BUILD.gn
[modify] https://crrev.com/9252a3b5bb4c21ab80082b5a82530dee524bdca7/ios/showcase/content_suggestions/sc_content_suggestions_data_source.h
[modify] https://crrev.com/9252a3b5bb4c21ab80082b5a82530dee524bdca7/ios/showcase/content_suggestions/sc_content_suggestions_data_source.mm
[modify] https://crrev.com/9252a3b5bb4c21ab80082b5a82530dee524bdca7/ios/showcase/content_suggestions/sc_content_suggestions_egtest.mm
[modify] https://crrev.com/9252a3b5bb4c21ab80082b5a82530dee524bdca7/ios/showcase/content_suggestions/sc_content_suggestions_item.mm
Project Member

Comment 6 by bugdroid1@chromium.org, Jun 27 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/717b58ffd06c514834037b488fe21280e55bda10

commit 717b58ffd06c514834037b488fe21280e55bda10
Author: gambard <gambard@chromium.org>
Date: Tue Jun 27 09:18:30 2017

Disable ContentSuggestions EG tests

The ContentSuggestions EG tests are failing because the protocol alerter
is a proxy for a protocol receiving a command for all scrolls.
This CL disable them.

BUG= 704493 

Change-Id: I465757918c3dc87cd88f299956edc9f6a8c0a8e5
Reviewed-on: https://chromium-review.googlesource.com/549637
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Commit-Queue: Louis Romero <lpromero@chromium.org>
Reviewed-by: Louis Romero <lpromero@chromium.org>
Cr-Commit-Position: refs/heads/master@{#482580}
[modify] https://crrev.com/717b58ffd06c514834037b488fe21280e55bda10/ios/showcase/content_suggestions/sc_content_suggestions_egtest.mm
Project Member

Comment 7 by bugdroid1@chromium.org, Jun 27 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1a687256189f82e98c8e79d0d7088580eb9f7a03

commit 1a687256189f82e98c8e79d0d7088580eb9f7a03
Author: gambard <gambard@chromium.org>
Date: Tue Jun 27 11:09:42 2017

Split the ContentSuggestionsCommands protocol

Split the ContentSuggestionsCommands protocol in two:
- One protocol handles the commands related to the content suggestions
- The other handles the commands sent to the header (fake omnibox + logo)

It allows to re-enable the eg tests.

BUG= 704493 

Change-Id: Ice0b52943bbb4f90b7bf154c278595516a1d1ead
Reviewed-on: https://chromium-review.googlesource.com/549361
Reviewed-by: Louis Romero <lpromero@chromium.org>
Commit-Queue: Louis Romero <lpromero@chromium.org>
Cr-Commit-Position: refs/heads/master@{#482595}
[modify] https://crrev.com/1a687256189f82e98c8e79d0d7088580eb9f7a03/ios/chrome/browser/content_suggestions/content_suggestions_coordinator.mm
[modify] https://crrev.com/1a687256189f82e98c8e79d0d7088580eb9f7a03/ios/chrome/browser/ui/content_suggestions/BUILD.gn
[modify] https://crrev.com/1a687256189f82e98c8e79d0d7088580eb9f7a03/ios/chrome/browser/ui/content_suggestions/content_suggestions_commands.h
[add] https://crrev.com/1a687256189f82e98c8e79d0d7088580eb9f7a03/ios/chrome/browser/ui/content_suggestions/content_suggestions_header_commands.h
[modify] https://crrev.com/1a687256189f82e98c8e79d0d7088580eb9f7a03/ios/chrome/browser/ui/content_suggestions/content_suggestions_view_controller.h
[modify] https://crrev.com/1a687256189f82e98c8e79d0d7088580eb9f7a03/ios/chrome/browser/ui/content_suggestions/content_suggestions_view_controller.mm
[modify] https://crrev.com/1a687256189f82e98c8e79d0d7088580eb9f7a03/ios/showcase/content_suggestions/sc_content_suggestions_egtest.mm

Comment 8 by gambard@chromium.org, Jul 28 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment