New issue
Advanced search Search tips

Issue 704487 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug



Sign in to add a comment

Remove the IsReadingListEnabled flags

Project Member Reported by gambard@chromium.org, Mar 23 2017

Issue description

ReadingList is now enabled by default and there is no major crashes for now.
The guards inside ios/ should be removed.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/65d69150df80f6272d3f81c855e85f0009dc7048

commit 65d69150df80f6272d3f81c855e85f0009dc7048
Author: gambard <gambard@chromium.org>
Date: Thu Mar 23 17:44:22 2017

Removes the IsReadingListEnabled flags

BUG= 704487 

Review-Url: https://codereview.chromium.org/2774603002
Cr-Commit-Position: refs/heads/master@{#459132}

[modify] https://crrev.com/65d69150df80f6272d3f81c855e85f0009dc7048/ios/chrome/app/BUILD.gn
[modify] https://crrev.com/65d69150df80f6272d3f81c855e85f0009dc7048/ios/chrome/app/main_controller.mm
[modify] https://crrev.com/65d69150df80f6272d3f81c855e85f0009dc7048/ios/chrome/app/startup_tasks.mm
[modify] https://crrev.com/65d69150df80f6272d3f81c855e85f0009dc7048/ios/chrome/browser/BUILD.gn
[modify] https://crrev.com/65d69150df80f6272d3f81c855e85f0009dc7048/ios/chrome/browser/about_flags.mm
[modify] https://crrev.com/65d69150df80f6272d3f81c855e85f0009dc7048/ios/chrome/browser/experimental_flags.h
[modify] https://crrev.com/65d69150df80f6272d3f81c855e85f0009dc7048/ios/chrome/browser/experimental_flags.mm
[modify] https://crrev.com/65d69150df80f6272d3f81c855e85f0009dc7048/ios/chrome/browser/reading_list/BUILD.gn
[modify] https://crrev.com/65d69150df80f6272d3f81c855e85f0009dc7048/ios/chrome/browser/reading_list/reading_list_model_factory.cc
[modify] https://crrev.com/65d69150df80f6272d3f81c855e85f0009dc7048/ios/chrome/browser/reading_list/reading_list_model_factory.h
[modify] https://crrev.com/65d69150df80f6272d3f81c855e85f0009dc7048/ios/chrome/browser/sync/BUILD.gn
[modify] https://crrev.com/65d69150df80f6272d3f81c855e85f0009dc7048/ios/chrome/browser/sync/ios_chrome_profile_sync_service_factory_unittest.cc
[modify] https://crrev.com/65d69150df80f6272d3f81c855e85f0009dc7048/ios/chrome/browser/sync/ios_chrome_sync_client.mm
[modify] https://crrev.com/65d69150df80f6272d3f81c855e85f0009dc7048/ios/chrome/browser/tabs/BUILD.gn
[modify] https://crrev.com/65d69150df80f6272d3f81c855e85f0009dc7048/ios/chrome/browser/tabs/tab.mm
[modify] https://crrev.com/65d69150df80f6272d3f81c855e85f0009dc7048/ios/chrome/browser/tabs/tab_helper_util.mm
[modify] https://crrev.com/65d69150df80f6272d3f81c855e85f0009dc7048/ios/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/65d69150df80f6272d3f81c855e85f0009dc7048/ios/chrome/browser/ui/activity_services/BUILD.gn
[modify] https://crrev.com/65d69150df80f6272d3f81c855e85f0009dc7048/ios/chrome/browser/ui/activity_services/activity_service_controller.mm
[modify] https://crrev.com/65d69150df80f6272d3f81c855e85f0009dc7048/ios/chrome/browser/ui/activity_services/activity_service_controller_unittest.mm
[modify] https://crrev.com/65d69150df80f6272d3f81c855e85f0009dc7048/ios/chrome/browser/ui/browser_view_controller.mm
[modify] https://crrev.com/65d69150df80f6272d3f81c855e85f0009dc7048/ios/chrome/browser/ui/ntp/BUILD.gn
[modify] https://crrev.com/65d69150df80f6272d3f81c855e85f0009dc7048/ios/chrome/browser/ui/ntp/google_landing_controller.mm
[modify] https://crrev.com/65d69150df80f6272d3f81c855e85f0009dc7048/ios/chrome/browser/ui/reading_list/BUILD.gn
[modify] https://crrev.com/65d69150df80f6272d3f81c855e85f0009dc7048/ios/chrome/browser/ui/reading_list/offline_page_native_content.mm
[modify] https://crrev.com/65d69150df80f6272d3f81c855e85f0009dc7048/ios/chrome/browser/ui/settings/sync_settings_collection_view_controller.mm
[modify] https://crrev.com/65d69150df80f6272d3f81c855e85f0009dc7048/ios/chrome/browser/ui/settings/sync_settings_collection_view_controller_unittest.mm
[modify] https://crrev.com/65d69150df80f6272d3f81c855e85f0009dc7048/ios/chrome/browser/ui/side_swipe/BUILD.gn
[modify] https://crrev.com/65d69150df80f6272d3f81c855e85f0009dc7048/ios/chrome/browser/ui/side_swipe/side_swipe_controller.mm
[modify] https://crrev.com/65d69150df80f6272d3f81c855e85f0009dc7048/ios/chrome/browser/ui/toolbar/BUILD.gn
[modify] https://crrev.com/65d69150df80f6272d3f81c855e85f0009dc7048/ios/chrome/browser/ui/toolbar/web_toolbar_controller.mm
[modify] https://crrev.com/65d69150df80f6272d3f81c855e85f0009dc7048/ios/chrome/browser/ui/tools_menu/BUILD.gn
[modify] https://crrev.com/65d69150df80f6272d3f81c855e85f0009dc7048/ios/chrome/browser/ui/tools_menu/tools_menu_model.mm
[modify] https://crrev.com/65d69150df80f6272d3f81c855e85f0009dc7048/ios/chrome/browser/ui/tools_menu/tools_menu_view_controller.mm

Status: Fixed (was: Assigned)

Sign in to add a comment