New issue
Advanced search Search tips

Issue 704446 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 3
Type: Bug



Sign in to add a comment

Impossible to double-click and select just a value in Network > Headers

Reported by bengo...@gmail.com, Mar 23 2017

Issue description

UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_3) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/56.0.2924.87 Safari/537.36

Steps to reproduce the problem:
1. Open Chromium Developer Tools and reload a web page.
2. Open the Network Tab, and click a request to show the Headers tab
3. In the table of key-value pairs, attempt to select the Request URL by double clicking at the end of the URL and dragging the mouse to the beginning of the value. 

What is the expected behavior?
I expect to be able to quickly select the value and copy-paste it to a co-worker, or use it to construct a test request, etc.

What went wrong?
Upon selecting the first "word" of the value, the last word of the column name (in this case "URL:") also becomes selected, meaning you'd need to edit the pasteboard after Ctrl-C.

(See GIF for visual example)

Did this work before? N/A 

Chrome version: 56.0.2924.87  Channel: stable
OS Version: OS X 10.12.3
Flash Version: 

I know this is a tiny thing but I do it all the time and it drives me crazy :-) I'll submit a patch that fixes it.
 
unwanted-behavior.gif
280 KB View Download
Labels: Needs-Milestone
Cc: jmukthavaram@chromium.org
Labels: Needs-Feedback
Unable to reproduce the issue on Mac 10.12.4,Ubuntu 14.04 & Windows 7 using chrome reported version-56.0.2924.87,stable-57.0.2987.110 & Canary-59.0.3055.0 as per comment#0 & above gif file.
Please find the attached screencast & let us know if we miss anything to reproduce the issue.
Thank you!!
704446.mp4
1.8 MB View Download

Comment 3 by bengo...@gmail.com, Mar 29 2017

Hey! Thanks for taking the time to reproduce this! In the video, it looks like you're starting a drag from a position past the end of the text and then moving the mouse over the value. That puts the selection in "individual character" mode and works fine for me as well.

The issue only occurs when you double-click the end of the value to begin the selection, which puts you in "word-by-word" selection mode as opposed to "individual character" selection mode. (It's totally possible that I'm the only one that starts selections by double-clicking...) In that case, because there are no word breaking characters between the column name and value, the selection will extend to the column name as soon as you mouse over the first word of the value.

Sorry for the hassle–I know this is super nitpicky, it was just bugging me one evening and I thought I'd try to contribute :-)
Project Member

Comment 4 by sheriffbot@chromium.org, Mar 29 2017

Labels: -Needs-Feedback
Thank you for providing more feedback. Adding requester "jmukthavaram@chromium.org" to the cc list and removing "Needs-Feedback" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 5 by ajha@chromium.org, Mar 30 2017

Cc: ajha@chromium.org
Labels: -Needs-Milestone M-59 OS-Linux OS-Windows
Status: Untriaged (was: Unconfirmed)
Marking this as Untriaged and for more inputs on this as per C#3. I am able to reproduce the issue on the latest canary(59.0.3055.0) on Windows-10, Mac OS 10.12.3 and Linux Ubuntu 14.04. Similar behavior is seen on older chrome version: 30.0.1549.0 as well.

Labels: -Pri-2 Hotlist-Polish Pri-3
Owner: allada@chromium.org
Status: Assigned (was: Untriaged)
I am able to recreate the issue. Thanks for the bug it's a simple boundary issue in CSS. I'll add it to my queue.

Thanks again!

Comment 7 by allada@chromium.org, Apr 11 2017

Status: Started (was: Assigned)
Owner: l...@chromium.org
Status: Assigned (was: Started)

Comment 9 by l...@chromium.org, Dec 21 2017

Cc: l...@chromium.org
 Issue 755572  has been merged into this issue.
Project Member

Comment 10 by bugdroid1@chromium.org, Jan 3 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cf3358943a335ad9a54b184d0e82cd7437b81af1

commit cf3358943a335ad9a54b184d0e82cd7437b81af1
Author: Erik Luo <luoe@chromium.org>
Date: Wed Jan 03 21:12:38 2018

DevTools: improve text selection in Network request headers

- Double click + drag over the value will not select the key
- Copying headers now includes a space after the ':' before the value

Screenshot: https://imgur.com/a/pRdPj

Bug:  704446 
Change-Id: Ibb05b0f4c94b56857a940c424323e6faaa9a57d2
Reviewed-on: https://chromium-review.googlesource.com/838405
Commit-Queue: Erik Luo <luoe@chromium.org>
Reviewed-by: Andrey Lushnikov <lushnikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526814}
[modify] https://crrev.com/cf3358943a335ad9a54b184d0e82cd7437b81af1/third_party/WebKit/Source/devtools/front_end/network/RequestHeadersView.js
[modify] https://crrev.com/cf3358943a335ad9a54b184d0e82cd7437b81af1/third_party/WebKit/Source/devtools/front_end/network/requestHeadersTree.css

Comment 11 by l...@chromium.org, Jan 3 2018

Status: Fixed (was: Assigned)

Comment 12 by ajha@chromium.org, Jan 4 2018

Labels: TE-Verified-M65 TE-Verified-65.0.3311.0
Verified the fix on the latest M-65(65.0.3311.0) on Windows-10(on unsigned chrome build), Mac OS 10.12.6 and Linux Ubuntu 14.04 and this is working as intended as per the CL description in C#10.

Adding the verified label therefore and attaching the screen-cast.
704446.mp4
3.6 MB View Download

Sign in to add a comment