Regression : Weird behaviour of text caret is seen in chrome://md-settings page.
Reported by
rp...@etouch.net,
Mar 23 2017
|
||||||||
Issue descriptionVersion: 59.0.3049.0 76aac97386e2788241161420c5e7e0bfee16f88c-refs/heads/master@{#458956} OS: Windows (7,8,8.1,10),Linux (14.04 LTS),Mac OS X(10.11.6,10.12.1) What steps will reproduce the problem? 1. Launch chrome, navigate to chrome://md-settings and click on show home button under 'Appearance' 2. Now click on 'Enter custom web add...' text field and observe text caret behavior Actual: Text caret blinks several times at first instance after clicking on 'Enter custom web add...' text field Expected: Text caret should not blink several times at first instance after clicking on 'Enter custom web add...' text field This is regression issue, broken in ‘M 59’ and will soon update other info : Good build:59.0.3043.0 Bad build: 59.0.3044.0
,
Mar 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8f35a712fd404645efbc73aa8a1ce71d6d0078c0 commit 8f35a712fd404645efbc73aa8a1ce71d6d0078c0 Author: wangxianzhu <wangxianzhu@chromium.org> Date: Mon Mar 27 18:24:29 2017 Fix caret visual rect on compositing change We should not clear CaretDisplayItemClient::m_localRect in CaretDisplayItemClient::clearPreviousVisualRects() (which is called on compositing change) because - it doesn't change on compositing change; - compositing change happens after updateStyleAndLayoutIfNeeded(); - we'll need m_localRect to calculate the new visual rect during paint invalidation. BUG= 704443 Review-Url: https://codereview.chromium.org/2777183003 Cr-Commit-Position: refs/heads/master@{#459833} [modify] https://crrev.com/8f35a712fd404645efbc73aa8a1ce71d6d0078c0/third_party/WebKit/Source/core/editing/CaretDisplayItemClient.cpp [modify] https://crrev.com/8f35a712fd404645efbc73aa8a1ce71d6d0078c0/third_party/WebKit/Source/core/editing/CaretDisplayItemClientTest.cpp
,
Mar 27 2017
,
Mar 27 2017
,
Mar 28 2017
Your change meets the bar and is auto-approved for M58. Please go ahead and merge the CL to branch 3029 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Mar 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/09159c33fefdbea144d2baf6485736f922ed8c08 commit 09159c33fefdbea144d2baf6485736f922ed8c08 Author: wangxianzhu <wangxianzhu@chromium.org> Date: Tue Mar 28 18:34:52 2017 Fix caret visual rect on compositing change We should not clear CaretDisplayItemClient::m_localRect in CaretDisplayItemClient::clearPreviousVisualRects() (which is called on compositing change) because - it doesn't change on compositing change; - compositing change happens after updateStyleAndLayoutIfNeeded(); - we'll need m_localRect to calculate the new visual rect during paint invalidation. BUG= 704443 TBR=wangxianzhu@chromium.org NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2777183003 Cr-Original-Commit-Position: refs/heads/master@{#459833} Review-Url: https://codereview.chromium.org/2779953002 Cr-Commit-Position: refs/branch-heads/3029@{#455} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} [modify] https://crrev.com/09159c33fefdbea144d2baf6485736f922ed8c08/third_party/WebKit/Source/core/editing/CaretDisplayItemClient.cpp [modify] https://crrev.com/09159c33fefdbea144d2baf6485736f922ed8c08/third_party/WebKit/Source/core/editing/CaretDisplayItemClientTest.cpp
,
Mar 28 2017
,
Mar 29 2017
Tested the issue on Windows-7,Mac-10.12.3 and Linux Ubuntu-14.04 using chrome version# 58.0.3029.41 with the steps mentioned in comment#0. Observed that the fix is working as expected. Hence adding TE-Verified labels. Please find the attached screen cast for the same. Thanks!!
,
Mar 29 2017
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by kkaluri@chromium.org
, Mar 23 2017Labels: hasbisect-per-revision
Owner: wangxianzhu@chromium.org
Status: Assigned (was: Unconfirmed)