New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 704443 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Regression : Weird behaviour of text caret is seen in chrome://md-settings page.

Reported by rp...@etouch.net, Mar 23 2017

Issue description

Version: 59.0.3049.0 76aac97386e2788241161420c5e7e0bfee16f88c-refs/heads/master@{#458956}
OS: Windows (7,8,8.1,10),Linux (14.04 LTS),Mac OS X(10.11.6,10.12.1)

What steps will reproduce the problem?
1. Launch chrome, navigate to chrome://md-settings and click on show home button under 'Appearance'
2. Now click on 'Enter custom web add...' text field and observe text caret behavior

Actual: Text caret blinks several times at first instance after clicking on 'Enter custom web add...' text field 
Expected: Text caret should not blink several times at first instance after clicking on 'Enter custom web add...' text field

This is regression issue, broken in ‘M 59’ and will soon update other info :
Good build:59.0.3043.0
Bad build: 59.0.3044.0
 
Actual_video.mp4
372 KB View Download
Expected_video.mp4
708 KB View Download
Cc: kkaluri@chromium.org
Labels: hasbisect-per-revision
Owner: wangxianzhu@chromium.org
Status: Assigned (was: Unconfirmed)
Bisect Info:
===========
Good build :  59.0.3043.0,  Revision Range - 457297
Bad build  :  59.0.3044.0,  Revision Range - 457648

After executing the per-revision bisect script , i got the following CL's between good and bad build versions
===========================================
https://chromium.googlesource.com/chromium/src/+log/2ca42b225daf7f14d092d601f67b154fcc3b8876..eeaca73ad3f97a71c35c8298ccf691ebad35161d

The suspecting Change Log is :
-----------
https://chromium.googlesource.com/chromium/src/+/eeaca73ad3f97a71c35c8298ccf691ebad35161d

Review-Url: https://codereview.chromium.org/2754993002

wangxianzhu@- Could you please look into this issue, if it's related to your change?  if not could you please help us to reassign this issue to the right owner.



Project Member

Comment 2 by bugdroid1@chromium.org, Mar 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8f35a712fd404645efbc73aa8a1ce71d6d0078c0

commit 8f35a712fd404645efbc73aa8a1ce71d6d0078c0
Author: wangxianzhu <wangxianzhu@chromium.org>
Date: Mon Mar 27 18:24:29 2017

Fix caret visual rect on compositing change

We should not clear CaretDisplayItemClient::m_localRect in
CaretDisplayItemClient::clearPreviousVisualRects() (which is called
on compositing change) because
- it doesn't change on compositing change;
- compositing change happens after updateStyleAndLayoutIfNeeded();
- we'll need m_localRect to calculate the new visual rect during paint
  invalidation.

BUG= 704443 

Review-Url: https://codereview.chromium.org/2777183003
Cr-Commit-Position: refs/heads/master@{#459833}

[modify] https://crrev.com/8f35a712fd404645efbc73aa8a1ce71d6d0078c0/third_party/WebKit/Source/core/editing/CaretDisplayItemClient.cpp
[modify] https://crrev.com/8f35a712fd404645efbc73aa8a1ce71d6d0078c0/third_party/WebKit/Source/core/editing/CaretDisplayItemClientTest.cpp

Labels: -M-59 Merge-Request-58 M-58
Components: Blink>Paint>Invalidation
Project Member

Comment 5 by sheriffbot@chromium.org, Mar 28 2017

Labels: -Merge-Request-58 Hotlist-Merge-Approved Merge-Approved-58
Your change meets the bar and is auto-approved for M58. Please go ahead and merge the CL to branch 3029 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 6 by bugdroid1@chromium.org, Mar 28 2017

Labels: -merge-approved-58 merge-merged-3029
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/09159c33fefdbea144d2baf6485736f922ed8c08

commit 09159c33fefdbea144d2baf6485736f922ed8c08
Author: wangxianzhu <wangxianzhu@chromium.org>
Date: Tue Mar 28 18:34:52 2017

Fix caret visual rect on compositing change

We should not clear CaretDisplayItemClient::m_localRect in
CaretDisplayItemClient::clearPreviousVisualRects() (which is called
on compositing change) because
- it doesn't change on compositing change;
- compositing change happens after updateStyleAndLayoutIfNeeded();
- we'll need m_localRect to calculate the new visual rect during paint
  invalidation.

BUG= 704443 
TBR=wangxianzhu@chromium.org
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2777183003
Cr-Original-Commit-Position: refs/heads/master@{#459833}
Review-Url: https://codereview.chromium.org/2779953002
Cr-Commit-Position: refs/branch-heads/3029@{#455}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}

[modify] https://crrev.com/09159c33fefdbea144d2baf6485736f922ed8c08/third_party/WebKit/Source/core/editing/CaretDisplayItemClient.cpp
[modify] https://crrev.com/09159c33fefdbea144d2baf6485736f922ed8c08/third_party/WebKit/Source/core/editing/CaretDisplayItemClientTest.cpp

Status: Fixed (was: Assigned)
Labels: TE-Verified-M58 TE-Verified-58.0.3029.41
Tested the issue on Windows-7,Mac-10.12.3 and Linux Ubuntu-14.04 using chrome version# 58.0.3029.41 with the steps mentioned in comment#0.
Observed that the fix is working as expected. Hence adding TE-Verified labels.
Please find the attached screen cast for the same.

Thanks!!
704443.mp4
511 KB View Download
Status: Verified (was: Fixed)

Sign in to add a comment