New issue
Advanced search Search tips

Issue 704441 link

Starred by 0 users
Status: Available
Owner: ----
Cc:
mastiz@chromium.org
dominickn@chromium.org
blundell@chromium.org
mlamouri@chromium.org
fhorschig@chromium.org
esprehn@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task

Blocking:
issue 787246



Sign in to add a comment

Onion soup content::ManifestManager

Project Member Reported by dominickn@chromium.org, Mar 23 2017 
The web app manifest object currently lives in content/public, with the ManifestParser in content/renderer (so it can talk to blink for some parsing work / run in the sandboxed process).

We'd like to move the manifest object itself to a component. The motivating driver is that we want to start caching icons from manifests in the FaviconService, which means that we need to have access to manifests within components/favicons/core (which does not depend on content). Additionally, componentising manifest means that we can reuse the object on iOS as well.

The ManifestParser would move directly into Blink and out of content/renderer in this process.

Mounir, do you have any thoughts / opinions on this proposal?

Comment 1 by fhorschig@google.com, Mar 23 2017

Cc: fhorschig@chromium.org

Comment 2 by mlamouri@chromium.org, Mar 23 2017

Cc: blundell@chromium.org
Is it usual to have web standards implementation in components/? Could Blink access the component?

Would it help if the manifest parser was servicified, assuming it can live in the renderer process? +blundell@

Comment 3 by dominickn@chromium.org, Mar 23 2017 

c#2: there are a few examples already of blink having DEPS on components. Payments is the primary example, where a bunch of the Chromium-internal implementation details (including mojom structs) are in components/payments.

The main motivation for componentization is to allow the same manifest struct to be reused on iOS and within the favicon code. I'm not sure whether servicifying the manifest parser would help allow the manifest itself to be used on the non-Blink iOS platform (though the manifest parser itself should move completely into Blink in this process).

Comment 4 by mlamouri@chromium.org, Mar 23 2017 

Is manifest support on iOS a goal or a nice side effect?

Comment 5 by blundell@chromium.org, Mar 24 2017 

It's unclear to me what the goals here are as well. Is it primarily to share interfaces, or is there a significant amount of code in //content that should be shared with iOS?

If it's primarily to share interfaces, I wonder how much of the surface of manifest.h the cross-platform code would be looking to use? 

FWIW, I am not a fan of //third_party/WebKit depending on //components and would like to avoid adding more such dependencies. //third_party/WebKit depending on //services, on the other hand, would be much more palatable.

Comment 6 by dominickn@chromium.org, Mar 30 2017 

mastiz: how important is being able to reuse the manifest object for iOS in the favicon code? Is it possible to have an all-but-iOS side that uses the manifest and fetches the manifest icons, and a separate (or no) implementation on iOS?

Comment 7 by mastiz@chromium.org, Mar 30 2017 

Prioritizing iOS is always a hard call, but is definitely desirable that Android and iOS don't diverge in features, including favicon support. This PM land though.

Considering the concerns around dependencies, starting with Android only is something I'm not against. Once we sort this out, and assuming there's no better solution to the problem of build dependencies, worst case, we could fork the manifest code into iOS.

Comment 8 by blundell@chromium.org, Mar 30 2017 

mastiz@: Could you answer the questions in c#5? That would help me understand better. Thanks!

Comment 9 by mastiz@chromium.org, Mar 30 2017 

Wrt to interfaces vs implementation: my understanding is that it's mostly about the implementation, ManifestParser. The interface we need to share is very simple, at least currently, a small subset of Manifest, which includes a short title (string) and list of favicons (relatively simple struct).

Comment 10 by blundell@chromium.org, Mar 31 2017 

Thanks for the info! I think that whenever the concrete need arises, a good way to proceed would be to make a CL that implements the needed functionality by doing the necessary duplication / wrapping to show exactly what the scope of sharing would need to be and what the cost of not sharing is. That will make it easier to reason about the tradeoffs between different approaches.

Comment 11 by blundell@chromium.org, Mar 31 2017 

(To be clear, in c#10 I mean to do the CL as a starting point for furthering this discussion concretely).

Comment 12 by dominickn@chromium.org, Apr 3 2017 

It seems we have a rough agreement to ignore the iOS side for the time being and start on Android only for mobile (i.e. Mojoify manifests, probably moving them into Blink which I think was the plan before we starting talking about adding a dependency from favicons on manifests). Then further down the line we can have another conversation about sharing the implementation / duplicating the code.

At the very least, we'll need to allow favicons to depend on where-ever manifests end up. Does this seem reasonable mastiz@?

Comment 13 by blundell@chromium.org, Apr 3 2017 

If there's a thought that we would share this interface and impl with iOS down the road, moving manifest parsing into a service that Blink connects to would be more useful architecturally than moving manifest parsing into Blink.

Comment 14 by mastiz@chromium.org, Apr 3 2017 

Sorry if I'm missing something, but if we ignore iOS, I'm no longer convinced we need to componentize manifests. I'm leaning towards integrating webmanifest favicons first (via ContentFaviconDriver), and short titles could be coupled to favicon-fetching in a first version.

Comment 15 by blundell@chromium.org, Apr 3 2017 

Re: c#14, that seems like a nice incremental approach - take the simple approach now (how layered components were initially designed to be used), and address c#10 at the time of considering serious iOS integration.

Comment 16 by dominickn@chromium.org, Apr 4 2017 

Yeah, the only motivation for componentisation was to have sharing with iOS. If we leave that aside there's no need to componentise right now.

Comment 17 by lafo...@chromium.org, May 5 2017

Components: -Manifest Blink>AppManifest
Deprecate (and bulk edit/ move) Manifest

Comment 18 by sa...@chromium.org, Nov 1 2017

Components: Blink>Internals>Modularization
Status: Started (was: Assigned)
Summary: Onion soup content::ManifestManager (was: Componentize content::Manifest)
Project Member

Comment 19 by bugdroid1@chromium.org, Nov 2 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cfe7a06100aaedfd38e1d2e37aea7877e682417c

commit cfe7a06100aaedfd38e1d2e37aea7877e682417c
Author: Sam McNally <sammc@chromium.org>
Date: Thu Nov 02 00:40:07 2017

Disassociate the ManifestManager mojo interface.

The ManifestManager interface is channel-associated to preserve ordering
only in tests.

The manifest browser tests rely on console logging IPCs being delivered
FIFO with the ManifestManager::RequestManifest response.  Replace this
channel-association with an explicit wait for a channel-associated round
trip only in the test by creating a channel-associated interface and
using FlushForTesting().

The service worker manifest fetching tests rely on injected JS code
running before the manifest request is received by the renderer. Change
this to wait for a response before requesting the manifest.

Bug: 704441
Change-Id: I290a72125769aae09b5460b75dbb2e0cbfe46c1d
Reviewed-on: https://chromium-review.googlesource.com/746503
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Sam McNally <sammc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513342}
[modify] https://crrev.com/cfe7a06100aaedfd38e1d2e37aea7877e682417c/chrome/browser/chrome_service_worker_browsertest.cc
[modify] https://crrev.com/cfe7a06100aaedfd38e1d2e37aea7877e682417c/content/browser/manifest/manifest_browsertest.cc
[modify] https://crrev.com/cfe7a06100aaedfd38e1d2e37aea7877e682417c/content/browser/manifest/manifest_manager_host.cc
[modify] https://crrev.com/cfe7a06100aaedfd38e1d2e37aea7877e682417c/content/browser/manifest/manifest_manager_host.h
[modify] https://crrev.com/cfe7a06100aaedfd38e1d2e37aea7877e682417c/content/renderer/manifest/manifest_manager.cc
[modify] https://crrev.com/cfe7a06100aaedfd38e1d2e37aea7877e682417c/content/renderer/manifest/manifest_manager.h
[modify] https://crrev.com/cfe7a06100aaedfd38e1d2e37aea7877e682417c/content/renderer/render_frame_impl.cc

Comment 20 by slangley@chromium.org, Nov 21 2017

Blocking: 787246
Project Member

Comment 21 by bugdroid1@chromium.org, Nov 27 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e44fa0d28e16691baa246e38bb0b518e3c26fba1

commit e44fa0d28e16691baa246e38bb0b518e3c26fba1
Author: Sam McNally <sammc@chromium.org>
Date: Mon Nov 27 23:28:05 2017

Unify the mojo and C++ ManifestManager interfaces.

ManifestManager will be moved from content/renderer into blink. Once
this is done, its clients in the renderer will no longer be able to
access it directly, instead using mojo. In preparation for this, migrate
ManifestDebugInfo to be a mojo struct, add it to the mojo interface and
migrate the in-process clients to use the mojo interface.

Change DevToolsAgent to use the manifest URL returned by the
ManifestManager instead of looking up the manifest URL from the
document, avoiding the possibility of reporting a newer manifest URL
not matching the reported manifest debug info.

Bug: 704441
Change-Id: Ib95ab9370f657987811cb85c9287d2de7f38e125
Reviewed-on: https://chromium-review.googlesource.com/749565
Reviewed-by: Greg Kerr <kerrnel@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: Sam McNally <sammc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519448}
[modify] https://crrev.com/e44fa0d28e16691baa246e38bb0b518e3c26fba1/content/browser/manifest/manifest_manager_host.cc
[modify] https://crrev.com/e44fa0d28e16691baa246e38bb0b518e3c26fba1/content/browser/manifest/manifest_manager_host.h
[modify] https://crrev.com/e44fa0d28e16691baa246e38bb0b518e3c26fba1/content/public/common/manifest.typemap
[modify] https://crrev.com/e44fa0d28e16691baa246e38bb0b518e3c26fba1/content/public/common/manifest_struct_traits.h
[modify] https://crrev.com/e44fa0d28e16691baa246e38bb0b518e3c26fba1/content/renderer/BUILD.gn
[modify] https://crrev.com/e44fa0d28e16691baa246e38bb0b518e3c26fba1/content/renderer/devtools/devtools_agent.cc
[modify] https://crrev.com/e44fa0d28e16691baa246e38bb0b518e3c26fba1/content/renderer/devtools/devtools_agent.h
[modify] https://crrev.com/e44fa0d28e16691baa246e38bb0b518e3c26fba1/content/renderer/installedapp/related_apps_fetcher.cc
[modify] https://crrev.com/e44fa0d28e16691baa246e38bb0b518e3c26fba1/content/renderer/installedapp/related_apps_fetcher.h
[delete] https://crrev.com/f43966946ab3000e019a997c8f368f19233d562c/content/renderer/manifest/manifest_debug_info.cc
[delete] https://crrev.com/f43966946ab3000e019a997c8f368f19233d562c/content/renderer/manifest/manifest_debug_info.h
[modify] https://crrev.com/e44fa0d28e16691baa246e38bb0b518e3c26fba1/content/renderer/manifest/manifest_manager.cc
[modify] https://crrev.com/e44fa0d28e16691baa246e38bb0b518e3c26fba1/content/renderer/manifest/manifest_manager.h
[modify] https://crrev.com/e44fa0d28e16691baa246e38bb0b518e3c26fba1/content/renderer/manifest/manifest_parser.cc
[modify] https://crrev.com/e44fa0d28e16691baa246e38bb0b518e3c26fba1/content/renderer/manifest/manifest_parser.h
[modify] https://crrev.com/e44fa0d28e16691baa246e38bb0b518e3c26fba1/content/renderer/manifest/manifest_parser_unittest.cc
[modify] https://crrev.com/e44fa0d28e16691baa246e38bb0b518e3c26fba1/content/renderer/push_messaging/push_messaging_client.cc
[modify] https://crrev.com/e44fa0d28e16691baa246e38bb0b518e3c26fba1/content/renderer/push_messaging/push_messaging_client.h
[modify] https://crrev.com/e44fa0d28e16691baa246e38bb0b518e3c26fba1/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/e44fa0d28e16691baa246e38bb0b518e3c26fba1/content/renderer/render_frame_impl.h
[modify] https://crrev.com/e44fa0d28e16691baa246e38bb0b518e3c26fba1/third_party/WebKit/public/platform/modules/manifest/manifest.mojom
[modify] https://crrev.com/e44fa0d28e16691baa246e38bb0b518e3c26fba1/third_party/WebKit/public/platform/modules/manifest/manifest_manager.mojom
Project Member

Comment 22 by bugdroid1@chromium.org, Dec 5 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/65b472737b0c1100ee672b9b89c3d2439defb654

commit 65b472737b0c1100ee672b9b89c3d2439defb654
Author: Sam McNally <sammc@chromium.org>
Date: Tue Dec 05 00:31:52 2017

Split manifest change notifications from ManifestManager.

Also remove layout test support's direct use of ManifestFetcher,
changing it to use ManifestManager instead.

Bug: 704441
Change-Id: I0417baaf6598a8c7d967e3ce1fd32e78bea22aa0
Reviewed-on: https://chromium-review.googlesource.com/774040
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Sam McNally <sammc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521548}
[modify] https://crrev.com/65b472737b0c1100ee672b9b89c3d2439defb654/content/public/test/layouttest_support.h
[modify] https://crrev.com/65b472737b0c1100ee672b9b89c3d2439defb654/content/renderer/BUILD.gn
[add] https://crrev.com/65b472737b0c1100ee672b9b89c3d2439defb654/content/renderer/manifest/manifest_change_notifier.cc
[add] https://crrev.com/65b472737b0c1100ee672b9b89c3d2439defb654/content/renderer/manifest/manifest_change_notifier.h
[modify] https://crrev.com/65b472737b0c1100ee672b9b89c3d2439defb654/content/renderer/manifest/manifest_manager.cc
[modify] https://crrev.com/65b472737b0c1100ee672b9b89c3d2439defb654/content/renderer/manifest/manifest_manager.h
[modify] https://crrev.com/65b472737b0c1100ee672b9b89c3d2439defb654/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/65b472737b0c1100ee672b9b89c3d2439defb654/content/shell/renderer/layout_test/blink_test_runner.cc
[modify] https://crrev.com/65b472737b0c1100ee672b9b89c3d2439defb654/content/shell/renderer/layout_test/blink_test_runner.h
[modify] https://crrev.com/65b472737b0c1100ee672b9b89c3d2439defb654/content/shell/test_runner/test_runner_for_specific_view.cc
[modify] https://crrev.com/65b472737b0c1100ee672b9b89c3d2439defb654/content/shell/test_runner/test_runner_for_specific_view.h
[modify] https://crrev.com/65b472737b0c1100ee672b9b89c3d2439defb654/content/shell/test_runner/web_test_delegate.h
[modify] https://crrev.com/65b472737b0c1100ee672b9b89c3d2439defb654/content/test/BUILD.gn
[modify] https://crrev.com/65b472737b0c1100ee672b9b89c3d2439defb654/content/test/layouttest_support.cc

Comment 23 by sa...@chromium.org, Feb 8 2018

Owner: ----
Status: Available (was: Started)
Project Member

Comment 24 by bugdroid1@chromium.org, Apr 27 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c26b0d003fe8869d827fe74eeb6911ee5be2a74c

commit c26b0d003fe8869d827fe74eeb6911ee5be2a74c
Author: Dmitry Gozman <dgozman@chromium.org>
Date: Fri Apr 27 00:39:09 2018

Mangle some reserved class names in java mojo bindings

Currently just two class names are listed:
R turns into R_, Manifest into Manifest_.

This is to resolve conflicting class name Manifest, which is used
widely on Android and is blacklisted in our build rules. See
https://chromium.googlesource.com/chromium/src/+/4201258320b95d3b599a4d1b899f89fb19baec7f/build/config/android/rules.gni#1650

This was discovered when trying to move manifest.mojom which defines
Manifest struct to blink so that android_webview build started to fail.

Bug: 704441
Change-Id: If6d59aecdad249ef5acb839a08f20ff5385fcd52
Reviewed-on: https://chromium-review.googlesource.com/1028979
Reviewed-by: Ken Rockot <rockot@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: David Turner <digit@chromium.org>
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554223}
[modify] https://crrev.com/c26b0d003fe8869d827fe74eeb6911ee5be2a74c/mojo/public/tools/bindings/generators/mojom_java_generator.py
Project Member

Comment 25 by bugdroid1@chromium.org, May 1 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c07726e17cf5280456e8e118a7775bc60c2f2e6d

commit c07726e17cf5280456e8e118a7775bc60c2f2e6d
Author: Dmitry Gozman <dgozman@chromium.org>
Date: Tue May 01 01:17:40 2018

Move manifest.mojom and content::Manifest to blink

... as a part of Onion Soup project.

This also required moving WebDisplayMode from public/platform
to public/common since it's referenced both in manifest itself
and, more generally, browser code.

mojom::blink::Manifest is typemapped to blink::Manifest, which uses
stl types and should be used by blink's embedder, not blink
implementation.

Bug: 704441
Change-Id: I94d07bb028278f17d215f64c14552793d5f916ae
Reviewed-on: https://chromium-review.googlesource.com/1006188
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554953}
[modify] https://crrev.com/c07726e17cf5280456e8e118a7775bc60c2f2e6d/chrome/android/java/src/org/chromium/chrome/browser/ShortcutHelper.java
[modify] https://crrev.com/c07726e17cf5280456e8e118a7775bc60c2f2e6d/chrome/browser/DEPS
[modify] https://crrev.com/c07726e17cf5280456e8e118a7775bc60c2f2e6d/chrome/browser/android/metrics/launch_metrics.cc
[modify] https://crrev.com/c07726e17cf5280456e8e118a7775bc60c2f2e6d/chrome/browser/android/shortcut_helper.cc
[modify] https://crrev.com/c07726e17cf5280456e8e118a7775bc60c2f2e6d/chrome/browser/android/shortcut_helper.h
[modify] https://crrev.com/c07726e17cf5280456e8e118a7775bc60c2f2e6d/chrome/browser/android/shortcut_info.cc
[modify] https://crrev.com/c07726e17cf5280456e8e118a7775bc60c2f2e6d/chrome/browser/android/shortcut_info.h
[modify] https://crrev.com/c07726e17cf5280456e8e118a7775bc60c2f2e6d/chrome/browser/android/shortcut_info_unittest.cc
[modify] https://crrev.com/c07726e17cf5280456e8e118a7775bc60c2f2e6d/chrome/browser/android/webapk/webapk_info.h
[modify] https://crrev.com/c07726e17cf5280456e8e118a7775bc60c2f2e6d/chrome/browser/android/webapk/webapk_installer.cc
[modify] https://crrev.com/c07726e17cf5280456e8e118a7775bc60c2f2e6d/chrome/browser/android/webapk/webapk_update_data_fetcher.cc
[modify] https://crrev.com/c07726e17cf5280456e8e118a7775bc60c2f2e6d/chrome/browser/android/webapk/webapk_update_data_fetcher.h
[modify] https://crrev.com/c07726e17cf5280456e8e118a7775bc60c2f2e6d/chrome/browser/android/webapk/webapk_web_manifest_checker.cc
[modify] https://crrev.com/c07726e17cf5280456e8e118a7775bc60c2f2e6d/chrome/browser/android/webapk/webapk_web_manifest_checker.h
[modify] https://crrev.com/c07726e17cf5280456e8e118a7775bc60c2f2e6d/chrome/browser/android/webapk/webapk_web_manifest_checker_unittest.cc
[modify] https://crrev.com/c07726e17cf5280456e8e118a7775bc60c2f2e6d/chrome/browser/android/webapps/add_to_homescreen_data_fetcher.cc
[modify] https://crrev.com/c07726e17cf5280456e8e118a7775bc60c2f2e6d/chrome/browser/android/webapps/add_to_homescreen_data_fetcher_unittest.cc
[modify] https://crrev.com/c07726e17cf5280456e8e118a7775bc60c2f2e6d/chrome/browser/banners/app_banner_infobar_delegate_desktop.cc
[modify] https://crrev.com/c07726e17cf5280456e8e118a7775bc60c2f2e6d/chrome/browser/banners/app_banner_infobar_delegate_desktop.h
[modify] https://crrev.com/c07726e17cf5280456e8e118a7775bc60c2f2e6d/chrome/browser/banners/app_banner_manager.cc
[modify] https://crrev.com/c07726e17cf5280456e8e118a7775bc60c2f2e6d/chrome/browser/banners/app_banner_manager.h
[modify] https://crrev.com/c07726e17cf5280456e8e118a7775bc60c2f2e6d/chrome/browser/banners/app_banner_metrics.h
[modify] https://crrev.com/c07726e17cf5280456e8e118a7775bc60c2f2e6d/chrome/browser/chrome_service_worker_browsertest.cc
[modify] https://crrev.com/c07726e17cf5280456e8e118a7775bc60c2f2e6d/chrome/browser/extensions/bookmark_app_helper.cc
[modify] https://crrev.com/c07726e17cf5280456e8e118a7775bc60c2f2e6d/chrome/browser/extensions/bookmark_app_helper.h
[modify] https://crrev.com/c07726e17cf5280456e8e118a7775bc60c2f2e6d/chrome/browser/extensions/bookmark_app_helper_unittest.cc
[modify] https://crrev.com/c07726e17cf5280456e8e118a7775bc60c2f2e6d/chrome/browser/infobars/infobars_browsertest.cc
[modify] https://crrev.com/c07726e17cf5280456e8e118a7775bc60c2f2e6d/chrome/browser/installable/installable_data.cc
[modify] https://crrev.com/c07726e17cf5280456e8e118a7775bc60c2f2e6d/chrome/browser/installable/installable_data.h
[modify] https://crrev.com/c07726e17cf5280456e8e118a7775bc60c2f2e6d/chrome/browser/installable/installable_manager.cc
[modify] https://crrev.com/c07726e17cf5280456e8e118a7775bc60c2f2e6d/chrome/browser/installable/installable_manager.h
[modify] https://crrev.com/c07726e17cf5280456e8e118a7775bc60c2f2e6d/chrome/browser/installable/installable_manager_browsertest.cc
[modify] https://crrev.com/c07726e17cf5280456e8e118a7775bc60c2f2e6d/chrome/browser/installable/installable_manager_unittest.cc
[modify] https://crrev.com/c07726e17cf5280456e8e118a7775bc60c2f2e6d/chrome/browser/installable/installable_task_queue_unittest.cc
[modify] https://crrev.com/c07726e17cf5280456e8e118a7775bc60c2f2e6d/chrome/browser/ui/webui/webapks_handler.cc
[modify] https://crrev.com/c07726e17cf5280456e8e118a7775bc60c2f2e6d/chrome/browser/webshare/share_target_pref_helper.cc
[modify] https://crrev.com/c07726e17cf5280456e8e118a7775bc60c2f2e6d/chrome/browser/webshare/share_target_pref_helper.h
[modify] https://crrev.com/c07726e17cf5280456e8e118a7775bc60c2f2e6d/chrome/browser/webshare/share_target_pref_helper_unittest.cc
[modify] https://crrev.com/c07726e17cf5280456e8e118a7775bc60c2f2e6d/components/favicon/content/DEPS
[modify] https://crrev.com/c07726e17cf5280456e8e118a7775bc60c2f2e6d/components/favicon/content/content_favicon_driver.cc
[modify] https://crrev.com/c07726e17cf5280456e8e118a7775bc60c2f2e6d/components/payments/content/DEPS
[modify] https://crrev.com/c07726e17cf5280456e8e118a7775bc60c2f2e6d/components/payments/content/installable_payment_app_crawler.cc
[modify] https://crrev.com/c07726e17cf5280456e8e118a7775bc60c2f2e6d/content/browser/DEPS
[modify] https://crrev.com/c07726e17cf5280456e8e118a7775bc60c2f2e6d/content/browser/devtools/protocol/page_handler.h
[modify] https://crrev.com/c07726e17cf5280456e8e118a7775bc60c2f2e6d/content/browser/manifest/manifest_browsertest.cc
[modify] https://crrev.com/c07726e17cf5280456e8e118a7775bc60c2f2e6d/content/browser/manifest/manifest_icon_selector.cc
[modify] https://crrev.com/c07726e17cf5280456e8e118a7775bc60c2f2e6d/content/browser/manifest/manifest_icon_selector_unittest.cc
[modify] https://crrev.com/c07726e17cf5280456e8e118a7775bc60c2f2e6d/content/browser/manifest/manifest_manager_host.cc
[modify] https://crrev.com/c07726e17cf5280456e8e118a7775bc60c2f2e6d/content/browser/manifest/manifest_manager_host.h
[modify] https://crrev.com/c07726e17cf5280456e8e118a7775bc60c2f2e6d/content/browser/net/accept_header_browsertest.cc
[modify] https://crrev.com/c07726e17cf5280456e8e118a7775bc60c2f2e6d/content/browser/payments/payment_app_database.cc
[modify] https://crrev.com/c07726e17cf5280456e8e118a7775bc60c2f2e6d/content/browser/payments/payment_app_info_fetcher.cc
[modify] https://crrev.com/c07726e17cf5280456e8e118a7775bc60c2f2e6d/content/browser/payments/payment_app_info_fetcher.h
[modify] https://crrev.com/c07726e17cf5280456e8e118a7775bc60c2f2e6d/content/browser/payments/payment_instrument_icon_fetcher.cc
[modify] https://crrev.com/c07726e17cf5280456e8e118a7775bc60c2f2e6d/content/browser/payments/payment_instrument_icon_fetcher.h
[modify] https://crrev.com/c07726e17cf5280456e8e118a7775bc60c2f2e6d/content/browser/renderer_host/render_widget_host_delegate.h
[modify] https://crrev.com/c07726e17cf5280456e8e118a7775bc60c2f2e6d/content/browser/renderer_host/render_widget_host_impl.h
[modify] https://crrev.com/c07726e17cf5280456e8e118a7775bc60c2f2e6d/content/common/DEPS
[modify] https://crrev.com/c07726e17cf5280456e8e118a7775bc60c2f2e6d/content/common/frame_visual_properties.h
[modify] https://crrev.com/c07726e17cf5280456e8e118a7775bc60c2f2e6d/content/common/view_messages.h
[modify] https://crrev.com/c07726e17cf5280456e8e118a7775bc60c2f2e6d/content/common/visual_properties.h
[modify] https://crrev.com/c07726e17cf5280456e8e118a7775bc60c2f2e6d/content/public/browser/manifest_icon_selector.h
[modify] https://crrev.com/c07726e17cf5280456e8e118a7775bc60c2f2e6d/content/public/browser/web_contents.h
[modify] https://crrev.com/c07726e17cf5280456e8e118a7775bc60c2f2e6d/content/public/browser/web_contents_delegate.h
[modify] https://crrev.com/c07726e17cf5280456e8e118a7775bc60c2f2e6d/content/public/common/BUILD.gn
[delete] https://crrev.com/e4774fc79110aa35c59cb9ba3de3863b8e40d2a8/content/public/common/manifest.typemap
[delete] https://crrev.com/e4774fc79110aa35c59cb9ba3de3863b8e40d2a8/content/public/common/manifest_struct_traits.h
[modify] https://crrev.com/c07726e17cf5280456e8e118a7775bc60c2f2e6d/content/public/common/manifest_util.h
[modify] https://crrev.com/c07726e17cf5280456e8e118a7775bc60c2f2e6d/content/public/common/typemaps.gni
[modify] https://crrev.com/c07726e17cf5280456e8e118a7775bc60c2f2e6d/content/public/test/layouttest_support.h
[modify] https://crrev.com/c07726e17cf5280456e8e118a7775bc60c2f2e6d/content/renderer/installedapp/related_apps_fetcher.cc
[modify] https://crrev.com/c07726e17cf5280456e8e118a7775bc60c2f2e6d/content/renderer/installedapp/related_apps_fetcher.h
[modify] https://crrev.com/c07726e17cf5280456e8e118a7775bc60c2f2e6d/content/renderer/manifest/manifest_manager.cc
[modify] https://crrev.com/c07726e17cf5280456e8e118a7775bc60c2f2e6d/content/renderer/manifest/manifest_manager.h
[modify] https://crrev.com/c07726e17cf5280456e8e118a7775bc60c2f2e6d/content/renderer/manifest/manifest_parser.cc
[modify] https://crrev.com/c07726e17cf5280456e8e118a7775bc60c2f2e6d/content/renderer/manifest/manifest_parser.h
[modify] https://crrev.com/c07726e17cf5280456e8e118a7775bc60c2f2e6d/content/renderer/manifest/manifest_parser_unittest.cc
[modify] https://crrev.com/c07726e17cf5280456e8e118a7775bc60c2f2e6d/content/renderer/manifest/manifest_uma_util.cc
[modify] https://crrev.com/c07726e17cf5280456e8e118a7775bc60c2f2e6d/content/renderer/manifest/manifest_uma_util.h
[modify] https://crrev.com/c07726e17cf5280456e8e118a7775bc60c2f2e6d/content/renderer/push_messaging/push_messaging_client.cc
[modify] https://crrev.com/c07726e17cf5280456e8e118a7775bc60c2f2e6d/content/renderer/push_messaging/push_messaging_client.h
[modify] https://crrev.com/c07726e17cf5280456e8e118a7775bc60c2f2e6d/content/renderer/render_frame_impl.h
[modify] https://crrev.com/c07726e17cf5280456e8e118a7775bc60c2f2e6d/content/renderer/render_widget.h
[modify] https://crrev.com/c07726e17cf5280456e8e118a7775bc60c2f2e6d/content/shell/renderer/layout_test/blink_test_runner.cc
[modify] https://crrev.com/c07726e17cf5280456e8e118a7775bc60c2f2e6d/content/shell/renderer/layout_test/blink_test_runner.h
[modify] https://crrev.com/c07726e17cf5280456e8e118a7775bc60c2f2e6d/content/shell/test_runner/test_runner_for_specific_view.cc
[modify] https://crrev.com/c07726e17cf5280456e8e118a7775bc60c2f2e6d/content/shell/test_runner/test_runner_for_specific_view.h
[modify] https://crrev.com/c07726e17cf5280456e8e118a7775bc60c2f2e6d/content/shell/test_runner/web_test_delegate.h
[modify] https://crrev.com/c07726e17cf5280456e8e118a7775bc60c2f2e6d/services/device/public/mojom/BUILD.gn
[modify] https://crrev.com/c07726e17cf5280456e8e118a7775bc60c2f2e6d/third_party/blink/common/BUILD.gn
[modify] https://crrev.com/c07726e17cf5280456e8e118a7775bc60c2f2e6d/third_party/blink/common/DEPS
[add] https://crrev.com/c07726e17cf5280456e8e118a7775bc60c2f2e6d/third_party/blink/common/manifest/OWNERS
[rename] https://crrev.com/c07726e17cf5280456e8e118a7775bc60c2f2e6d/third_party/blink/common/manifest/manifest.cc
[rename] https://crrev.com/c07726e17cf5280456e8e118a7775bc60c2f2e6d/third_party/blink/common/manifest/manifest_mojom_traits.cc
[modify] https://crrev.com/c07726e17cf5280456e8e118a7775bc60c2f2e6d/third_party/blink/public/BUILD.gn
[modify] https://crrev.com/c07726e17cf5280456e8e118a7775bc60c2f2e6d/third_party/blink/public/common/BUILD.gn
[modify] https://crrev.com/c07726e17cf5280456e8e118a7775bc60c2f2e6d/third_party/blink/public/common/DEPS
[add] https://crrev.com/c07726e17cf5280456e8e118a7775bc60c2f2e6d/third_party/blink/public/common/manifest/OWNERS
[add] https://crrev.com/c07726e17cf5280456e8e118a7775bc60c2f2e6d/third_party/blink/public/common/manifest/display_mode.typemap
[rename] https://crrev.com/c07726e17cf5280456e8e118a7775bc60c2f2e6d/third_party/blink/public/common/manifest/manifest.h
[add] https://crrev.com/c07726e17cf5280456e8e118a7775bc60c2f2e6d/third_party/blink/public/common/manifest/manifest.typemap
[add] https://crrev.com/c07726e17cf5280456e8e118a7775bc60c2f2e6d/third_party/blink/public/common/manifest/manifest_mojom_traits.h
[rename] https://crrev.com/c07726e17cf5280456e8e118a7775bc60c2f2e6d/third_party/blink/public/common/manifest/web_display_mode.h
[rename] https://crrev.com/c07726e17cf5280456e8e118a7775bc60c2f2e6d/third_party/blink/public/common/manifest/web_display_mode_mojom_traits.h
[modify] https://crrev.com/c07726e17cf5280456e8e118a7775bc60c2f2e6d/third_party/blink/public/mojom/BUILD.gn
[rename] https://crrev.com/c07726e17cf5280456e8e118a7775bc60c2f2e6d/third_party/blink/public/mojom/manifest/OWNERS
[rename] https://crrev.com/c07726e17cf5280456e8e118a7775bc60c2f2e6d/third_party/blink/public/mojom/manifest/display_mode.mojom
[rename] https://crrev.com/c07726e17cf5280456e8e118a7775bc60c2f2e6d/third_party/blink/public/mojom/manifest/manifest.mojom
[rename] https://crrev.com/c07726e17cf5280456e8e118a7775bc60c2f2e6d/third_party/blink/public/mojom/manifest/manifest_manager.mojom
[delete] https://crrev.com/e4774fc79110aa35c59cb9ba3de3863b8e40d2a8/third_party/blink/public/platform/display_mode.typemap
[modify] https://crrev.com/c07726e17cf5280456e8e118a7775bc60c2f2e6d/third_party/blink/public/platform/modules/payments/payment_app.mojom
[modify] https://crrev.com/c07726e17cf5280456e8e118a7775bc60c2f2e6d/third_party/blink/public/public_typemaps.gni
[modify] https://crrev.com/c07726e17cf5280456e8e118a7775bc60c2f2e6d/third_party/blink/public/web/web_view.h
[modify] https://crrev.com/c07726e17cf5280456e8e118a7775bc60c2f2e6d/third_party/blink/renderer/core/css/media_query_evaluator.cc
[modify] https://crrev.com/c07726e17cf5280456e8e118a7775bc60c2f2e6d/third_party/blink/renderer/core/css/media_values.h
[modify] https://crrev.com/c07726e17cf5280456e8e118a7775bc60c2f2e6d/third_party/blink/renderer/core/exported/web_view_impl.h
[modify] https://crrev.com/c07726e17cf5280456e8e118a7775bc60c2f2e6d/third_party/blink/renderer/core/exported/web_view_test.cc
[modify] https://crrev.com/c07726e17cf5280456e8e118a7775bc60c2f2e6d/third_party/blink/renderer/core/frame/local_frame_view.h
[modify] https://crrev.com/c07726e17cf5280456e8e118a7775bc60c2f2e6d/third_party/blink/renderer/core/frame/settings.h
[modify] https://crrev.com/c07726e17cf5280456e8e118a7775bc60c2f2e6d/third_party/blink/renderer/core/testing/internal_settings.h
[modify] https://crrev.com/c07726e17cf5280456e8e118a7775bc60c2f2e6d/third_party/blink/renderer/modules/payments/payment_instruments.cc
[modify] https://crrev.com/c07726e17cf5280456e8e118a7775bc60c2f2e6d/third_party/blink/renderer/platform/mojo/blink_typemaps.gni
Project Member

Comment 26 by bugdroid1@chromium.org, May 1 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/40b34a579b660733420e1e6e87fe0972f3d04903

commit 40b34a579b660733420e1e6e87fe0972f3d04903
Author: Alan Cutter <alancutter@chromium.org>
Date: Tue May 01 04:29:29 2018

Revert "Move manifest.mojom and content::Manifest to blink"

This reverts commit c07726e17cf5280456e8e118a7775bc60c2f2e6d.

Reason for revert:
Sorry to do this. D:
Fails to link on 32-bit Windows.
https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Win%20Builder%20(dbg)/130895
FAILED: blink_common_unittests.exe blink_common_unittests.exe.pdb 
E:/b/depot_tools/win_tools-2_7_6_bin/python/bin/python.exe ../../build/toolchain/win/tool_wrapper.py link-wrapper environment.x86 False link.exe /nologo /OUT:./blink_common_unittests.exe /PDB:./blink_common_unittests.exe.pdb @./blink_common_unittests.exe.rsp
manifest.mojom.obj : error LNK2019: unresolved external symbol "public: static unsigned int const blink::Manifest::kMaxIPCStringLength" (?kMaxIPCStringLength@Manifest@blink@@2IB) referenced in function "class base::BasicStringPiece<class std::basic_string<wchar_t,struct std::char_traits<wchar_t>,class std::allocator<wchar_t> > > __cdecl mojo::internal::TruncateString16(class std::basic_string<wchar_t,struct std::char_traits<wchar_t>,class std::allocator<wchar_t> > const &)" (?TruncateString16@internal@mojo@@YA?AV?$BasicStringPiece@V?$basic_string@_WU?$char_traits@_W@std@@V?$allocator@_W@2@@std@@@base@@ABV?$basic_string@_WU?$char_traits@_W@std@@V?$allocator@_W@2@@std@@@Z)
manifest_manager.mojom.obj : error LNK2001: unresolved external symbol "public: static unsigned int const blink::Manifest::kMaxIPCStringLength" (?kMaxIPCStringLength@Manifest@blink@@2IB)
manifest_mojom_traits.obj : error LNK2001: unresolved external symbol "public: static unsigned int const blink::Manifest::kMaxIPCStringLength" (?kMaxIPCStringLength@Manifest@blink@@2IB)
manifest_mojom_traits.obj : error LNK2019: unresolved external symbol "public: static __int64 const blink::Manifest::kInvalidOrMissingColor" (?kInvalidOrMissingColor@Manifest@blink@@2_JB) referenced in function "bool __cdecl mojo::`anonymous namespace'::ValidateColor(__int64)" (?ValidateColor@?A@mojo@@YA_N_J@Z)
./blink_common_unittests.exe : fatal error LNK1120: 2 unresolved externals

Original change's description:
> Move manifest.mojom and content::Manifest to blink
> 
> ... as a part of Onion Soup project.
> 
> This also required moving WebDisplayMode from public/platform
> to public/common since it's referenced both in manifest itself
> and, more generally, browser code.
> 
> mojom::blink::Manifest is typemapped to blink::Manifest, which uses
> stl types and should be used by blink's embedder, not blink
> implementation.
> 
> Bug: 704441
> Change-Id: I94d07bb028278f17d215f64c14552793d5f916ae
> Reviewed-on: https://chromium-review.googlesource.com/1006188
> Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Reviewed-by: Reilly Grant <reillyg@chromium.org>
> Reviewed-by: Kentaro Hara <haraken@chromium.org>
> Reviewed-by: Mathieu Perreault <mathp@chromium.org>
> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
> Reviewed-by: Mikel Astiz <mastiz@chromium.org>
> Reviewed-by: Scott Violet <sky@chromium.org>
> Reviewed-by: David Trainor <dtrainor@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#554953}

TBR=dgozman@chromium.org,sky@chromium.org,dcheng@chromium.org,mathp@chromium.org,dtrainor@chromium.org,reillyg@chromium.org,haraken@chromium.org,mlamouri@chromium.org,mastiz@chromium.org

Change-Id: Ia896e0fe0f368303f332a72ef866433cf649dbce
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 704441
Reviewed-on: https://chromium-review.googlesource.com/1036665
Reviewed-by: Alan Cutter <alancutter@chromium.org>
Commit-Queue: Alan Cutter <alancutter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554989}
[modify] https://crrev.com/40b34a579b660733420e1e6e87fe0972f3d04903/chrome/android/java/src/org/chromium/chrome/browser/ShortcutHelper.java
[modify] https://crrev.com/40b34a579b660733420e1e6e87fe0972f3d04903/chrome/browser/DEPS
[modify] https://crrev.com/40b34a579b660733420e1e6e87fe0972f3d04903/chrome/browser/android/metrics/launch_metrics.cc
[modify] https://crrev.com/40b34a579b660733420e1e6e87fe0972f3d04903/chrome/browser/android/shortcut_helper.cc
[modify] https://crrev.com/40b34a579b660733420e1e6e87fe0972f3d04903/chrome/browser/android/shortcut_helper.h
[modify] https://crrev.com/40b34a579b660733420e1e6e87fe0972f3d04903/chrome/browser/android/shortcut_info.cc
[modify] https://crrev.com/40b34a579b660733420e1e6e87fe0972f3d04903/chrome/browser/android/shortcut_info.h
[modify] https://crrev.com/40b34a579b660733420e1e6e87fe0972f3d04903/chrome/browser/android/shortcut_info_unittest.cc
[modify] https://crrev.com/40b34a579b660733420e1e6e87fe0972f3d04903/chrome/browser/android/webapk/webapk_info.h
[modify] https://crrev.com/40b34a579b660733420e1e6e87fe0972f3d04903/chrome/browser/android/webapk/webapk_installer.cc
[modify] https://crrev.com/40b34a579b660733420e1e6e87fe0972f3d04903/chrome/browser/android/webapk/webapk_update_data_fetcher.cc
[modify] https://crrev.com/40b34a579b660733420e1e6e87fe0972f3d04903/chrome/browser/android/webapk/webapk_update_data_fetcher.h
[modify] https://crrev.com/40b34a579b660733420e1e6e87fe0972f3d04903/chrome/browser/android/webapk/webapk_web_manifest_checker.cc
[modify] https://crrev.com/40b34a579b660733420e1e6e87fe0972f3d04903/chrome/browser/android/webapk/webapk_web_manifest_checker.h
[modify] https://crrev.com/40b34a579b660733420e1e6e87fe0972f3d04903/chrome/browser/android/webapk/webapk_web_manifest_checker_unittest.cc
[modify] https://crrev.com/40b34a579b660733420e1e6e87fe0972f3d04903/chrome/browser/android/webapps/add_to_homescreen_data_fetcher.cc
[modify] https://crrev.com/40b34a579b660733420e1e6e87fe0972f3d04903/chrome/browser/android/webapps/add_to_homescreen_data_fetcher_unittest.cc
[modify] https://crrev.com/40b34a579b660733420e1e6e87fe0972f3d04903/chrome/browser/banners/app_banner_infobar_delegate_desktop.cc
[modify] https://crrev.com/40b34a579b660733420e1e6e87fe0972f3d04903/chrome/browser/banners/app_banner_infobar_delegate_desktop.h
[modify] https://crrev.com/40b34a579b660733420e1e6e87fe0972f3d04903/chrome/browser/banners/app_banner_manager.cc
[modify] https://crrev.com/40b34a579b660733420e1e6e87fe0972f3d04903/chrome/browser/banners/app_banner_manager.h
[modify] https://crrev.com/40b34a579b660733420e1e6e87fe0972f3d04903/chrome/browser/banners/app_banner_metrics.h
[modify] https://crrev.com/40b34a579b660733420e1e6e87fe0972f3d04903/chrome/browser/chrome_service_worker_browsertest.cc
[modify] https://crrev.com/40b34a579b660733420e1e6e87fe0972f3d04903/chrome/browser/extensions/bookmark_app_helper.cc
[modify] https://crrev.com/40b34a579b660733420e1e6e87fe0972f3d04903/chrome/browser/extensions/bookmark_app_helper.h
[modify] https://crrev.com/40b34a579b660733420e1e6e87fe0972f3d04903/chrome/browser/extensions/bookmark_app_helper_unittest.cc
[modify] https://crrev.com/40b34a579b660733420e1e6e87fe0972f3d04903/chrome/browser/infobars/infobars_browsertest.cc
[modify] https://crrev.com/40b34a579b660733420e1e6e87fe0972f3d04903/chrome/browser/installable/installable_data.cc
[modify] https://crrev.com/40b34a579b660733420e1e6e87fe0972f3d04903/chrome/browser/installable/installable_data.h
[modify] https://crrev.com/40b34a579b660733420e1e6e87fe0972f3d04903/chrome/browser/installable/installable_manager.cc
[modify] https://crrev.com/40b34a579b660733420e1e6e87fe0972f3d04903/chrome/browser/installable/installable_manager.h
[modify] https://crrev.com/40b34a579b660733420e1e6e87fe0972f3d04903/chrome/browser/installable/installable_manager_browsertest.cc
[modify] https://crrev.com/40b34a579b660733420e1e6e87fe0972f3d04903/chrome/browser/installable/installable_manager_unittest.cc
[modify] https://crrev.com/40b34a579b660733420e1e6e87fe0972f3d04903/chrome/browser/installable/installable_task_queue_unittest.cc
[modify] https://crrev.com/40b34a579b660733420e1e6e87fe0972f3d04903/chrome/browser/ui/webui/webapks_handler.cc
[modify] https://crrev.com/40b34a579b660733420e1e6e87fe0972f3d04903/chrome/browser/webshare/share_target_pref_helper.cc
[modify] https://crrev.com/40b34a579b660733420e1e6e87fe0972f3d04903/chrome/browser/webshare/share_target_pref_helper.h
[modify] https://crrev.com/40b34a579b660733420e1e6e87fe0972f3d04903/chrome/browser/webshare/share_target_pref_helper_unittest.cc
[modify] https://crrev.com/40b34a579b660733420e1e6e87fe0972f3d04903/components/favicon/content/DEPS
[modify] https://crrev.com/40b34a579b660733420e1e6e87fe0972f3d04903/components/favicon/content/content_favicon_driver.cc
[modify] https://crrev.com/40b34a579b660733420e1e6e87fe0972f3d04903/components/payments/content/DEPS
[modify] https://crrev.com/40b34a579b660733420e1e6e87fe0972f3d04903/components/payments/content/installable_payment_app_crawler.cc
[modify] https://crrev.com/40b34a579b660733420e1e6e87fe0972f3d04903/content/browser/DEPS
[modify] https://crrev.com/40b34a579b660733420e1e6e87fe0972f3d04903/content/browser/devtools/protocol/page_handler.h
[modify] https://crrev.com/40b34a579b660733420e1e6e87fe0972f3d04903/content/browser/manifest/manifest_browsertest.cc
[modify] https://crrev.com/40b34a579b660733420e1e6e87fe0972f3d04903/content/browser/manifest/manifest_icon_selector.cc
[modify] https://crrev.com/40b34a579b660733420e1e6e87fe0972f3d04903/content/browser/manifest/manifest_icon_selector_unittest.cc
[modify] https://crrev.com/40b34a579b660733420e1e6e87fe0972f3d04903/content/browser/manifest/manifest_manager_host.cc
[modify] https://crrev.com/40b34a579b660733420e1e6e87fe0972f3d04903/content/browser/manifest/manifest_manager_host.h
[modify] https://crrev.com/40b34a579b660733420e1e6e87fe0972f3d04903/content/browser/net/accept_header_browsertest.cc
[modify] https://crrev.com/40b34a579b660733420e1e6e87fe0972f3d04903/content/browser/payments/payment_app_database.cc
[modify] https://crrev.com/40b34a579b660733420e1e6e87fe0972f3d04903/content/browser/payments/payment_app_info_fetcher.cc
[modify] https://crrev.com/40b34a579b660733420e1e6e87fe0972f3d04903/content/browser/payments/payment_app_info_fetcher.h
[modify] https://crrev.com/40b34a579b660733420e1e6e87fe0972f3d04903/content/browser/payments/payment_instrument_icon_fetcher.cc
[modify] https://crrev.com/40b34a579b660733420e1e6e87fe0972f3d04903/content/browser/payments/payment_instrument_icon_fetcher.h
[modify] https://crrev.com/40b34a579b660733420e1e6e87fe0972f3d04903/content/browser/renderer_host/render_widget_host_delegate.h
[modify] https://crrev.com/40b34a579b660733420e1e6e87fe0972f3d04903/content/browser/renderer_host/render_widget_host_impl.h
[modify] https://crrev.com/40b34a579b660733420e1e6e87fe0972f3d04903/content/common/DEPS
[modify] https://crrev.com/40b34a579b660733420e1e6e87fe0972f3d04903/content/common/frame_visual_properties.h
[modify] https://crrev.com/40b34a579b660733420e1e6e87fe0972f3d04903/content/common/view_messages.h
[modify] https://crrev.com/40b34a579b660733420e1e6e87fe0972f3d04903/content/common/visual_properties.h
[modify] https://crrev.com/40b34a579b660733420e1e6e87fe0972f3d04903/content/public/browser/manifest_icon_selector.h
[modify] https://crrev.com/40b34a579b660733420e1e6e87fe0972f3d04903/content/public/browser/web_contents.h
[modify] https://crrev.com/40b34a579b660733420e1e6e87fe0972f3d04903/content/public/browser/web_contents_delegate.h
[modify] https://crrev.com/40b34a579b660733420e1e6e87fe0972f3d04903/content/public/common/BUILD.gn
[rename] https://crrev.com/40b34a579b660733420e1e6e87fe0972f3d04903/content/public/common/manifest.cc
[rename] https://crrev.com/40b34a579b660733420e1e6e87fe0972f3d04903/content/public/common/manifest.h
[add] https://crrev.com/40b34a579b660733420e1e6e87fe0972f3d04903/content/public/common/manifest.typemap
[rename] https://crrev.com/40b34a579b660733420e1e6e87fe0972f3d04903/content/public/common/manifest_struct_traits.cc
[add] https://crrev.com/40b34a579b660733420e1e6e87fe0972f3d04903/content/public/common/manifest_struct_traits.h
[modify] https://crrev.com/40b34a579b660733420e1e6e87fe0972f3d04903/content/public/common/manifest_util.h
[modify] https://crrev.com/40b34a579b660733420e1e6e87fe0972f3d04903/content/public/common/typemaps.gni
[modify] https://crrev.com/40b34a579b660733420e1e6e87fe0972f3d04903/content/public/test/layouttest_support.h
[modify] https://crrev.com/40b34a579b660733420e1e6e87fe0972f3d04903/content/renderer/installedapp/related_apps_fetcher.cc
[modify] https://crrev.com/40b34a579b660733420e1e6e87fe0972f3d04903/content/renderer/installedapp/related_apps_fetcher.h
[modify] https://crrev.com/40b34a579b660733420e1e6e87fe0972f3d04903/content/renderer/manifest/manifest_manager.cc
[modify] https://crrev.com/40b34a579b660733420e1e6e87fe0972f3d04903/content/renderer/manifest/manifest_manager.h
[modify] https://crrev.com/40b34a579b660733420e1e6e87fe0972f3d04903/content/renderer/manifest/manifest_parser.cc
[modify] https://crrev.com/40b34a579b660733420e1e6e87fe0972f3d04903/content/renderer/manifest/manifest_parser.h
[modify] https://crrev.com/40b34a579b660733420e1e6e87fe0972f3d04903/content/renderer/manifest/manifest_parser_unittest.cc
[modify] https://crrev.com/40b34a579b660733420e1e6e87fe0972f3d04903/content/renderer/manifest/manifest_uma_util.cc
[modify] https://crrev.com/40b34a579b660733420e1e6e87fe0972f3d04903/content/renderer/manifest/manifest_uma_util.h
[modify] https://crrev.com/40b34a579b660733420e1e6e87fe0972f3d04903/content/renderer/push_messaging/push_messaging_client.cc
[modify] https://crrev.com/40b34a579b660733420e1e6e87fe0972f3d04903/content/renderer/push_messaging/push_messaging_client.h
[modify] https://crrev.com/40b34a579b660733420e1e6e87fe0972f3d04903/content/renderer/render_frame_impl.h
[modify] https://crrev.com/40b34a579b660733420e1e6e87fe0972f3d04903/content/renderer/render_widget.h
[modify] https://crrev.com/40b34a579b660733420e1e6e87fe0972f3d04903/content/shell/renderer/layout_test/blink_test_runner.cc
[modify] https://crrev.com/40b34a579b660733420e1e6e87fe0972f3d04903/content/shell/renderer/layout_test/blink_test_runner.h
[modify] https://crrev.com/40b34a579b660733420e1e6e87fe0972f3d04903/content/shell/test_runner/test_runner_for_specific_view.cc
[modify] https://crrev.com/40b34a579b660733420e1e6e87fe0972f3d04903/content/shell/test_runner/test_runner_for_specific_view.h
[modify] https://crrev.com/40b34a579b660733420e1e6e87fe0972f3d04903/content/shell/test_runner/web_test_delegate.h
[modify] https://crrev.com/40b34a579b660733420e1e6e87fe0972f3d04903/services/device/public/mojom/BUILD.gn
[modify] https://crrev.com/40b34a579b660733420e1e6e87fe0972f3d04903/third_party/blink/common/BUILD.gn
[modify] https://crrev.com/40b34a579b660733420e1e6e87fe0972f3d04903/third_party/blink/common/DEPS
[delete] https://crrev.com/da76f5004aae54562c7f6996fdd1e6274a5a7aab/third_party/blink/common/manifest/OWNERS
[modify] https://crrev.com/40b34a579b660733420e1e6e87fe0972f3d04903/third_party/blink/public/BUILD.gn
[modify] https://crrev.com/40b34a579b660733420e1e6e87fe0972f3d04903/third_party/blink/public/common/BUILD.gn
[modify] https://crrev.com/40b34a579b660733420e1e6e87fe0972f3d04903/third_party/blink/public/common/DEPS
[delete] https://crrev.com/da76f5004aae54562c7f6996fdd1e6274a5a7aab/third_party/blink/public/common/manifest/OWNERS
[delete] https://crrev.com/da76f5004aae54562c7f6996fdd1e6274a5a7aab/third_party/blink/public/common/manifest/display_mode.typemap
[delete] https://crrev.com/da76f5004aae54562c7f6996fdd1e6274a5a7aab/third_party/blink/public/common/manifest/manifest.typemap
[delete] https://crrev.com/da76f5004aae54562c7f6996fdd1e6274a5a7aab/third_party/blink/public/common/manifest/manifest_mojom_traits.h
[modify] https://crrev.com/40b34a579b660733420e1e6e87fe0972f3d04903/third_party/blink/public/mojom/BUILD.gn
[rename] https://crrev.com/40b34a579b660733420e1e6e87fe0972f3d04903/third_party/blink/public/platform/display_mode.mojom
[add] https://crrev.com/40b34a579b660733420e1e6e87fe0972f3d04903/third_party/blink/public/platform/display_mode.typemap
[rename] https://crrev.com/40b34a579b660733420e1e6e87fe0972f3d04903/third_party/blink/public/platform/modules/manifest/OWNERS
[rename] https://crrev.com/40b34a579b660733420e1e6e87fe0972f3d04903/third_party/blink/public/platform/modules/manifest/manifest.mojom
[rename] https://crrev.com/40b34a579b660733420e1e6e87fe0972f3d04903/third_party/blink/public/platform/modules/manifest/manifest_manager.mojom
[modify] https://crrev.com/40b34a579b660733420e1e6e87fe0972f3d04903/third_party/blink/public/platform/modules/payments/payment_app.mojom
[rename] https://crrev.com/40b34a579b660733420e1e6e87fe0972f3d04903/third_party/blink/public/platform/web_display_mode.h
[rename] https://crrev.com/40b34a579b660733420e1e6e87fe0972f3d04903/third_party/blink/public/platform/web_display_mode_struct_traits.h
[modify] https://crrev.com/40b34a579b660733420e1e6e87fe0972f3d04903/third_party/blink/public/public_typemaps.gni
[modify] https://crrev.com/40b34a579b660733420e1e6e87fe0972f3d04903/third_party/blink/public/web/web_view.h
[modify] https://crrev.com/40b34a579b660733420e1e6e87fe0972f3d04903/third_party/blink/renderer/core/css/media_query_evaluator.cc
[modify] https://crrev.com/40b34a579b660733420e1e6e87fe0972f3d04903/third_party/blink/renderer/core/css/media_values.h
[modify] https://crrev.com/40b34a579b660733420e1e6e87fe0972f3d04903/third_party/blink/renderer/core/exported/web_view_impl.h
[modify] https://crrev.com/40b34a579b660733420e1e6e87fe0972f3d04903/third_party/blink/renderer/core/exported/web_view_test.cc
[modify] https://crrev.com/40b34a579b660733420e1e6e87fe0972f3d04903/third_party/blink/renderer/core/frame/local_frame_view.h
[modify] https://crrev.com/40b34a579b660733420e1e6e87fe0972f3d04903/third_party/blink/renderer/core/frame/settings.h
[modify] https://crrev.com/40b34a579b660733420e1e6e87fe0972f3d04903/third_party/blink/renderer/core/testing/internal_settings.h
[modify] https://crrev.com/40b34a579b660733420e1e6e87fe0972f3d04903/third_party/blink/renderer/modules/payments/payment_instruments.cc
[modify] https://crrev.com/40b34a579b660733420e1e6e87fe0972f3d04903/third_party/blink/renderer/platform/mojo/blink_typemaps.gni
Project Member

Comment 27 by bugdroid1@chromium.org, May 2 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5419f89266c7d65ab5d5440919fb217b9be5171a

commit 5419f89266c7d65ab5d5440919fb217b9be5171a
Author: Dmitry Gozman <dgozman@chromium.org>
Date: Wed May 02 18:38:10 2018

Reland "Move manifest.mojom and content::Manifest to blink"

This is a reland of c07726e17cf5280456e8e118a7775bc60c2f2e6d

Original change's description:
> Move manifest.mojom and content::Manifest to blink
>
> ... as a part of Onion Soup project.
>
> This also required moving WebDisplayMode from public/platform
> to public/common since it's referenced both in manifest itself
> and, more generally, browser code.
>
> mojom::blink::Manifest is typemapped to blink::Manifest, which uses
> stl types and should be used by blink's embedder, not blink
> implementation.
>
> Bug: 704441
> Change-Id: I94d07bb028278f17d215f64c14552793d5f916ae
> Reviewed-on: https://chromium-review.googlesource.com/1006188
> Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Reviewed-by: Reilly Grant <reillyg@chromium.org>
> Reviewed-by: Kentaro Hara <haraken@chromium.org>
> Reviewed-by: Mathieu Perreault <mathp@chromium.org>
> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
> Reviewed-by: Mikel Astiz <mastiz@chromium.org>
> Reviewed-by: Scott Violet <sky@chromium.org>
> Reviewed-by: David Trainor <dtrainor@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#554953}

TBR=dgozman

Bug: 704441
No-Presubmit: true
Change-Id: Ie4f16da0aa695e6eecef72574f263cbbb4b3254f
Reviewed-on: https://chromium-review.googlesource.com/1036507
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555485}
[modify] https://crrev.com/5419f89266c7d65ab5d5440919fb217b9be5171a/chrome/android/java/src/org/chromium/chrome/browser/ShortcutHelper.java
[modify] https://crrev.com/5419f89266c7d65ab5d5440919fb217b9be5171a/chrome/browser/DEPS
[modify] https://crrev.com/5419f89266c7d65ab5d5440919fb217b9be5171a/chrome/browser/android/metrics/launch_metrics.cc
[modify] https://crrev.com/5419f89266c7d65ab5d5440919fb217b9be5171a/chrome/browser/android/shortcut_helper.cc
[modify] https://crrev.com/5419f89266c7d65ab5d5440919fb217b9be5171a/chrome/browser/android/shortcut_helper.h
[modify] https://crrev.com/5419f89266c7d65ab5d5440919fb217b9be5171a/chrome/browser/android/shortcut_info.cc
[modify] https://crrev.com/5419f89266c7d65ab5d5440919fb217b9be5171a/chrome/browser/android/shortcut_info.h
[modify] https://crrev.com/5419f89266c7d65ab5d5440919fb217b9be5171a/chrome/browser/android/shortcut_info_unittest.cc
[modify] https://crrev.com/5419f89266c7d65ab5d5440919fb217b9be5171a/chrome/browser/android/webapk/webapk_info.h
[modify] https://crrev.com/5419f89266c7d65ab5d5440919fb217b9be5171a/chrome/browser/android/webapk/webapk_installer.cc
[modify] https://crrev.com/5419f89266c7d65ab5d5440919fb217b9be5171a/chrome/browser/android/webapk/webapk_update_data_fetcher.cc
[modify] https://crrev.com/5419f89266c7d65ab5d5440919fb217b9be5171a/chrome/browser/android/webapk/webapk_update_data_fetcher.h
[modify] https://crrev.com/5419f89266c7d65ab5d5440919fb217b9be5171a/chrome/browser/android/webapk/webapk_web_manifest_checker.cc
[modify] https://crrev.com/5419f89266c7d65ab5d5440919fb217b9be5171a/chrome/browser/android/webapk/webapk_web_manifest_checker.h
[modify] https://crrev.com/5419f89266c7d65ab5d5440919fb217b9be5171a/chrome/browser/android/webapk/webapk_web_manifest_checker_unittest.cc
[modify] https://crrev.com/5419f89266c7d65ab5d5440919fb217b9be5171a/chrome/browser/android/webapps/add_to_homescreen_data_fetcher.cc
[modify] https://crrev.com/5419f89266c7d65ab5d5440919fb217b9be5171a/chrome/browser/android/webapps/add_to_homescreen_data_fetcher_unittest.cc
[modify] https://crrev.com/5419f89266c7d65ab5d5440919fb217b9be5171a/chrome/browser/banners/app_banner_infobar_delegate_desktop.cc
[modify] https://crrev.com/5419f89266c7d65ab5d5440919fb217b9be5171a/chrome/browser/banners/app_banner_infobar_delegate_desktop.h
[modify] https://crrev.com/5419f89266c7d65ab5d5440919fb217b9be5171a/chrome/browser/banners/app_banner_manager.cc
[modify] https://crrev.com/5419f89266c7d65ab5d5440919fb217b9be5171a/chrome/browser/banners/app_banner_manager.h
[modify] https://crrev.com/5419f89266c7d65ab5d5440919fb217b9be5171a/chrome/browser/banners/app_banner_metrics.h
[modify] https://crrev.com/5419f89266c7d65ab5d5440919fb217b9be5171a/chrome/browser/chrome_service_worker_browsertest.cc
[modify] https://crrev.com/5419f89266c7d65ab5d5440919fb217b9be5171a/chrome/browser/extensions/bookmark_app_helper.cc
[modify] https://crrev.com/5419f89266c7d65ab5d5440919fb217b9be5171a/chrome/browser/extensions/bookmark_app_helper.h
[modify] https://crrev.com/5419f89266c7d65ab5d5440919fb217b9be5171a/chrome/browser/extensions/bookmark_app_helper_unittest.cc
[modify] https://crrev.com/5419f89266c7d65ab5d5440919fb217b9be5171a/chrome/browser/infobars/infobars_browsertest.cc
[modify] https://crrev.com/5419f89266c7d65ab5d5440919fb217b9be5171a/chrome/browser/installable/installable_data.cc
[modify] https://crrev.com/5419f89266c7d65ab5d5440919fb217b9be5171a/chrome/browser/installable/installable_data.h
[modify] https://crrev.com/5419f89266c7d65ab5d5440919fb217b9be5171a/chrome/browser/installable/installable_manager.cc
[modify] https://crrev.com/5419f89266c7d65ab5d5440919fb217b9be5171a/chrome/browser/installable/installable_manager.h
[modify] https://crrev.com/5419f89266c7d65ab5d5440919fb217b9be5171a/chrome/browser/installable/installable_manager_browsertest.cc
[modify] https://crrev.com/5419f89266c7d65ab5d5440919fb217b9be5171a/chrome/browser/installable/installable_manager_unittest.cc
[modify] https://crrev.com/5419f89266c7d65ab5d5440919fb217b9be5171a/chrome/browser/installable/installable_task_queue_unittest.cc
[modify] https://crrev.com/5419f89266c7d65ab5d5440919fb217b9be5171a/chrome/browser/ui/webui/webapks_handler.cc
[modify] https://crrev.com/5419f89266c7d65ab5d5440919fb217b9be5171a/chrome/browser/webshare/share_target_pref_helper.cc
[modify] https://crrev.com/5419f89266c7d65ab5d5440919fb217b9be5171a/chrome/browser/webshare/share_target_pref_helper.h
[modify] https://crrev.com/5419f89266c7d65ab5d5440919fb217b9be5171a/chrome/browser/webshare/share_target_pref_helper_unittest.cc
[modify] https://crrev.com/5419f89266c7d65ab5d5440919fb217b9be5171a/components/favicon/content/DEPS
[modify] https://crrev.com/5419f89266c7d65ab5d5440919fb217b9be5171a/components/favicon/content/content_favicon_driver.cc
[modify] https://crrev.com/5419f89266c7d65ab5d5440919fb217b9be5171a/components/payments/content/DEPS
[modify] https://crrev.com/5419f89266c7d65ab5d5440919fb217b9be5171a/components/payments/content/installable_payment_app_crawler.cc
[modify] https://crrev.com/5419f89266c7d65ab5d5440919fb217b9be5171a/content/browser/DEPS
[modify] https://crrev.com/5419f89266c7d65ab5d5440919fb217b9be5171a/content/browser/devtools/protocol/page_handler.h
[modify] https://crrev.com/5419f89266c7d65ab5d5440919fb217b9be5171a/content/browser/manifest/manifest_browsertest.cc
[modify] https://crrev.com/5419f89266c7d65ab5d5440919fb217b9be5171a/content/browser/manifest/manifest_icon_selector.cc
[modify] https://crrev.com/5419f89266c7d65ab5d5440919fb217b9be5171a/content/browser/manifest/manifest_icon_selector_unittest.cc
[modify] https://crrev.com/5419f89266c7d65ab5d5440919fb217b9be5171a/content/browser/manifest/manifest_manager_host.cc
[modify] https://crrev.com/5419f89266c7d65ab5d5440919fb217b9be5171a/content/browser/manifest/manifest_manager_host.h
[modify] https://crrev.com/5419f89266c7d65ab5d5440919fb217b9be5171a/content/browser/net/accept_header_browsertest.cc
[modify] https://crrev.com/5419f89266c7d65ab5d5440919fb217b9be5171a/content/browser/payments/payment_app_database.cc
[modify] https://crrev.com/5419f89266c7d65ab5d5440919fb217b9be5171a/content/browser/payments/payment_app_info_fetcher.cc
[modify] https://crrev.com/5419f89266c7d65ab5d5440919fb217b9be5171a/content/browser/payments/payment_app_info_fetcher.h
[modify] https://crrev.com/5419f89266c7d65ab5d5440919fb217b9be5171a/content/browser/payments/payment_instrument_icon_fetcher.cc
[modify] https://crrev.com/5419f89266c7d65ab5d5440919fb217b9be5171a/content/browser/payments/payment_instrument_icon_fetcher.h
[modify] https://crrev.com/5419f89266c7d65ab5d5440919fb217b9be5171a/content/browser/renderer_host/render_widget_host_delegate.h
[modify] https://crrev.com/5419f89266c7d65ab5d5440919fb217b9be5171a/content/browser/renderer_host/render_widget_host_impl.h
[modify] https://crrev.com/5419f89266c7d65ab5d5440919fb217b9be5171a/content/common/DEPS
[modify] https://crrev.com/5419f89266c7d65ab5d5440919fb217b9be5171a/content/common/frame_visual_properties.h
[modify] https://crrev.com/5419f89266c7d65ab5d5440919fb217b9be5171a/content/common/view_messages.h
[modify] https://crrev.com/5419f89266c7d65ab5d5440919fb217b9be5171a/content/common/visual_properties.h
[modify] https://crrev.com/5419f89266c7d65ab5d5440919fb217b9be5171a/content/public/browser/manifest_icon_selector.h
[modify] https://crrev.com/5419f89266c7d65ab5d5440919fb217b9be5171a/content/public/browser/web_contents.h
[modify] https://crrev.com/5419f89266c7d65ab5d5440919fb217b9be5171a/content/public/browser/web_contents_delegate.h
[modify] https://crrev.com/5419f89266c7d65ab5d5440919fb217b9be5171a/content/public/common/BUILD.gn
[delete] https://crrev.com/9af650571273676119bde851aab4e8d7d73ece49/content/public/common/manifest.typemap
[delete] https://crrev.com/9af650571273676119bde851aab4e8d7d73ece49/content/public/common/manifest_struct_traits.h
[modify] https://crrev.com/5419f89266c7d65ab5d5440919fb217b9be5171a/content/public/common/manifest_util.h
[modify] https://crrev.com/5419f89266c7d65ab5d5440919fb217b9be5171a/content/public/common/typemaps.gni
[modify] https://crrev.com/5419f89266c7d65ab5d5440919fb217b9be5171a/content/public/test/layouttest_support.h
[modify] https://crrev.com/5419f89266c7d65ab5d5440919fb217b9be5171a/content/renderer/installedapp/related_apps_fetcher.cc
[modify] https://crrev.com/5419f89266c7d65ab5d5440919fb217b9be5171a/content/renderer/installedapp/related_apps_fetcher.h
[modify] https://crrev.com/5419f89266c7d65ab5d5440919fb217b9be5171a/content/renderer/manifest/manifest_manager.cc
[modify] https://crrev.com/5419f89266c7d65ab5d5440919fb217b9be5171a/content/renderer/manifest/manifest_manager.h
[modify] https://crrev.com/5419f89266c7d65ab5d5440919fb217b9be5171a/content/renderer/manifest/manifest_parser.cc
[modify] https://crrev.com/5419f89266c7d65ab5d5440919fb217b9be5171a/content/renderer/manifest/manifest_parser.h
[modify] https://crrev.com/5419f89266c7d65ab5d5440919fb217b9be5171a/content/renderer/manifest/manifest_parser_unittest.cc
[modify] https://crrev.com/5419f89266c7d65ab5d5440919fb217b9be5171a/content/renderer/manifest/manifest_uma_util.cc
[modify] https://crrev.com/5419f89266c7d65ab5d5440919fb217b9be5171a/content/renderer/manifest/manifest_uma_util.h
[modify] https://crrev.com/5419f89266c7d65ab5d5440919fb217b9be5171a/content/renderer/push_messaging/push_messaging_client.cc
[modify] https://crrev.com/5419f89266c7d65ab5d5440919fb217b9be5171a/content/renderer/push_messaging/push_messaging_client.h
[modify] https://crrev.com/5419f89266c7d65ab5d5440919fb217b9be5171a/content/renderer/render_frame_impl.h
[modify] https://crrev.com/5419f89266c7d65ab5d5440919fb217b9be5171a/content/renderer/render_widget.h
[modify] https://crrev.com/5419f89266c7d65ab5d5440919fb217b9be5171a/content/shell/renderer/layout_test/blink_test_runner.cc
[modify] https://crrev.com/5419f89266c7d65ab5d5440919fb217b9be5171a/content/shell/renderer/layout_test/blink_test_runner.h
[modify] https://crrev.com/5419f89266c7d65ab5d5440919fb217b9be5171a/content/shell/test_runner/test_runner_for_specific_view.cc
[modify] https://crrev.com/5419f89266c7d65ab5d5440919fb217b9be5171a/content/shell/test_runner/test_runner_for_specific_view.h
[modify] https://crrev.com/5419f89266c7d65ab5d5440919fb217b9be5171a/content/shell/test_runner/web_test_delegate.h
[modify] https://crrev.com/5419f89266c7d65ab5d5440919fb217b9be5171a/services/device/public/mojom/BUILD.gn
[modify] https://crrev.com/5419f89266c7d65ab5d5440919fb217b9be5171a/third_party/blink/common/BUILD.gn
[modify] https://crrev.com/5419f89266c7d65ab5d5440919fb217b9be5171a/third_party/blink/common/DEPS
[add] https://crrev.com/5419f89266c7d65ab5d5440919fb217b9be5171a/third_party/blink/common/manifest/OWNERS
[rename] https://crrev.com/5419f89266c7d65ab5d5440919fb217b9be5171a/third_party/blink/common/manifest/manifest.cc
[rename] https://crrev.com/5419f89266c7d65ab5d5440919fb217b9be5171a/third_party/blink/common/manifest/manifest_mojom_traits.cc
[modify] https://crrev.com/5419f89266c7d65ab5d5440919fb217b9be5171a/third_party/blink/public/BUILD.gn
[modify] https://crrev.com/5419f89266c7d65ab5d5440919fb217b9be5171a/third_party/blink/public/common/BUILD.gn
[modify] https://crrev.com/5419f89266c7d65ab5d5440919fb217b9be5171a/third_party/blink/public/common/DEPS
[add] https://crrev.com/5419f89266c7d65ab5d5440919fb217b9be5171a/third_party/blink/public/common/manifest/OWNERS
[add] https://crrev.com/5419f89266c7d65ab5d5440919fb217b9be5171a/third_party/blink/public/common/manifest/display_mode.typemap
[rename] https://crrev.com/5419f89266c7d65ab5d5440919fb217b9be5171a/third_party/blink/public/common/manifest/manifest.h
[add] https://crrev.com/5419f89266c7d65ab5d5440919fb217b9be5171a/third_party/blink/public/common/manifest/manifest.typemap
[add] https://crrev.com/5419f89266c7d65ab5d5440919fb217b9be5171a/third_party/blink/public/common/manifest/manifest_mojom_traits.h
[rename] https://crrev.com/5419f89266c7d65ab5d5440919fb217b9be5171a/third_party/blink/public/common/manifest/web_display_mode.h
[rename] https://crrev.com/5419f89266c7d65ab5d5440919fb217b9be5171a/third_party/blink/public/common/manifest/web_display_mode_mojom_traits.h
[modify] https://crrev.com/5419f89266c7d65ab5d5440919fb217b9be5171a/third_party/blink/public/mojom/BUILD.gn
[rename] https://crrev.com/5419f89266c7d65ab5d5440919fb217b9be5171a/third_party/blink/public/mojom/manifest/OWNERS
[rename] https://crrev.com/5419f89266c7d65ab5d5440919fb217b9be5171a/third_party/blink/public/mojom/manifest/display_mode.mojom
[rename] https://crrev.com/5419f89266c7d65ab5d5440919fb217b9be5171a/third_party/blink/public/mojom/manifest/manifest.mojom
[rename] https://crrev.com/5419f89266c7d65ab5d5440919fb217b9be5171a/third_party/blink/public/mojom/manifest/manifest_manager.mojom
[delete] https://crrev.com/9af650571273676119bde851aab4e8d7d73ece49/third_party/blink/public/platform/display_mode.typemap
[modify] https://crrev.com/5419f89266c7d65ab5d5440919fb217b9be5171a/third_party/blink/public/platform/modules/payments/payment_app.mojom
[modify] https://crrev.com/5419f89266c7d65ab5d5440919fb217b9be5171a/third_party/blink/public/public_typemaps.gni
[modify] https://crrev.com/5419f89266c7d65ab5d5440919fb217b9be5171a/third_party/blink/public/web/web_view.h
[modify] https://crrev.com/5419f89266c7d65ab5d5440919fb217b9be5171a/third_party/blink/renderer/core/css/media_query_evaluator.cc
[modify] https://crrev.com/5419f89266c7d65ab5d5440919fb217b9be5171a/third_party/blink/renderer/core/css/media_values.h
[modify] https://crrev.com/5419f89266c7d65ab5d5440919fb217b9be5171a/third_party/blink/renderer/core/exported/web_view_impl.h
[modify] https://crrev.com/5419f89266c7d65ab5d5440919fb217b9be5171a/third_party/blink/renderer/core/exported/web_view_test.cc
[modify] https://crrev.com/5419f89266c7d65ab5d5440919fb217b9be5171a/third_party/blink/renderer/core/frame/local_frame_view.h
[modify] https://crrev.com/5419f89266c7d65ab5d5440919fb217b9be5171a/third_party/blink/renderer/core/frame/settings.h
[modify] https://crrev.com/5419f89266c7d65ab5d5440919fb217b9be5171a/third_party/blink/renderer/core/testing/internal_settings.h
[modify] https://crrev.com/5419f89266c7d65ab5d5440919fb217b9be5171a/third_party/blink/renderer/modules/payments/payment_instruments.cc
[modify] https://crrev.com/5419f89266c7d65ab5d5440919fb217b9be5171a/third_party/blink/renderer/platform/mojo/blink_typemaps.gni
Project Member

Comment 28 by bugdroid1@chromium.org, May 2 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8b0c28df834046650307e5762e65a0ce8c4baac6

commit 8b0c28df834046650307e5762e65a0ce8c4baac6
Author: Dmitry Gozman <dgozman@chromium.org>
Date: Wed May 02 20:07:44 2018

Revert "Reland "Move manifest.mojom and content::Manifest to blink""

This reverts commit 5419f89266c7d65ab5d5440919fb217b9be5171a.

Reason for revert: fails again. See https://logs.chromium.org/v/?s=chromium%2Fbb%2Fchromium.webkit%2FWebKit_Win_Builder__dbg_%2F130922%2F%2B%2Frecipes%2Fsteps%2Fcompile%2F0%2Fstdout.

Original change's description:
> Reland "Move manifest.mojom and content::Manifest to blink"
> 
> This is a reland of c07726e17cf5280456e8e118a7775bc60c2f2e6d
> 
> Original change's description:
> > Move manifest.mojom and content::Manifest to blink
> >
> > ... as a part of Onion Soup project.
> >
> > This also required moving WebDisplayMode from public/platform
> > to public/common since it's referenced both in manifest itself
> > and, more generally, browser code.
> >
> > mojom::blink::Manifest is typemapped to blink::Manifest, which uses
> > stl types and should be used by blink's embedder, not blink
> > implementation.
> >
> > Bug: 704441
> > Change-Id: I94d07bb028278f17d215f64c14552793d5f916ae
> > Reviewed-on: https://chromium-review.googlesource.com/1006188
> > Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
> > Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> > Reviewed-by: Reilly Grant <reillyg@chromium.org>
> > Reviewed-by: Kentaro Hara <haraken@chromium.org>
> > Reviewed-by: Mathieu Perreault <mathp@chromium.org>
> > Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
> > Reviewed-by: Mikel Astiz <mastiz@chromium.org>
> > Reviewed-by: Scott Violet <sky@chromium.org>
> > Reviewed-by: David Trainor <dtrainor@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#554953}
> 
> TBR=dgozman
> 
> Bug: 704441
> No-Presubmit: true
> Change-Id: Ie4f16da0aa695e6eecef72574f263cbbb4b3254f
> Reviewed-on: https://chromium-review.googlesource.com/1036507
> Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
> Reviewed-by: Jeremy Roman <jbroman@chromium.org>
> Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#555485}

TBR=dgozman@chromium.org,sky@chromium.org,dcheng@chromium.org,jbroman@chromium.org,mathp@chromium.org,dtrainor@chromium.org,reillyg@chromium.org,haraken@chromium.org,mlamouri@chromium.org,mastiz@chromium.org

Change-Id: I2b3d28d1eafb06d480701e6bc69033ea3bcca33a
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 704441
Reviewed-on: https://chromium-review.googlesource.com/1040685
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555503}
[modify] https://crrev.com/8b0c28df834046650307e5762e65a0ce8c4baac6/chrome/android/java/src/org/chromium/chrome/browser/ShortcutHelper.java
[modify] https://crrev.com/8b0c28df834046650307e5762e65a0ce8c4baac6/chrome/browser/DEPS
[modify] https://crrev.com/8b0c28df834046650307e5762e65a0ce8c4baac6/chrome/browser/android/metrics/launch_metrics.cc
[modify] https://crrev.com/8b0c28df834046650307e5762e65a0ce8c4baac6/chrome/browser/android/shortcut_helper.cc
[modify] https://crrev.com/8b0c28df834046650307e5762e65a0ce8c4baac6/chrome/browser/android/shortcut_helper.h
[modify] https://crrev.com/8b0c28df834046650307e5762e65a0ce8c4baac6/chrome/browser/android/shortcut_info.cc
[modify] https://crrev.com/8b0c28df834046650307e5762e65a0ce8c4baac6/chrome/browser/android/shortcut_info.h
[modify] https://crrev.com/8b0c28df834046650307e5762e65a0ce8c4baac6/chrome/browser/android/shortcut_info_unittest.cc
[modify] https://crrev.com/8b0c28df834046650307e5762e65a0ce8c4baac6/chrome/browser/android/webapk/webapk_info.h
[modify] https://crrev.com/8b0c28df834046650307e5762e65a0ce8c4baac6/chrome/browser/android/webapk/webapk_installer.cc
[modify] https://crrev.com/8b0c28df834046650307e5762e65a0ce8c4baac6/chrome/browser/android/webapk/webapk_update_data_fetcher.cc
[modify] https://crrev.com/8b0c28df834046650307e5762e65a0ce8c4baac6/chrome/browser/android/webapk/webapk_update_data_fetcher.h
[modify] https://crrev.com/8b0c28df834046650307e5762e65a0ce8c4baac6/chrome/browser/android/webapk/webapk_web_manifest_checker.cc
[modify] https://crrev.com/8b0c28df834046650307e5762e65a0ce8c4baac6/chrome/browser/android/webapk/webapk_web_manifest_checker.h
[modify] https://crrev.com/8b0c28df834046650307e5762e65a0ce8c4baac6/chrome/browser/android/webapk/webapk_web_manifest_checker_unittest.cc
[modify] https://crrev.com/8b0c28df834046650307e5762e65a0ce8c4baac6/chrome/browser/android/webapps/add_to_homescreen_data_fetcher.cc
[modify] https://crrev.com/8b0c28df834046650307e5762e65a0ce8c4baac6/chrome/browser/android/webapps/add_to_homescreen_data_fetcher_unittest.cc
[modify] https://crrev.com/8b0c28df834046650307e5762e65a0ce8c4baac6/chrome/browser/banners/app_banner_infobar_delegate_desktop.cc
[modify] https://crrev.com/8b0c28df834046650307e5762e65a0ce8c4baac6/chrome/browser/banners/app_banner_infobar_delegate_desktop.h
[modify] https://crrev.com/8b0c28df834046650307e5762e65a0ce8c4baac6/chrome/browser/banners/app_banner_manager.cc
[modify] https://crrev.com/8b0c28df834046650307e5762e65a0ce8c4baac6/chrome/browser/banners/app_banner_manager.h
[modify] https://crrev.com/8b0c28df834046650307e5762e65a0ce8c4baac6/chrome/browser/banners/app_banner_metrics.h
[modify] https://crrev.com/8b0c28df834046650307e5762e65a0ce8c4baac6/chrome/browser/chrome_service_worker_browsertest.cc
[modify] https://crrev.com/8b0c28df834046650307e5762e65a0ce8c4baac6/chrome/browser/extensions/bookmark_app_helper.cc
[modify] https://crrev.com/8b0c28df834046650307e5762e65a0ce8c4baac6/chrome/browser/extensions/bookmark_app_helper.h
[modify] https://crrev.com/8b0c28df834046650307e5762e65a0ce8c4baac6/chrome/browser/extensions/bookmark_app_helper_unittest.cc
[modify] https://crrev.com/8b0c28df834046650307e5762e65a0ce8c4baac6/chrome/browser/infobars/infobars_browsertest.cc
[modify] https://crrev.com/8b0c28df834046650307e5762e65a0ce8c4baac6/chrome/browser/installable/installable_data.cc
[modify] https://crrev.com/8b0c28df834046650307e5762e65a0ce8c4baac6/chrome/browser/installable/installable_data.h
[modify] https://crrev.com/8b0c28df834046650307e5762e65a0ce8c4baac6/chrome/browser/installable/installable_manager.cc
[modify] https://crrev.com/8b0c28df834046650307e5762e65a0ce8c4baac6/chrome/browser/installable/installable_manager.h
[modify] https://crrev.com/8b0c28df834046650307e5762e65a0ce8c4baac6/chrome/browser/installable/installable_manager_browsertest.cc
[modify] https://crrev.com/8b0c28df834046650307e5762e65a0ce8c4baac6/chrome/browser/installable/installable_manager_unittest.cc
[modify] https://crrev.com/8b0c28df834046650307e5762e65a0ce8c4baac6/chrome/browser/installable/installable_task_queue_unittest.cc
[modify] https://crrev.com/8b0c28df834046650307e5762e65a0ce8c4baac6/chrome/browser/ui/webui/webapks_handler.cc
[modify] https://crrev.com/8b0c28df834046650307e5762e65a0ce8c4baac6/chrome/browser/webshare/share_target_pref_helper.cc
[modify] https://crrev.com/8b0c28df834046650307e5762e65a0ce8c4baac6/chrome/browser/webshare/share_target_pref_helper.h
[modify] https://crrev.com/8b0c28df834046650307e5762e65a0ce8c4baac6/chrome/browser/webshare/share_target_pref_helper_unittest.cc
[modify] https://crrev.com/8b0c28df834046650307e5762e65a0ce8c4baac6/components/favicon/content/DEPS
[modify] https://crrev.com/8b0c28df834046650307e5762e65a0ce8c4baac6/components/favicon/content/content_favicon_driver.cc
[modify] https://crrev.com/8b0c28df834046650307e5762e65a0ce8c4baac6/components/payments/content/DEPS
[modify] https://crrev.com/8b0c28df834046650307e5762e65a0ce8c4baac6/components/payments/content/installable_payment_app_crawler.cc
[modify] https://crrev.com/8b0c28df834046650307e5762e65a0ce8c4baac6/content/browser/DEPS
[modify] https://crrev.com/8b0c28df834046650307e5762e65a0ce8c4baac6/content/browser/devtools/protocol/page_handler.h
[modify] https://crrev.com/8b0c28df834046650307e5762e65a0ce8c4baac6/content/browser/manifest/manifest_browsertest.cc
[modify] https://crrev.com/8b0c28df834046650307e5762e65a0ce8c4baac6/content/browser/manifest/manifest_icon_selector.cc
[modify] https://crrev.com/8b0c28df834046650307e5762e65a0ce8c4baac6/content/browser/manifest/manifest_icon_selector_unittest.cc
[modify] https://crrev.com/8b0c28df834046650307e5762e65a0ce8c4baac6/content/browser/manifest/manifest_manager_host.cc
[modify] https://crrev.com/8b0c28df834046650307e5762e65a0ce8c4baac6/content/browser/manifest/manifest_manager_host.h
[modify] https://crrev.com/8b0c28df834046650307e5762e65a0ce8c4baac6/content/browser/net/accept_header_browsertest.cc
[modify] https://crrev.com/8b0c28df834046650307e5762e65a0ce8c4baac6/content/browser/payments/payment_app_database.cc
[modify] https://crrev.com/8b0c28df834046650307e5762e65a0ce8c4baac6/content/browser/payments/payment_app_info_fetcher.cc
[modify] https://crrev.com/8b0c28df834046650307e5762e65a0ce8c4baac6/content/browser/payments/payment_app_info_fetcher.h
[modify] https://crrev.com/8b0c28df834046650307e5762e65a0ce8c4baac6/content/browser/payments/payment_instrument_icon_fetcher.cc
[modify] https://crrev.com/8b0c28df834046650307e5762e65a0ce8c4baac6/content/browser/payments/payment_instrument_icon_fetcher.h
[modify] https://crrev.com/8b0c28df834046650307e5762e65a0ce8c4baac6/content/browser/renderer_host/render_widget_host_delegate.h
[modify] https://crrev.com/8b0c28df834046650307e5762e65a0ce8c4baac6/content/browser/renderer_host/render_widget_host_impl.h
[modify] https://crrev.com/8b0c28df834046650307e5762e65a0ce8c4baac6/content/common/DEPS
[modify] https://crrev.com/8b0c28df834046650307e5762e65a0ce8c4baac6/content/common/frame_visual_properties.h
[modify] https://crrev.com/8b0c28df834046650307e5762e65a0ce8c4baac6/content/common/view_messages.h
[modify] https://crrev.com/8b0c28df834046650307e5762e65a0ce8c4baac6/content/common/visual_properties.h
[modify] https://crrev.com/8b0c28df834046650307e5762e65a0ce8c4baac6/content/public/browser/manifest_icon_selector.h
[modify] https://crrev.com/8b0c28df834046650307e5762e65a0ce8c4baac6/content/public/browser/web_contents.h
[modify] https://crrev.com/8b0c28df834046650307e5762e65a0ce8c4baac6/content/public/browser/web_contents_delegate.h
[modify] https://crrev.com/8b0c28df834046650307e5762e65a0ce8c4baac6/content/public/common/BUILD.gn
[rename] https://crrev.com/8b0c28df834046650307e5762e65a0ce8c4baac6/content/public/common/manifest.cc
[rename] https://crrev.com/8b0c28df834046650307e5762e65a0ce8c4baac6/content/public/common/manifest.h
[add] https://crrev.com/8b0c28df834046650307e5762e65a0ce8c4baac6/content/public/common/manifest.typemap
[rename] https://crrev.com/8b0c28df834046650307e5762e65a0ce8c4baac6/content/public/common/manifest_struct_traits.cc
[add] https://crrev.com/8b0c28df834046650307e5762e65a0ce8c4baac6/content/public/common/manifest_struct_traits.h
[modify] https://crrev.com/8b0c28df834046650307e5762e65a0ce8c4baac6/content/public/common/manifest_util.h
[modify] https://crrev.com/8b0c28df834046650307e5762e65a0ce8c4baac6/content/public/common/typemaps.gni
[modify] https://crrev.com/8b0c28df834046650307e5762e65a0ce8c4baac6/content/public/test/layouttest_support.h
[modify] https://crrev.com/8b0c28df834046650307e5762e65a0ce8c4baac6/content/renderer/installedapp/related_apps_fetcher.cc
[modify] https://crrev.com/8b0c28df834046650307e5762e65a0ce8c4baac6/content/renderer/installedapp/related_apps_fetcher.h
[modify] https://crrev.com/8b0c28df834046650307e5762e65a0ce8c4baac6/content/renderer/manifest/manifest_manager.cc
[modify] https://crrev.com/8b0c28df834046650307e5762e65a0ce8c4baac6/content/renderer/manifest/manifest_manager.h
[modify] https://crrev.com/8b0c28df834046650307e5762e65a0ce8c4baac6/content/renderer/manifest/manifest_parser.cc
[modify] https://crrev.com/8b0c28df834046650307e5762e65a0ce8c4baac6/content/renderer/manifest/manifest_parser.h
[modify] https://crrev.com/8b0c28df834046650307e5762e65a0ce8c4baac6/content/renderer/manifest/manifest_parser_unittest.cc
[modify] https://crrev.com/8b0c28df834046650307e5762e65a0ce8c4baac6/content/renderer/manifest/manifest_uma_util.cc
[modify] https://crrev.com/8b0c28df834046650307e5762e65a0ce8c4baac6/content/renderer/manifest/manifest_uma_util.h
[modify] https://crrev.com/8b0c28df834046650307e5762e65a0ce8c4baac6/content/renderer/push_messaging/push_messaging_client.cc
[modify] https://crrev.com/8b0c28df834046650307e5762e65a0ce8c4baac6/content/renderer/push_messaging/push_messaging_client.h
[modify] https://crrev.com/8b0c28df834046650307e5762e65a0ce8c4baac6/content/renderer/render_frame_impl.h
[modify] https://crrev.com/8b0c28df834046650307e5762e65a0ce8c4baac6/content/renderer/render_widget.h
[modify] https://crrev.com/8b0c28df834046650307e5762e65a0ce8c4baac6/content/shell/renderer/layout_test/blink_test_runner.cc
[modify] https://crrev.com/8b0c28df834046650307e5762e65a0ce8c4baac6/content/shell/renderer/layout_test/blink_test_runner.h
[modify] https://crrev.com/8b0c28df834046650307e5762e65a0ce8c4baac6/content/shell/test_runner/test_runner_for_specific_view.cc
[modify] https://crrev.com/8b0c28df834046650307e5762e65a0ce8c4baac6/content/shell/test_runner/test_runner_for_specific_view.h
[modify] https://crrev.com/8b0c28df834046650307e5762e65a0ce8c4baac6/content/shell/test_runner/web_test_delegate.h
[modify] https://crrev.com/8b0c28df834046650307e5762e65a0ce8c4baac6/services/device/public/mojom/BUILD.gn
[modify] https://crrev.com/8b0c28df834046650307e5762e65a0ce8c4baac6/third_party/blink/common/BUILD.gn
[modify] https://crrev.com/8b0c28df834046650307e5762e65a0ce8c4baac6/third_party/blink/common/DEPS
[delete] https://crrev.com/c2913b9855db00283818286085a19ba122d09c9b/third_party/blink/common/manifest/OWNERS
[modify] https://crrev.com/8b0c28df834046650307e5762e65a0ce8c4baac6/third_party/blink/public/BUILD.gn
[modify] https://crrev.com/8b0c28df834046650307e5762e65a0ce8c4baac6/third_party/blink/public/common/BUILD.gn
[modify] https://crrev.com/8b0c28df834046650307e5762e65a0ce8c4baac6/third_party/blink/public/common/DEPS
[delete] https://crrev.com/c2913b9855db00283818286085a19ba122d09c9b/third_party/blink/public/common/manifest/OWNERS
[delete] https://crrev.com/c2913b9855db00283818286085a19ba122d09c9b/third_party/blink/public/common/manifest/display_mode.typemap
[delete] https://crrev.com/c2913b9855db00283818286085a19ba122d09c9b/third_party/blink/public/common/manifest/manifest.typemap
[delete] https://crrev.com/c2913b9855db00283818286085a19ba122d09c9b/third_party/blink/public/common/manifest/manifest_mojom_traits.h
[modify] https://crrev.com/8b0c28df834046650307e5762e65a0ce8c4baac6/third_party/blink/public/mojom/BUILD.gn
[rename] https://crrev.com/8b0c28df834046650307e5762e65a0ce8c4baac6/third_party/blink/public/platform/display_mode.mojom
[add] https://crrev.com/8b0c28df834046650307e5762e65a0ce8c4baac6/third_party/blink/public/platform/display_mode.typemap
[rename] https://crrev.com/8b0c28df834046650307e5762e65a0ce8c4baac6/third_party/blink/public/platform/modules/manifest/OWNERS
[rename] https://crrev.com/8b0c28df834046650307e5762e65a0ce8c4baac6/third_party/blink/public/platform/modules/manifest/manifest.mojom
[rename] https://crrev.com/8b0c28df834046650307e5762e65a0ce8c4baac6/third_party/blink/public/platform/modules/manifest/manifest_manager.mojom
[modify] https://crrev.com/8b0c28df834046650307e5762e65a0ce8c4baac6/third_party/blink/public/platform/modules/payments/payment_app.mojom
[rename] https://crrev.com/8b0c28df834046650307e5762e65a0ce8c4baac6/third_party/blink/public/platform/web_display_mode.h
[rename] https://crrev.com/8b0c28df834046650307e5762e65a0ce8c4baac6/third_party/blink/public/platform/web_display_mode_struct_traits.h
[modify] https://crrev.com/8b0c28df834046650307e5762e65a0ce8c4baac6/third_party/blink/public/public_typemaps.gni
[modify] https://crrev.com/8b0c28df834046650307e5762e65a0ce8c4baac6/third_party/blink/public/web/web_view.h
[modify] https://crrev.com/8b0c28df834046650307e5762e65a0ce8c4baac6/third_party/blink/renderer/core/css/media_query_evaluator.cc
[modify] https://crrev.com/8b0c28df834046650307e5762e65a0ce8c4baac6/third_party/blink/renderer/core/css/media_values.h
[modify] https://crrev.com/8b0c28df834046650307e5762e65a0ce8c4baac6/third_party/blink/renderer/core/exported/web_view_impl.h
[modify] https://crrev.com/8b0c28df834046650307e5762e65a0ce8c4baac6/third_party/blink/renderer/core/exported/web_view_test.cc
[modify] https://crrev.com/8b0c28df834046650307e5762e65a0ce8c4baac6/third_party/blink/renderer/core/frame/local_frame_view.h
[modify] https://crrev.com/8b0c28df834046650307e5762e65a0ce8c4baac6/third_party/blink/renderer/core/frame/settings.h
[modify] https://crrev.com/8b0c28df834046650307e5762e65a0ce8c4baac6/third_party/blink/renderer/core/testing/internal_settings.h
[modify] https://crrev.com/8b0c28df834046650307e5762e65a0ce8c4baac6/third_party/blink/renderer/modules/payments/payment_instruments.cc
[modify] https://crrev.com/8b0c28df834046650307e5762e65a0ce8c4baac6/third_party/blink/renderer/platform/mojo/blink_typemaps.gni
Project Member

Comment 29 by bugdroid1@chromium.org, May 5 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c5f1009cd42d24d77fb811042815cf5d94c770fb

commit c5f1009cd42d24d77fb811042815cf5d94c770fb
Author: Dmitry Gozman <dgozman@chromium.org>
Date: Sat May 05 02:12:12 2018

Reland #2 "Move manifest.mojom and content::Manifest to blink"

This is a reland of c07726e17cf5280456e8e118a7775bc60c2f2e6d

Original change's description:
> Move manifest.mojom and content::Manifest to blink
>
> ... as a part of Onion Soup project.
>
> This also required moving WebDisplayMode from public/platform
> to public/common since it's referenced both in manifest itself
> and, more generally, browser code.
>
> mojom::blink::Manifest is typemapped to blink::Manifest, which uses
> stl types and should be used by blink's embedder, not blink
> implementation.
>
> Bug: 704441
> Change-Id: I94d07bb028278f17d215f64c14552793d5f916ae
> Reviewed-on: https://chromium-review.googlesource.com/1006188
> Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Reviewed-by: Reilly Grant <reillyg@chromium.org>
> Reviewed-by: Kentaro Hara <haraken@chromium.org>
> Reviewed-by: Mathieu Perreault <mathp@chromium.org>
> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
> Reviewed-by: Mikel Astiz <mastiz@chromium.org>
> Reviewed-by: Scott Violet <sky@chromium.org>
> Reviewed-by: David Trainor <dtrainor@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#554953}

TBR=dgozman
NOPRESUBMIT=true

Bug: 704441
Change-Id: I3f2138335ea98710d2e8f6f06ab9fe9f3d561b96
Reviewed-on: https://chromium-review.googlesource.com/1040686
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556292}
[modify] https://crrev.com/c5f1009cd42d24d77fb811042815cf5d94c770fb/chrome/android/java/src/org/chromium/chrome/browser/ShortcutHelper.java
[modify] https://crrev.com/c5f1009cd42d24d77fb811042815cf5d94c770fb/chrome/browser/DEPS
[modify] https://crrev.com/c5f1009cd42d24d77fb811042815cf5d94c770fb/chrome/browser/android/metrics/launch_metrics.cc
[modify] https://crrev.com/c5f1009cd42d24d77fb811042815cf5d94c770fb/chrome/browser/android/shortcut_helper.cc
[modify] https://crrev.com/c5f1009cd42d24d77fb811042815cf5d94c770fb/chrome/browser/android/shortcut_helper.h
[modify] https://crrev.com/c5f1009cd42d24d77fb811042815cf5d94c770fb/chrome/browser/android/shortcut_info.cc
[modify] https://crrev.com/c5f1009cd42d24d77fb811042815cf5d94c770fb/chrome/browser/android/shortcut_info.h
[modify] https://crrev.com/c5f1009cd42d24d77fb811042815cf5d94c770fb/chrome/browser/android/shortcut_info_unittest.cc
[modify] https://crrev.com/c5f1009cd42d24d77fb811042815cf5d94c770fb/chrome/browser/android/webapk/webapk_info.h
[modify] https://crrev.com/c5f1009cd42d24d77fb811042815cf5d94c770fb/chrome/browser/android/webapk/webapk_installer.cc
[modify] https://crrev.com/c5f1009cd42d24d77fb811042815cf5d94c770fb/chrome/browser/android/webapk/webapk_update_data_fetcher.cc
[modify] https://crrev.com/c5f1009cd42d24d77fb811042815cf5d94c770fb/chrome/browser/android/webapk/webapk_update_data_fetcher.h
[modify] https://crrev.com/c5f1009cd42d24d77fb811042815cf5d94c770fb/chrome/browser/android/webapk/webapk_web_manifest_checker.cc
[modify] https://crrev.com/c5f1009cd42d24d77fb811042815cf5d94c770fb/chrome/browser/android/webapk/webapk_web_manifest_checker.h
[modify] https://crrev.com/c5f1009cd42d24d77fb811042815cf5d94c770fb/chrome/browser/android/webapk/webapk_web_manifest_checker_unittest.cc
[modify] https://crrev.com/c5f1009cd42d24d77fb811042815cf5d94c770fb/chrome/browser/android/webapps/add_to_homescreen_data_fetcher.cc
[modify] https://crrev.com/c5f1009cd42d24d77fb811042815cf5d94c770fb/chrome/browser/android/webapps/add_to_homescreen_data_fetcher_unittest.cc
[modify] https://crrev.com/c5f1009cd42d24d77fb811042815cf5d94c770fb/chrome/browser/banners/app_banner_infobar_delegate_desktop.cc
[modify] https://crrev.com/c5f1009cd42d24d77fb811042815cf5d94c770fb/chrome/browser/banners/app_banner_infobar_delegate_desktop.h
[modify] https://crrev.com/c5f1009cd42d24d77fb811042815cf5d94c770fb/chrome/browser/banners/app_banner_manager.cc
[modify] https://crrev.com/c5f1009cd42d24d77fb811042815cf5d94c770fb/chrome/browser/banners/app_banner_manager.h
[modify] https://crrev.com/c5f1009cd42d24d77fb811042815cf5d94c770fb/chrome/browser/banners/app_banner_metrics.h
[modify] https://crrev.com/c5f1009cd42d24d77fb811042815cf5d94c770fb/chrome/browser/chrome_service_worker_browsertest.cc
[modify] https://crrev.com/c5f1009cd42d24d77fb811042815cf5d94c770fb/chrome/browser/extensions/bookmark_app_helper.cc
[modify] https://crrev.com/c5f1009cd42d24d77fb811042815cf5d94c770fb/chrome/browser/extensions/bookmark_app_helper.h
[modify] https://crrev.com/c5f1009cd42d24d77fb811042815cf5d94c770fb/chrome/browser/extensions/bookmark_app_helper_unittest.cc
[modify] https://crrev.com/c5f1009cd42d24d77fb811042815cf5d94c770fb/chrome/browser/infobars/infobars_browsertest.cc
[modify] https://crrev.com/c5f1009cd42d24d77fb811042815cf5d94c770fb/chrome/browser/installable/installable_data.cc
[modify] https://crrev.com/c5f1009cd42d24d77fb811042815cf5d94c770fb/chrome/browser/installable/installable_data.h
[modify] https://crrev.com/c5f1009cd42d24d77fb811042815cf5d94c770fb/chrome/browser/installable/installable_manager.cc
[modify] https://crrev.com/c5f1009cd42d24d77fb811042815cf5d94c770fb/chrome/browser/installable/installable_manager.h
[modify] https://crrev.com/c5f1009cd42d24d77fb811042815cf5d94c770fb/chrome/browser/installable/installable_manager_browsertest.cc
[modify] https://crrev.com/c5f1009cd42d24d77fb811042815cf5d94c770fb/chrome/browser/installable/installable_manager_unittest.cc
[modify] https://crrev.com/c5f1009cd42d24d77fb811042815cf5d94c770fb/chrome/browser/installable/installable_task_queue_unittest.cc
[modify] https://crrev.com/c5f1009cd42d24d77fb811042815cf5d94c770fb/chrome/browser/ui/webui/webapks_handler.cc
[modify] https://crrev.com/c5f1009cd42d24d77fb811042815cf5d94c770fb/chrome/browser/webshare/share_target_pref_helper.cc
[modify] https://crrev.com/c5f1009cd42d24d77fb811042815cf5d94c770fb/chrome/browser/webshare/share_target_pref_helper.h
[modify] https://crrev.com/c5f1009cd42d24d77fb811042815cf5d94c770fb/chrome/browser/webshare/share_target_pref_helper_unittest.cc
[modify] https://crrev.com/c5f1009cd42d24d77fb811042815cf5d94c770fb/components/favicon/content/DEPS
[modify] https://crrev.com/c5f1009cd42d24d77fb811042815cf5d94c770fb/components/favicon/content/content_favicon_driver.cc
[modify] https://crrev.com/c5f1009cd42d24d77fb811042815cf5d94c770fb/components/payments/content/DEPS
[modify] https://crrev.com/c5f1009cd42d24d77fb811042815cf5d94c770fb/components/payments/content/installable_payment_app_crawler.cc
[modify] https://crrev.com/c5f1009cd42d24d77fb811042815cf5d94c770fb/content/browser/DEPS
[modify] https://crrev.com/c5f1009cd42d24d77fb811042815cf5d94c770fb/content/browser/devtools/protocol/page_handler.h
[modify] https://crrev.com/c5f1009cd42d24d77fb811042815cf5d94c770fb/content/browser/manifest/manifest_browsertest.cc
[modify] https://crrev.com/c5f1009cd42d24d77fb811042815cf5d94c770fb/content/browser/manifest/manifest_icon_selector.cc
[modify] https://crrev.com/c5f1009cd42d24d77fb811042815cf5d94c770fb/content/browser/manifest/manifest_icon_selector_unittest.cc
[modify] https://crrev.com/c5f1009cd42d24d77fb811042815cf5d94c770fb/content/browser/manifest/manifest_manager_host.cc
[modify] https://crrev.com/c5f1009cd42d24d77fb811042815cf5d94c770fb/content/browser/manifest/manifest_manager_host.h
[modify] https://crrev.com/c5f1009cd42d24d77fb811042815cf5d94c770fb/content/browser/net/accept_header_browsertest.cc
[modify] https://crrev.com/c5f1009cd42d24d77fb811042815cf5d94c770fb/content/browser/payments/payment_app_database.cc
[modify] https://crrev.com/c5f1009cd42d24d77fb811042815cf5d94c770fb/content/browser/payments/payment_app_info_fetcher.cc
[modify] https://crrev.com/c5f1009cd42d24d77fb811042815cf5d94c770fb/content/browser/payments/payment_app_info_fetcher.h
[modify] https://crrev.com/c5f1009cd42d24d77fb811042815cf5d94c770fb/content/browser/payments/payment_instrument_icon_fetcher.cc
[modify] https://crrev.com/c5f1009cd42d24d77fb811042815cf5d94c770fb/content/browser/payments/payment_instrument_icon_fetcher.h
[modify] https://crrev.com/c5f1009cd42d24d77fb811042815cf5d94c770fb/content/browser/renderer_host/render_widget_host_delegate.h
[modify] https://crrev.com/c5f1009cd42d24d77fb811042815cf5d94c770fb/content/browser/renderer_host/render_widget_host_impl.h
[modify] https://crrev.com/c5f1009cd42d24d77fb811042815cf5d94c770fb/content/common/DEPS
[modify] https://crrev.com/c5f1009cd42d24d77fb811042815cf5d94c770fb/content/common/frame_visual_properties.h
[modify] https://crrev.com/c5f1009cd42d24d77fb811042815cf5d94c770fb/content/common/view_messages.h
[modify] https://crrev.com/c5f1009cd42d24d77fb811042815cf5d94c770fb/content/common/visual_properties.h
[modify] https://crrev.com/c5f1009cd42d24d77fb811042815cf5d94c770fb/content/public/browser/manifest_icon_selector.h
[modify] https://crrev.com/c5f1009cd42d24d77fb811042815cf5d94c770fb/content/public/browser/web_contents.h
[modify] https://crrev.com/c5f1009cd42d24d77fb811042815cf5d94c770fb/content/public/browser/web_contents_delegate.h
[modify] https://crrev.com/c5f1009cd42d24d77fb811042815cf5d94c770fb/content/public/common/BUILD.gn
[delete] https://crrev.com/bd3ce415ffd8e60875ab6dcc653e1ac7dcae2e91/content/public/common/manifest.typemap
[delete] https://crrev.com/bd3ce415ffd8e60875ab6dcc653e1ac7dcae2e91/content/public/common/manifest_struct_traits.h
[modify] https://crrev.com/c5f1009cd42d24d77fb811042815cf5d94c770fb/content/public/common/manifest_util.h
[modify] https://crrev.com/c5f1009cd42d24d77fb811042815cf5d94c770fb/content/public/common/typemaps.gni
[modify] https://crrev.com/c5f1009cd42d24d77fb811042815cf5d94c770fb/content/public/test/layouttest_support.h
[modify] https://crrev.com/c5f1009cd42d24d77fb811042815cf5d94c770fb/content/renderer/installedapp/related_apps_fetcher.cc
[modify] https://crrev.com/c5f1009cd42d24d77fb811042815cf5d94c770fb/content/renderer/installedapp/related_apps_fetcher.h
[modify] https://crrev.com/c5f1009cd42d24d77fb811042815cf5d94c770fb/content/renderer/manifest/manifest_manager.cc
[modify] https://crrev.com/c5f1009cd42d24d77fb811042815cf5d94c770fb/content/renderer/manifest/manifest_manager.h
[modify] https://crrev.com/c5f1009cd42d24d77fb811042815cf5d94c770fb/content/renderer/manifest/manifest_parser.cc
[modify] https://crrev.com/c5f1009cd42d24d77fb811042815cf5d94c770fb/content/renderer/manifest/manifest_parser.h
[modify] https://crrev.com/c5f1009cd42d24d77fb811042815cf5d94c770fb/content/renderer/manifest/manifest_parser_unittest.cc
[modify] https://crrev.com/c5f1009cd42d24d77fb811042815cf5d94c770fb/content/renderer/manifest/manifest_uma_util.cc
[modify] https://crrev.com/c5f1009cd42d24d77fb811042815cf5d94c770fb/content/renderer/manifest/manifest_uma_util.h
[modify] https://crrev.com/c5f1009cd42d24d77fb811042815cf5d94c770fb/content/renderer/push_messaging/push_messaging_client.cc
[modify] https://crrev.com/c5f1009cd42d24d77fb811042815cf5d94c770fb/content/renderer/push_messaging/push_messaging_client.h
[modify] https://crrev.com/c5f1009cd42d24d77fb811042815cf5d94c770fb/content/renderer/render_frame_impl.h
[modify] https://crrev.com/c5f1009cd42d24d77fb811042815cf5d94c770fb/content/renderer/render_widget.h
[modify] https://crrev.com/c5f1009cd42d24d77fb811042815cf5d94c770fb/content/shell/renderer/layout_test/blink_test_runner.cc
[modify] https://crrev.com/c5f1009cd42d24d77fb811042815cf5d94c770fb/content/shell/renderer/layout_test/blink_test_runner.h
[modify] https://crrev.com/c5f1009cd42d24d77fb811042815cf5d94c770fb/content/shell/test_runner/test_runner_for_specific_view.cc
[modify] https://crrev.com/c5f1009cd42d24d77fb811042815cf5d94c770fb/content/shell/test_runner/test_runner_for_specific_view.h
[modify] https://crrev.com/c5f1009cd42d24d77fb811042815cf5d94c770fb/content/shell/test_runner/web_test_delegate.h
[modify] https://crrev.com/c5f1009cd42d24d77fb811042815cf5d94c770fb/services/device/public/mojom/BUILD.gn
[modify] https://crrev.com/c5f1009cd42d24d77fb811042815cf5d94c770fb/third_party/blink/common/BUILD.gn
[modify] https://crrev.com/c5f1009cd42d24d77fb811042815cf5d94c770fb/third_party/blink/common/DEPS
[add] https://crrev.com/c5f1009cd42d24d77fb811042815cf5d94c770fb/third_party/blink/common/manifest/OWNERS
[rename] https://crrev.com/c5f1009cd42d24d77fb811042815cf5d94c770fb/third_party/blink/common/manifest/manifest.cc
[rename] https://crrev.com/c5f1009cd42d24d77fb811042815cf5d94c770fb/third_party/blink/common/manifest/manifest_mojom_traits.cc
[modify] https://crrev.com/c5f1009cd42d24d77fb811042815cf5d94c770fb/third_party/blink/public/BUILD.gn
[modify] https://crrev.com/c5f1009cd42d24d77fb811042815cf5d94c770fb/third_party/blink/public/common/BUILD.gn
[modify] https://crrev.com/c5f1009cd42d24d77fb811042815cf5d94c770fb/third_party/blink/public/common/DEPS
[add] https://crrev.com/c5f1009cd42d24d77fb811042815cf5d94c770fb/third_party/blink/public/common/manifest/OWNERS
[add] https://crrev.com/c5f1009cd42d24d77fb811042815cf5d94c770fb/third_party/blink/public/common/manifest/display_mode.typemap
[rename] https://crrev.com/c5f1009cd42d24d77fb811042815cf5d94c770fb/third_party/blink/public/common/manifest/manifest.h
[add] https://crrev.com/c5f1009cd42d24d77fb811042815cf5d94c770fb/third_party/blink/public/common/manifest/manifest.typemap
[add] https://crrev.com/c5f1009cd42d24d77fb811042815cf5d94c770fb/third_party/blink/public/common/manifest/manifest_mojom_traits.h
[rename] https://crrev.com/c5f1009cd42d24d77fb811042815cf5d94c770fb/third_party/blink/public/common/manifest/web_display_mode.h
[rename] https://crrev.com/c5f1009cd42d24d77fb811042815cf5d94c770fb/third_party/blink/public/common/manifest/web_display_mode_mojom_traits.h
[modify] https://crrev.com/c5f1009cd42d24d77fb811042815cf5d94c770fb/third_party/blink/public/mojom/BUILD.gn
[rename] https://crrev.com/c5f1009cd42d24d77fb811042815cf5d94c770fb/third_party/blink/public/mojom/manifest/OWNERS
[rename] https://crrev.com/c5f1009cd42d24d77fb811042815cf5d94c770fb/third_party/blink/public/mojom/manifest/display_mode.mojom
[rename] https://crrev.com/c5f1009cd42d24d77fb811042815cf5d94c770fb/third_party/blink/public/mojom/manifest/manifest.mojom
[rename] https://crrev.com/c5f1009cd42d24d77fb811042815cf5d94c770fb/third_party/blink/public/mojom/manifest/manifest_manager.mojom
[delete] https://crrev.com/bd3ce415ffd8e60875ab6dcc653e1ac7dcae2e91/third_party/blink/public/platform/display_mode.typemap
[modify] https://crrev.com/c5f1009cd42d24d77fb811042815cf5d94c770fb/third_party/blink/public/platform/modules/payments/payment_app.mojom
[modify] https://crrev.com/c5f1009cd42d24d77fb811042815cf5d94c770fb/third_party/blink/public/public_typemaps.gni
[modify] https://crrev.com/c5f1009cd42d24d77fb811042815cf5d94c770fb/third_party/blink/public/web/web_view.h
[modify] https://crrev.com/c5f1009cd42d24d77fb811042815cf5d94c770fb/third_party/blink/renderer/core/css/media_query_evaluator.cc
[modify] https://crrev.com/c5f1009cd42d24d77fb811042815cf5d94c770fb/third_party/blink/renderer/core/css/media_values.h
[modify] https://crrev.com/c5f1009cd42d24d77fb811042815cf5d94c770fb/third_party/blink/renderer/core/exported/web_view_impl.h
[modify] https://crrev.com/c5f1009cd42d24d77fb811042815cf5d94c770fb/third_party/blink/renderer/core/exported/web_view_test.cc
[modify] https://crrev.com/c5f1009cd42d24d77fb811042815cf5d94c770fb/third_party/blink/renderer/core/frame/local_frame_view.h
[modify] https://crrev.com/c5f1009cd42d24d77fb811042815cf5d94c770fb/third_party/blink/renderer/core/frame/settings.h
[modify] https://crrev.com/c5f1009cd42d24d77fb811042815cf5d94c770fb/third_party/blink/renderer/core/testing/internal_settings.h
[modify] https://crrev.com/c5f1009cd42d24d77fb811042815cf5d94c770fb/third_party/blink/renderer/modules/payments/payment_instruments.cc
[modify] https://crrev.com/c5f1009cd42d24d77fb811042815cf5d94c770fb/third_party/blink/renderer/platform/mojo/blink_typemaps.gni
Project Member

Comment 30 by bugdroid1@chromium.org, May 5 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/093657ed3434f6b619a7e5e6818aca7d4ead1c52

commit 093657ed3434f6b619a7e5e6818aca7d4ead1c52
Author: Findit <findit-for-me@appspot.gserviceaccount.com>
Date: Sat May 05 04:07:30 2018

Revert "Reland #2 "Move manifest.mojom and content::Manifest to blink""

This reverts commit c5f1009cd42d24d77fb811042815cf5d94c770fb.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 556292 as the
culprit for failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2M1ZjEwMDljZDQyZDI0ZDc3ZmI4MTEwNDI4MTVjZjVkOTRjNzcwZmIM

Sample Failed Build: https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Win%20Builder%20%28dbg%29/130960

Sample Failed Step: compile

Original change's description:
> Reland #2 "Move manifest.mojom and content::Manifest to blink"
> 
> This is a reland of c07726e17cf5280456e8e118a7775bc60c2f2e6d
> 
> Original change's description:
> > Move manifest.mojom and content::Manifest to blink
> >
> > ... as a part of Onion Soup project.
> >
> > This also required moving WebDisplayMode from public/platform
> > to public/common since it's referenced both in manifest itself
> > and, more generally, browser code.
> >
> > mojom::blink::Manifest is typemapped to blink::Manifest, which uses
> > stl types and should be used by blink's embedder, not blink
> > implementation.
> >
> > Bug: 704441
> > Change-Id: I94d07bb028278f17d215f64c14552793d5f916ae
> > Reviewed-on: https://chromium-review.googlesource.com/1006188
> > Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
> > Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> > Reviewed-by: Reilly Grant <reillyg@chromium.org>
> > Reviewed-by: Kentaro Hara <haraken@chromium.org>
> > Reviewed-by: Mathieu Perreault <mathp@chromium.org>
> > Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
> > Reviewed-by: Mikel Astiz <mastiz@chromium.org>
> > Reviewed-by: Scott Violet <sky@chromium.org>
> > Reviewed-by: David Trainor <dtrainor@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#554953}
> 
> TBR=dgozman
> NOPRESUBMIT=true
> 
> Bug: 704441
> Change-Id: I3f2138335ea98710d2e8f6f06ab9fe9f3d561b96
> Reviewed-on: https://chromium-review.googlesource.com/1040686
> Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
> Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
> Reviewed-by: Kentaro Hara <haraken@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#556292}

Change-Id: I1e43dfd4225b5bf48768c4109ad25e54cf25463b
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 704441
Reviewed-on: https://chromium-review.googlesource.com/1045846
Cr-Commit-Position: refs/heads/master@{#556305}
[modify] https://crrev.com/093657ed3434f6b619a7e5e6818aca7d4ead1c52/chrome/android/java/src/org/chromium/chrome/browser/ShortcutHelper.java
[modify] https://crrev.com/093657ed3434f6b619a7e5e6818aca7d4ead1c52/chrome/browser/DEPS
[modify] https://crrev.com/093657ed3434f6b619a7e5e6818aca7d4ead1c52/chrome/browser/android/metrics/launch_metrics.cc
[modify] https://crrev.com/093657ed3434f6b619a7e5e6818aca7d4ead1c52/chrome/browser/android/shortcut_helper.cc
[modify] https://crrev.com/093657ed3434f6b619a7e5e6818aca7d4ead1c52/chrome/browser/android/shortcut_helper.h
[modify] https://crrev.com/093657ed3434f6b619a7e5e6818aca7d4ead1c52/chrome/browser/android/shortcut_info.cc
[modify] https://crrev.com/093657ed3434f6b619a7e5e6818aca7d4ead1c52/chrome/browser/android/shortcut_info.h
[modify] https://crrev.com/093657ed3434f6b619a7e5e6818aca7d4ead1c52/chrome/browser/android/shortcut_info_unittest.cc
[modify] https://crrev.com/093657ed3434f6b619a7e5e6818aca7d4ead1c52/chrome/browser/android/webapk/webapk_info.h
[modify] https://crrev.com/093657ed3434f6b619a7e5e6818aca7d4ead1c52/chrome/browser/android/webapk/webapk_installer.cc
[modify] https://crrev.com/093657ed3434f6b619a7e5e6818aca7d4ead1c52/chrome/browser/android/webapk/webapk_update_data_fetcher.cc
[modify] https://crrev.com/093657ed3434f6b619a7e5e6818aca7d4ead1c52/chrome/browser/android/webapk/webapk_update_data_fetcher.h
[modify] https://crrev.com/093657ed3434f6b619a7e5e6818aca7d4ead1c52/chrome/browser/android/webapk/webapk_web_manifest_checker.cc
[modify] https://crrev.com/093657ed3434f6b619a7e5e6818aca7d4ead1c52/chrome/browser/android/webapk/webapk_web_manifest_checker.h
[modify] https://crrev.com/093657ed3434f6b619a7e5e6818aca7d4ead1c52/chrome/browser/android/webapk/webapk_web_manifest_checker_unittest.cc
[modify] https://crrev.com/093657ed3434f6b619a7e5e6818aca7d4ead1c52/chrome/browser/android/webapps/add_to_homescreen_data_fetcher.cc
[modify] https://crrev.com/093657ed3434f6b619a7e5e6818aca7d4ead1c52/chrome/browser/android/webapps/add_to_homescreen_data_fetcher_unittest.cc
[modify] https://crrev.com/093657ed3434f6b619a7e5e6818aca7d4ead1c52/chrome/browser/banners/app_banner_infobar_delegate_desktop.cc
[modify] https://crrev.com/093657ed3434f6b619a7e5e6818aca7d4ead1c52/chrome/browser/banners/app_banner_infobar_delegate_desktop.h
[modify] https://crrev.com/093657ed3434f6b619a7e5e6818aca7d4ead1c52/chrome/browser/banners/app_banner_manager.cc
[modify] https://crrev.com/093657ed3434f6b619a7e5e6818aca7d4ead1c52/chrome/browser/banners/app_banner_manager.h
[modify] https://crrev.com/093657ed3434f6b619a7e5e6818aca7d4ead1c52/chrome/browser/banners/app_banner_metrics.h
[modify] https://crrev.com/093657ed3434f6b619a7e5e6818aca7d4ead1c52/chrome/browser/chrome_service_worker_browsertest.cc
[modify] https://crrev.com/093657ed3434f6b619a7e5e6818aca7d4ead1c52/chrome/browser/extensions/bookmark_app_helper.cc
[modify] https://crrev.com/093657ed3434f6b619a7e5e6818aca7d4ead1c52/chrome/browser/extensions/bookmark_app_helper.h
[modify] https://crrev.com/093657ed3434f6b619a7e5e6818aca7d4ead1c52/chrome/browser/extensions/bookmark_app_helper_unittest.cc
[modify] https://crrev.com/093657ed3434f6b619a7e5e6818aca7d4ead1c52/chrome/browser/infobars/infobars_browsertest.cc
[modify] https://crrev.com/093657ed3434f6b619a7e5e6818aca7d4ead1c52/chrome/browser/installable/installable_data.cc
[modify] https://crrev.com/093657ed3434f6b619a7e5e6818aca7d4ead1c52/chrome/browser/installable/installable_data.h
[modify] https://crrev.com/093657ed3434f6b619a7e5e6818aca7d4ead1c52/chrome/browser/installable/installable_manager.cc
[modify] https://crrev.com/093657ed3434f6b619a7e5e6818aca7d4ead1c52/chrome/browser/installable/installable_manager.h
[modify] https://crrev.com/093657ed3434f6b619a7e5e6818aca7d4ead1c52/chrome/browser/installable/installable_manager_browsertest.cc
[modify] https://crrev.com/093657ed3434f6b619a7e5e6818aca7d4ead1c52/chrome/browser/installable/installable_manager_unittest.cc
[modify] https://crrev.com/093657ed3434f6b619a7e5e6818aca7d4ead1c52/chrome/browser/installable/installable_task_queue_unittest.cc
[modify] https://crrev.com/093657ed3434f6b619a7e5e6818aca7d4ead1c52/chrome/browser/ui/webui/webapks_handler.cc
[modify] https://crrev.com/093657ed3434f6b619a7e5e6818aca7d4ead1c52/chrome/browser/webshare/share_target_pref_helper.cc
[modify] https://crrev.com/093657ed3434f6b619a7e5e6818aca7d4ead1c52/chrome/browser/webshare/share_target_pref_helper.h
[modify] https://crrev.com/093657ed3434f6b619a7e5e6818aca7d4ead1c52/chrome/browser/webshare/share_target_pref_helper_unittest.cc
[modify] https://crrev.com/093657ed3434f6b619a7e5e6818aca7d4ead1c52/components/favicon/content/DEPS
[modify] https://crrev.com/093657ed3434f6b619a7e5e6818aca7d4ead1c52/components/favicon/content/content_favicon_driver.cc
[modify] https://crrev.com/093657ed3434f6b619a7e5e6818aca7d4ead1c52/components/payments/content/DEPS
[modify] https://crrev.com/093657ed3434f6b619a7e5e6818aca7d4ead1c52/components/payments/content/installable_payment_app_crawler.cc
[modify] https://crrev.com/093657ed3434f6b619a7e5e6818aca7d4ead1c52/content/browser/DEPS
[modify] https://crrev.com/093657ed3434f6b619a7e5e6818aca7d4ead1c52/content/browser/devtools/protocol/page_handler.h
[modify] https://crrev.com/093657ed3434f6b619a7e5e6818aca7d4ead1c52/content/browser/manifest/manifest_browsertest.cc
[modify] https://crrev.com/093657ed3434f6b619a7e5e6818aca7d4ead1c52/content/browser/manifest/manifest_icon_selector.cc
[modify] https://crrev.com/093657ed3434f6b619a7e5e6818aca7d4ead1c52/content/browser/manifest/manifest_icon_selector_unittest.cc
[modify] https://crrev.com/093657ed3434f6b619a7e5e6818aca7d4ead1c52/content/browser/manifest/manifest_manager_host.cc
[modify] https://crrev.com/093657ed3434f6b619a7e5e6818aca7d4ead1c52/content/browser/manifest/manifest_manager_host.h
[modify] https://crrev.com/093657ed3434f6b619a7e5e6818aca7d4ead1c52/content/browser/net/accept_header_browsertest.cc
[modify] https://crrev.com/093657ed3434f6b619a7e5e6818aca7d4ead1c52/content/browser/payments/payment_app_database.cc
[modify] https://crrev.com/093657ed3434f6b619a7e5e6818aca7d4ead1c52/content/browser/payments/payment_app_info_fetcher.cc
[modify] https://crrev.com/093657ed3434f6b619a7e5e6818aca7d4ead1c52/content/browser/payments/payment_app_info_fetcher.h
[modify] https://crrev.com/093657ed3434f6b619a7e5e6818aca7d4ead1c52/content/browser/payments/payment_instrument_icon_fetcher.cc
[modify] https://crrev.com/093657ed3434f6b619a7e5e6818aca7d4ead1c52/content/browser/payments/payment_instrument_icon_fetcher.h
[modify] https://crrev.com/093657ed3434f6b619a7e5e6818aca7d4ead1c52/content/browser/renderer_host/render_widget_host_delegate.h
[modify] https://crrev.com/093657ed3434f6b619a7e5e6818aca7d4ead1c52/content/browser/renderer_host/render_widget_host_impl.h
[modify] https://crrev.com/093657ed3434f6b619a7e5e6818aca7d4ead1c52/content/common/DEPS
[modify] https://crrev.com/093657ed3434f6b619a7e5e6818aca7d4ead1c52/content/common/frame_visual_properties.h
[modify] https://crrev.com/093657ed3434f6b619a7e5e6818aca7d4ead1c52/content/common/view_messages.h
[modify] https://crrev.com/093657ed3434f6b619a7e5e6818aca7d4ead1c52/content/common/visual_properties.h
[modify] https://crrev.com/093657ed3434f6b619a7e5e6818aca7d4ead1c52/content/public/browser/manifest_icon_selector.h
[modify] https://crrev.com/093657ed3434f6b619a7e5e6818aca7d4ead1c52/content/public/browser/web_contents.h
[modify] https://crrev.com/093657ed3434f6b619a7e5e6818aca7d4ead1c52/content/public/browser/web_contents_delegate.h
[modify] https://crrev.com/093657ed3434f6b619a7e5e6818aca7d4ead1c52/content/public/common/BUILD.gn
[rename] https://crrev.com/093657ed3434f6b619a7e5e6818aca7d4ead1c52/content/public/common/manifest.cc
[rename] https://crrev.com/093657ed3434f6b619a7e5e6818aca7d4ead1c52/content/public/common/manifest.h
[add] https://crrev.com/093657ed3434f6b619a7e5e6818aca7d4ead1c52/content/public/common/manifest.typemap
[rename] https://crrev.com/093657ed3434f6b619a7e5e6818aca7d4ead1c52/content/public/common/manifest_struct_traits.cc
[add] https://crrev.com/093657ed3434f6b619a7e5e6818aca7d4ead1c52/content/public/common/manifest_struct_traits.h
[modify] https://crrev.com/093657ed3434f6b619a7e5e6818aca7d4ead1c52/content/public/common/manifest_util.h
[modify] https://crrev.com/093657ed3434f6b619a7e5e6818aca7d4ead1c52/content/public/common/typemaps.gni
[modify] https://crrev.com/093657ed3434f6b619a7e5e6818aca7d4ead1c52/content/public/test/layouttest_support.h
[modify] https://crrev.com/093657ed3434f6b619a7e5e6818aca7d4ead1c52/content/renderer/installedapp/related_apps_fetcher.cc
[modify] https://crrev.com/093657ed3434f6b619a7e5e6818aca7d4ead1c52/content/renderer/installedapp/related_apps_fetcher.h
[modify] https://crrev.com/093657ed3434f6b619a7e5e6818aca7d4ead1c52/content/renderer/manifest/manifest_manager.cc
[modify] https://crrev.com/093657ed3434f6b619a7e5e6818aca7d4ead1c52/content/renderer/manifest/manifest_manager.h
[modify] https://crrev.com/093657ed3434f6b619a7e5e6818aca7d4ead1c52/content/renderer/manifest/manifest_parser.cc
[modify] https://crrev.com/093657ed3434f6b619a7e5e6818aca7d4ead1c52/content/renderer/manifest/manifest_parser.h
[modify] https://crrev.com/093657ed3434f6b619a7e5e6818aca7d4ead1c52/content/renderer/manifest/manifest_parser_unittest.cc
[modify] https://crrev.com/093657ed3434f6b619a7e5e6818aca7d4ead1c52/content/renderer/manifest/manifest_uma_util.cc
[modify] https://crrev.com/093657ed3434f6b619a7e5e6818aca7d4ead1c52/content/renderer/manifest/manifest_uma_util.h
[modify] https://crrev.com/093657ed3434f6b619a7e5e6818aca7d4ead1c52/content/renderer/push_messaging/push_messaging_client.cc
[modify] https://crrev.com/093657ed3434f6b619a7e5e6818aca7d4ead1c52/content/renderer/push_messaging/push_messaging_client.h
[modify] https://crrev.com/093657ed3434f6b619a7e5e6818aca7d4ead1c52/content/renderer/render_frame_impl.h
[modify] https://crrev.com/093657ed3434f6b619a7e5e6818aca7d4ead1c52/content/renderer/render_widget.h
[modify] https://crrev.com/093657ed3434f6b619a7e5e6818aca7d4ead1c52/content/shell/renderer/layout_test/blink_test_runner.cc
[modify] https://crrev.com/093657ed3434f6b619a7e5e6818aca7d4ead1c52/content/shell/renderer/layout_test/blink_test_runner.h
[modify] https://crrev.com/093657ed3434f6b619a7e5e6818aca7d4ead1c52/content/shell/test_runner/test_runner_for_specific_view.cc
[modify] https://crrev.com/093657ed3434f6b619a7e5e6818aca7d4ead1c52/content/shell/test_runner/test_runner_for_specific_view.h
[modify] https://crrev.com/093657ed3434f6b619a7e5e6818aca7d4ead1c52/content/shell/test_runner/web_test_delegate.h
[modify] https://crrev.com/093657ed3434f6b619a7e5e6818aca7d4ead1c52/services/device/public/mojom/BUILD.gn
[modify] https://crrev.com/093657ed3434f6b619a7e5e6818aca7d4ead1c52/third_party/blink/common/BUILD.gn
[modify] https://crrev.com/093657ed3434f6b619a7e5e6818aca7d4ead1c52/third_party/blink/common/DEPS
[delete] https://crrev.com/5b854a5af6b74557ec6eaaf9423085d7bd78fad9/third_party/blink/common/manifest/OWNERS
[modify] https://crrev.com/093657ed3434f6b619a7e5e6818aca7d4ead1c52/third_party/blink/public/BUILD.gn
[modify] https://crrev.com/093657ed3434f6b619a7e5e6818aca7d4ead1c52/third_party/blink/public/common/BUILD.gn
[modify] https://crrev.com/093657ed3434f6b619a7e5e6818aca7d4ead1c52/third_party/blink/public/common/DEPS
[delete] https://crrev.com/5b854a5af6b74557ec6eaaf9423085d7bd78fad9/third_party/blink/public/common/manifest/OWNERS
[delete] https://crrev.com/5b854a5af6b74557ec6eaaf9423085d7bd78fad9/third_party/blink/public/common/manifest/display_mode.typemap
[delete] https://crrev.com/5b854a5af6b74557ec6eaaf9423085d7bd78fad9/third_party/blink/public/common/manifest/manifest.typemap
[delete] https://crrev.com/5b854a5af6b74557ec6eaaf9423085d7bd78fad9/third_party/blink/public/common/manifest/manifest_mojom_traits.h
[modify] https://crrev.com/093657ed3434f6b619a7e5e6818aca7d4ead1c52/third_party/blink/public/mojom/BUILD.gn
[rename] https://crrev.com/093657ed3434f6b619a7e5e6818aca7d4ead1c52/third_party/blink/public/platform/display_mode.mojom
[add] https://crrev.com/093657ed3434f6b619a7e5e6818aca7d4ead1c52/third_party/blink/public/platform/display_mode.typemap
[rename] https://crrev.com/093657ed3434f6b619a7e5e6818aca7d4ead1c52/third_party/blink/public/platform/modules/manifest/OWNERS
[rename] https://crrev.com/093657ed3434f6b619a7e5e6818aca7d4ead1c52/third_party/blink/public/platform/modules/manifest/manifest.mojom
[rename] https://crrev.com/093657ed3434f6b619a7e5e6818aca7d4ead1c52/third_party/blink/public/platform/modules/manifest/manifest_manager.mojom
[modify] https://crrev.com/093657ed3434f6b619a7e5e6818aca7d4ead1c52/third_party/blink/public/platform/modules/payments/payment_app.mojom
[rename] https://crrev.com/093657ed3434f6b619a7e5e6818aca7d4ead1c52/third_party/blink/public/platform/web_display_mode.h
[rename] https://crrev.com/093657ed3434f6b619a7e5e6818aca7d4ead1c52/third_party/blink/public/platform/web_display_mode_struct_traits.h
[modify] https://crrev.com/093657ed3434f6b619a7e5e6818aca7d4ead1c52/third_party/blink/public/public_typemaps.gni
[modify] https://crrev.com/093657ed3434f6b619a7e5e6818aca7d4ead1c52/third_party/blink/public/web/web_view.h
[modify] https://crrev.com/093657ed3434f6b619a7e5e6818aca7d4ead1c52/third_party/blink/renderer/core/css/media_query_evaluator.cc
[modify] https://crrev.com/093657ed3434f6b619a7e5e6818aca7d4ead1c52/third_party/blink/renderer/core/css/media_values.h
[modify] https://crrev.com/093657ed3434f6b619a7e5e6818aca7d4ead1c52/third_party/blink/renderer/core/exported/web_view_impl.h
[modify] https://crrev.com/093657ed3434f6b619a7e5e6818aca7d4ead1c52/third_party/blink/renderer/core/exported/web_view_test.cc
[modify] https://crrev.com/093657ed3434f6b619a7e5e6818aca7d4ead1c52/third_party/blink/renderer/core/frame/local_frame_view.h
[modify] https://crrev.com/093657ed3434f6b619a7e5e6818aca7d4ead1c52/third_party/blink/renderer/core/frame/settings.h
[modify] https://crrev.com/093657ed3434f6b619a7e5e6818aca7d4ead1c52/third_party/blink/renderer/core/testing/internal_settings.h
[modify] https://crrev.com/093657ed3434f6b619a7e5e6818aca7d4ead1c52/third_party/blink/renderer/modules/payments/payment_instruments.cc
[modify] https://crrev.com/093657ed3434f6b619a7e5e6818aca7d4ead1c52/third_party/blink/renderer/platform/mojo/blink_typemaps.gni
Project Member

Comment 31 by bugdroid1@chromium.org, May 18 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/88ca5a99ceb351ad68770557e8bc9bb4f2bfc07e

commit 88ca5a99ceb351ad68770557e8bc9bb4f2bfc07e
Author: Dmitry Gozman <dgozman@chromium.org>
Date: Fri May 18 00:13:33 2018

Reland #3 "Move manifest.mojom and content::Manifest to blink"

This is a reland of c07726e17cf5280456e8e118a7775bc60c2f2e6d

Original change's description:
> Move manifest.mojom and content::Manifest to blink
>
> ... as a part of Onion Soup project.
>
> This also required moving WebDisplayMode from public/platform
> to public/common since it's referenced both in manifest itself
> and, more generally, browser code.
>
> mojom::blink::Manifest is typemapped to blink::Manifest, which uses
> stl types and should be used by blink's embedder, not blink
> implementation.
>
> Bug: 704441
> Change-Id: I94d07bb028278f17d215f64c14552793d5f916ae
> Reviewed-on: https://chromium-review.googlesource.com/1006188
> Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Reviewed-by: Reilly Grant <reillyg@chromium.org>
> Reviewed-by: Kentaro Hara <haraken@chromium.org>
> Reviewed-by: Mathieu Perreault <mathp@chromium.org>
> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
> Reviewed-by: Mikel Astiz <mastiz@chromium.org>
> Reviewed-by: Scott Violet <sky@chromium.org>
> Reviewed-by: David Trainor <dtrainor@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#554953}

TBR=dgozman
NOPRESUBMIT=true

Bug: 704441
Change-Id: Ia2c243f5b904629c354cc75989e3497999c40957
Reviewed-on: https://chromium-review.googlesource.com/1046025
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559746}
[modify] https://crrev.com/88ca5a99ceb351ad68770557e8bc9bb4f2bfc07e/chrome/android/java/src/org/chromium/chrome/browser/ShortcutHelper.java
[modify] https://crrev.com/88ca5a99ceb351ad68770557e8bc9bb4f2bfc07e/chrome/browser/DEPS
[modify] https://crrev.com/88ca5a99ceb351ad68770557e8bc9bb4f2bfc07e/chrome/browser/android/metrics/launch_metrics.cc
[modify] https://crrev.com/88ca5a99ceb351ad68770557e8bc9bb4f2bfc07e/chrome/browser/android/shortcut_helper.cc
[modify] https://crrev.com/88ca5a99ceb351ad68770557e8bc9bb4f2bfc07e/chrome/browser/android/shortcut_helper.h
[modify] https://crrev.com/88ca5a99ceb351ad68770557e8bc9bb4f2bfc07e/chrome/browser/android/shortcut_info.cc
[modify] https://crrev.com/88ca5a99ceb351ad68770557e8bc9bb4f2bfc07e/chrome/browser/android/shortcut_info.h
[modify] https://crrev.com/88ca5a99ceb351ad68770557e8bc9bb4f2bfc07e/chrome/browser/android/shortcut_info_unittest.cc
[modify] https://crrev.com/88ca5a99ceb351ad68770557e8bc9bb4f2bfc07e/chrome/browser/android/webapk/webapk_info.h
[modify] https://crrev.com/88ca5a99ceb351ad68770557e8bc9bb4f2bfc07e/chrome/browser/android/webapk/webapk_update_data_fetcher.cc
[modify] https://crrev.com/88ca5a99ceb351ad68770557e8bc9bb4f2bfc07e/chrome/browser/android/webapk/webapk_update_data_fetcher.h
[modify] https://crrev.com/88ca5a99ceb351ad68770557e8bc9bb4f2bfc07e/chrome/browser/android/webapk/webapk_web_manifest_checker.cc
[modify] https://crrev.com/88ca5a99ceb351ad68770557e8bc9bb4f2bfc07e/chrome/browser/android/webapk/webapk_web_manifest_checker.h
[modify] https://crrev.com/88ca5a99ceb351ad68770557e8bc9bb4f2bfc07e/chrome/browser/android/webapk/webapk_web_manifest_checker_unittest.cc
[modify] https://crrev.com/88ca5a99ceb351ad68770557e8bc9bb4f2bfc07e/chrome/browser/android/webapps/add_to_homescreen_data_fetcher.cc
[modify] https://crrev.com/88ca5a99ceb351ad68770557e8bc9bb4f2bfc07e/chrome/browser/android/webapps/add_to_homescreen_data_fetcher_unittest.cc
[modify] https://crrev.com/88ca5a99ceb351ad68770557e8bc9bb4f2bfc07e/chrome/browser/banners/app_banner_infobar_delegate_desktop.cc
[modify] https://crrev.com/88ca5a99ceb351ad68770557e8bc9bb4f2bfc07e/chrome/browser/banners/app_banner_infobar_delegate_desktop.h
[modify] https://crrev.com/88ca5a99ceb351ad68770557e8bc9bb4f2bfc07e/chrome/browser/banners/app_banner_manager.cc
[modify] https://crrev.com/88ca5a99ceb351ad68770557e8bc9bb4f2bfc07e/chrome/browser/banners/app_banner_manager.h
[modify] https://crrev.com/88ca5a99ceb351ad68770557e8bc9bb4f2bfc07e/chrome/browser/banners/app_banner_metrics.h
[modify] https://crrev.com/88ca5a99ceb351ad68770557e8bc9bb4f2bfc07e/chrome/browser/chrome_service_worker_browsertest.cc
[modify] https://crrev.com/88ca5a99ceb351ad68770557e8bc9bb4f2bfc07e/chrome/browser/extensions/bookmark_app_helper.cc
[modify] https://crrev.com/88ca5a99ceb351ad68770557e8bc9bb4f2bfc07e/chrome/browser/extensions/bookmark_app_helper.h
[modify] https://crrev.com/88ca5a99ceb351ad68770557e8bc9bb4f2bfc07e/chrome/browser/extensions/bookmark_app_helper_unittest.cc
[modify] https://crrev.com/88ca5a99ceb351ad68770557e8bc9bb4f2bfc07e/chrome/browser/infobars/infobars_browsertest.cc
[modify] https://crrev.com/88ca5a99ceb351ad68770557e8bc9bb4f2bfc07e/chrome/browser/installable/installable_data.cc
[modify] https://crrev.com/88ca5a99ceb351ad68770557e8bc9bb4f2bfc07e/chrome/browser/installable/installable_data.h
[modify] https://crrev.com/88ca5a99ceb351ad68770557e8bc9bb4f2bfc07e/chrome/browser/installable/installable_manager.cc
[modify] https://crrev.com/88ca5a99ceb351ad68770557e8bc9bb4f2bfc07e/chrome/browser/installable/installable_manager.h
[modify] https://crrev.com/88ca5a99ceb351ad68770557e8bc9bb4f2bfc07e/chrome/browser/installable/installable_manager_browsertest.cc
[modify] https://crrev.com/88ca5a99ceb351ad68770557e8bc9bb4f2bfc07e/chrome/browser/installable/installable_manager_unittest.cc
[modify] https://crrev.com/88ca5a99ceb351ad68770557e8bc9bb4f2bfc07e/chrome/browser/installable/installable_task_queue_unittest.cc
[modify] https://crrev.com/88ca5a99ceb351ad68770557e8bc9bb4f2bfc07e/chrome/browser/webshare/share_target_pref_helper.cc
[modify] https://crrev.com/88ca5a99ceb351ad68770557e8bc9bb4f2bfc07e/chrome/browser/webshare/share_target_pref_helper.h
[modify] https://crrev.com/88ca5a99ceb351ad68770557e8bc9bb4f2bfc07e/chrome/browser/webshare/share_target_pref_helper_unittest.cc
[modify] https://crrev.com/88ca5a99ceb351ad68770557e8bc9bb4f2bfc07e/components/favicon/content/DEPS
[modify] https://crrev.com/88ca5a99ceb351ad68770557e8bc9bb4f2bfc07e/components/favicon/content/content_favicon_driver.cc
[modify] https://crrev.com/88ca5a99ceb351ad68770557e8bc9bb4f2bfc07e/components/payments/content/DEPS
[modify] https://crrev.com/88ca5a99ceb351ad68770557e8bc9bb4f2bfc07e/components/payments/content/installable_payment_app_crawler.cc
[modify] https://crrev.com/88ca5a99ceb351ad68770557e8bc9bb4f2bfc07e/content/browser/DEPS
[modify] https://crrev.com/88ca5a99ceb351ad68770557e8bc9bb4f2bfc07e/content/browser/devtools/protocol/page_handler.h
[modify] https://crrev.com/88ca5a99ceb351ad68770557e8bc9bb4f2bfc07e/content/browser/manifest/manifest_browsertest.cc
[modify] https://crrev.com/88ca5a99ceb351ad68770557e8bc9bb4f2bfc07e/content/browser/manifest/manifest_icon_selector.cc
[modify] https://crrev.com/88ca5a99ceb351ad68770557e8bc9bb4f2bfc07e/content/browser/manifest/manifest_icon_selector_unittest.cc
[modify] https://crrev.com/88ca5a99ceb351ad68770557e8bc9bb4f2bfc07e/content/browser/manifest/manifest_manager_host.cc
[modify] https://crrev.com/88ca5a99ceb351ad68770557e8bc9bb4f2bfc07e/content/browser/manifest/manifest_manager_host.h
[modify] https://crrev.com/88ca5a99ceb351ad68770557e8bc9bb4f2bfc07e/content/browser/net/accept_header_browsertest.cc
[modify] https://crrev.com/88ca5a99ceb351ad68770557e8bc9bb4f2bfc07e/content/browser/payments/payment_app_database.cc
[modify] https://crrev.com/88ca5a99ceb351ad68770557e8bc9bb4f2bfc07e/content/browser/payments/payment_app_info_fetcher.cc
[modify] https://crrev.com/88ca5a99ceb351ad68770557e8bc9bb4f2bfc07e/content/browser/payments/payment_app_info_fetcher.h
[modify] https://crrev.com/88ca5a99ceb351ad68770557e8bc9bb4f2bfc07e/content/browser/payments/payment_instrument_icon_fetcher.cc
[modify] https://crrev.com/88ca5a99ceb351ad68770557e8bc9bb4f2bfc07e/content/browser/payments/payment_instrument_icon_fetcher.h
[modify] https://crrev.com/88ca5a99ceb351ad68770557e8bc9bb4f2bfc07e/content/browser/renderer_host/render_widget_host_delegate.h
[modify] https://crrev.com/88ca5a99ceb351ad68770557e8bc9bb4f2bfc07e/content/browser/renderer_host/render_widget_host_impl.h
[modify] https://crrev.com/88ca5a99ceb351ad68770557e8bc9bb4f2bfc07e/content/common/DEPS
[modify] https://crrev.com/88ca5a99ceb351ad68770557e8bc9bb4f2bfc07e/content/common/frame_visual_properties.h
[modify] https://crrev.com/88ca5a99ceb351ad68770557e8bc9bb4f2bfc07e/content/common/view_messages.h
[modify] https://crrev.com/88ca5a99ceb351ad68770557e8bc9bb4f2bfc07e/content/common/visual_properties.h
[modify] https://crrev.com/88ca5a99ceb351ad68770557e8bc9bb4f2bfc07e/content/public/browser/manifest_icon_selector.h
[modify] https://crrev.com/88ca5a99ceb351ad68770557e8bc9bb4f2bfc07e/content/public/browser/web_contents.h
[modify] https://crrev.com/88ca5a99ceb351ad68770557e8bc9bb4f2bfc07e/content/public/browser/web_contents_delegate.h
[modify] https://crrev.com/88ca5a99ceb351ad68770557e8bc9bb4f2bfc07e/content/public/common/BUILD.gn
[delete] https://crrev.com/4328424affe17cef04068b43da6aee9f676f368c/content/public/common/manifest.typemap
[modify] https://crrev.com/88ca5a99ceb351ad68770557e8bc9bb4f2bfc07e/content/public/common/manifest_util.h
[modify] https://crrev.com/88ca5a99ceb351ad68770557e8bc9bb4f2bfc07e/content/public/common/typemaps.gni
[modify] https://crrev.com/88ca5a99ceb351ad68770557e8bc9bb4f2bfc07e/content/public/test/layouttest_support.h
[modify] https://crrev.com/88ca5a99ceb351ad68770557e8bc9bb4f2bfc07e/content/renderer/installedapp/related_apps_fetcher.cc
[modify] https://crrev.com/88ca5a99ceb351ad68770557e8bc9bb4f2bfc07e/content/renderer/installedapp/related_apps_fetcher.h
[modify] https://crrev.com/88ca5a99ceb351ad68770557e8bc9bb4f2bfc07e/content/renderer/manifest/manifest_manager.cc
[modify] https://crrev.com/88ca5a99ceb351ad68770557e8bc9bb4f2bfc07e/content/renderer/manifest/manifest_manager.h
[modify] https://crrev.com/88ca5a99ceb351ad68770557e8bc9bb4f2bfc07e/content/renderer/manifest/manifest_parser.cc
[modify] https://crrev.com/88ca5a99ceb351ad68770557e8bc9bb4f2bfc07e/content/renderer/manifest/manifest_parser.h
[modify] https://crrev.com/88ca5a99ceb351ad68770557e8bc9bb4f2bfc07e/content/renderer/manifest/manifest_parser_unittest.cc
[modify] https://crrev.com/88ca5a99ceb351ad68770557e8bc9bb4f2bfc07e/content/renderer/manifest/manifest_uma_util.cc
[modify] https://crrev.com/88ca5a99ceb351ad68770557e8bc9bb4f2bfc07e/content/renderer/manifest/manifest_uma_util.h
[modify] https://crrev.com/88ca5a99ceb351ad68770557e8bc9bb4f2bfc07e/content/renderer/push_messaging/push_messaging_client.cc
[modify] https://crrev.com/88ca5a99ceb351ad68770557e8bc9bb4f2bfc07e/content/renderer/push_messaging/push_messaging_client.h
[modify] https://crrev.com/88ca5a99ceb351ad68770557e8bc9bb4f2bfc07e/content/renderer/render_frame_impl.h
[modify] https://crrev.com/88ca5a99ceb351ad68770557e8bc9bb4f2bfc07e/content/renderer/render_widget.h
[modify] https://crrev.com/88ca5a99ceb351ad68770557e8bc9bb4f2bfc07e/content/shell/renderer/layout_test/blink_test_runner.cc
[modify] https://crrev.com/88ca5a99ceb351ad68770557e8bc9bb4f2bfc07e/content/shell/renderer/layout_test/blink_test_runner.h
[modify] https://crrev.com/88ca5a99ceb351ad68770557e8bc9bb4f2bfc07e/content/shell/test_runner/test_runner_for_specific_view.cc
[modify] https://crrev.com/88ca5a99ceb351ad68770557e8bc9bb4f2bfc07e/content/shell/test_runner/test_runner_for_specific_view.h
[modify] https://crrev.com/88ca5a99ceb351ad68770557e8bc9bb4f2bfc07e/content/shell/test_runner/web_test_delegate.h
[modify] https://crrev.com/88ca5a99ceb351ad68770557e8bc9bb4f2bfc07e/services/device/public/mojom/BUILD.gn
[modify] https://crrev.com/88ca5a99ceb351ad68770557e8bc9bb4f2bfc07e/third_party/blink/common/BUILD.gn
[modify] https://crrev.com/88ca5a99ceb351ad68770557e8bc9bb4f2bfc07e/third_party/blink/common/DEPS
[add] https://crrev.com/88ca5a99ceb351ad68770557e8bc9bb4f2bfc07e/third_party/blink/common/manifest/OWNERS
[rename] https://crrev.com/88ca5a99ceb351ad68770557e8bc9bb4f2bfc07e/third_party/blink/common/manifest/manifest.cc
[rename] https://crrev.com/88ca5a99ceb351ad68770557e8bc9bb4f2bfc07e/third_party/blink/common/manifest/manifest_mojom_traits.cc
[modify] https://crrev.com/88ca5a99ceb351ad68770557e8bc9bb4f2bfc07e/third_party/blink/public/BUILD.gn
[modify] https://crrev.com/88ca5a99ceb351ad68770557e8bc9bb4f2bfc07e/third_party/blink/public/common/BUILD.gn
[modify] https://crrev.com/88ca5a99ceb351ad68770557e8bc9bb4f2bfc07e/third_party/blink/public/common/DEPS
[add] https://crrev.com/88ca5a99ceb351ad68770557e8bc9bb4f2bfc07e/third_party/blink/public/common/manifest/OWNERS
[add] https://crrev.com/88ca5a99ceb351ad68770557e8bc9bb4f2bfc07e/third_party/blink/public/common/manifest/display_mode.typemap
[rename] https://crrev.com/88ca5a99ceb351ad68770557e8bc9bb4f2bfc07e/third_party/blink/public/common/manifest/manifest.h
[add] https://crrev.com/88ca5a99ceb351ad68770557e8bc9bb4f2bfc07e/third_party/blink/public/common/manifest/manifest.typemap
[add] https://crrev.com/88ca5a99ceb351ad68770557e8bc9bb4f2bfc07e/third_party/blink/public/common/manifest/manifest_mojom_traits.h
[rename] https://crrev.com/88ca5a99ceb351ad68770557e8bc9bb4f2bfc07e/third_party/blink/public/common/manifest/web_display_mode.h
[rename] https://crrev.com/88ca5a99ceb351ad68770557e8bc9bb4f2bfc07e/third_party/blink/public/common/manifest/web_display_mode_mojom_traits.h
[modify] https://crrev.com/88ca5a99ceb351ad68770557e8bc9bb4f2bfc07e/third_party/blink/public/mojom/BUILD.gn
[rename] https://crrev.com/88ca5a99ceb351ad68770557e8bc9bb4f2bfc07e/third_party/blink/public/mojom/manifest/OWNERS
[rename] https://crrev.com/88ca5a99ceb351ad68770557e8bc9bb4f2bfc07e/third_party/blink/public/mojom/manifest/display_mode.mojom
[rename] https://crrev.com/88ca5a99ceb351ad68770557e8bc9bb4f2bfc07e/third_party/blink/public/mojom/manifest/manifest.mojom
[rename] https://crrev.com/88ca5a99ceb351ad68770557e8bc9bb4f2bfc07e/third_party/blink/public/mojom/manifest/manifest_manager.mojom
[delete] https://crrev.com/4328424affe17cef04068b43da6aee9f676f368c/third_party/blink/public/platform/display_mode.typemap
[modify] https://crrev.com/88ca5a99ceb351ad68770557e8bc9bb4f2bfc07e/third_party/blink/public/platform/modules/payments/payment_app.mojom
[modify] https://crrev.com/88ca5a99ceb351ad68770557e8bc9bb4f2bfc07e/third_party/blink/public/public_typemaps.gni
[modify] https://crrev.com/88ca5a99ceb351ad68770557e8bc9bb4f2bfc07e/third_party/blink/public/web/web_view.h
[modify] https://crrev.com/88ca5a99ceb351ad68770557e8bc9bb4f2bfc07e/third_party/blink/renderer/core/css/media_query_evaluator.cc
[modify] https://crrev.com/88ca5a99ceb351ad68770557e8bc9bb4f2bfc07e/third_party/blink/renderer/core/css/media_values.h
[modify] https://crrev.com/88ca5a99ceb351ad68770557e8bc9bb4f2bfc07e/third_party/blink/renderer/core/exported/web_view_impl.h
[modify] https://crrev.com/88ca5a99ceb351ad68770557e8bc9bb4f2bfc07e/third_party/blink/renderer/core/exported/web_view_test.cc
[modify] https://crrev.com/88ca5a99ceb351ad68770557e8bc9bb4f2bfc07e/third_party/blink/renderer/core/frame/local_frame_view.h
[modify] https://crrev.com/88ca5a99ceb351ad68770557e8bc9bb4f2bfc07e/third_party/blink/renderer/core/frame/settings.h
[modify] https://crrev.com/88ca5a99ceb351ad68770557e8bc9bb4f2bfc07e/third_party/blink/renderer/core/testing/internal_settings.h
[modify] https://crrev.com/88ca5a99ceb351ad68770557e8bc9bb4f2bfc07e/third_party/blink/renderer/modules/payments/payment_instruments.cc
[modify] https://crrev.com/88ca5a99ceb351ad68770557e8bc9bb4f2bfc07e/third_party/blink/renderer/platform/mojo/blink_typemaps.gni
Project Member

Comment 32 by bugdroid1@chromium.org, May 18 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/76953b5c495871be689a97885447d26ffdfa96fb

commit 76953b5c495871be689a97885447d26ffdfa96fb
Author: Dmitry Gozman <dgozman@chromium.org>
Date: Fri May 18 16:37:54 2018

WebManifest: move manifest_share_target_util to blink

This is a part of moving manifest implementation to blink.
These util functions will be used from blink and chrome, so
their final destination is blink/public/common.

Bug: 704441
Change-Id: I6b1bb93e602bf7cccf067994d16d5aeae32f985a
Reviewed-on: https://chromium-review.googlesource.com/1054608
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Matt Giuca <mgiuca@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559918}
[modify] https://crrev.com/76953b5c495871be689a97885447d26ffdfa96fb/chrome/browser/webshare/share_service_impl.cc
[modify] https://crrev.com/76953b5c495871be689a97885447d26ffdfa96fb/content/public/common/BUILD.gn
[delete] https://crrev.com/7e3f29a34181f6413b5495c023c7593231672095/content/public/common/manifest_share_target_util.h
[modify] https://crrev.com/76953b5c495871be689a97885447d26ffdfa96fb/content/renderer/manifest/manifest_parser.cc
[modify] https://crrev.com/76953b5c495871be689a97885447d26ffdfa96fb/content/test/BUILD.gn
[modify] https://crrev.com/76953b5c495871be689a97885447d26ffdfa96fb/third_party/blink/common/BUILD.gn
[rename] https://crrev.com/76953b5c495871be689a97885447d26ffdfa96fb/third_party/blink/common/manifest/manifest_share_target_util.cc
[rename] https://crrev.com/76953b5c495871be689a97885447d26ffdfa96fb/third_party/blink/common/manifest/manifest_share_target_util_unittest.cc
[modify] https://crrev.com/76953b5c495871be689a97885447d26ffdfa96fb/third_party/blink/public/common/BUILD.gn
[add] https://crrev.com/76953b5c495871be689a97885447d26ffdfa96fb/third_party/blink/public/common/manifest/manifest_share_target_util.h
Project Member

Comment 33 by bugdroid1@chromium.org, Jun 7 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b6e16ce4395b6db7d91a32cadf529b5bd8b4d95b

commit b6e16ce4395b6db7d91a32cadf529b5bd8b4d95b
Author: Dmitry Gozman <dgozman@chromium.org>
Date: Thu Jun 07 22:15:47 2018

Add error reporting to ParseJSON

This will be used by manifest parser.

We now pass around a Cursor struct instead of CharType*
and return error type from all internal parsing methods.

Bug: 704441
Change-Id: If2773404d66d6a264cc5b573d7132ad57db117cd
Reviewed-on: https://chromium-review.googlesource.com/1072525
Reviewed-by: Ian Clelland <iclelland@chromium.org>
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565438}
[modify] https://crrev.com/b6e16ce4395b6db7d91a32cadf529b5bd8b4d95b/third_party/blink/renderer/platform/json/json_parser.cc
[modify] https://crrev.com/b6e16ce4395b6db7d91a32cadf529b5bd8b4d95b/third_party/blink/renderer/platform/json/json_parser.h
[modify] https://crrev.com/b6e16ce4395b6db7d91a32cadf529b5bd8b4d95b/third_party/blink/renderer/platform/json/json_parser_test.cc
►

Sign in to add a comment